Hi Chris, Igor, and Alex,
Thank you for reviewing this change!
Best regards,
Daniil
On 12/20/19, 5:18 PM, "Alex Menkov" wrote:
+1
--alex
On 12/20/2019 17:12, Chris Plummer wrote:
> Looks good.
>
> Chris
>
> On 12/20/19 4:42 PM, Daniil Titov wrote:
+1
--alex
On 12/20/2019 17:12, Chris Plummer wrote:
Looks good.
Chris
On 12/20/19 4:42 PM, Daniil Titov wrote:
Please a review a changeset below that removes
vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
and runtime/appcds/cacheObject/RedefineClassTest.java
LGTM
— Igor
>> On Dec 20, 2019, at 4:42 PM, Daniil Titov wrote:
> Please a review a changeset below that removes
> vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
> and runtime/appcds/cacheObject/RedefineClassTest.java tests from
> test/hotspot/jtreg/ProblemList-g
Looks good.
Chris
On 12/20/19 4:42 PM, Daniil Titov wrote:
Please a review a changeset below that removes
vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
and runtime/appcds/cacheObject/RedefineClassTest.java tests from
test/hotspot/jtreg/ProblemList-graal.txt.
Please a review a changeset below that removes
vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java
and runtime/appcds/cacheObject/RedefineClassTest.java tests from
test/hotspot/jtreg/ProblemList-graal.txt.
--- a/test/hotspot/jtreg/ProblemList-graal.txt Wed Dec 11 19:2
Hi Christoph,
thanks for the review.
> I think it would ease understanding of the code if you would also
> create a method DumpWriter::start_dump_segment().
That's a feature, so you only have to check in one place.
> Also, all that DumpWriter::end_sub_record() does is asserting and
> debug only
Hi Richard,
thanks for the review.
Best regards,
Ralf
Hi Ralf,
I've spent some time with your change now as well.
Overall, looks good. I only have some minor findings:
There are 3 new methods:
void DumpWriter::finish_dump_segment()
void DumpWriter::start_sub_record()
void DumpWriter::end_sub_record()
I think it would ease understanding of the code
Hi Ralf,
the enhacement you're proposing is useful I'd say. The enhancements it enables
(streaming,
compression) even more so.
Your change looks good to me. Note that I'm a JDK Committer not a Reviewer.
Best regards,
Richard.
-Original Message-
From: serviceability-dev On
Behalf Of S
On 20/12/2019 01:08, Yasumasa Suenaga wrote:
Hi Chris,
Can we treat (part of) jdk.hotspot.agent like jdk.unsupported module?
jdk.unsupported exports unspec'd API like Unsafe.
If we do so, we might need to separate SA API into exported class and
internal class.
I've proposed to export all SA
So, here comes the O(1) implementation:
- Whenever a class is 'prepared', it is registered with a tag, and we
set-up a listener to get notified when it is unloaded.
- Prepared classes are kept in a datastructure that is a table, which
each entry being the head of a linked-list of KlassNode*. The t
11 matches
Mail list logo
