Re: jmx-dev RFR: 8213222: remove RMIConnectorServer.CREDENTIAL_TYPES

2020-01-10 Thread Alan Bateman
On 11/01/2020 04:52, Daniil Titov wrote: Please review a change [1] that removes constant javax.management.remote.rmi.RMIConnectorServer.CREDENTIAL_TYPE. This constant represents the name of the attribute that specifies a list of class names acceptable to the RMIServer.newClient() remote method

RFR: 8213222: remove RMIConnectorServer.CREDENTIAL_TYPES

2020-01-10 Thread Daniil Titov
Please review a change [1] that removes constant javax.management.remote.rmi.RMIConnectorServer.CREDENTIAL_TYPE. This constant represents the name of the attribute that specifies a list of class names acceptable to the RMIServer.newClient() remote method call. This constant was superseded by RM

Re: RFR(M): 8236913: debug agent's jdwp command logging should include the command set name and command name

2020-01-10 Thread Chris Plummer
Hi Alex, I'll fix the mistakes in MethodImpl.c and ReferenceTypeImpl.c. As for the "_p" suffix, it means the argument is a pointer type that a value will be returned in. I've seen this used elsewhere in hotspot. For example VM_RedefineClasses::merge_constant_pools() and ObjectSynchronizer::de

Re: RFR(M): 8236913: debug agent's jdwp command logging should include the command set name and command name

2020-01-10 Thread Alex Menkov
Hi Chris, Thanks for making the code more "typed" (this "void*" arrays are error prone). Looks good in general, some minor comments: MethodImpl.c - command names starts with lower case letters ReferenceTypeImpl.c - please fix indentation for command definitions debugDispatch.h/.c +debugDi

Re: serviceability agent : problems when using gcc LTO (link time optimization)

2020-01-10 Thread Chris Plummer
Hi Matthias, There is already support for lto in the configure script and makefiles. It was added long ago for minimalVM support. It was likely only ever used/tested with minimalVM, which does not support SA, thus the issue you are referring to did not show

RFR(M): 8236913: debug agent's jdwp command logging should include the command set name and command name

2020-01-10 Thread Chris Plummer
Hello, Please review the following https://bugs.openjdk.java.net/browse/JDK-8236913 http://cr.openjdk.java.net/~cjplummer/8236913/webrev.00/ The debug agent has logging support that will trace all jdwp commands coming in. Currently all it traces is the command set number and the command numbe

serviceability agent : problems when using gcc LTO (link time optimization)

2020-01-10 Thread Baesken, Matthias
Hello, I recently looked into the gcc lto optimization mode (see for some details https://gcc.gnu.org/onlinedocs/gccint/LTO-Overview.html and http://hubicka.blogspot.com/2019/05/gcc-9-link-time-and-inter-procedural.html ). This mode can lead to more compact binaries (~10% smaller) , it