Re: RFR(XS): 8193237 - SA: ClhsdbLauncher should show the command being executed

Hi Chris, This looks good to me. I always prefer verbose output in tests. :) Thanks, Serguei On 2/24/20 21:48, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8193237 http://cr.openjdk.java.net/~cjplummer/8193237/webrev.00/ The fix is to is

RFR(XS): 8193237 - SA: ClhsdbLauncher should show the command being executed

Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8193237 http://cr.openjdk.java.net/~cjplummer/8193237/webrev.00/ The fix is to issue an "echo on" command before the test commands. The bug gives an example of how this fix improves the test output. thanks, Chris

Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

Hi Serguei, Thanks for your review and advice. I modified these. Could you review this again, please? Webrev : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.05/ Regards, Chihiro 2020年2月25日(火) 3:36 serguei.spit...@oracle.com : > Hi Chihiro, > > Thank you for taking care about this issu

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

The JFR heap walker does use the shared barriers in the safepoint though. So that optimization sounds like it won’t work. Okay. Having said that, the null check will be taken only for runtime code, not when going through the JIT. I would be surprised if this very well predicted NULL ch

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

Hi Zhengyu, > On 24 Feb 2020, at 21:59, Zhengyu Gu wrote: > > Hi Erik, > >> On 2/24/20 12:04 PM, Erik Österlund wrote: >> Hi Zhengyu, >> Can’t your barriers just perform a NULL check on the forwardee instead? >> forwardee() == NULL never means forwarded, does it? Both JVMTI and JFR just >> ”

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

Hi Erik, On 2/24/20 12:04 PM, Erik Österlund wrote: Hi Zhengyu, Can’t your barriers just perform a NULL check on the forwardee instead? forwardee() == NULL never means forwarded, does it? Both JVMTI and JFR just ”mark” the markWord, leaving its forwardee == NULL. That way you can solve the i

Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

Hi Martin, I'm not so sure I agree with the approach to this fix, nor for the one already done for JDK-8220348. Shouldn't a user be expected to be able to pass a jlong variable to SetLongArrayRegion() without the need for any special platform dependent modi

Re: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

Hi Martin, It looks good to me. Thanks, Serguei On 2/24/20 05:51, Doerr, Martin wrote: Hi,   reposting on serviceability-dev (was core-libs-dev before).  

Re: RFR: 8196751: Add jhsdb option to specify debug server RMI connector port

Hi Daniil, I've looked at CSR and posted a couple of questions there. It'd be nice if you help to resolve my confusion. :) Thanks, Serguei On 2/23/20 20:21, Daniil Titov wrote: Please review change that adds a new command line option to jhsdb tool for the debugd mode to specify a RMI connect

Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

Hi Chihiro, Thank you for taking care about this issue! It looks good to me. Just a couple of minor comments. http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.04/src/java.base/share/classes/jdk/internal/vm/VMSupport.java.frames.html 88

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

Hi Zhengyu, Can’t your barriers just perform a NULL check on the forwardee instead? forwardee() == NULL never means forwarded, does it? Both JVMTI and JFR just ”mark” the markWord, leaving its forwardee == NULL. That way you can solve the issue in the backend instead, and we don’t need to do a

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

Hi all, Updated according to your comments: http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.02/ I modified vmTestbase/nsk/jvmti/unit/heap/HeapWalkTests/TestDescription.java test [1] to walk 300K objects. Without patch: Time: 987431 nsecs Time: 1135390 nsecs Time: 1142519 nsecs Time: 96281

RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

Hi, I had a look at the progress of this change. Nothing happened since Richard posted his update using more handshakes [1]. But we (SAP) would appreciate a lot if this change could be successfully reviewed and pushed. I think there is basic understanding that this change is helpful. It fixes a

RE: RFR(XS): 8239856: [ntintel] asserts about copying unaligned array element

Hi, reposting on serviceability-dev (was core-libs-dev before). Bug: https://bugs.openjdk.java.net/browse/JDK-8239856 Webrev: http://cr.openjdk.java.net/~mdoerr/8239856_win32_long_double_align/webrev.00/ Thanks for the review, Thomas! Best regards, Martin From: Thomas Stüfe Sent: Montag, 24

Re: RFR: 8196751: Add jhsdb option to specify debug server RMI connector port

Hi Daniil, - SALauncher::buildAttachArgs is not only to build arguments but also to check consistency of arguments. Thus you should use buildAttachArgs() in runDEBUGD(). If you do so, runDEBUGD() would be more simply. - SADebugDTest::testWithPidAndRmiPort would retry until `--rmiport`