Hi Serguei,
Thanks for the review!
Can I get one more reviewer please?
thanks,
Chris
On 3/12/20 12:06 AM, serguei.spit...@oracle.com wrote:
Hi Chris,
On 3/12/20 00:03, Chris
+1
--alex
On 03/12/2020 13:53, Mandy Chung wrote:
This change looks okay.
Mandy
On 3/12/20 1:50 PM, Jonathan Gibbons wrote:
Please review a simple fix regarding the non-standard use of some CSS
in some doc comments.
From the JBS Description:
Recently, for the display of javadoc block tags
Please review a simple fix regarding the non-standard use of some CSS in
some doc comments.
From the JBS Description:
Recently, for the display of javadoc block tags, javadoc changed from
using an inconsistent set of CSS class names on the generated 'dt'
elements to using a single new name ("
This change looks okay.
Mandy
On 3/12/20 1:50 PM, Jonathan Gibbons wrote:
Please review a simple fix regarding the non-standard use of some CSS
in some doc comments.
From the JBS Description:
Recently, for the display of javadoc block tags, javadoc changed from
using an inconsistent set of
Hi Egor,
This stems from the JDWP spec. If you look at the
ObjectReference.DisableCollection command:
https://docs.oracle.com/javase/10/docs/specs/jdwp/jdwp-protocol.html#JDWP_ObjectReference_DisableCollection
"By default all objects in back-end replies may be collected at any time
the targe
Hi Richard,
I managed to find time for a (almost) complete review of webrev.4. (I'll review
the tests separately.)
First of all, the change seems to be in pretty good quality for its significant
complexity. I couldn't find any real bugs. But I'd like to propose minor
improvements.
I'm convinc
Hi,
I agree with Yasunaga's idea. The current implementation seems to be
required for the JVM to read and write. According to the test results,
it is difficult to improve this. However, as in JBS, we also need
human-readable output.
Regards,
Chihiro
2020年3月12日(木) 12:15 Chihiro Ito :
>
> Hi Sergu
Hi all,
it seems that the result of the invokeMethod could be gced immediately,
which is quite strange.
Currently we have to do:
invoke + disableCollection
new(Array)Instance + disableCollection
(String)mirrorOf + disableCollection
in a loop until succeeded, to allow something like foo().boo().
Hi Chris,
On 3/12/20 00:03, Chris Plummer wrote:
Hi Serguei,
That check used to be in Platform.shouldSAAttach(), which
essentially was moved to SATestUtils.checkAttachOk() and
reworked some. It was necessary in Platform
Hi Serguei,
That check used to be in Platform.shouldSAAttach(), which
essentially was moved to SATestUtils.checkAttachOk() and reworked
some. It was necessary in Platform.shouldSAAttach() since that was
used to evaluation vm.hasSAandCanAttach (which is now
10 matches
Mail list logo
