Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Hi Mandy, On 2/04/2020 3:17 pm, Mandy Chung wrote: Hi David, Thanks for the edits to the comments.   "weak hidden" were missed to be changed to "non-strong hidden".  Here is the patch fixing the comments. There are 33 cases of "weak hidden" in the patch I reviewed and also some "hidden weak

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Hi David, Thanks for the edits to the comments.   "weak hidden" were missed to be changed to "non-strong hidden".  Here is the patch fixing the comments. diff --git a/src/hotspot/share/ci/ciField.cpp b/src/hotspot/share/ci/ciField.cpp --- a/src/hotspot/share/ci/ciField.cpp +++ b/src/hotspot/

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Hi Mandy, On 1/04/2020 1:01 pm, Mandy Chung wrote: Thanks to the review feedbacks. Updated webrev: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.04/ I've had a good look through all the hotspot related changes. All looks good. A few minor comments: src/hotspot/

Re: RFR: 8241456: ThreadRunner shouldn't use Wicket for threads starting synchronization

Looks good - thanks Leonid. David On 2/04/2020 12:17 pm, Leonid Mesnik wrote: Find new version (updated webrev.00 by mistake) http://cr.openjdk.java.net/~lmesnik/8241456/webrev.00/ The moving lock.lock() outside of try is required to don't get IllegalStateException. And avoiding locks in T

Re: RFR: 8241456: ThreadRunner shouldn't use Wicket for threads starting synchronization

Find new version (updated webrev.00 by mistake) http://cr.openjdk.java.net/~lmesnik/8241456/webrev.00/ The moving lock.lock() outside of try is required to don't get IllegalStateException. And avoiding locks in ThreadRunner is needed to avoid OOME. Leonid On 3/26/20 4:41 PM, Leonid Mesnik w

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 2/04/2020 10:21 am, Chris Plummer wrote: On 4/1/20 4:29 PM, David Holmes wrote: On 2/04/2020 8:16 am, coleen.phillim...@oracle.com wrote: On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all -

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 4/1/20 4:29 PM, David Holmes wrote: On 2/04/2020 8:16 am, coleen.phillim...@oracle.com wrote: On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove at

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 2/04/2020 8:16 am, coleen.phillim...@oracle.com wrote: On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 4/1/20 4:01 PM, Chris Plummer wrote: On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstac

Re: RFR: 8240698: LingeredApp does not pass getTestJavaOpts() to the children process if vmArguments is already specified

Thank you for review. Filed https://bugs.openjdk.java.net/browse/JDK-8242009 for issue with passing arguments into debugger/tools processes. Leonid > On Apr 1, 2020, at 11:21 AM, Chris Plummer wrote: > > Hi Leonid, > > Looks good. Thanks fo

Re: RFR: 8241530: com/sun/jdi tests fail due to network issues on OSX 10.15

Hi Daniil, LGTM++ Thanks, Serguei On 3/30/20 13:06, Alex Menkov wrote: Looks good. --alex On 03/30/2020 12:43, Daniil Titov wrote: Please review the change [1] that fixes the failure of com/sun/jdi/JdwpListenTest.java and com/sun/jdi/JdwpAttachTest.java tests on OSX 10.15. The problem he

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 4/1/20 5:13 AM, Magnus Ihse Bursie wrote: On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clh

Re: RFR: 8240698: LingeredApp does not pass getTestJavaOpts() to the children process if vmArguments is already specified

Hi Leonid, Looks good. Thanks for cleaning this up! Chris On 3/31/20 4:12 PM, Leonid Mesnik wrote: Here is new webrev: http://cr.openjdk.java.net/~lmesnik/8240698/webrev.03/ The only difference is upd

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 4/1/20 7:26 AM, Alan Bateman wrote: Maybe I missed it going by, but why is the isHidden check in the field offset methods on sun.misc.Unsafe rather than the internal Unsafe? The reflection and VarHandle implementation uses jdk.internal.misc.Unsafe to do field access (both read and write)

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 31/03/2020 20:25, Mandy Chung wrote: Alex's feedback:  rename isHiddenClass to isHidden as it can be a hidden class or interface. `isLocalClass` and `sAnonymousClass` are correct because the Java language only has local classes and anon classes, not local interfaces or anon. interfaces.

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 4/1/20 6:22 AM, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clhsdb is ideally more flexible than that. The

Re: Thread Local Handshake in JVMTI functions

Thanks David! If JDK-8201641 is not assigned when JDK-8240918 is resolved, I will start to work for JDK-8201641. (It would be large patch...) Cheers, Yasumasa On 2020/04/01 19:05, David Holmes wrote: On 1/04/2020 11:02 am, Yasumasa Suenaga wrote: Thanks Dan and Serguei! I added a comment

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 2020-04-01 12:22, Kevin Walls wrote: Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clhsdb is ideally more flexible than that. Th

Re: Discussion about fixing deprecation in jdk.hotspot.agent

Hi Coleen and all - Given the choice I'd ask that we don't remove attach/detach because it limits the scope of what a clhsdb can do in future. Commands like jstack are a one-shot operation.  A Tool like clhsdb is ideally more flexible than that. The SA is (I suggest) "too static" in its "the

Re: Thread Local Handshake in JVMTI functions

On 1/04/2020 11:02 am, Yasumasa Suenaga wrote: Thanks Dan and Serguei! I added a comment for this to JDK-8201641. David, can you share Bug ID for thread-to-thread handshake? I want to record it to JDK-8201641 as a blocker. https://bugs.openjdk.java.net/browse/JDK-8240918 I heard the RFR coul