Please review a change [1] that fixes an intermittent test timeout.
The main logic of the test has this basic structure:
try {
// lots of thread state manipulation of target
}
finally {
thread.getLog();
}
and as David noticed in his comment ( the last comment in [2] ) if an
exception oc
Hi Alex and Serguei,
Please review a new version of the change [1] that makes sure that the test
counts
only the threads it creates and ignores Internal threads VM might create or
destroy.
Testing: Running this test in Mach5 with Graal on several hundred times ,
tier1-tier3 tests are in pro
Hi David and reviewers,
I've updated the webrev and CSR according to agreement with David
to add
new error code to the JDWP ThreadReference::Stop command and new
exception
to the JDI ThreadReference::stop method.
Also, I've updated one of the ns
+1
On 5/29/20 1:52 PM, serguei.spit...@oracle.com wrote:
Hi Alex,
Thank you for the update!
LGTM.
Thanks,
Serguei
On 5/29/20 13:35, Alex Menkov wrote:
Hi Serguei,
ok, I added the loop.
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_WaitForEvent/webrev.2/
--alex
On 05/28/2020 20
Hi Alex,
Thank you for the update!
LGTM.
Thanks,
Serguei
On 5/29/20 13:35, Alex Menkov wrote:
Hi Serguei,
ok, I added the loop.
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_WaitForEvent/webrev.2/
--alex
On 05/28/2020 20:35, serguei.spit...@oracle.com wrote:
Hi Alex,
It'd be n
Hi Serguei,
ok, I added the loop.
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_WaitForEvent/webrev.2/
--alex
On 05/28/2020 20:35, serguei.spit...@oracle.com wrote:
Hi Alex,
It'd be nice to reduce noise from such intermittent issues and also get
rid of such bugs in the future.
My
Hi David and reviewers,
The updated webrev version is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-stop-thread.2/src/
This update adds testing that StopThread can return
JVMTI_ERROR_INVALID_OBJECT error code.
The JVM TI Sto
On 29/05/2020 6:24 pm, serguei.spit...@oracle.com wrote:
On 5/29/20 00:56, serguei.spit...@oracle.com wrote:
On 5/29/20 00:42, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@o
On 5/29/20 00:56, serguei.spit...@oracle.com wrote:
On 5/29/20 00:42, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webr
Thanks for the info, Vladimir, and for looking at the webrev.
Best regards,
Richard.
-Original Message-
From: Vladimir Kozlov
Sent: Donnerstag, 28. Mai 2020 18:03
To: Reingruber, Richard ;
serviceability-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
hotspot-runtime-...@
On 5/29/20 00:59, David Holmes wrote:
On 29/05/2020 5:42 pm, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webrev in pla
On 29/05/2020 5:42 pm, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webrev in place.
The changes are:
- addressed Dav
On 5/29/20 00:42, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webrev in place.
The changes are:
- addressed David's
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webrev in place.
The changes are:
- addressed David's suggestion to rephrase StopThread description
change
14 matches
Mail list logo
