Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

On 2020/08/04 14:12, Chris Plummer wrote: On 8/3/20 9:43 PM, Yasumasa Suenaga wrote: Hi Chris, On 2020/08/04 12:18, Chris Plummer wrote: Hi Yasumasa, I'm not sure yet. I'm waiting for a answer from the build support team. It looks like some sort of sporadic build failure unrelated to your

Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

On 8/3/20 9:43 PM, Yasumasa Suenaga wrote: Hi Chris, On 2020/08/04 12:18, Chris Plummer wrote: Hi Yasumasa, I'm not sure yet. I'm waiting for a answer from the build support team. It looks like some sort of sporadic build failure unrelated to your changes. Only one of several macosx builds

Re: RFR(S): 8247516: DSO.closestSymbolToPC() should use dbg.lookup() rather than rely on java ELF file support

Hi Chris, Looks good. Yasumasa On 2020/08/04 13:10, Chris Plummer wrote: Ping! On 7/27/20 10:04 PM, Chris Plummer wrote: I should have mentioned that currently there is no testing of this code. There will with the changes for [1] JDK-8247514, which will add the lost clhsdb "whatis"

Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

Hi Chris, On 2020/08/04 12:18, Chris Plummer wrote: Hi Yasumasa, I'm not sure yet. I'm waiting for a answer from the build support team. It looks like some sort of sporadic build failure unrelated to your changes. Only one of several macosx builds failed. You might just want to try to submit

Re: RFR(S): 8247516: DSO.closestSymbolToPC() should use dbg.lookup() rather than rely on java ELF file support

Ping! On 7/27/20 10:04 PM, Chris Plummer wrote: I should have mentioned that currently there is no testing of this code. There will with the changes for [1] JDK-8247514, which will add the lost clhsdb "whatis" functionality, which was lost when JavaScript support went away. "whatis" used

Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

Hi Yasumasa, The changes look good. thanks, Chris On 8/3/20 6:38 PM, Yasumasa Suenaga wrote: Hi Chris, Thanks for your comment! I updated webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8250930/webrev.01/ This change produces infinite loop as below, it works fine.   1150:   8b 05

Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

Hi Yasumasa, I'm not sure yet. I'm waiting for a answer from the build support team. It looks like some sort of sporadic build failure unrelated to your changes. Only one of several macosx builds failed. You might just want to try to submit the changes again. thanks, Chris On 8/3/20 7:41

Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

Submit repo reported build failure on macOS. Can you share details? Job: mach5-one-ysuenaga-JDK-8250930-1-20200804-0139-13140081 Thanks, Yasumasa On 2020/08/04 10:38, Yasumasa Suenaga wrote: Hi Chris, Thanks for your comment! I updated webrev:  

Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

Hi Chris, Thanks for your comment! I updated webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8250930/webrev.01/ This change produces infinite loop as below, it works fine. 1150: 8b 05 ae 2e 00 00 mov0x2eae(%rip),%eax# 4004

Re: RFR: 8250826: jhsdb does not work with coredump which comes from Substrate VM

Thanks Chris! I will push it when I got second reviewer. Yasumasa On 2020/08/04 9:54, Chris Plummer wrote: Hi Yasumasa, Your changes look good now. thanks, Chris On 8/3/20 5:47 PM, Yasumasa Suenaga wrote: Hi Chris, Thank you for the comment! I updated webrev:  

Re: RFR: 8250826: jhsdb does not work with coredump which comes from Substrate VM

Hi Yasumasa, Your changes look good now. thanks, Chris On 8/3/20 5:47 PM, Yasumasa Suenaga wrote: Hi Chris, Thank you for the comment! I updated webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8250826/webrev.02/   Diff from webrev.01:

Re: RFR: 8250930: [TESTBUG] Some forceEarlyReturn00* tests failed due to compiler optimization

Hi Yasumasa, Although I don't doubt that it works, calling fgetc() seems like an odd way to resolve this issue. I had some internal discussions on how to safely cause an infinite loop. Something like the following should work: static volatile int dummy_counter = 0; while (dummy_counter ==

Re: RFR: 8250826: jhsdb does not work with coredump which comes from Substrate VM

Hi Chris, Thank you for the comment! I updated webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8250826/webrev.02/ Diff from webrev.01: http://hg.openjdk.java.net/jdk/submit/rev/e98dc25b69c2 On 2020/08/04 6:41, Chris Plummer wrote: Hi Yasumasa, Your updated fix resulted in using the core

Re: Fwd: RFR(XXS): 8249150: SA core file tests sometimes time out on OSX with "java.io.IOException: App waiting timeout"

Thanks Alex and Serguei! On 8/3/20 4:46 PM, serguei.spit...@oracle.com wrote: Hi Chris, LGTM++ Thanks, Serguei On 8/3/20 16:19, Alex Menkov wrote: Hi Chris, Looks good --alex On 08/03/2020 14:53, Chris Plummer wrote: Ping! This is a fairly trivial testing fix to avoid timeouts when

Re: Fwd: RFR(XXS): 8249150: SA core file tests sometimes time out on OSX with "java.io.IOException: App waiting timeout"

Hi Chris, LGTM++ Thanks, Serguei On 8/3/20 16:19, Alex Menkov wrote: Hi Chris, Looks good --alex On 08/03/2020 14:53, Chris Plummer wrote: Ping! This is a fairly trivial testing fix to avoid timeouts when using LingeredApp to generate a core dump. No knowledge of SA is needed. thanks,

Re: Fwd: RFR(XXS): 8249150: SA core file tests sometimes time out on OSX with "java.io.IOException: App waiting timeout"

Hi Chris, Looks good --alex On 08/03/2020 14:53, Chris Plummer wrote: Ping! This is a fairly trivial testing fix to avoid timeouts when using LingeredApp to generate a core dump. No knowledge of SA is needed. thanks, Chris Forwarded Message Subject: RFR(XXS): 8249150:

Re: RFR(S): 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols

Thanks Kevin and Serguei! Chris On 8/3/20 2:51 PM, serguei.spit...@oracle.com wrote: Hi Chris, LGTM++ Thanks, Serguei On 7/30/20 02:16, Kevin Walls wrote: Hi Chris - Yes, that's a good discovery, looks good, Thanks Kevin On 29/07/2020 21:08, Chris Plummer wrote: Hello, Please help

Fwd: RFR(XXS): 8249150: SA core file tests sometimes time out on OSX with "java.io.IOException: App waiting timeout"

Ping! This is a fairly trivial testing fix to avoid timeouts when using LingeredApp to generate a core dump. No knowledge of SA is needed. thanks, Chris Forwarded Message Subject:

Re: RFR(S): 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols

Hi Chris, LGTM++ Thanks, Serguei On 7/30/20 02:16, Kevin Walls wrote: Hi Chris - Yes, that's a good discovery, looks good, Thanks Kevin On 29/07/2020 21:08, Chris Plummer wrote: Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8250750

Re: RFR: 8250826: jhsdb does not work with coredump which comes from Substrate VM

Hi Yasumasa, Your updated fix resulted in using the core file map whereas the original fix used the library map. In both cases the assert is avoided, which I think is the main goal. Does it matter which map is used?   42 #ifndef PF_R   43 #define PF_R 0x4   44 #endif  156   if ((map =

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

Dear Stefan, May I ask your help to review again? I have made a delta based on the last changeset you have reviewed(webrev04),hope it could ease your reviewing work. webrev: https://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_10/ delta (vs webrev04):