RE: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

The latest webrev looks good to me also. Thanks, Paul From: "linzang(臧琳)" Date: Tuesday, August 11, 2020 at 5:24 PM To: "serguei.spit...@oracle.com" Cc: "Hohensee, Paul" , Stefan Karlsson , David Holmes , serviceability-dev , "hotspot-gc-...@openjdk.java.net" Subject: RE: RFR(L): 8215624: a

RE: RFR(S):8251374:jmap -dump should not accept invalid options

Looks good, but for readability, please add a space before the trailing single quote string, vis System.err.println("Fail: invalid option: '" + subopt +"'"); should be System.err.println("Fail: invalid option: '" + subopt + "'"); No need for a new webrev. Thanks, Paul On 8/10/20, 8:00 PM, "

Re: RFR(S):8251374:jmap -dump should not accept invalid options

Hi Lin, It looks good. Just one comment. + System.err.println("Fail: invalid option: '" + subopt +"'"); + System.exit(1); Exit needs to be replaced wit usage for consistency. Thanks, Serguei On 8/10/20 19:57, linzang(臧琳) wrote: Here is the webrev: http://

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

Hi Lin, Thanks you for testing details, it looks good. Thanks, Serguei On 8/11/20 17:22, linzang(臧琳) wrote: Dear Serguei,     Here are the tests I have done:    

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

Dear All, Really appreciated for your time and effort for reviewing this webrev. So it got 3 approval now (From Paul, Serguei and Stefan). I think maybe it is okay to be pushed? Or If needs more review, here are the latest webrev and related info. Webrev:  http:

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

Hi Lin, Yes, this fix can pushed. Thanks, Serguei On 8/12/20 16:46, linzang(臧琳) wrote: Dear All, Really appreciated for your time and effort for reviewing this webrev. So it got 3 approval now (From Paul, Serguei and Stefan). I think maybe it is okay to be pushed? Or

Re: RFR(S):8251374:jmap -dump should not accept invalid options(Internet mail)

Hi Paul and Serguei, Thanks for your comments, here is the updated patch: http://cr.openjdk.java.net/~lzang/8251374/webrev02/ BRs, Lin On 2020/8/13, 12:55 AM, "serguei.spit...@oracle.com" wrote: Hi Lin, It looks good. Just one comment. + System.er

Re: RFR(S):8251374:jmap -dump should not accept invalid options(Internet mail)

Hi Lin. Thank you for the update. It looks good. Thanks, Serguei On 8/12/20 17:08, linzang(臧琳) wrote: Hi Paul and Serguei, Thanks for your comments, here is the updated patch: http://cr.openjdk.java.net/~lzang/8251374/webrev02/ BRs, Lin On 2020/8/13, 12:55 AM, "serguei.spit...@ora