Re: RFR: 8252537: Updated @exception with @throws [v3]

2020-09-19 Thread Vipin Sharma
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: > https://mail.openjdk.java.net/pipermail/core-libs-dev/20

Re: RFR: 8234808: jdb quoted option parsing broken

2020-09-19 Thread Serguei Spitsyn
On Wed, 16 Sep 2020 19:47:02 GMT, Alex Menkov wrote: > Migrating this review from the mailing list into a pull request. > > Some background: > when jdb launches debuggee process it passes java options from "options" > value for CommandLineLaunch connector and > forward options specified before

Re: RFR: 8252997: Null-proofing for linker_md.c

2020-09-19 Thread serguei.spit...@oracle.com
Okay, thanks, guys! Serguei On 9/18/20 14:17, Daniel D. Daugherty wrote: On 9/18/20 5:13 PM, Chris Plummer wrote: On 9/18/20 1:59 PM, Serguei Spitsyn wrote: On Fri, 18 Sep 2020 20:23:15 GMT, Chris Plummer wrote: In the platform-specific implementations of linker_md.c, we see the dll_build

Re: RFR: 8252537: Updated @exception with @throws [v2]

2020-09-19 Thread Vipin Sharma
On Tue, 15 Sep 2020 19:19:07 GMT, Roger Riggs wrote: >> @RogerRiggs I understand your point and will update PR with correct >> indentation. >> But I think adding 3 spaces after throws may not be right for all cases. >> For example when >> 1. Another tag in same method is using only 1 space. >> 2

Re: RFR: 8252537: Updated @exception with @throws [v2]

2020-09-19 Thread Vipin Sharma
> Updated @exception with @throws for core-libs, it fixes all open sub-tasks of > JDK-8252536. > > Open Subtasks part of this fix are: > 1. JDK-8252537 > 2. JDK-8252539 > 3. JDK-8252540 > 4. JDK-8252541 > > Previous conversation on this: > https://mail.openjdk.java.net/pipermail/core-libs-dev/20

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support

2020-09-19 Thread Andrew Haley
On 18/09/2020 11:14, Monica Beckwith wrote: > This is a continuation of > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html The diffs in assembler_aarch64.cpp are mostly spurious. Please try this. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Lt

Re: RFR: 8248238: Implementation of JEP: Windows AArch64 Support

2020-09-19 Thread Andrew Haley
On 18/09/2020 11:14, Monica Beckwith wrote: > This is a continuation of > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html > > Changes since then: > * We've improved the write barrier as suggested by Andrew [1] It's still wrong, I'm afraid. This is not a full barri