On Tue, 15 Sep 2020 19:19:07 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> @RogerRiggs I understand your point and will update PR with correct >> indentation. >> But I think adding 3 spaces after throws may not be right for all cases. >> For example when >> 1. Another tag in same method is using only 1 space. >> 2. In some cases (e.g. free method of Blob.java) we had a mix of throws and >> exception in the same method both with one >> space after. Here after adding 3 spaces throws tags will have the different >> number of spaces and indentation will not >> be same as before. I will update PR to make sure the indentation looks same >> as before and there is no change in >> javadoc. Please tell me in case my understnding is not correct here. > > HI Vipin, > > Correct, a better description is "fix the indentation". > I mnetioned 3 because that was the difference in length between > "exception" and "throws". > > Thanks for the followup, Roger > > > > On 9/15/20 3:14 PM, Vipin Sharma wrote: >> >> @RogerRiggs >> <https://urldefense.com/v3/__https://github.com/RogerRiggs__;!!GqivPVa7Brio!IQp3U9OccSzrjwI7nzJl491MGc8URG355lsnpdvFTIOGQcgmRGlpC-Kpz3kh64J6$> >> I understand your point and will update PR with correct indentation. >> But I think adding 3 spaces after throws may not be right for all cases. >> For example when >> >> 1. Another tag in same method is using only 1 space. >> 2. In some cases (e.g. free method of Blob.java) we had a mix of >> throws and exception in the same method both with one space after. >> Here after adding 3 spaces throws tags will have the different >> number of spaces and indentation will not be same as before. >> >> I will update PR to make sure the indentation looks same as before and >> there is no change in javadoc. >> Please tell me in case my understnding is not correct here. >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/95*issuecomment-692922280__;Iw!!GqivPVa7Brio!IQp3U9OccSzrjwI7nzJl491MGc8URG355lsnpdvFTIOGQcgmRGlpC-Kpz78EqgGt$>, >> or unsubscribe >> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAIRSVAMITTR62U3YVETCM3SF64IFANCNFSM4RDCQ4MA__;!!GqivPVa7Brio!IQp3U9OccSzrjwI7nzJl491MGc8URG355lsnpdvFTIOGQcgmRGlpC-Kpz1RGWzIm$>. >> There was something wrong with the way I updated this PR, please ignore this. I will try to correct this or will close this PR and create a new one. ------------- PR: https://git.openjdk.java.net/jdk/pull/95