On Tue, 22 Sep 2020 03:12:01 GMT, David Holmes wrote:
>> Looks mostly good to me!
>
> Hi Robbin,
>
> I've gone back to refresh myself on the previous discussions and (internal)
> design walk-throughs to get a better sense
> of these changes. Really the "asynchronous handshake" aspect is only a
On Mon, 21 Sep 2020 21:18:20 GMT, Coleen Phillimore wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains five additional commi
On Mon, 21 Sep 2020 21:26:08 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/handshake.hpp line 78:
>>
>>> 76: FilterQueue _queue;
>>> 77: Mutex _lock;
>>> 78: Thread* _active_handshaker;
>>
>> Nit: can you line up the data member names for lock and _active_handshaker ?
>
> Fil
On Tue, 22 Sep 2020 07:00:06 GMT, Robbin Ehn wrote:
>> Hi Robbin,
>>
>> I've gone back to refresh myself on the previous discussions and (internal)
>> design walk-throughs to get a better sense
>> of these changes. Really the "asynchronous handshake" aspect is only a small
>> part of this. The
> This patch implements asynchronous handshake, which changes how handshakes
> works by default. Asynchronous handshakes
> are target only executed, which they may never be executed. (target may block
> on socket for the rest of VM lifetime)
> Since we have several use-cases for them we can have
On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote:
>> Hi Vicente,
>> Please file a separate subtask for the javax.lang.model changes. This helps
>> with the JSR 269 MR paperwork.
>> Thanks,
>> -Joe
>
> note: I have removed from the original patch the code related to
> javax.lang.model, I w
This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
Processing" (cf.
https://openjdk.java.net/jeps/376).
Basically, this patch modifies the epilog safepoint when returning from a frame
(supporting interpreter frames, c1, c2,
and native wrapper frames), to compare the stack point
On Tue, 22 Sep 2020 07:54:57 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
On Tue, 22 Sep 2020 07:20:30 GMT, Robbin Ehn wrote:
>> FilterQueue _queue;
>> JavaThread* _handshakee;
>> Mutex _lock;
>> Thread* _active_handshaker;
>>
>> Isn't this nicer? (it didn't keep the formatting in the comment)
>
> The order of members matter since C++ initialize
On Tue, 22 Sep 2020 11:43:41 GMT, Erik Österlund wrote:
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter fra
On Tue, 22 Sep 2020 11:43:41 GMT, Erik Österlund wrote:
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter fra
On Tue, 22 Sep 2020 12:14:19 GMT, Coleen Phillimore wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/prims/whitebox.cpp line 2050:
>
>> 2048: JavaThread* target = java_la
On Tue, 22 Sep 2020 12:20:36 GMT, Coleen Phillimore wrote:
>> The order of members matter since C++ initialize them in declared order.
>> My opinion when changing this was that it was easier to read when passing
>> the only argument to the first member being
>> initialized, thus _handshakee must
On Tue, 22 Sep 2020 13:47:21 GMT, Stefan Karlsson wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interpret
On Tue, 22 Sep 2020 14:22:58 GMT, Robbin Ehn wrote:
>> I don't understand, you'd have to rearrange the initializers in the
>> constructor too, but I don't see any order
>> dependance. Moving over _lock helps, so this is fine.
>
> You want a cosmetic change in the member declaration.
> I'm sayi
On Tue, 22 Sep 2020 07:54:57 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
On Tue, 22 Sep 2020 14:07:11 GMT, Robbin Ehn wrote:
>> src/hotspot/share/prims/whitebox.cpp line 2050:
>>
>>> 2048: JavaThread* target = java_lang_Thread::thread(thread_oop);
>>> 2049: TraceSelfClosure* tsc = new TraceSelfClosure(target);
>>> 2050: Handshake::execute(tsc, target);
>>
On Tue, 22 Sep 2020 14:38:05 GMT, Daniel D. Daugherty
wrote:
> @fisk - You are missing testing information for this PR.
Sorry about that. I have performed testing with ZGC enabled from tier1-7
(multiple times), and standard testing
tier1-5. I have also stress tested the change with gc-test-sui
On Tue, 22 Sep 2020 15:09:51 GMT, Erik Österlund wrote:
>> @fisk - You are missing testing information for this PR.
>
>> @fisk - You are missing testing information for this PR.
>
> Sorry about that. I have performed testing with ZGC enabled from tier1-7
> (multiple times), and standard testing
Please review this small change to remove "--memory 200m" option from
TestUseContainerSupport.java. This can cause
test failures on systems where swap accounting is disabled.
-
Commit messages:
- 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap
limit capa
On Mon, 21 Sep 2020 07:10:47 GMT, Bernhard Urban-Forster
wrote:
>> I assume you need the rest of the PATH on Windows.
>
>> I assume you need the rest of the PATH on Windows.
>
> Doesn't look like it actually. I've reverted it, thanks for catching it.
Thanks, I tried the updated patch and it wo
On Tue, 22 Sep 2020 07:54:57 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
the patch
- removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
- updates `AODRunnerArgParser` to remove surrounding `"` symbols from
`javaOpts` option values
- updates vmTestbase/nsk/aod test descriptions to have `"` in `javaOpts` values
(as opposed of around `-javaOpts=$value`
This is subtask which covers test in hotspot/jtreg except
test/hotspot/jtreg/vmTestbase/nsk/jvmti (there is a separate
issue for it: JDK-8253371)
In most tests just "@requires vm.jvmti" is added,
in several test '@requires vm.flavor != "minimal"' is removed (when this
requirement is only to ensu
On Tue, 22 Sep 2020 22:51:13 GMT, Alex Menkov wrote:
> This is subtask which covers test in hotspot/jtreg except
> test/hotspot/jtreg/vmTestbase/nsk/jvmti (there is a separate
> issue for it: JDK-8253371)
> In most tests just "@requires vm.jvmti" is added,
> in several test '@requires vm.flavor
On Tue, 22 Sep 2020 22:51:13 GMT, Alex Menkov wrote:
> This is subtask which covers test in hotspot/jtreg except
> test/hotspot/jtreg/vmTestbase/nsk/jvmti (there is a separate
> issue for it: JDK-8253371)
> In most tests just "@requires vm.jvmti" is added,
> in several test '@requires vm.flavor
On Tue, 22 Sep 2020 22:51:13 GMT, Alex Menkov wrote:
> This is subtask which covers test in hotspot/jtreg except
> test/hotspot/jtreg/vmTestbase/nsk/jvmti (there is a separate
> issue for it: JDK-8253371)
> In most tests just "@requires vm.jvmti" is added,
> in several test '@requires vm.flavor
good catch Chris, thanks for the patch,
Vicente
On 9/22/20 5:51 AM, Chris Hegarty wrote:
On Mon, 21 Sep 2020 23:21:18 GMT, Vicente Romero wrote:
Hi Vicente,
Please file a separate subtask for the javax.lang.model changes. This helps
with the JSR 269 MR paperwork.
Thanks,
-Joe
note: I have
> Co-authored-by: Vicente Romero
> Co-authored-by: Harold Seigel
> Co-authored-by: Jonathan Gibbons
> Co-authored-by: Brian Goetz
> Co-authored-by: Maurizio Cimadamore
> Co-authored-by: Joe Darcy
> Co-authored-by: Chris Hegarty
> Co-authored-by: Jan Lahoda
Vicente Romero has updated the pu
On Tue, 22 Sep 2020 07:54:57 GMT, Robbin Ehn wrote:
>> This patch implements asynchronous handshake, which changes how handshakes
>> works by default. Asynchronous handshakes
>> are target only executed, which they may never be executed. (target may
>> block on socket for the rest of VM lifetim
On Mon, 21 Sep 2020 11:07:14 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.hpp line 44:
>>
>>> 42: // by the target JavaThread itself or, depending on whether the
>>> operation is
>>> 43: // a single target/direct handshake or not, by the JavaThread that
>>> requested the
>>> 4
On Mon, 21 Sep 2020 21:59:40 GMT, Coleen Phillimore wrote:
>> The thread executing this handshake operation, what the current thread is
>> doesn't matter.
>> You can't use current threads resources or be dependent otherwise on it.
>>
>> Exception being locking issues in JVM TI, where we are dep
On Tue, 22 Sep 2020 21:13:53 GMT, Igor Ignatyev wrote:
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from
> `javaOpts` option values
> - updates vmTestbase/nsk/aod test descriptions to have `"
On Tue, 22 Sep 2020 21:13:53 GMT, Igor Ignatyev wrote:
> the patch
> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from
> `javaOpts` option values
> - updates vmTestbase/nsk/aod test descriptions to have `"
35 matches
Mail list logo
