Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v7]

2020-10-07 Thread Serguei Spitsyn
On Wed, 7 Oct 2020 17:52:27 GMT, Richard Reingruber wrote: >> Hi, >> >> this is the continuation of the review of the implementation for: >> >> https://bugs.openjdk.java.net/browse/JDK-8227745 >> https://bugs.openjdk.java.net/browse/JDK-8233915 >> >> It allows for JIT optimizations based on es

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v3]

2020-10-07 Thread Severin Gehwolf
On Wed, 7 Oct 2020 19:05:57 GMT, Bob Vandette wrote: >> @bobvandette Done in the latest version. Thoughts? > > I'm a little uncomfortable making such a dramatic change just to fix this > small isolated problem. I think about all > the churn we've had on these files and the backports to come.

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v3]

2020-10-07 Thread Bob Vandette
On Wed, 7 Oct 2020 08:06:58 GMT, Severin Gehwolf wrote: >> OK. I'll probably fold JDK-8254001 into this one then. > > @bobvandette Done in the latest version. Thoughts? I'm a little uncomfortable making such a dramatic change just to fix this small isolated problem. I think about all the chur

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v12]

2020-10-07 Thread Stuart Monteith
On Tue, 6 Oct 2020 12:17:05 GMT, Erik Österlund wrote: >> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack >> Processing" (cf. >> https://openjdk.java.net/jeps/376). >> Basically, this patch modifies the epilog safepoint when returning from a >> frame (supporting interpreter

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v3]

2020-10-07 Thread Richard Reingruber
On Wed, 7 Oct 2020 04:28:16 GMT, Serguei Spitsyn wrote: >> Hi Serguei >> (@sspitsyn) >> >> are you ok with the changes I made based on your comments? >> Will you further review the change? >> >> Thanks, Richard. > > Hi Richard, > > Thank you for making the refactoring. I like it more now. :) >

Re: RFR: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents [v7]

2020-10-07 Thread Richard Reingruber
> Hi, > > this is the continuation of the review of the implementation for: > > https://bugs.openjdk.java.net/browse/JDK-8227745 > https://bugs.openjdk.java.net/browse/JDK-8233915 > > It allows for JIT optimizations based on escape analysis even if JVMTI agents > acquire capabilities to access

Re: RFR: 8246774: implementing Record Classes as a standard feature in Java [v10]

2020-10-07 Thread Vicente Romero
> 8246774: implementing Record Classes as a standard feature in Java Vicente Romero has updated the pull request incrementally with one additional commit since the last revision: removing unused jcod file - Changes: - all: https://git.openjdk.java.net/jdk/pull/290/files - new

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v4]

2020-10-07 Thread Boris Ulasevich
On Wed, 7 Oct 2020 08:08:13 GMT, Severin Gehwolf wrote: >> Yes. I've removed unused groups now, though. >> >> Originally, my thinking was that `mount root` and `mount path` would be >> useful too so I kept it in. It would certainly >> be useful for getting rid of reading `/proc/self/mountinfo`

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v4]

2020-10-07 Thread Severin Gehwolf
> An issue similar to > [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been > discovered. On the > affected system, `/proc/self/mountinfo` contains a line such as this one: > > 35 26 0:26 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup > systemd rw,name=sy

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v4]

2020-10-07 Thread Severin Gehwolf
On Mon, 5 Oct 2020 08:59:34 GMT, Severin Gehwolf wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java >> line 80: >> >>> 78: */ >>> 79: private static final Pattern MOUNTINFO_PATTERN = >>> 80: >>> Pattern.compile("^[^\\s]+\\s+[^\\s]+\\s+[^\\s]+\\s+([^

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v3]

2020-10-07 Thread Severin Gehwolf
On Tue, 6 Oct 2020 08:32:25 GMT, Severin Gehwolf wrote: >> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java >> line 150: >> >>> 148: // find anyway in that case. >>> 149: try (Stream mntInfo = >>> CgroupUtil.readFilePrivileged(Paths.get(mountInfo)))

Integrated: 8252997: Null-proofing for linker_md.c

2020-10-07 Thread Adam Farley
On Fri, 18 Sep 2020 11:09:19 GMT, Adam Farley wrote: > In the platform-specific implementations of linker_md.c, we see the > dll_build_name methods begin with a call to > jvmtiAllocate. > We then appear to rush ahead and try to use that variable without checking > for a null. > > I propose mov

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v8]

2020-10-07 Thread Erik Österlund
On Tue, 6 Oct 2020 12:18:39 GMT, Erik Österlund wrote: >>> Hi Erik, >>> Can you give an overview of the use of the "poll word" and its relation to >>> the "poll page" please? >>> Thanks, >>> David >> >> Hi David, >> >> Thanks for reviewing this code. >> >> There are various polls in the VM. W