On Wed, 2 Dec 2020 04:16:11 GMT, Leonid Mesnik wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> c
On Wed, 2 Dec 2020 04:48:08 GMT, Coleen Phillimore wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted001/TestDescription.java
>> line 41:
>>
>>> 39: * @library /vmTestbase
>>> 40: * /test/lib
>>> 41: * @run main/othervm/native/manual/timeout=240
>>
>>
On Tue, 1 Dec 2020 14:16:14 GMT, Coleen Phillimore wrote:
>> Give an error message rather than logging the error and then crashing later
>> because the JVM can't detect stack overflow. In a resource exhausted
>> situation, thread creation is also failing. This is the
>> vm_exit_out_of_memory
On Tue, 1 Dec 2020 14:19:15 GMT, Coleen Phillimore wrote:
>> The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv is still
>> on the list but the env is "disposed" of and the tag_map is deleted to save
>> memory until the JvmtiEnv can be reclaimed at a safepoint and taken off the
On Tue, 1 Dec 2020 21:44:09 GMT, Harold Seigel wrote:
>> Please review this change to obsolete the deprecated and aliased Trace
>> flags. The now empty aliased_logging_flags support was left in
>> arguments.cpp for use by trace flags that get deprecated and aliased in the
>> future.
>>
>> Wi
On Wed, 2 Dec 2020 02:01:41 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
On Wed, 2 Dec 2020 02:11:35 GMT, Coleen Phillimore wrote:
>> Keeping the message for any flag requires keeping all the supporting code. I
>> don't see the "big 3" are special. They have been deprecated since 9 and we
>> have clearly told people this when they use them. We're also release-noting
On Tue, 1 Dec 2020 21:44:09 GMT, Harold Seigel wrote:
>> Please review this change to obsolete the deprecated and aliased Trace
>> flags. The now empty aliased_logging_flags support was left in
>> arguments.cpp for use by trace flags that get deprecated and aliased in the
>> future.
>>
>> Wi
Including serviceability-dev.
On 12/1/20 9:03 PM, Coleen Phillimore wrote:
On 12/1/20 7:12 PM, Serguei Spitsyn wrote:
On Tue, 1 Dec 2020 14:19:15 GMT, Coleen Phillimore
wrote:
The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv
is still on the list but the env is "disposed"
including serviceability-dev.
On 12/1/20 9:08 PM, Coleen Phillimore wrote:
On 12/1/20 9:04 PM, David Holmes wrote:
On Tue, 1 Dec 2020 14:16:14 GMT, Coleen Phillimore
wrote:
Give an error message rather than logging the error and then
crashing later because the JVM can't detect stack overf
On Tue, 1 Dec 2020 23:01:51 GMT, David Holmes wrote:
>> src/hotspot/share/runtime/arguments.cpp line 612:
>>
>>> 610: { "TraceRedefineClasses", "-Xlog:redefine+class=", "info",
>>> "16.0" },
>>> 611: { "PrintJNIResolving", "-Xlog:jni+resolve=",
>>> "debug", "16.0
On Tue, 1 Dec 2020 14:16:14 GMT, Coleen Phillimore wrote:
>> Give an error message rather than logging the error and then crashing later
>> because the JVM can't detect stack overflow. In a resource exhausted
>> situation, thread creation is also failing. This is the
>> vm_exit_out_of_memory
On Tue, 1 Dec 2020 21:05:12 GMT, Alex Menkov wrote:
>> JdbTest can get exception before jdb field is initialized.
>> As Jdb logging does not depend on the instance, made Jdb.log method static
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last r
On Tue, 1 Dec 2020 14:16:14 GMT, Coleen Phillimore wrote:
>> Give an error message rather than logging the error and then crashing later
>> because the JVM can't detect stack overflow. In a resource exhausted
>> situation, thread creation is also failing. This is the
>> vm_exit_out_of_memory
On Tue, 1 Dec 2020 14:19:15 GMT, Coleen Phillimore wrote:
>> The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv is still
>> on the list but the env is "disposed" of and the tag_map is deleted to save
>> memory until the JvmtiEnv can be reclaimed at a safepoint and taken off the
On Tue, 1 Dec 2020 12:04:43 GMT, Coleen Phillimore wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256718: Obsolete the long term deprecated and aliased Trace flags
>
> src/hotspot/share/runtime/arguments.cpp lin
On Tue, 1 Dec 2020 21:44:09 GMT, Harold Seigel wrote:
>> Please review this change to obsolete the deprecated and aliased Trace
>> flags. The now empty aliased_logging_flags support was left in
>> arguments.cpp for use by trace flags that get deprecated and aliased in the
>> future.
>>
>> Wi
On Tue, 1 Dec 2020 15:55:41 GMT, Daniel D. Daugherty wrote:
>> Test passed tier1-3 with no failures.
>
>> Test passed tier1-3 with no failures.
>
> Tier5 and Tier6 have more JPDA testing (JVM/TI, JDWP, JDI, ...)
tier 4,5,6 pass with no failures.
-
PR: https://git.openjdk.java.net/
On Tue, 1 Dec 2020 20:16:05 GMT, Thomas Stuefe wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> c
On Tue, 1 Dec 2020 20:12:28 GMT, Thomas Stuefe wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> c
On Tue, 1 Dec 2020 12:10:59 GMT, Coleen Phillimore wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8256718: Obsolete the long term deprecated and aliased Trace flags
>
> I agree with David. We should remove the h
> Please review this change to obsolete the deprecated and aliased Trace flags.
> The now empty aliased_logging_flags support was left in arguments.cpp for
> use by trace flags that get deprecated and aliased in the future.
>
> With this change, users will get the following example messages whe
On Tue, 1 Dec 2020 21:05:12 GMT, Alex Menkov wrote:
>> JdbTest can get exception before jdb field is initialized.
>> As Jdb logging does not depend on the instance, made Jdb.log method static
>
> Alex Menkov has updated the pull request incrementally with one additional
> commit since the last r
> JdbTest can get exception before jdb field is initialized.
> As Jdb logging does not depend on the instance, made Jdb.log method static
Alex Menkov has updated the pull request incrementally with one additional
commit since the last revision:
Updated accordingly feedback
- made Jdb.log
On Tue, 1 Dec 2020 14:16:14 GMT, Coleen Phillimore wrote:
>> Give an error message rather than logging the error and then crashing later
>> because the JVM can't detect stack overflow. In a resource exhausted
>> situation, thread creation is also failing. This is the
>> vm_exit_out_of_memory
On Tue, 1 Dec 2020 14:12:58 GMT, Coleen Phillimore wrote:
>> You need to merge from master to get GH Actions fixes. They are currently
>> failing with outdated dependencies in your branch, and master has a fix for
>> that.
>
> Thanks Aleksey, I've remerged, we'll see if that helps.
Hi Coleen,
On Tue, 1 Dec 2020 12:47:04 GMT, Coleen Phillimore wrote:
> Test passed tier1-3 with no failures.
Tier5 and Tier6 have more JPDA testing (JVM/TI, JDWP, JDI, ...)
-
PR: https://git.openjdk.java.net/jdk/pull/1539
> The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv is still on
> the list but the env is "disposed" of and the tag_map is deleted to save
> memory until the JvmtiEnv can be reclaimed at a safepoint and taken off the
> list.
>
> There's a check JvmtiEnvBase::check_for_periodic_c
> Give an error message rather than logging the error and then crashing later
> because the JVM can't detect stack overflow. In a resource exhausted
> situation, thread creation is also failing. This is the
> vm_exit_out_of_memory message printed:
>
> `$ java -XX:+UseNewCode -version
> [0.003
On Tue, 1 Dec 2020 13:53:08 GMT, Aleksey Shipilev wrote:
>> Give an error message rather than logging the error and then crashing later
>> because the JVM can't detect stack overflow. In a resource exhausted
>> situation, thread creation is also failing. This is the
>> vm_exit_out_of_memory
Give an error message rather than logging the error and then crashing later
because the JVM can't detect stack overflow. In a resource exhausted
situation, thread creation is also failing. This is the vm_exit_out_of_memory
message printed:
`$ java -XX:+UseNewCode -version
[0.003s][warning][os
On Tue, 1 Dec 2020 12:55:05 GMT, Coleen Phillimore wrote:
> Give an error message rather than logging the error and then crashing later
> because the JVM can't detect stack overflow. In a resource exhausted
> situation, thread creation is also failing. This is the
> vm_exit_out_of_memory mes
On Mon, 30 Nov 2020 13:57:14 GMT, Coleen Phillimore wrote:
>> The ServiceThread cleaning used a stale ObjectFree state when calling
>> remove_dead_entries, because another thread had concurrently set is_enabled
>> to false. Add a lock around setting/resetting the lock event state and
>> retes
On Tue, 1 Dec 2020 13:04:56 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make enable events lock unconditionally if tagmap present.
>
> Thanks Coleen.
>
> I think the locking strategy aro
On Wed, 25 Nov 2020 18:40:49 GMT, Coleen Phillimore wrote:
> The ServiceThread cleaning used a stale ObjectFree state when calling
> remove_dead_entries, because another thread had concurrently set is_enabled
> to false. Add a lock around setting/resetting the lock event state and
> retest th
On Tue, 1 Dec 2020 10:02:08 GMT, Kim Barrett wrote:
>> That isn't quite what I asked. The claim is that
>> `remove_dead_entries_locked` needs to recheck `is_enabled` if
>> `post_object_free` is true in case the enabled state changed from true to
>> false. But I can't see how such a situation c
The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv is still on
the list but the env is "disposed" of and the tag_map is deleted to save memory
until the JvmtiEnv can be reclaimed at a safepoint and taken off the list.
There's a check JvmtiEnvBase::check_for_periodic_clean_up() tha
On Tue, 1 Dec 2020 12:44:24 GMT, Coleen Phillimore wrote:
> The JvmtiTagMap can be deleted while it is posting. The JvmtiEnv is still on
> the list but the env is "disposed" of and the tag_map is deleted to save
> memory until the JvmtiEnv can be reclaimed at a safepoint and taken off the
> l
On Mon, 30 Nov 2020 20:03:01 GMT, Chris Plummer wrote:
>> Just a friendly ping. Still looking for reviewers for this fix.
>
>> Just a friendly ping. Still looking for reviewers for this fix.
>
> Until we resolve the discussion in
> [JDK-8255987](https://bugs.openjdk.java.net/browse/JDK-8255987)
On Tue, 1 Dec 2020 10:02:08 GMT, Kim Barrett wrote:
>> That isn't quite what I asked. The claim is that
>> `remove_dead_entries_locked` needs to recheck `is_enabled` if
>> `post_object_free` is true in case the enabled state changed from true to
>> false. But I can't see how such a situation c
On Mon, 30 Nov 2020 21:13:05 GMT, Harold Seigel wrote:
> Please review this change to obsolete the deprecated and aliased Trace flags.
> The now empty aliased_logging_flags support was left in arguments.cpp for
> use by trace flags that get deprecated and aliased in the future.
>
> With this
On Tue, 1 Dec 2020 02:22:57 GMT, David Holmes wrote:
>> void JvmtiTagMap::flush_object_free_events() {
>> assert_not_at_safepoint();
>> if (env()->is_enabled(JVMTI_EVENT_OBJECT_FREE)) {
>>
>> Called by JVMTI to disable events and called by the service thread. And
>> here for get_objects_wi
42 matches
Mail list logo
