On Sat, 6 Feb 2021 04:47:10 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove useless code and update copyright
>
> Marked as reviewed by cjplummer (Reviewer).
Thanks @plummercj for help review
On Sat, 6 Feb 2021 04:42:32 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine help message and also refactor the logic in CommandProcessor
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot
On Fri, 5 Feb 2021 02:47:01 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-82
On Fri, 5 Feb 2021 02:47:01 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-82
On Fri, 5 Feb 2021 06:38:53 GMT, Lin Zang wrote:
>> 8261131: jcmd jmap dump should not accept gz option with no value
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove useless code and update copyright
Marked as reviewed
On Fri, 5 Feb 2021 15:36:00 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine help message and also refactor the logic in CommandProce
On Fri, 5 Feb 2021 19:58:42 GMT, Serguei Spitsyn wrote:
>> Dear @plummercj,
>>
>>> `--dumpfile` and `--gz` can only be used with `--binaryheap`. That should
>>> be made clear in the help text.
>>
>> I added indentation for these two sub-options.
>>
>>> * SA's `jhsdb jmap --binaryheap` (which
On Fri, 5 Feb 2021 22:11:39 GMT, Chris Plummer wrote:
>> JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
>> The fix un-problemlists RemovingUnixDomainSocketTest and changes
>> serviceability tests to use
>> OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings
On Fri, 5 Feb 2021 21:09:37 GMT, Alex Menkov wrote:
> JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
> The fix un-problemlists RemovingUnixDomainSocketTest and changes
> serviceability tests to use
> OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings inste
On Fri, 5 Feb 2021 21:09:37 GMT, Alex Menkov wrote:
> JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
> The fix un-problemlists RemovingUnixDomainSocketTest and changes
> serviceability tests to use
> OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings inste
JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
The fix un-problemlists RemovingUnixDomainSocketTest and changes serviceability
tests to use OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings instead
of stderrShouldBeEmptyIgnoreVMWarnings
-
Comm
On Thu, 4 Feb 2021 23:23:41 GMT, Chris Plummer wrote:
>> Thanks for the thorough list, I have tested most of them but not all. I will
>> cover them and update here later.
>>
>>> So really there are two implementations of heap dumping, one in the VM and
>>> one in SA, but a total of 5 ways to g
On Fri, 5 Feb 2021 15:32:26 GMT, Lin Zang wrote:
>> One implementation is in the JVM itself, to be used when the JVM is still
>> running well, and not just from command line tools. Heap dumping can also be
>> triggered by the JVM itslef by setting flags like -XX:+HeapDumpBeforeFullGC.
>> The o
On Tue, 2 Feb 2021 18:35:51 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.hpp line 93:
>
>> 91: CPU_MARVELL
On Fri, 5 Feb 2021 14:48:25 GMT, Harold Seigel wrote:
> Please review this change to clean up warnings, such as the following, in the
> vmTestbase tests.
>
> warning: [synchronization] attempt to synchronize on an instance of a
> value-based class
> warning: [removal] Integer(int) in Intege
On Wed, 3 Feb 2021 23:29:30 GMT, Gerard Ziemski wrote:
>> using ` ```c `
>> https://docs.github.com/en/github/writing-on-github/creating-and-highlighting-code-blocks
>>
>> I was wrong about `SIGFPE` / `EXC_MASK_ARITHMETIC`, it's used on i386,
>> x86_64:
>> https://github.com/openjdk/jdk/blob/2
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Fri, 5 Feb 2021 14:48:25 GMT, Harold Seigel wrote:
> Please review this change to clean up warnings, such as the following, in the
> vmTestbase tests.
>
> warning: [synchronization] attempt to synchronize on an instance of a
> value-based class
> warning: [removal] Integer(int) in Intege
On Fri, 5 Feb 2021 12:26:27 GMT, Anton Kozlov wrote:
>> Marked as reviewed by ihse (Reviewer).
>
>> I haven't got a MacOS AArch64 system right now. Is it possible to
>> enable W^X in Linux in order to kick the tyres?
>
> I've just got rid of asserts that fired on Linux sometime :) As for W^X lik
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine help message and also refactor the logic in CommandProcessor
-
Changes:
- all: https://git.openjdk.ja
On Fri, 5 Feb 2021 15:01:26 GMT, Lin Zang wrote:
>> Also, this method can be refactored to something like this (the check for
>> exactly one option argument is needed):
>>private int parseHeapDumpCompressionLevel(String option) {
>>String[] keyValue = option.split("=");
>>if
On 2/5/21 4:51 AM, Magnus Ihse Bursie wrote:
On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote:
Anton Kozlov has updated the pull request incrementally with one additional
commit since the last revision:
support macos_aarch64 in hsdis
make/autoconf/flags.m4 line 140:
138:
On Fri, 5 Feb 2021 10:36:25 GMT, Serguei Spitsyn wrote:
>> Hi Lin,
>>
>> A week ago you replied that you are accepting the following suggested
>> refactoring:
>>
>>/*
>> * Possible commands:
>> * dumpheap gz=1 file
>>
Please review this change to clean up warnings, such as the following, in the
vmTestbase tests.
warning: [synchronization] attempt to synchronize on an instance of a
value-based class
warning: [removal] Integer(int) in Integer has been deprecated and marked for
removal
This change cleans up
On Mon, 25 Jan 2021 22:48:50 GMT, Chris Plummer wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Refactor CDS disabling
>> - Redo builsys support for aarch64-darwin
>
> src/jdk.hotspot.agent/macosx/native/libsapr
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Fri, 5 Feb 2021 09:57:54 GMT, Magnus Ihse Bursie wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>
On Fri, 5 Feb 2021 10:03:09 GMT, Serguei Spitsyn wrote:
>> One implementation is in the JVM itself, to be used when the JVM is still
>> running well, and not just from command line tools. Heap dumping can also be
>> triggered by the JVM itslef by setting flags like -XX:+HeapDumpBeforeFullGC.
>
On Thu, 4 Feb 2021 23:23:41 GMT, Chris Plummer wrote:
>> Thanks for the thorough list, I have tested most of them but not all. I will
>> cover them and update here later.
>>
>>> So really there are two implementations of heap dumping, one in the VM and
>>> one in SA, but a total of 5 ways to g
On Fri, 5 Feb 2021 09:49:11 GMT, Andrew Haley wrote:
>> I reviewed bsd_aarch64.cpp digging bit deeper and left some comments.
>
>> > Umm, so how does patching work? We don't even know if other threads are
>> > executing the code we need to patch.
>>
>> I thought java can handle that scenario in
On Wed, 3 Feb 2021 20:01:15 GMT, Anton Kozlov wrote:
>> Please review the implementation of JEP 391: macOS/AArch64 Port.
>>
>> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
>> windows/aarch64.
>>
>> Major changes are in:
>> * src/hotspot/cpu/aarch64: support of the
On Thu, 4 Feb 2021 23:05:56 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Add comments to WX transitions
>>
>>
On Tue, 2 Feb 2021 21:20:52 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> make/autoconf/flags.m4 line 140:
>
>> 138: else
>> 139: MACOSX_VERS
On Fri, 22 Jan 2021 14:21:52 GMT, Roland Westrelin wrote:
> I noticed that the SA's dumpreplaydata command fails with:
>
> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
> please wait...
> hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata does no
> I noticed that the SA's dumpreplaydata command fails with:
>
> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
> please wait...
> hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata does not
> appear to be polymorphic
>
> with a simple test progra
On Thu, 4 Feb 2021 18:25:45 GMT, Igor Ignatyev wrote:
>> Roland Westrelin has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commi
36 matches
Mail list logo
