On Tue, 16 Feb 2021 17:20:37 GMT, Julia Boes wrote:
>> 8080272 Refactor I/O stream copying to use
>> InputStream.transferTo/readAllBytes and Files.copy
>
> Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall -
> have they been addressed?
> https://github.com/openjdk/jdk/pu
On Wed, 17 Feb 2021 18:46:51 GMT, Aleksey Shipilev wrote:
> I am seeing exactly the same error in GitHub Actions on x86_32, as in
> [JDK-8232839](https://bugs.openjdk.java.net/browse/JDK-8232839).
> [JDK-8258832](JDK-8258832) put it on problemlist for linux-x64, let's elevate
> that to linux-a
On Wed, 17 Feb 2021 23:30:04 GMT, Serguei Spitsyn wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Put replicated strings into a local variable.
>
> It looks good to me.
> One side comment about the test. It is not
> See CR for details. In brief, fixed the `inspect` command to remove duplicate
> output:
>
> hsdb> inspect 0x0007fef00770
> instance of Oop for java/lang/Class @ 0x0007fef00770 @ 0x0007fef00770
> (size = 160)
> in: Oop for java/io/BufferedInputStream @ 0x82005b08 Oop for
>
The test is checking for "cannot be cast to" because at one point there was a
bug in `printall` that was causing a `ClassCastException`. See
[JDK-8175384](https://bugs.openjdk.java.net/browse/JDK-8175384). However, there
is also a "cannot be cast to" message in the `printall` output when
disass
On Wed, 17 Feb 2021 18:22:01 GMT, Lutz Schmidt wrote:
>> Dear community,
>> may I please request reviews for this fix, improving the usefulness of
>> method invocation counters.
>> - aggregation counters are retyped as uint64_t, shifting the overflow
>> probability way out (185 days in case of
On Wed, 17 Feb 2021 21:55:57 GMT, Serguei Spitsyn wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use p_filesz instead of p_memsz
>
> Hi Yasumasa,
>
> Just some comments.
>
> src/jdk.hotspot.agent/linux/nativ
> This PR relates to
> [JDK-8261702](https://bugs.openjdk.java.net/browse/JDK-8261702) ( #2562 )
> When SA creates a DSO object, which is used to represent a shared object file
> (.so), it initializes the "size" to be the size of the shared object file.
> This usually results in the size being t
On Sun, 14 Feb 2021 07:14:24 GMT, Yasumasa Suenaga wrote:
> This PR relates to
> [JDK-8261702](https://bugs.openjdk.java.net/browse/JDK-8261702) ( #2562 )
> When SA creates a DSO object, which is used to represent a shared object file
> (.so), it initializes the "size" to be the size of the sha
Hi Dan,
On 18/02/2021 3:36 am, Daniel D.Daugherty wrote:
On Wed, 17 Feb 2021 07:32:46 GMT, David Holmes wrote:
Daniel D. Daugherty has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/re
On Sat, 13 Feb 2021 19:05:17 GMT, Chris Plummer wrote:
> See bug description for details. The fix is simple and just a matter of
> moving some code to avoid incorrectly thinking an address is in a .so when it
> is in some other area of VM memory that occurs just after the last .so.
Looks good.
On Tue, 16 Feb 2021 07:28:45 GMT, Chris Plummer wrote:
> See CR for details. In brief, fixed the `inspect` command to remove duplicate
> output:
>
> hsdb> inspect 0x0007fef00770
> instance of Oop for java/lang/Class @ 0x0007fef00770 @ 0x0007fef00770
> (size = 160)
> in: Oop for jav
On Wed, 17 Feb 2021 02:12:56 GMT, Chris Plummer wrote:
>> Add "findsym" to clhsdb. See the CR and CSR for details. The
>> [CSR](https://bugs.openjdk.java.net/browse/JDK-8261101) still needs a
>> reviewer.
>>
>> There is a fix in LinuxDebuggerLocal_lookupByName0() to allow passing in
>> NULL f
On Wed, 17 Feb 2021 06:28:09 GMT, Yasumasa Suenaga wrote:
>> This PR relates to
>> [JDK-8261702](https://bugs.openjdk.java.net/browse/JDK-8261702) ( #2562 )
>> When SA creates a DSO object, which is used to represent a shared object
>> file (.so), it initializes the "size" to be the size of the
On Wed, 17 Feb 2021 07:07:44 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains three
>> additional
On Wed, 17 Feb 2021 06:53:20 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address coleenp CR0 comments.
>
> src/hotspot/share/compiler/compileBroker.cpp line 1008:
>
>> 1006: if (
On Wed, 17 Feb 2021 02:12:56 GMT, Chris Plummer wrote:
>> Add "findsym" to clhsdb. See the CR and CSR for details. The
>> [CSR](https://bugs.openjdk.java.net/browse/JDK-8261101) still needs a
>> reviewer.
>>
>> There is a fix in LinuxDebuggerLocal_lookupByName0() to allow passing in
>> NULL f
On Wed, 17 Feb 2021 18:46:51 GMT, Aleksey Shipilev wrote:
> I am seeing exactly the same error in GitHub Actions on x86_32, as in
> [JDK-8232839](https://bugs.openjdk.java.net/browse/JDK-8232839).
> [JDK-8258832](JDK-8258832) put it on problemlist for linux-x64, let's elevate
> that to linux-a
On Wed, 17 Feb 2021 06:46:27 GMT, Yasumasa Suenaga wrote:
>> If you run ClhsdbPmap.java, you can see pmap output for both core and live
>> processes. The sizes of the maps are very large for both of them, and
>> actually a bit bigger with the live process. Here's the output for a live
>> proce
I am seeing exactly the same error in GitHub Actions on x86_32, as in
[JDK-8232839](https://bugs.openjdk.java.net/browse/JDK-8232839).
[JDK-8258832](JDK-8258832) put it on problemlist for linux-x64, let's elevate
that to linux-all.
Additional testing:
- [x] Test on Linux x86_64 (still skipped)
On Mon, 15 Feb 2021 18:21:53 GMT, Lutz Schmidt wrote:
>> This is a request for help. Could someone with SA knowledge please check if
>> my assumption is correct?
>>
>> In hotspot code, the field Method::_compiled_invocation_count is annotated
>> with a comment that it is used by SA. The field
> Dear community,
> may I please request reviews for this fix, improving the usefulness of method
> invocation counters.
> - aggregation counters are retyped as uint64_t, shifting the overflow
> probability way out (185 days in case of a 1 GHz counter update frequency).
> - counters for individua
On Wed, 17 Feb 2021 06:56:26 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains three
>> additional
On Wed, 17 Feb 2021 07:32:46 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains three
>> additional
On Tue, 16 Feb 2021 06:24:05 GMT, Vladimir Kempik wrote:
>> This is when passing a float, yes? In the case where we have more float
>> arguments than n_float_register_parameters_c.
>> I don't understand why you think it's acceptable to bail in this case. Can
>> you explain, please?
>
> it's for
On Mon, 15 Feb 2021 17:45:32 GMT, Anton Kozlov wrote:
>> I'm not sure it can wait. This change turns already-messy code into
>> something significantly messier, to the extent that it's not really good
>> enough to go into mainline.
>
> The latest merge with JDK-8261071 should resolve the issue.
On Tue, 2 Feb 2021 22:42:22 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/share/logging/logStream.hpp line 35:
>
>> 33: class LogStream : p
On Mon, 15 Feb 2021 16:21:53 GMT, Bernhard Urban-Forster
wrote:
>> This is the version of w^x on-demand switch implemented by microsoft guys.
>> This is enabled only for debug builds.
>> @lewurm could you comment here please
>
> Those values can be observed in the debugger, but aren't documente
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 2 Feb 2021 21:51:56 GMT, Daniel D. Daugherty wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 31:
>
>> 29: #include
On Wed, 17 Feb 2021 06:46:27 GMT, Yasumasa Suenaga wrote:
>> If you run ClhsdbPmap.java, you can see pmap output for both core and live
>> processes. The sizes of the maps are very large for both of them, and
>> actually a bit bigger with the live process. Here's the output for a live
>> proce
31 matches
Mail list logo
