On Wed, 10 Mar 2021 05:11:30 GMT, Vipin Sharma wrote:
>> JDK-8261095: Add test for clhsdb "symbol" command
>
> Vipin Sharma has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated formatting and grammer changes
Marked as reviewed by ysuena
See CR for a description of why this change is needed.
-
Commit messages:
- Don't check for ReceiverTypeData in the printmdo output.
Changes: https://git.openjdk.java.net/jdk/pull/2905/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2905&range=00
Issue: https://bugs.o
On Wed, 10 Mar 2021 04:54:03 GMT, Vipin Sharma wrote:
>> After moving the filter to the next line also can not fit this in one line.
>> In addition to the filter, moving all characters starting from "new
>> RuntimeException(" also goes till 126 char.
>> Following is one suggestion, does it l
On Wed, 10 Mar 2021 05:11:30 GMT, Vipin Sharma wrote:
>> JDK-8261095: Add test for clhsdb "symbol" command
>
> Vipin Sharma has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated formatting and grammer changes
Marked as reviewed by cjplum
> JDK-8261095: Add test for clhsdb "symbol" command
Vipin Sharma has updated the pull request incrementally with one additional
commit since the last revision:
Updated formatting and grammer changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2863/files
- new: htt
> JDK-8261095: Add test for clhsdb "symbol" command
Vipin Sharma has updated the pull request incrementally with one additional
commit since the last revision:
Moving filter call to next line for better formatting
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2863/fil
On Wed, 10 Mar 2021 04:49:27 GMT, Vipin Sharma wrote:
>> test/hotspot/jtreg/serviceability/sa/ClhsdbSymbol.java line 68:
>>
>>> 66: .map(addresses ->
>>> addresses[1])
>>> 67: .orElseThro
On Wed, 10 Mar 2021 04:30:57 GMT, Chris Plummer wrote:
>> Vipin Sharma has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Started using orElseThrow and removed null check following this
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbSymbol.
On Tue, 9 Mar 2021 21:50:25 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>>
On Wed, 10 Mar 2021 03:48:29 GMT, Vipin Sharma wrote:
>> JDK-8261095: Add test for clhsdb "symbol" command
>
> Vipin Sharma has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Started using orElseThrow and removed null check following this
I d
> JDK-8261095: Add test for clhsdb "symbol" command
Vipin Sharma has updated the pull request incrementally with one additional
commit since the last revision:
Started using orElseThrow and removed null check following this
-
Changes:
- all: https://git.openjdk.java.net/jdk/pul
On Wed, 10 Mar 2021 02:16:17 GMT, Daniel D. Daugherty
wrote:
>> David Holmes has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> c
On 10/03/2021 12:19 pm, Daniel D.Daugherty wrote:
On Wed, 10 Mar 2021 00:57:40 GMT, David Holmes wrote:
ObjectMonitors can only be used by JavaThreads (modulo some interactions with hashcodes
and deflation) but we use "Thread*" almost everywhere mainly due to use of
TRAPS (and TRAPS will its
On Wed, 10 Mar 2021 00:57:40 GMT, David Holmes wrote:
>> ObjectMonitors can only be used by JavaThreads (modulo some interactions
>> with hashcodes and deflation) but we use "Thread*" almost everywhere mainly
>> due to use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685
>> is d
> Many tests run `LingeredApp`, get its stack with `jstack`, and then look for
> `LingeredApp.main` in the output, which should appear in the stack trace of
> the main thread. Usually this works fine since the main thread is in a loop,
> and usually blocked in `Thread.sleep()`. However, during t
On Wed, 10 Mar 2021 01:04:31 GMT, Serguei Spitsyn wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use onSpinWait() instead of sleep(), and check for BLOCKED thread state.
>
> Marked as reviewed by sspitsyn (Review
On Tue, 9 Mar 2021 18:13:09 GMT, Leonid Mesnik wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use onSpinWait() instead of sleep(), and check for BLOCKED thread state.
>
> Marked as reviewed by lmesnik (Committer)
On Tue, 9 Mar 2021 07:27:26 GMT, Chris Plummer wrote:
>> Many tests run `LingeredApp`, get its stack with `jstack`, and then look for
>> `LingeredApp.main` in the output, which should appear in the stack trace of
>> the main thread. Usually this works fine since the main thread is in a loop,
>
> ObjectMonitors can only be used by JavaThreads (modulo some interactions with
> hashcodes and deflation) but we use "Thread*" almost everywhere mainly due to
> use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685 is done).
> Also some uses of TRAPS in the API's are wrong as, for
Hi Serguei,
Thanks for taking a look.
On 10/03/2021 9:53 am, Serguei Spitsyn wrote:
On Tue, 9 Mar 2021 18:52:27 GMT, Chris Plummer wrote:
David Holmes has updated the pull request incrementally with three additional
commits since the last revision:
- Fix typo
- Fixed up BiasedLocking c
On Fri, 5 Mar 2021 04:59:02 GMT, David Holmes wrote:
>> ObjectMonitors can only be used by JavaThreads (modulo some interactions
>> with hashcodes and deflation) but we use "Thread*" almost everywhere mainly
>> due to use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685
>> is do
On Tue, 9 Mar 2021 18:52:27 GMT, Chris Plummer wrote:
>> David Holmes has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix typo
>> - Fixed up BiasedLocking code in ObjectSynchronizer::enter
>> - iFixed alignment in macro
>
> JVMTI c
On Sun, 7 Mar 2021 07:32:17 GMT, Yasumasa Suenaga wrote:
> We can command line debugger via "Windows" -> "Console" menu on HSDB. If the
> command shows error message in localized string (e.g. Japanese), it might
> garble as following:
>
>  and
> coredump, but it cannot connect to debug server. CLHSDB does not have a
> command to connect to debug server.
>
> Other jhsdb commands (jstack, jmap, etc...) can co
RFR got migrated to github as https://github.com/openjdk/jdk/pull/2800
-- Igor
On Jun 5, 2020, at 9:10 AM, Igor Ignatyev
mailto:igor.ignat...@oracle.com>> wrote:
Hi Per,
you are reading this correctly, make
TEST=test/hotspot/jtreg/gc/z/TestSmallHeap.java JTREG="VM_OPTIONS=-XX:+UseZGC"
won't
On 10/03/2021 4:55 am, Chris Plummer wrote:
On Fri, 5 Mar 2021 04:59:02 GMT, David Holmes wrote:
ObjectMonitors can only be used by JavaThreads (modulo some interactions with hashcodes
and deflation) but we use "Thread*" almost everywhere mainly due to use of
TRAPS (and TRAPS will itself use
> Hi, Please review
>
> Added jcmd option for dumping CDS archive during application runtime.
> Before this change, user has to dump shared archive in two steps: first run
> application with
> `java -XX:DumpLoadedClassList= `
> to collect shareable class names and saved in file `` ,
On Wed, 3 Mar 2021 20:17:04 GMT, Chris Plummer wrote:
> In the loom repo there are a number of trivial changes to the JDWP agent that
> are not loom specific. Moving them to the jdk repo will make future merges
> simpler, along with making it easier to get a diff of the important
> differences
On Tue, 9 Mar 2021 00:54:25 GMT, Yasumasa Suenaga wrote:
>> We can command line debugger via "Windows" -> "Console" menu on HSDB. If the
>> command shows error message in localized string (e.g. Japanese), it might
>> garble as following:
>>
>> ![garbled](https://user-images.githubusercontent.c
On Tue, 9 Mar 2021 00:54:25 GMT, Yasumasa Suenaga wrote:
>> We can command line debugger via "Windows" -> "Console" menu on HSDB. If the
>> command shows error message in localized string (e.g. Japanese), it might
>> garble as following:
>>
>>  but we use "Thread*" almost everywhere mainly
>> due to use of TRAPS (and TRAPS will itself use JavaThread once JDK-8252685
>> is do
On Tue, 9 Mar 2021 00:54:25 GMT, Yasumasa Suenaga wrote:
>> We can command line debugger via "Windows" -> "Console" menu on HSDB. If the
>> command shows error message in localized string (e.g. Japanese), it might
>> garble as following:
>>
>>  and
>> coredump, but it cannot connect to debug server. CLHSDB does not have a
>> command to connect to debug server.
>>
>> Other jhsdb commands (jstack, jmap, etc...) c
On Tue, 9 Feb 2021 09:12:13 GMT, Stefan Karlsson wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update signal handler part for debugger
>
> src/hotspot/share/runtime/thread.hpp line 848:
>
>> 846: void init_wx(
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 9 Feb 2021 09:06:26 GMT, Stefan Karlsson wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update signal handler part for debugger
>
> src/hotspot/share/runtime/threadWXSetters.hpp line 28:
>
>> 26: #define
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
> out
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Revert "reduce memory consumption"
This reverts commit 70e43ddd453724ce36bf729fa6489c0027957b8e.
-
On Fri, 5 Mar 2021 11:05:57 GMT, Lin Zang wrote:
>> Hi Chris,
>> Thanks a lot, I am still wip to reduce the memory consumption. So I think
>> you could help review after my next update :)
>>
>> BRs,
>> Lin
>
> Update a new patch that reduce the memory consumption issue.
> As mentioned in the CR
On Tue, 9 Mar 2021 07:27:26 GMT, Chris Plummer wrote:
>> Many tests run `LingeredApp`, get its stack with `jstack`, and then look for
>> `LingeredApp.main` in the output, which should appear in the stack trace of
>> the main thread. Usually this works fine since the main thread is in a loop,
>
On Tue, 9 Mar 2021 07:17:28 GMT, Chris Plummer wrote:
>> This a new test that runs jstack on a process that is busy doing things. It
>> runs jstack 4 times as the process is starting up.
>
> Chris Plummer has updated the pull request incrementally with one additional
> commit since the last rev
On Tue, 9 Mar 2021 01:31:33 GMT, Alex Menkov wrote:
> The fix updates ResetPeakThreadCount.java test - increases number of threads,
> but relaxes conditions so start/termination of system threads don't cause
> failures.
> Additional changes:
> - store threads in a list instead of array (we need
On 9/03/2021 7:58 pm, Doug Simon wrote:
On Thu, 4 Mar 2021 23:37:27 GMT, Daniel D. Daugherty wrote:
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
More pointer declaration style fixups
src/jdk.internal.vm.compiler/share/classe
On Thu, 4 Mar 2021 23:37:27 GMT, Daniel D. Daugherty wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More pointer declaration style fixups
>
> src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot
47 matches
Mail list logo
