On 9/03/2021 7:58 pm, Doug Simon wrote:
On Thu, 4 Mar 2021 23:37:27 GMT, Daniel D. Daugherty <[email protected]> wrote:

David Holmes has updated the pull request incrementally with one additional 
commit since the last revision:

   More pointer declaration style fixups

src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java
 line 516:

514:     public final int objectMonitorCxq = getFieldOffset("ObjectMonitor::_cxq", 
Integer.class, "ObjectWaiter*", -1, jdk13Backport);
515:     public final int objectMonitorEntryList = 
getFieldOffset("ObjectMonitor::_EntryList", Integer.class, "ObjectWaiter*", -1, 
jdk13Backport);
516:     public final int objectMonitorSucc = getFieldOffset("ObjectMonitor::_succ", Integer.class, 
JDK < 17 ? "Thread*" : "JavaThread*", -1, jdk13Backport);

That makes my brain hurt...

That's the price of maintaining Graal to work across 10 (and counting...) JDK 
versions.
This change looks good to me. Thanks for the heads up @dholmes-ora - I'll port 
this change to Graal upstream.

Many thanks Doug!

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/2802

Reply via email to