Integrated: 8263342: Add --connect option to jhsdb hsdb/clhsdb

2021-03-22 Thread Yasumasa Suenaga
On Wed, 10 Mar 2021 08:29:37 GMT, Yasumasa Suenaga wrote: > Most of subcommands in jhsdb supports to connect to debug server via > `--connect` command line option, however `hsdb` and `clhsdb` do not accept it. > > Both HSDB and CLHSDB support to connect to debug server, so they should have > c

Re: RFR: 8264004: Don't use TRAPS if no exceptions are thrown [v2]

2021-03-22 Thread Ioi Lam
On Tue, 23 Mar 2021 01:22:56 GMT, Coleen Phillimore wrote: >> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in >> ConstantPool merging functions. >> Tested with vmTestbase/nsk/jvmti and tier1 (in progress). > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8264004: Don't use TRAPS if no exceptions are thrown [v2]

2021-03-22 Thread Ioi Lam
On Tue, 23 Mar 2021 04:59:10 GMT, David Holmes wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> missed THREAD that should be CHECK_false argument. > > src/hotspot/share/prims/jvmtiRedefineClasses.hpp line 484:

Re: RFR: 8264004: Don't use TRAPS if no exceptions are thrown [v2]

2021-03-22 Thread David Holmes
On Tue, 23 Mar 2021 01:22:56 GMT, Coleen Phillimore wrote: >> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in >> ConstantPool merging functions. >> Tested with vmTestbase/nsk/jvmti and tier1 (in progress). > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8263670: pmap and pstack in jhsdb do not work on debug server [v2]

2021-03-22 Thread Yasumasa Suenaga
On Tue, 23 Mar 2021 02:16:43 GMT, Serguei Spitsyn wrote: >> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update testcases > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/PMap.java line 81: > >> 79:

Re: RFR: 8263670: pmap and pstack in jhsdb do not work on debug server [v3]

2021-03-22 Thread Yasumasa Suenaga
> jhsdb supports pmap (jhsdb jmap) and pstack (jhsdb jstack --mixed), and they > work fine if they attach to live process or to coredump, however they do not > work on debug server as following: > > $ jhsdb jmap --connect localhost > Attaching to remote server localhost, please wait... > Debugge

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI [v2]

2021-03-22 Thread lyndseyBeil
On Fri, 19 Mar 2021 21:28:09 GMT, Daniel D. Daugherty wrote: >> Add three tests from JDK-4413752 ported to JVM/TI: >> >> - RawMonitorEnter() with SuspendThread() >> - >> test/hotspot/jtreg/serviceability/jvmti/SuspendWithRawMonitorEnter/SuspendWithRawMonitorEnter.java >> - >> test/hotspot

Re: RFR: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"

2021-03-22 Thread Serguei Spitsyn
On Mon, 22 Mar 2021 21:56:01 GMT, Alex Menkov wrote: > The fix updates the test to use special method to wait for ThreadDeathEvent > for the specific thread, ignoring event from other threads Hi Alex, LGTM++ Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https:/

Re: RFR: 8263572: Output from jstack mixed mode is misaligned [v2]

2021-03-22 Thread Serguei Spitsyn
On Tue, 16 Mar 2021 06:09:25 GMT, Koichi Sakata wrote: >> When running jstack with mixed option, the output of the lines that doesn't >> have an address are misaligned as followings. >> >> $ sudo jhsdb jstack --mixed --pid 8281 >> - 8330 - >> "event-handler" #20

Re: RFR: 8263342: Add --connect option to jhsdb hsdb/clhsdb [v2]

2021-03-22 Thread Serguei Spitsyn
On Thu, 11 Mar 2021 00:20:35 GMT, Yasumasa Suenaga wrote: >> Most of subcommands in jhsdb supports to connect to debug server via >> `--connect` command line option, however `hsdb` and `clhsdb` do not accept >> it. >> >> Both HSDB and CLHSDB support to connect to debug server, so they should h

Re: RFR: 8263670: pmap and pstack in jhsdb do not work on debug server [v2]

2021-03-22 Thread Serguei Spitsyn
On Thu, 18 Mar 2021 05:17:10 GMT, Yasumasa Suenaga wrote: >> jhsdb supports pmap (jhsdb jmap) and pstack (jhsdb jstack --mixed), and they >> work fine if they attach to live process or to coredump, however they do not >> work on debug server as following: >> >> $ jhsdb jmap --connect localhost

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI [v2]

2021-03-22 Thread Serguei Spitsyn
On Mon, 22 Mar 2021 14:22:36 GMT, Daniel D. Daugherty wrote: >> Hi Dan, >> >> If you change the native methods, e.g. : >> native static void RawMonitorEnter(int id); >> To something like: >> native static int RawMonitorEnter(); >> >> You can then handle the jvmti error in the Java code, so you

Re: RFR: 8264004: Don't use TRAPS if no exceptions are thrown [v2]

2021-03-22 Thread Coleen Phillimore
> Removed the TRAPS in function declarations in jvmtiRedefineClasses and in > ConstantPool merging functions. > Tested with vmTestbase/nsk/jvmti and tier1 (in progress). Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: missed THR

RFR: 8264004: Don't use TRAPS if no exceptions are thrown

2021-03-22 Thread Coleen Phillimore
Removed the TRAPS in function declarations in jvmtiRedefineClasses and in ConstantPool merging functions. Tested with vmTestbase/nsk/jvmti and tier1 (in progress). - Commit messages: - Don't pass TRAPS to functions that don't throw exceptions. Changes: https://git.openjdk.java.net/

Re: RFR: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"

2021-03-22 Thread Leonid Mesnik
On Mon, 22 Mar 2021 21:56:01 GMT, Alex Menkov wrote: > The fix updates the test to use special method to wait for ThreadDeathEvent > for the specific thread, ignoring event from other threads Marked as reviewed by lmesnik (Committer). - PR: https://git.openjdk.java.net/jdk/pull/31

Re: RFR: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"

2021-03-22 Thread Chris Plummer
On Mon, 22 Mar 2021 21:56:01 GMT, Alex Menkov wrote: > The fix updates the test to use special method to wait for ThreadDeathEvent > for the specific thread, ignoring event from other threads Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3

Re: RFR: 8259070: Add jcmd option to dump CDS [v5]

2021-03-22 Thread Yumin Qi
> Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to collect shareable class names and saved in file `` ,

Re: RFR: 8263976: Remove block allocation from BasicHashtable [v2]

2021-03-22 Thread Ioi Lam
On Mon, 22 Mar 2021 22:48:05 GMT, Coleen Phillimore wrote: >> From CR: >> The useful/general BasicHashtable uses a block allocation scheme to >> reportedly reduce fragmentation. When the StringTable and SymbolTable used >> to use this hashtable, performance benefits were reportedly observed bec

Re: RFR: 8263976: Remove block allocation from BasicHashtable [v2]

2021-03-22 Thread Coleen Phillimore
> From CR: > The useful/general BasicHashtable uses a block allocation scheme to > reportedly reduce fragmentation. When the StringTable and SymbolTable used to > use this hashtable, performance benefits were reportedly observed because of > the block allocation scheme. Since these tables were m

Re: RFR: 8263976: Remove block allocation from BasicHashtable

2021-03-22 Thread Coleen Phillimore
On Mon, 22 Mar 2021 21:58:09 GMT, Ioi Lam wrote: >> Yes, I'd like to make the constructors initialize the fields, but didn't >> know what to do about this block zeroing code. Would you have to add it >> back with deterministic GC? > >> Yes, I'd like to make the constructors initialize the fiel

RFR: 8262081: vmTestbase/nsk/jdi/ThreadDeathRequest/addThreadFilter/addthreadfilter001/TestDescription.java failed with "ERROR: eventSet1.size() != 3 :: 2"

2021-03-22 Thread Alex Menkov
The fix updates the test to use special method to wait for ThreadDeathEvent for the specific thread, ignoring event from other threads - Commit messages: - Filter out events from unexpected threads Changes: https://git.openjdk.java.net/jdk/pull/3133/files Webrev: https://webrevs.o

Re: RFR: 8263976: Remove block allocation from BasicHashtable

2021-03-22 Thread Ioi Lam
On Mon, 22 Mar 2021 21:54:23 GMT, Coleen Phillimore wrote: >> src/hotspot/share/utilities/hashtable.cpp line 64: >> >>> 62: >>> 63: if (DumpSharedSpaces) { >>> 64: // Avoid random bits in structure padding so we can have >>> deterministic content in CDS archive >> >> Hmm, the sequence l

Re: RFR: 8263976: Remove block allocation from BasicHashtable

2021-03-22 Thread Ioi Lam
On Mon, 22 Mar 2021 15:49:24 GMT, Coleen Phillimore wrote: > From CR: > The useful/general BasicHashtable uses a block allocation scheme to > reportedly reduce fragmentation. When the StringTable and SymbolTable used to > use this hashtable, performance benefits were reportedly observed because

Re: RFR: 8263976: Remove block allocation from BasicHashtable

2021-03-22 Thread Coleen Phillimore
On Mon, 22 Mar 2021 21:42:51 GMT, Ioi Lam wrote: >> From CR: >> The useful/general BasicHashtable uses a block allocation scheme to >> reportedly reduce fragmentation. When the StringTable and SymbolTable used >> to use this hashtable, performance benefits were reportedly observed because >> o

Re: RFR: 8263976: Remove block allocation from BasicHashtable

2021-03-22 Thread Lois Foltan
On Mon, 22 Mar 2021 15:49:24 GMT, Coleen Phillimore wrote: > From CR: > The useful/general BasicHashtable uses a block allocation scheme to > reportedly reduce fragmentation. When the StringTable and SymbolTable used to > use this hashtable, performance benefits were reportedly observed because

Integrated: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices

2021-03-22 Thread Leonid Mesnik
On Fri, 19 Mar 2021 22:20:35 GMT, Leonid Mesnik wrote: > 8263895: Test > nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses > incorrect indices This pull request has now been integrated. Changeset: f62b1008 Author:Leonid Mesnik URL: https://git.openjdk.ja

Re: RFR: 8263976: Remove block allocation from BasicHashtable

2021-03-22 Thread Coleen Phillimore
On Mon, 22 Mar 2021 15:49:24 GMT, Coleen Phillimore wrote: > From CR: > The useful/general BasicHashtable uses a block allocation scheme to > reportedly reduce fragmentation. When the StringTable and SymbolTable used to > use this hashtable, performance benefits were reportedly observed because

RFR: 8263976: Remove block allocation from BasicHashtable

2021-03-22 Thread Coleen Phillimore
>From CR: The useful/general BasicHashtable uses a block allocation scheme to reportedly reduce fragmentation. When the StringTable and SymbolTable used to use this hashtable, performance benefits were reportedly observed because of the block allocation scheme. Since these tables were moved to t

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI [v2]

2021-03-22 Thread Daniel D . Daugherty
On Mon, 22 Mar 2021 09:02:02 GMT, Robbin Ehn wrote: >> @sspitsyn - Thanks for the review! I figured you would enjoy this 20 year old >> blast from the past! I'm tempted to ping @karenkinnear just to see if she'll >> remember these tests! >> >> I'll fix the indents in the .cpp files. Right now I'

Integrated: 8263855: Use the blessed modifier order in java.management/naming

2021-03-22 Thread Alex Blewitt
On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt wrote: > As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. This pull request has now been integrated. Changeset: 5262d95b Author:Alex Blewitt Co

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

2021-03-22 Thread Daniel Fuchs
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Alex Blewitt has updated the pull request incrementally with one additional > commit

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v29]

2021-03-22 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v18]

2021-03-22 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request incrementally with two additional commits since the last revision: - remove parallel option and dumpheapext command - Revert "hide the dumpheapext error message" This reverts commit 1af0e1e2bfab4f

Re: RFR: 8263855: Use the blessed modifier order in java.management/naming [v2]

2021-03-22 Thread Aleksei Efimov
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt wrote: >> As with #2993 changing the order of `final static` to `static final` for the >> `java.management`, `java.management.rmi` and `java.naming` modules. > > Alex Blewitt has updated the pull request incrementally with one additional > commit

Re: RFR: 8176026: SA: Huge heap sizes cause a negative value to be displayed in the jhisto heap total

2021-03-22 Thread Kevin Walls
On Fri, 19 Mar 2021 11:49:39 GMT, Koichi Sakata wrote: > When a heap is used more than about 2.1GB, clhsdb jhisto shows a negative > number in the total field. > > $ java -Xmx20g Sample > > $ jhsdb clhsdb --pid 5773 > Attaching to process 5773, please wait... > hsdb> jhisto > ... > 299:

Re: RFR: 8263895: Test nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp uses incorrect indices [v2]

2021-03-22 Thread Kevin Walls
On Sat, 20 Mar 2021 03:00:52 GMT, Leonid Mesnik wrote: >> 8263895: Test >> nsk/jvmti/GetThreadGroupChildren/getthrdgrpchld001/getthrdgrpchld001.cpp >> uses incorrect indices > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v17]

2021-03-22 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: - resize large object threshold - Merge branch 'master' into par-dump - Merge branch 'master' into par-dump

Re: RFR: 8262881: port JVM/DI tests from JDK-4413752 to JVM/TI [v2]

2021-03-22 Thread Robbin Ehn
On Fri, 19 Mar 2021 20:16:29 GMT, Daniel D. Daugherty wrote: >> Hi Dan, >> It is interesting how much these tests were changed when ported. >> A couple of indent-related comments. >> There are incorrect indents in the following lines in all .cpp files: >> ``` >> 68 Java_SuspendWithObjectMonitor

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v10]

2021-03-22 Thread Lin Zang
On Fri, 19 Mar 2021 20:01:01 GMT, Chris Plummer wrote: >> Dear Ralf and Chris, >> >>> to be honest I would prefer if we would not add the parallel option but >>> instead do it automatically depending on the number of GC threads >>> available. I doubt that the user has a good idea about number