Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread Robbin Ehn
On Wed, 14 Apr 2021 02:15:07 GMT, David Holmes wrote: > Latest updates look good - thanks. > > David Thank you! - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v8]

2021-04-13 Thread Robbin Ehn
> A suspend request is done by handshaking thread target thread(s). When > executing the handshake operation we know the target mutator thread is in a > dormant state (as in safepoint safe state). We have a guarantee that it will > check it's poll before leaving the dormant state. To stop the th

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 16:49:53 GMT, Daniel D. Daugherty wrote: >> Robbin Ehn has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Obsolete unused flags >> - Review fixes 3 > > src/hotspot/share/runtime/arguments.cpp line 525: > >> 523: {

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread Robbin Ehn
On Wed, 14 Apr 2021 02:10:18 GMT, David Holmes wrote: >> Robbin Ehn has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Obsolete unused flags >> - Review fixes 3 > > src/hotspot/share/runtime/thread.cpp line 1446: > >> 1444: // The c

Re: RFR: 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods

2021-04-13 Thread Vladimir Kozlov
On Wed, 14 Apr 2021 00:35:55 GMT, Tom Rodriguez wrote: > 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of > nmethods Good. - Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3481

Re: RFR: 8265104: CpuLoad and SystemCpuLoad in OperatingSystem MXBean returns -1.0 [v2]

2021-04-13 Thread David Holmes
On Tue, 13 Apr 2021 06:55:20 GMT, Yasumasa Suenaga wrote: >> I got -1.0 from both CpuLoad and SystemCpuLoad in OperatingSystem MXBean >> when I run the application on Fedora 33 x64 which is installed cgroups V2. >> >> ![jconsole-cpuload](https://user-images.githubusercontent.com/7421132/1144857

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread David Holmes
On Tue, 13 Apr 2021 11:57:36 GMT, Robbin Ehn wrote: >> A suspend request is done by handshaking thread target thread(s). When >> executing the handshake operation we know the target mutator thread is in a >> dormant state (as in safepoint safe state). We have a guarantee that it will >> check

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread David Holmes
On Tue, 13 Apr 2021 11:57:36 GMT, Robbin Ehn wrote: >> A suspend request is done by handshaking thread target thread(s). When >> executing the handshake operation we know the target mutator thread is in a >> dormant state (as in safepoint safe state). We have a guarantee that it will >> check

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8259070: Add jcmd option to dump CDS [v11]

2021-04-13 Thread Ioi Lam
On Tue, 13 Apr 2021 23:04:24 GMT, Yumin Qi wrote: >> Hi, Please review >> >> Added jcmd option for dumping CDS archive during application runtime. >> Before this change, user has to dump shared archive in two steps: first run >> application with >> `java -XX:DumpLoadedClassList= ` >

RFR: 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods

2021-04-13 Thread Tom Rodriguez
8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods - Commit messages: - 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods Changes: https://git.openjdk.java.net/jdk/pull/3481/files Webrev: https://webrevs.openjdk.java.

RFR: 8265153: add time based test for ThreadMXBean.getThreadInfo() and ThreadInfo.getLockOwnerName()

2021-04-13 Thread Daniel D . Daugherty
The synopsis pretty much says it all. There's a more detailed history in the RFE itself. Currently running the new test thru Mach5 Tier[1-7]. I've run the test thru several 12 hour runs on my MBP13 and on my Linux-X64 server. - Commit messages: - 8265153: add time based test for Th

Re: RFR: 8263636: Add --disable-registry option to jhsdb debugd [v5]

2021-04-13 Thread Yasumasa Suenaga
On Wed, 7 Apr 2021 00:12:11 GMT, Yasumasa Suenaga wrote: >> `jhsdb debugd` will start RMI registry by default, but we want to prevent it >> due to port confliction in some cases. We can control it with >> `sun.jvm.hotspot.rmi.startRegistry` system property. However we have no way >> to set it

Re: RFR: 8259070: Add jcmd option to dump CDS [v11]

2021-04-13 Thread Yumin Qi
> Hi, Please review > > Added jcmd option for dumping CDS archive during application runtime. > Before this change, user has to dump shared archive in two steps: first run > application with > `java -XX:DumpLoadedClassList= ` > to collect shareable class names and saved in file `` ,

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread David Holmes
On 14/04/2021 2:59 am, Daniel D.Daugherty wrote: On Tue, 13 Apr 2021 11:57:36 GMT, Robbin Ehn wrote: Robbin Ehn has updated the pull request incrementally with two additional commits since the last revision: - Obsolete unused flags - Review fixes 3 Still thumbs up. I only looked at the

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread Daniel D . Daugherty
On Tue, 13 Apr 2021 11:57:36 GMT, Robbin Ehn wrote: >> A suspend request is done by handshaking thread target thread(s). When >> executing the handshake operation we know the target mutator thread is in a >> dormant state (as in safepoint safe state). We have a guarantee that it will >> check

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8265104: CpuLoad and SystemCpuLoad in OperatingSystem MXBean returns -1.0 [v2]

2021-04-13 Thread Severin Gehwolf
On Tue, 13 Apr 2021 06:55:20 GMT, Yasumasa Suenaga wrote: >> I got -1.0 from both CpuLoad and SystemCpuLoad in OperatingSystem MXBean >> when I run the application on Fedora 33 x64 which is installed cgroups V2. >> >> ![jconsole-cpuload](https://user-images.githubusercontent.com/7421132/1144857

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 11:57:36 GMT, Robbin Ehn wrote: >> A suspend request is done by handshaking thread target thread(s). When >> executing the handshake operation we know the target mutator thread is in a >> dormant state (as in safepoint safe state). We have a guarantee that it will >> check

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v7]

2021-04-13 Thread Robbin Ehn
> A suspend request is done by handshaking thread target thread(s). When > executing the handshake operation we know the target mutator thread is in a > dormant state (as in safepoint safe state). We have a guarantee that it will > check it's poll before leaving the dormant state. To stop the th

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 07:44:58 GMT, David Holmes wrote: > Could be a neat use of a lambda "on_suspension_do" ... If no one else picks that up, I'll give it go after this :) - PR: https://git.openjdk.java.net/jdk/pull/3191

Re: RFR: 8257831: Suspend with handshakes [v6]

2021-04-13 Thread David Holmes
On 13/04/2021 5:26 pm, Robbin Ehn wrote: On Tue, 13 Apr 2021 02:41:41 GMT, David Holmes wrote: Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge branch 'master' into SuspendInHandshake - Review

Re: RFR: 8257831: Suspend with handshakes [v6]

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 02:51:32 GMT, David Holmes wrote: >> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge branch 'master' into SuspendInHandshake >> - Review fixes 2 >> - White space fixes

Re: RFR: 8257831: Suspend with handshakes [v4]

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 02:46:46 GMT, David Holmes wrote: >> src/hotspot/share/runtime/thread.cpp line 455: >> >>> 453: ParkEvent::Release(_ParkEvent); >>> 454: // Can be racingly loaded in signal handler via has_terminated() >>> 455: Atomic::store(&_ParkEvent, (ParkEvent*)NULL); >> >> Nice s

Re: RFR: 8257831: Suspend with handshakes [v2]

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 02:24:45 GMT, David Holmes wrote: >> Any unsafe (not native/blocked) is fine, therefore I never completed the >> transition. >> I set the state to _thread_in_vm before. > > Sorry I was misremembering the restriction, please remove the transition to > _thread_in_vm again (it

Re: RFR: 8257831: Suspend with handshakes [v6]

2021-04-13 Thread Robbin Ehn
On Tue, 13 Apr 2021 02:41:41 GMT, David Holmes wrote: >> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge branch 'master' into SuspendInHandshake >> - Review fixes 2 >> - White space fixes

Re: RFR: 8257831: Suspend with handshakes [v6]

2021-04-13 Thread Robbin Ehn
On Mon, 12 Apr 2021 20:51:17 GMT, Daniel D. Daugherty wrote: >> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge branch 'master' into SuspendInHandshake >> - Review fixes 2 >> - White spa

Re: RFR: 8265104: CpuLoad and SystemCpuLoad in OperatingSystem MXBean returns -1.0 [v2]

2021-04-13 Thread Yasumasa Suenaga
On Tue, 13 Apr 2021 06:14:42 GMT, David Holmes wrote: > This strikes me as the wrong fix to the problem. isCpuSetSameAsHostCpuSet is > only intended to be used as a simple optimization when the configured cpuset > happens to match the hosts. What you are looking for is a fix to the problem > w