On Tue, 13 Apr 2021 02:51:32 GMT, David Holmes <[email protected]> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge branch 'master' into SuspendInHandshake
>> - Review fixes 2
>> - White space fixes
>> - Merge branch 'master' into SuspendInHandshake
>> - Review fixes
>> - Merge branch 'master' into SuspendInHandshake
>> - Merge branch 'master' into SuspendInHandshake
>> - 8257831: Suspend with handshake (review baseline)
>
> src/hotspot/share/runtime/thread.hpp line 746:
>
>> 744:
>> 745: // _ParkEvent is cleared
>> 746: bool has_terminated() { return
>> Atomic::load(&_ParkEvent) == NULL; };
>
> Please change the comment to:
>
> // Termination indicator used by the signal handler. _ParkEvent is just a
> convenient field
> // we can NULL out after setting the JavaThread termination state (which
> can't itself be read
> // from the signal handler if a signal hits during the Thread destructor.
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/3191
