On Tue, 11 May 2021 23:34:29 GMT, Daniel D. Daugherty
wrote:
>> The synopsis pretty much says it all. There's a more detailed history in the
>> RFE itself.
>>
>> Currently running the new test thru Mach5 Tier[1-7].
>> I've run the test thru several 12 hour runs on my MBP13 and
>> on my Linux-X
On Fri, 14 May 2021 00:51:12 GMT, Yasumasa Suenaga wrote:
>> I think this is better, but I think better help output is needed. `prefix`
>> has a default and `unique_id` does not. I think both of these need to be
>> mentioned in the help output. Also, if `unique_id` is not specified, then
>> th
On Fri, 14 May 2021 02:08:13 GMT, Lin Zang wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
>> line 1528:
>>
>>> 1526: }
>>> 1527: writeInteger(0);
>>> 1528: writeInteger(size);
>>
>> You've added `writeInteger(
On Fri, 14 May 2021 02:28:17 GMT, Lin Zang wrote:
>> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
>> out
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought i
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
> out
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 14 additi
On Thu, 13 May 2021 20:23:10 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 12 additional commits
>> sinc
On Thu, 13 May 2021 18:28:24 GMT, Chris Plummer wrote:
> I think maybe the property name of sun.jvm.hotspot.rmi.serverNamePrefix was
> not a good choice, and is making it harder to come up with good argument
> names and syntax. If designing this from scratch, I would have called it
> sun.jvm.h
Thanks for the review Ioi!
David
On 14/05/2021 3:03 am, Ioi Lam wrote:
On Thu, 13 May 2021 04:59:11 GMT, David Holmes wrote:
Our code is littered with API's that take, or manifest, a Thread* and then assert/guarantee that it
must be a JavaThread, rather than taking/manifesting a JavaThread
Maybe you were thinking
`jdk.internal.reflect.ReflectUtil::isVMAnonymousClass` that is now
removed by this patch [1].
[1]
https://github.com/openjdk/jdk/pull/3974/files#diff-1af3026a3b4942af3ebe6a4df02f8952fb9d51bf93336a2f7f93ce175d047574
On 5/13/21 12:03 PM, Brian Goetz wrote:
Thanks for ch
On Wed, 12 May 2021 11:11:39 GMT, Lin Zang wrote:
>> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed
>> out
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought i
Thanks for checking. I thought I remembered something like this
somewhere, but it may be that you already fixed such tests when you did
hidden classes? In any case, seems like we're all good now.
Cheers,
-Brian
On 5/13/2021 2:50 PM, Mandy Chung wrote:
I did a search on java.base and the test
I did a search on java.base and the tests on `String::indexOf` and
`String::contains` of a slash and don't spot any such test. The JDK has
no use of VM anonymous class. If the test is trying to determine if
it's lambda proxy class, it should be converted to call
`Class::isHidden` but testing
On Thu, 13 May 2021 05:56:00 GMT, Yasumasa Suenaga wrote:
>> Ok, this explanation seems reasonable, but is not something that is really
>> conveyed with the the name `--prefix` or with the help "Sets the prefix to
>> distinguish SA debugee". We are at the same giving too much and too little
>>
On Tue, 27 Apr 2021 23:21:51 GMT, Chris Plummer wrote:
>> The synopsis pretty much says it all. There's a more detailed history in the
>> RFE itself.
>>
>> Currently running the new test thru Mach5 Tier[1-7].
>> I've run the test thru several 12 hour runs on my MBP13 and
>> on my Linux-X64 serv
On Thu, 13 May 2021 04:59:11 GMT, David Holmes wrote:
>> Our code is littered with API's that take, or manifest, a Thread* and then
>> assert/guarantee that it must be a JavaThread, rather than
>> taking/manifesting a JavaThread in the first place. The main reason for this
>> is that the TRAPS
On Thu, 13 May 2021 08:12:22 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Drop exit_delta and the VMTestbase style of exiting on test failure.
>
> Hi Dan,
>
> Seems fine. Thanks for the
On Thu, 13 May 2021 03:26:50 GMT, Vladimir Kozlov wrote:
> Compiler related changes seems fine.
> @dougxc, note that jvmci is affected. It looks reasonable for me but you may
> need to check if it is correct from libgraal POV.
I tried to test this patch against GraalVM but am blocked due to
`j
On Thu, 13 May 2021 12:31:44 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Tue, 11 May 2021 12:50:31 GMT, Harold Seigel wrote:
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> t
On Thu, 13 May 2021 07:19:03 GMT, David Holmes wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix Weak hidden comment
>
> src/hotspot/share/oops/constantPool.hpp line 493:
>
>> 491: // object into a CONSTANT_S
On Wed, 12 May 2021 22:30:30 GMT, Mandy Chung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test changes and small fixes
>
> src/hotspot/share/classfile/classLoaderData.cpp line 299:
>
>> 297: }
>> 298:
>> 299
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> the tests were modified to use hidden classes, others were
On Tue, 11 May 2021 23:34:29 GMT, Daniel D. Daugherty
wrote:
>> The synopsis pretty much says it all. There's a more detailed history in the
>> RFE itself.
>>
>> Currently running the new test thru Mach5 Tier[1-7].
>> I've run the test thru several 12 hour runs on my MBP13 and
>> on my Linux-X
On Wed, 12 May 2021 16:10:24 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
24 matches
Mail list logo
