Maybe you were thinking
`jdk.internal.reflect.ReflectUtil::isVMAnonymousClass` that is now
removed by this patch [1].
[1]
https://github.com/openjdk/jdk/pull/3974/files#diff-1af3026a3b4942af3ebe6a4df02f8952fb9d51bf93336a2f7f93ce175d047574
On 5/13/21 12:03 PM, Brian Goetz wrote:
Thanks for checking. I thought I remembered something like this
somewhere, but it may be that you already fixed such tests when you
did hidden classes? In any case, seems like we're all good now.
Cheers,
-Brian
On 5/13/2021 2:50 PM, Mandy Chung wrote:
I did a search on java.base and the tests on `String::indexOf` and
`String::contains` of a slash and don't spot any such test. The JDK
has no use of VM anonymous class. If the test is trying to
determine if it's lambda proxy class, it should be converted to call
`Class::isHidden` but testing of the class name containing a slash is
still valid (I haven't found any of such test though).
Mandy
On 5/11/21 6:20 AM, Brian Goetz wrote:
There may be some JDK code that checks for anon classes by comparing the name
to see if it contains a slash, especially tests, but which don’t say
“anonymous”. Did you do a search for these idioms too, which are now dead
tests?
Sent from my iPad
On May 11, 2021, at 8:59 AM, Harold Seigel<hsei...@openjdk.java.net> wrote:
Please review this large change to remove Unsafe::defineAnonymousClass(). The
change removes dAC relevant code and changes a lot of tests. Many of the
changed tests need renaming. I hope to do this in a follow up RFE. Some of
the tests were modified to use hidden classes, others were deleted because
either similar hidden classes tests already exist or they tested dAC specific
functionality, such as host classes.
This change was tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and
Mach5 tiers 3-7 on Linux x64.
Thanks, Harold
-------------
Commit messages:
- 8243287: Removal of Unsafe::defineAnonymousClass
Changes:https://git.openjdk.java.net/jdk/pull/3974/files
Webrev:https://webrevs.openjdk.java.net/?repo=jdk&pr=3974&range=00
Issue:https://bugs.openjdk.java.net/browse/JDK-8243287
Stats: 3516 lines in 116 files changed: 69 ins; 3181 del; 266 mod
Patch:https://git.openjdk.java.net/jdk/pull/3974.diff
Fetch: git fetchhttps://git.openjdk.java.net/jdk pull/3974/head:pull/3974
PR:https://git.openjdk.java.net/jdk/pull/3974
