Re: RFR: 8272805: Avoid looking up standard charsets [v2]

2021-08-24 Thread Alexander Zvegintsev
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote: >> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120. >> >> In many places standard charsets are looked up via their names, for example: >> absolutePath.getBytes("UTF-8"); >> >> This could be done more efficiently(up t

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v5]

2021-08-24 Thread Lin Zang
On Tue, 24 Aug 2021 07:12:51 GMT, Lin Zang wrote: >> This PR rewrite the implementation of the HeapHprofBinWriter, which could >> simplify the logic of current implementation. >> please see detail description at >> https://bugs.openjdk.java.net/browse/JDK-8269685. > > Lin Zang has updated the p

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v6]

2021-08-24 Thread Lin Zang
> This PR rewrite the implementation of the HeapHprofBinWriter, which could > simplify the logic of current implementation. > please see detail description at > https://bugs.openjdk.java.net/browse/JDK-8269685. Lin Zang has updated the pull request incrementally with one additional commit since

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v5]

2021-08-24 Thread Serguei Spitsyn
On Tue, 24 Aug 2021 07:12:51 GMT, Lin Zang wrote: >> This PR rewrite the implementation of the HeapHprofBinWriter, which could >> simplify the logic of current implementation. >> please see detail description at >> https://bugs.openjdk.java.net/browse/JDK-8269685. > > Lin Zang has updated the p

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v3]

2021-08-24 Thread Serguei Spitsyn
On Mon, 5 Jul 2021 12:04:17 GMT, Lin Zang wrote: >> This PR rewrite the implementation of the HeapHprofBinWriter, which could >> simplify the logic of current implementation. >> please see detail description at >> https://bugs.openjdk.java.net/browse/JDK-8269685. > > Lin Zang has updated the pu

Re: RFR: 8178287: AsyncGetCallTrace fails to traverse valid Java stacks [v4]

2021-08-24 Thread David Holmes
On 24/08/2021 9:40 am, Marcus Hirt wrote: On Mon, 23 Aug 2021 10:57:54 GMT, David Holmes wrote: @dcubed-ojdk , @dholmes-ora would you be willing/able to take a look at this change, pretty please? Sorry @jbachorik but frames and code-blobs are not an area I know. David @dholmes-ora, do y

Re: RFR: 8269685: Optimize HeapHprofBinWriter implementation [v5]

2021-08-24 Thread Lin Zang
> This PR rewrite the implementation of the HeapHprofBinWriter, which could > simplify the logic of current implementation. > please see detail description at > https://bugs.openjdk.java.net/browse/JDK-8269685. Lin Zang has updated the pull request incrementally with one additional commit since