On Tue, 24 Aug 2021 07:12:51 GMT, Lin Zang <lz...@openjdk.org> wrote:
>> This PR rewrite the implementation of the HeapHprofBinWriter, which could >> simplify the logic of current implementation. >> please see detail description at >> https://bugs.openjdk.java.net/browse/JDK-8269685. > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > code clean up and remove useless methods Hi Serguei, I update the PR to make the `calculateGlobalJNIHandlesDumpRecordSize()` method abstract. For other empty ones that already there in original implementation, I will leave them as they are. do you think it is OK? BRs, Lin ------------- PR: https://git.openjdk.java.net/jdk/pull/4666
