RFR: 8275384: Change nested classes in jdk.jconsole to static nested classes

2021-10-18 Thread Andrey Turbanov
Non-static classes hold a link to their parent classes, which can be avoided. - Commit messages: - [PATCH] Change nested classes in jdk.jconsole to static nested classes Changes: https://git.openjdk.java.net/jdk/pull/5974/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=

RFR: 8275385: Change nested classes in jdk.jdi to static nested classes

2021-10-18 Thread Andrey Turbanov
Non-static classes hold a link to their parent classes, which can be avoided. - Commit messages: - [PATCH] Change nested classes in jdk.jdi to static nested classes Changes: https://git.openjdk.java.net/jdk/pull/5978/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5978&

Re: RFR: 8275384: Change nested classes in jdk.jconsole to static nested classes

2021-10-18 Thread Alan Bateman
On Sat, 16 Oct 2021 20:32:43 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5974

Re: RFR: 8266936: Add a finalization JFR event [v19]

2021-10-18 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and mit

Re: RFR: 8275384: Change nested classes in jdk.jconsole to static nested classes

2021-10-18 Thread Serguei Spitsyn
On Sat, 16 Oct 2021 20:32:43 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by sspitsyn (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5974

Re: RFR: 8275385: Change nested classes in jdk.jdi to static nested classes

2021-10-18 Thread Serguei Spitsyn
On Sun, 17 Oct 2021 17:28:37 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by sspitsyn (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5978

Integrated: 8275322: Change nested classes in java.management to static nested classes

2021-10-18 Thread Andrey Turbanov
On Fri, 15 Oct 2021 06:43:13 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. This pull request has now been integrated. Changeset: 1afddb25 Author:Andrey Turbanov Committer: Daniel Fuchs URL: https://git.openjdk.java.net/j

Some call sites don't pass 'size' to sharedRuntime::dtrace_object_alloc/dtrace_object_alloc_base

2021-10-18 Thread Denghui Dong
Hi, A new param named 'size' was added to sharedRuntime::dtrace_object_alloc/dtrace_object_alloc_base in JDK-8039904("dtrace/hotspot/Monitors/Monitors001 fails with "assert(s > 0) failed: Bad size calculated"). But in some places where these two functions are called, this new parameter is not

Re: RFR: 8275384: Change nested classes in jdk.jconsole to static nested classes

2021-10-18 Thread Mandy Chung
On Sat, 16 Oct 2021 20:32:43 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5974

Re: RFR: 8266936: Add a finalization JFR event [v10]

2021-10-18 Thread Erik Gahlin
On Fri, 27 Aug 2021 15:23:35 GMT, Markus Grönlund wrote: >> Greetings, >> >> Object.finalize() was deprecated in JDK9. There is an ongoing effort to >> replace and mitigate Object.finalize() uses in the JDK libraries; please see >> https://bugs.openjdk.java.net/browse/JDK-8253568 for more info

Re: RFR: 8266936: Add a finalization JFR event [v10]

2021-10-18 Thread Markus Grönlund
On Tue, 31 Aug 2021 08:42:58 GMT, Erik Gahlin wrote: >> Markus Grönlund has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - localize >> - cleanup >> - FinalizerStatistics > > test/jdk/jdk/jfr/event/runtime/TestFinalizerStatisticsEvent.

Re: RFR: 8266936: Add a finalization JFR event [v10]

2021-10-18 Thread Markus Grönlund
On Tue, 31 Aug 2021 08:45:54 GMT, Erik Gahlin wrote: >> Markus Grönlund has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - localize >> - cleanup >> - FinalizerStatistics > > src/java.base/share/classes/java/lang/ref/Finalizer.java lin

Re: RFR: 8266936: Add a finalization JFR event [v20]

2021-10-18 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and mit

Re: RFR: 8266936: Add a finalization JFR event [v12]

2021-10-18 Thread Markus Grönlund
On Fri, 24 Sep 2021 22:31:18 GMT, Mandy Chung wrote: >> Markus Grönlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> no precompiled headers and mtServiceability nmt classification > > Hi Markus, > > It's a little surprised to see Fin

Integrated: 8266936: Add a finalization JFR event

2021-10-18 Thread Markus Grönlund
On Thu, 8 Jul 2021 19:47:26 GMT, Markus Grönlund wrote: > Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more informatio

RFR: JDK-8275436 [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect

2021-10-18 Thread Daniel D . Daugherty
This reverts commit 31500692d1503cb73249e0425e693049258a. - Commit messages: - JDK-8275436 [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect Changes: https://git.openjdk.java.net/jdk/pull/5994/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&p

Re: RFR: JDK-8275436 [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect

2021-10-18 Thread Daniel D . Daugherty
On Mon, 18 Oct 2021 18:14:16 GMT, Markus Grönlund wrote: >> This reverts commit 31500692d1503cb73249e0425e693049258a. > > Thanks for creating the backout Dan, looks good. @mgronlun - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk/pull/5994

Re: RFR: JDK-8275436 [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect

2021-10-18 Thread Markus Grönlund
On Mon, 18 Oct 2021 17:58:25 GMT, Daniel D. Daugherty wrote: > This reverts commit 31500692d1503cb73249e0425e693049258a. Thanks for creating the backout Dan, looks good. - Marked as reviewed by mgronlun (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5994

Integrated: JDK-8275436 [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect

2021-10-18 Thread Daniel D . Daugherty
On Mon, 18 Oct 2021 17:58:25 GMT, Daniel D. Daugherty wrote: > This reverts commit 31500692d1503cb73249e0425e693049258a. This pull request has now been integrated. Changeset: a03119ce Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/a03119ce1a34642565c669

Re: RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v7]

2021-10-18 Thread Richard Reingruber
> This change fixes deadlocks described in the JBS-bug by: > > * Releasing `handlerLock` before waiting on `threadLock` in > `blockOnDebuggerSuspend()` > > * Notifying on `threadLock` in `threadControl_reset()` > > Also the actions in handleAppResumeBreakpoint() are moved/deferred until > doPen

Re: RFR: 8274687: JDWP deadlocks if some Java thread reaches wait in blockOnDebuggerSuspend [v4]

2021-10-18 Thread Richard Reingruber
On Fri, 15 Oct 2021 11:52:09 GMT, Richard Reingruber wrote: > > > Hm, I think this can be simplified by swaping blockOnDebuggerSuspend() and > trackAppResume(). Can't try it today but will on Monday. I've done that with commit https://github.com/openjdk/jdk/pull/5849/commits/0b0fef0e6670c20a

Re: RFR: 8275385: Change nested classes in jdk.jdi to static nested classes

2021-10-18 Thread Alex Menkov
On Sun, 17 Oct 2021 17:28:37 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which can be avoided. Marked as reviewed by amenkov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5978

Re: RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v5]

2021-10-18 Thread Jakob Cornell
On Thu, 30 Sep 2021 19:22:40 GMT, Chris Plummer wrote: >> Hey Chris, is there any update on this? I've revised the Problem section so >> I think we're waiting on the CSR ticket to be updated accordingly and for >> someone to be assigned for the CSR review. > >> Hey Chris, is there any update o

Re: RFR: 8271356: Modify jdb to treat an empty command as a repeat of the previous command [v5]

2021-10-18 Thread Chris Plummer
On Thu, 30 Sep 2021 19:22:40 GMT, Chris Plummer wrote: >> Hey Chris, is there any update on this? I've revised the Problem section so >> I think we're waiting on the CSR ticket to be updated accordingly and for >> someone to be assigned for the CSR review. > >> Hey Chris, is there any update o