On Fri, 24 Sep 2021 22:31:18 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Markus Grönlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> no precompiled headers and mtServiceability nmt classification > > Hi Markus, > > It's a little surprised to see Finalizer.c to depend JMM interface which is > used by `java.management` and `jdk.management` modules only. It's more > appropriate for it to be a JVM_* entry point for Finalizer to report > completion of the finalization instead. I understand that you want to make > FinalizerService to be a conditional feature which is a good idea. Such JVM > entry can be made as a nop if not INCLUDE_SERVICES. Thank you for staying around with this protracted PR. Thanks @mlchung , @coleenp and @egahlin for your reviews! ------------- PR: https://git.openjdk.java.net/jdk/pull/4731
