Re: RFR: 8274982: Add a test for 8269574.

2021-11-12 Thread Vladimir Kozlov
On Mon, 11 Oct 2021 09:55:28 GMT, Evgeny Nikitin wrote: > This PR contains a relatively simple test which verifies that JVMTI-agents > are correctly informed about exceptions caught in C2-compiled code. The > 8269574 introduces pre-allocated exceptions in some paths, so the test tries > to

Re: RFR: 8276658: Clean up JNI local handles code [v2]

2021-11-12 Thread Coleen Phillimore
On Fri, 12 Nov 2021 15:08:24 GMT, Patricio Chilano Mateo wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add _is_running initialization. > > src/hotspot/share/jfr/dcmd/jfrDcmds.cpp line 181: > >> 179:

Integrated: 8276658: Clean up JNI local handles code

2021-11-12 Thread Coleen Phillimore
On Wed, 10 Nov 2021 17:16:29 GMT, Coleen Phillimore wrote: > JNI Local handles can only be created by JavaThread (there's an assert in > make_local) but the fields are added to Thread. > Move the fields to JavaThread and adding JavaThread* argument. > Also, the global freelist isn't very useful

Re: RFR: 8276658: Clean up JNI local handles code [v2]

2021-11-12 Thread Coleen Phillimore
On Thu, 11 Nov 2021 13:58:06 GMT, Coleen Phillimore wrote: >> JNI Local handles can only be created by JavaThread (there's an assert in >> make_local) but the fields are added to Thread. >> Move the fields to JavaThread and adding JavaThread* argument. >> Also, the global freelist isn't very

Re: RFR: 8276658: Clean up JNI local handles code [v3]

2021-11-12 Thread Coleen Phillimore
> JNI Local handles can only be created by JavaThread (there's an assert in > make_local) but the fields are added to Thread. > Move the fields to JavaThread and adding JavaThread* argument. > Also, the global freelist isn't very useful now that global JNI handles don't > use JNIHandleBlock, so

Re: RFR: 8276658: Clean up JNI local handles code [v2]

2021-11-12 Thread Patricio Chilano Mateo
On Thu, 11 Nov 2021 13:58:06 GMT, Coleen Phillimore wrote: >> JNI Local handles can only be created by JavaThread (there's an assert in >> make_local) but the fields are added to Thread. >> Move the fields to JavaThread and adding JavaThread* argument. >> Also, the global freelist isn't very

RFR: JDK-8276983: Small fixes to DumpAllocStat::print_stats

2021-11-12 Thread Thomas Stuefe
When looking at CDS code in the context of Lilliput, I had to spend some time in DumpAllocStat::print(). I noticed two small things which can be fixed independently: - the divide-by-zero check at lines 45ff is not needed, since `percent_of` does this already. It also can cause the asserts at