Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-03-03 Thread Yi Yang
On Fri, 4 Mar 2022 05:13:58 GMT, Ioi Lam wrote: > You should change it to `%4d`. Otherwise, when the numbers are changed in the > future (e.g., to 3 or 4 digits) they will be misaligned: > > ``` > KlassAddr Size State FlagsClassName > 0x000800df8400 62

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v9]

2022-03-03 Thread Lin Zang
On Fri, 4 Mar 2022 07:20:14 GMT, Yi Yang wrote: > > Sorry that I just chime in. It seems this change adds new command options, > > so it seems that `csr` is required? > > Hi @linzang, according to [previous > discussion](https://github.com/openjdk/jdk/pull/6075) and [comments in >

Re: RFR: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default [v2]

2022-03-03 Thread Chris Plummer
> jdb has a probably very little used command called "threadgroup" which is > used to set the current TheadGroup. The only purpose of the current > ThreadGroup is as the default ThreadGroup to use for the "threads" command > when no ThreadGroup argument is passed to it. > > "threads" prints

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v9]

2022-03-03 Thread Yi Yang
On Fri, 4 Mar 2022 07:12:03 GMT, Lin Zang wrote: > Sorry that I just chime in. It seems this change adds new command options, so > it seems that `csr` is required? Hi @linzang, according to [previous discussion](https://github.com/openjdk/jdk/pull/6075) and [comments in

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v9]

2022-03-03 Thread Lin Zang
On Fri, 4 Mar 2022 03:53:52 GMT, Yi Yang wrote: >> Add VM.classes to print details of all classes, output looks like: >> >> 1. jcmd VM.classes >> >> KlassAddr Size State Flags LoaderName ClassName >> 0x000800c0b400 62 inited W bootstrap >> java.lang.invoke.LambdaForm$MH/0x000800c0b400

RFR: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default

2022-03-03 Thread Chris Plummer
jdb has a probably very little used command called "threadgroup" which is used to set the current TheadGroup. The only purpose of the current ThreadGroup is as the default ThreadGroup to use for the "threads" command when no ThreadGroup argument is passed to it. "threads" prints out every

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-03-03 Thread Ioi Lam
On Fri, 4 Mar 2022 02:47:28 GMT, Yi Yang wrote: >> This issue seem still outstanding. > > Current: > > $./jcmd 83908 VM.classes|head -10 > 83908: > KlassAddr Size State FlagsClassName > 0x000800df8400 62fully_initialized W >

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v9]

2022-03-03 Thread David Holmes
On Fri, 4 Mar 2022 03:53:52 GMT, Yi Yang wrote: >> Add VM.classes to print details of all classes, output looks like: >> >> 1. jcmd VM.classes >> >> KlassAddr Size State Flags LoaderName ClassName >> 0x000800c0b400 62 inited W bootstrap >> java.lang.invoke.LambdaForm$MH/0x000800c0b400

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-03-03 Thread David Holmes
On Fri, 4 Mar 2022 03:03:10 GMT, Yi Yang wrote: >> src/hotspot/share/services/diagnosticCommand.cpp line 964: >> >>> 962:"Dump the detail content of Java class. " >>> 963:"Some classes are annotated with flags: " >>> 964:"F = has finializer method, " >> >>

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-03-03 Thread Yi Yang
On Fri, 4 Mar 2022 03:43:59 GMT, David Holmes wrote: >> I'm not sure what's the meaning of "non-trivial finalize" method, can you >> elaborate more for it? >> (P.S. All comments are addressed) > > I mean a finalize() method that actually does something. I checked the code > and you will print

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v9]

2022-03-03 Thread Yi Yang
> Add VM.classes to print details of all classes, output looks like: > > 1. jcmd VM.classes > > KlassAddr Size State Flags LoaderName ClassName > 0x000800c0b400 62 inited W bootstrap > java.lang.invoke.LambdaForm$MH/0x000800c0b400 > 0x000800c0b000 62 inited W bootstrap >

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v2]

2022-03-03 Thread Yi Yang
On Wed, 19 Jan 2022 02:50:16 GMT, Chris Plummer wrote: >>> It seems it would be useful to support the verbose output with just a >>> single class that is specified, although that would suggest that the dcmd >>> name should then be something other than `VM.classes`. >> >> This is a good idea,

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-03-03 Thread Yi Yang
On Fri, 11 Feb 2022 06:53:23 GMT, David Holmes wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix > > src/hotspot/share/services/diagnosticCommand.cpp line 964: > >> 962:"Dump the detail content of Java

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v7]

2022-03-03 Thread Yi Yang
On Fri, 4 Mar 2022 03:29:51 GMT, David Holmes wrote: >> Yi Yang has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains eight commits: >> >> - Merge branch 'master' into jcmd_classes >> - typo >> - fix >> - fix test >> - -verbose

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v8]

2022-03-03 Thread Yi Yang
> Add VM.classes to print details of all classes, output looks like: > > 1. jcmd VM.classes > > KlassAddr Size State Flags LoaderName ClassName > 0x000800c0b400 62 inited W bootstrap > java.lang.invoke.LambdaForm$MH/0x000800c0b400 > 0x000800c0b000 62 inited W bootstrap >

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v7]

2022-03-03 Thread David Holmes
On Fri, 4 Mar 2022 03:07:26 GMT, Yi Yang wrote: >> Add VM.classes to print details of all classes, output looks like: >> >> 1. jcmd VM.classes >> >> KlassAddr Size State Flags LoaderName ClassName >> 0x000800c0b400 62 inited W bootstrap >> java.lang.invoke.LambdaForm$MH/0x000800c0b400

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v7]

2022-03-03 Thread Yi Yang
> Add VM.classes to print details of all classes, output looks like: > > 1. jcmd VM.classes > > KlassAddr Size State Flags LoaderName ClassName > 0x000800c0b400 62 inited W bootstrap > java.lang.invoke.LambdaForm$MH/0x000800c0b400 > 0x000800c0b000 62 inited W bootstrap >

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v6]

2022-03-03 Thread Yi Yang
On Fri, 11 Feb 2022 06:49:25 GMT, David Holmes wrote: >> src/hotspot/share/oops/instanceKlass.cpp line 2081: >> >>> 2079: _st->print(INTPTR_FORMAT " ", p2i(k)); >>> 2080: // klass size >>> 2081: _st->print("%-4d ", k->size()); >> >> Should be `%4d` so that the numbers are aligned

Re: RFR: 8282241: Invalid generic signature for redefined classes

2022-03-03 Thread Coleen Phillimore
On Thu, 3 Mar 2022 15:07:05 GMT, Alex Menkov wrote: > JDK-8238048 (fixed in jdk15) moved major_version, minor_version, > generic_signature_index and source_file_name_index from InstanceKlass to > ConstantPool. > We still have some incorrect code in CP merge during class redefinition. > >

Possible memory leak in invoker_completeInvokeRequest()?

2022-03-03 Thread Roman Kennke
A user is reporting a memory leak starting from invoker_completeInvokeRequest(). Consider the trace below (relative to JDK11): It looks like invoker_completeInvokeRequest() calls outStream_writeValue(), which calls outStream_writeObjectRef(), which then ends up calling commonRef_refToID().

RFR: 8282241: Invalid generic signature for redefined classes

2022-03-03 Thread Alex Menkov
JDK-8238048 (fixed in jdk15) moved major_version, minor_version, generic_signature_index and source_file_name_index from InstanceKlass to ConstantPool. We still have some incorrect code in CP merge during class redefinition. rewrite_cp_refs(scratch_class) updates generic_signature_index and