Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v4]

2022-04-18 Thread ExE Boss
On Sun, 17 Apr 2022 16:03:30 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8284903: Fix typos in hotspot

2022-04-18 Thread Coleen Phillimore
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so

Re: RFR: 8284903: Fix typos in hotspot

2022-04-18 Thread Vladimir Kozlov
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v4]

2022-04-18 Thread Mandy Chung
On Sun, 17 Apr 2022 16:03:30 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v4]

2022-04-18 Thread Mandy Chung
On Sun, 17 Apr 2022 16:03:30 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8284903: Fix typos in hotspot

2022-04-18 Thread David Holmes
On Fri, 15 Apr 2022 07:40:04 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on hotspot, and accepted those changes where it indeed > discovered real typos. > > You'd be surprised over the many implementions of instrinsics and other > intructions accross all archtectures I've encounted, so

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v4]

2022-04-18 Thread Mandy Chung
On Sun, 17 Apr 2022 16:03:30 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8283179: SA tests fail with "ERROR: catch_mach_exception_raise: Message doesn't denote a Unix soft signal."

2022-04-18 Thread David Holmes
On Thu, 14 Apr 2022 22:16:36 GMT, Chris Plummer wrote: > During the SA attach process on macOS, SA installs an exception handler and > expects to get an EXC_SOFTWARE exception for the expected SIGSTOP signal. On > aarch64, sometimes it instead gets an EXC_BAD_INSTRUCTION exception. I found > i

Re: RFR: 8283179: SA tests fail with "ERROR: catch_mach_exception_raise: Message doesn't denote a Unix soft signal." [v2]

2022-04-18 Thread Chris Plummer
On Tue, 19 Apr 2022 02:56:28 GMT, David Holmes wrote: > Based on your description this approach seems quite reasonable. I take it > that we can't install an exception handler only for the SIGSTOP (like how we > would install a signal handler only for SIGSTOP) ? On the debugger side I don't thi

Re: RFR: 8283179: SA tests fail with "ERROR: catch_mach_exception_raise: Message doesn't denote a Unix soft signal." [v2]

2022-04-18 Thread Chris Plummer
> During the SA attach process on macOS, SA installs an exception handler and > expects to get an EXC_SOFTWARE exception for the expected SIGSTOP signal. On > aarch64, sometimes it instead gets an EXC_BAD_INSTRUCTION exception. I found > if I changed the code to just ignore this, it eventually g

Re: RFR: 8283179: SA tests fail with "ERROR: catch_mach_exception_raise: Message doesn't denote a Unix soft signal." [v2]

2022-04-18 Thread David Holmes
On Tue, 19 Apr 2022 04:01:16 GMT, Chris Plummer wrote: >> During the SA attach process on macOS, SA installs an exception handler and >> expects to get an EXC_SOFTWARE exception for the expected SIGSTOP signal. On >> aarch64, sometimes it instead gets an EXC_BAD_INSTRUCTION exception. I found