Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

On Tue, 26 Apr 2022 18:58:23 GMT, Daniel Fuchs wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Refresh 8d8f0a2fd646e57fe6b4e8ab669f836dc46dda69 > > src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java li

Re: RFR: 8285149: Using HashMap.newHashMap to replace new HashMap(int) [v4]

On Wed, 27 Apr 2022 04:36:37 GMT, Phil Race wrote: > I'm getting a bit tired of seeing these JDK wide changes with lots of files > touched. @prrace I'm also a bit tired of seeing so many amazing mis-use in existed codes in jdk. In some place I even see somebody creates a HashMap with factor

Re: RFR: 8285149: Using HashMap.newHashMap to replace new HashMap(int) [v4]

On Sat, 23 Apr 2022 14:34:58 GMT, XenoAmess wrote: >> These are the changes that too many to be reviewed in 8186958, thus split >> some of them out. > > XenoAmess has updated the pull request incrementally with two additional > commits since the last revision: > > - maintains compatibility wi

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be separated > out in an

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be separated > out in an

Re: RFR: 8285032: [LOOM] vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected" [v2]

On Tue, 26 Apr 2022 19:25:44 GMT, Chris Plummer wrote: >> The test is testing that EventSets for ThreadStartEvents have the proper >> suspendPolicy. When there is more than one ThreadStartRequest and a thread >> is started, each ThreadStartRequest results in a ThreadStartEvent being >> created

Re: RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote: > To enable more complete doclint checking (courtesy @jonathan-gibbons), please > review this PR to add type-level @param tags where they are missing. > > To the maintainers of java.util.concurrent, those changes could be separated > out in an

Re: RFR: 8283179: SA tests fail with "ERROR: catch_mach_exception_raise: Message doesn't denote a Unix soft signal." [v2]

On Tue, 19 Apr 2022 04:01:16 GMT, Chris Plummer wrote: >> During the SA attach process on macOS, SA installs an exception handler and >> expects to get an EXC_SOFTWARE exception for the expected SIGSTOP signal. On >> aarch64, sometimes it instead gets an EXC_BAD_INSTRUCTION exception. I found

RFR: JDK-8285676: Add missing @param tags for type parameters on classes and interfaces

To enable more complete doclint checking (courtesy @jonathan-gibbons), please review this PR to add type-level @param tags where they are missing. To the maintainers of java.util.concurrent, those changes could be separated out in another bug if that would ease maintenance of that code. Making

Re: RFR: 8285032: [LOOM] vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected" [v2]

On Tue, 26 Apr 2022 18:13:40 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add comment > > test/hotspot/jtreg/vmTestbase/nsk/share/jdi/EventFilters.java line 342: > >> 340: if (even

Re: RFR: 8285032: [LOOM] vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected" [v2]

> The test is testing that EventSets for ThreadStartEvents have the proper > suspendPolicy. When there is more than one ThreadStartRequest and a thread is > started, each ThreadStartRequest results in a ThreadStartEvent being created, > and they all are grouped into the same EventSet. The suspen

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the

Re: RFR: 8285032: [LOOM] vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected"

On Thu, 21 Apr 2022 20:14:49 GMT, Chris Plummer wrote: > The test is testing that EventSets for ThreadStartEvents have the proper > suspendPolicy. When there is more than one ThreadStartRequest and a thread is > started, each ThreadStartRequest results in a ThreadStartEvent being created, > an

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v7]

> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which > JDK version to target. > > We will refresh this PR periodically to pick up changes and fixes from the > loom repo. > > Most of the new mechanisms in the HotSpot VM are disabled by default and > require running with

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v6]

On Mon, 25 Apr 2022 13:19:49 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in the