Re: RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp

2022-05-20 Thread Alan Bateman
On Fri, 20 May 2022 22:27:29 GMT, Leonid Mesnik wrote: > Sync improved in test test/jdk/java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java line 43: > 41: private static final Object LOCK2 = new Object(); > 42: > 43: private static volatile boolean lock2Obtained = false;

Re: RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp

2022-05-20 Thread Alan Bateman
On Fri, 20 May 2022 22:27:29 GMT, Leonid Mesnik wrote: > Sync improved in test Can you add `@bug 8284161 8287103` to the test description? - PR: https://git.openjdk.java.net/jdk/pull/8821

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Serguei Spitsyn
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable

RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp

2022-05-20 Thread Leonid Mesnik
Sync improved in test - Commit messages: - 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp Changes: https://git.openjdk.java.net/jdk/pull/8821/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8821=00 Issue:

Concurrent heap monitoring

2022-05-20 Thread Kemper, William
Taking a heap dump is a stop the world event. Garbage collection events can provide heap utilization information only after a cycle completes. We've found that detailed heap occupancy data (such as heap inspections provide) are too expensive to use for production monitoring. Similarly, we find

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Vladimir Kozlov
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
On Fri, 20 May 2022 20:09:59 GMT, Leonid Mesnik wrote: >> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI >> capabilities are enabled and --enable-preview. >> >> It restores the same behavior as it was before >> https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable

Re: RFR: 8285739: disable EA when both JVMTI and Preview are enabled [v2]

2022-05-20 Thread Leonid Mesnik
> The fix disables EscapeBarrier and EscapeAnalysis when certain JVMTI > capabilities are enabled and --enable-preview. > > It restores the same behavior as it was before > https://bugs.openjdk.java.net/browse/JDK-8227745 "Enable Escape Analysis for > Better Performance in the Presence of

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v3]

2022-05-20 Thread Alan Bateman
> This is a test-only change to add some test infrastructure and improve the > testing of thread dumps in JSON format. The new tests added by JEP 425 for > this thread dump format search the JSON text for strings but don't parse it > completely. These tests can be improved with a test class

RFR: 8286711: AArch64: serviceability agent tests fail with PAC enabled

2022-05-20 Thread Nick Gasson
When the VM is run with `-XX:UseBranchProtection=pac-ret` on a supported CPU, the upper bits of the saved link register contain a "pointer authentication code" which must be checked and removed by a special instruction before a function returns. The serviceability agent is unaware of this and

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v2]

2022-05-20 Thread Daniel Fuchs
On Fri, 20 May 2022 11:32:14 GMT, Alan Bateman wrote: >> This is a test-only change to add some test infrastructure and improve the >> testing of thread dumps in JSON format. The new tests added by JEP 425 for >> this thread dump format search the JSON text for strings but don't parse it >>

Re: RFR: 8287008: Improve tests for thread dumps in JSON format

2022-05-20 Thread Alan Bateman
On Fri, 20 May 2022 04:22:21 GMT, Chris Plummer wrote: > I think a short example dump would actually be easier to read alongside the > code. That's a good idea. I've updated the class description to include an example and also a code example of how it can be used in tests. The thread dump

Re: RFR: 8287008: Improve tests for thread dumps in JSON format [v2]

2022-05-20 Thread Alan Bateman
> This is a test-only change to add some test infrastructure and improve the > testing of thread dumps in JSON format. The new tests added by JEP 425 for > this thread dump format search the JSON text for strings but don't parse it > completely. These tests can be improved with a test class

Re: RFR: 8284209: Replace remaining usages of 'a the' in source code

2022-05-20 Thread Magnus Ihse Bursie
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/theā€¦ > > It's the last issue in the series, and it still touches different areas of > the code. Build changes look good. Thanks for the