Re: [8u] RFR: 8150986: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java failing because expects HPROF JAVA PROFILE 1.0.1 file format

2020-05-18 Thread Andrew Hughes
On 18/05/2020 10:08, Severin Gehwolf wrote: > Hi, > > Please review this 8u backport of JDK-8150986. It's a clean backport > except for the copyright change. In the 8u252 cycle JDK-8144732 got > backported which now makes the test fail. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8150986

Re: [8u] RFR: 8216058: [TESTBUG] tools/launcher/VersionCheck.java fails after JDK-8215992

2019-01-03 Thread Andrew Hughes
On Thu, 3 Jan 2019 at 12:01, Andrew Haley wrote: > > On 1/3/19 11:24 AM, Severin Gehwolf wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8216058 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8216058/webrev.01/ > > > > Testing: Failing VersionCheck.java prior the patch, pass

Re: [8u] RFR: 8059038: Create new launcher for SA tools

2018-12-19 Thread Andrew Hughes
On Wed, 19 Dec 2018 at 16:59, Severin Gehwolf wrote: > > On Wed, 2018-12-19 at 16:56 +, Andrew Hughes wrote: > > On Wed, 19 Dec 2018 at 12:15, Severin Gehwolf wrote: > > > > > > On Wed, 2018-12-19 at 06:46 +, Andrew Hughes wrote: > > > > On

Re: [8u] RFR: 8059038: Create new launcher for SA tools

2018-12-19 Thread Andrew Hughes
On Wed, 19 Dec 2018 at 12:15, Severin Gehwolf wrote: > > On Wed, 2018-12-19 at 06:46 +, Andrew Hughes wrote: > > On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf > > wrote: > > > > > > On Thu, 2018-12-13 at 15:49 +, Andrew Hughes wrote: > > > &g

Re: [8u] RFR: 8059038: Create new launcher for SA tools

2018-12-18 Thread Andrew Hughes
On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf wrote: > > On Thu, 2018-12-13 at 15:49 +, Andrew Hughes wrote: > > Ok, I presume that's not a change you're also going to make in > > OpenJDK 12? > > Yes. I don't intend to change this in JDK 12. JDK 8

Re: [8u] RFR: 8059038: Create new launcher for SA tools

2018-12-13 Thread Andrew Hughes
On Wed, 12 Dec 2018 at 17:28, Severin Gehwolf wrote: > > On Wed, 2018-12-12 at 16:18 +, Andrew Hughes wrote: > > On Wed, 12 Dec 2018 at 14:10, Severin Gehwolf wrote: > > > > > > Hi, > > > > > > Can I get a review of this small 8u enhancement,

Re: [8u] RFR: 8059038: Create new launcher for SA tools

2018-12-12 Thread Andrew Hughes
On Wed, 12 Dec 2018 at 14:10, Severin Gehwolf wrote: > > Hi, > > Can I get a review of this small 8u enhancement, please? It adds two > new launchers for the serviceability agent, one CLI version and one GUI > version: > > $ /bin/clhsdb > $ /bin/hsdb > > The enhancement request has been approved h

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-21 Thread Andrew Hughes
On Wed, 21 Nov 2018 at 10:20, Severin Gehwolf wrote: > > On Wed, 2018-11-21 at 06:47 +, Andrew Hughes wrote: > > On Mon, 19 Nov 2018 at 15:39, Severin Gehwolf wrote: > > > > snip... > > > > > > > > Two reasons: (1) JDK-8140482 isn't a smal

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-20 Thread Andrew Hughes
On Mon, 19 Nov 2018 at 15:39, Severin Gehwolf wrote: snip... > > Two reasons: (1) JDK-8140482 isn't a small change. (2) The patch > doesn't apply cleanly[1] from JDK 9 so would be some work to get the > pre-requisite in. > > It appears the code is already out of sync and the risk would be higher

[8u] [RFR] 8140482: Various minor code improvements (runtime)

2018-11-20 Thread Andrew Hughes
Bug: https://bugs.openjdk.java.net/browse/JDK-8140482 Original changeset: https://hg.openjdk.java.net/jdk-updates/jdk9u/hotspot/rev/cd86b5699825 Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8140482/webrev.01/ The patch largely applies as is, with some adjustment for context and the droppin

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

2018-11-19 Thread Andrew Hughes
On Fri, 9 Nov 2018 at 16:02, Severin Gehwolf wrote: > > Hi, > > Could somebody please review this 8u backport of 8210836 as I'd like to > get 8210647 (opt for sa) backported to 8u as well? Unfortunately the > change from JDK 12 doesn't apply cleanly so I've included select > changes from 8140482 s

Re: jmx-dev [8] RFR(S): 8147857: RMIConnector logs attribute names incorrectly

2016-01-22 Thread Andrew Hughes
- Original Message - > > On 22/01/16 15:58, Andrew Hughes wrote: > >> >Yes - please fix this issue in JDK 9 first as per rule 1: > >> >http://openjdk.java.net/projects/jdk8u/groundrules.html > >> > > >> >In a nutshell, produ

Re: jmx-dev [8] RFR(S): 8147857: RMIConnector logs attribute names incorrectly

2016-01-22 Thread Andrew Hughes
- Original Message - > On 22/01/16 14:50, Andrew Hughes wrote: > > - Original Message - > >> On 21/01/16 15:20, Severin Gehwolf wrote: > >>> Thanks, Jaroslav. Any JDK 8 reviewer willing to have a look at this? > >> Looks good to me Severi

Re: DTrace on BSD, future support

2013-09-06 Thread Andrew Hughes
- Original Message - > Hello all! > > I'm working with a GSoC student adding dtrace probe support to JRuby, > and ran into the issue that user-defined dtrace probes only work on > Solaris. So I started poking around hotspot source and found that both > the linux and bsd JSDT sources are em

Re: Attach API on Linux and Root

2013-07-17 Thread Andrew Hughes
- Original Message - > Thanks for the patch, I think it sounds like a good idea. For consistency, > however, we need to do the same modifications to the other platforms > (solaris, windows) and preferably add tests for this functionality as well. > The patch makes sense to me. While a ve

Re: Code review request for Linux DEBUG_BINARIES/FDS fix (7188168)

2012-08-02 Thread Andrew Hughes
- Original Message - > Greetings, > > I have a fix for the following Linux specific FDS bug: > > 7188168 4/4 7071904 broke the DEBUG_BINARIES option on Linux > > Here is the URL for the webrev: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7188168-webrev/0/ > > What the

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Andrew Hughes
- Original Message - > On 3/23/12 12:08 PM, Andrew Hughes wrote: > > > > - Original Message - > >> - Original Message - > >>> Greetings, > >>> > >>> I've backported the FDS changes to JDK7u6. Here's

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Andrew Hughes
- Original Message - > - Original Message - > > Greetings, > > > > I've backported the FDS changes to JDK7u6. Here's the webrevs: > > > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-root/ > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7

Re: code review request for Full Debug Symbols Revamp (7102323, 7136506)

2012-03-23 Thread Andrew Hughes
- Original Message - > Greetings, > > I've backported the FDS changes to JDK7u6. Here's the webrevs: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-root/ > http://cr.openjdk.java.net/~dcubed/fds_revamp/7136506-webrev/0-7u6-jdk/ > http://cr.openjdk.java.net/~dcubed/

Re: Patch to fix build breakage with GCC 4.7

2012-03-08 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2012-03-02 10:09]: > > - Original Message - > > > * Andrew Hughes [2012-03-01 15:40]: > > > > - Original Message - > > > > > * Kelly O'Hair [2012-02-29 20:39]: > > > >

Re: Patch to fix build breakage with GCC 4.7

2012-03-02 Thread Andrew Hughes
- Original Message - > * Andrew Hughes [2012-03-01 15:40]: > > - Original Message - > > > * Kelly O'Hair [2012-02-29 20:39]: > > > > The sample.makefile.txt files may not even be used during the > > > > build, I'm n

Re: Patch to fix build breakage with GCC 4.7

2012-03-01 Thread Andrew Hughes
- Original Message - > * Kelly O'Hair [2012-02-29 20:39]: > > The sample.makefile.txt files may not even be used during the > > build, I'm not sure. > > They may have only been supplied as documentation on how to build > > the native code. > > > > Deleting the -mimpure-text is probably ri

Re: Patch to fix build breakage with GCC 4.7

2012-01-31 Thread Andrew Hughes
- Original Message - > On 31/01/2012 12:36 PM, Deepak Bhole wrote: > > * David Holmes [2012-01-30 19:57]: > >> While gcc compilation on sparc is rare I'm not sure that simply > >> deleting the sparc-only option unconditionally is the right thing > >> to > >> do. > >> > > > > I thought ab