On Fri, 10 Jun 2022 15:30:41 GMT, Ioi Lam wrote:
>> A trivial fix to ProblemList
>> serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java.
>
> Marked as reviewed by iklam (Reviewer).
@iklam - Thanks for the fast review.
I have got to learn to type!
On Fri, 10 Jun 2022 15:21:34 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java.
This pull request has now been integrated.
Changeset: 0164145a
Author:Daniel D. Daughert
On Fri, 10 Jun 2022 15:27:09 GMT, Alan Bateman wrote:
>> A trivial fix to ProblemList
>> serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java.
>
> Marked as reviewed by alanb (Reviewer).
@AlanBateman - Thanks for the fast review!
-
PR: https://git.
A trivial fix to ProblemList
serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java.
-
Commit messages:
- 8288222: ProblemList
serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java
Changes: https://git.openjdk.org/jdk1
On Tue, 7 Jun 2022 00:49:29 GMT, Leonid Mesnik wrote:
> Please review following fix which exclude failing test.
Thumbs up. This is a trivial change.
-
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/9050
On Mon, 6 Jun 2022 07:20:10 GMT, David Holmes wrote:
>> src/hotspot/share/prims/jvmtiEventController.cpp line 370:
>>
>>> 368: }
>>> 369: EnterInterpOnlyModeClosure hs;
>>> 370: assert(state->get_thread() != NULL, "sanity check");
>>
>> Existing: We have already performed this check. We s
On Mon, 6 Jun 2022 07:17:15 GMT, David Holmes wrote:
>> Johan Sjölén has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - do_thread(target) not self
>> - Remove checks for is_handshake_for, instead call Handshake::execute
>> - Switch or
On Fri, 3 Jun 2022 09:45:31 GMT, Johan Sjölén wrote:
>> Please review this PR for fixing JDK-8287281.
>>
>> If a thread is handshake safe we immediately execute the closure, instead of
>> going through the regular Handshake process.
>>
>> Finally: Should `VirtualThreadGetThreadClosure` and i
On Fri, 3 Jun 2022 17:02:44 GMT, Daniel D. Daugherty wrote:
> A trivial fix that deletes an errant `debugee.resume()` call that causes a
> race
> between the debugger and debuggee. I've also corrected incorrect line number
> values mentioned in comments.
>
> This fix h
On Fri, 3 Jun 2022 22:08:50 GMT, Chris Plummer wrote:
>> Marked as reviewed by cjplummer (Reviewer).
>
>> @plummercj - Thanks for the review!
>>
>> Do you agree that this is a trivial change?
>
> Yes
@plummercj - Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/9020
On Fri, 3 Jun 2022 21:43:02 GMT, Chris Plummer wrote:
>> A trivial fix that deletes an errant `debugee.resume()` call that causes a
>> race
>> between the debugger and debuggee. I've also corrected incorrect line number
>> values mentioned in comments.
>>
>> This fix has been tested with the up
On Fri, 3 Jun 2022 17:02:44 GMT, Daniel D. Daugherty wrote:
> A trivial fix that deletes an errant `debugee.resume()` call that causes a
> race
> between the debugger and debuggee. I've also corrected incorrect line number
> values mentioned in comments.
>
> This fix h
A trivial fix that deletes an errant `debugee.resume()` call that causes a race
between the debugger and debuggee. I've also corrected incorrect line number
values mentioned in comments.
This fix has been tested with the updated failing test both with and without the
debug code that makes the fail
On Fri, 3 Jun 2022 17:02:44 GMT, Daniel D. Daugherty wrote:
> A trivial fix that deletes an errant `debugee.resume()` call that causes a
> race
> between the debugger and debuggee. I've also corrected incorrect line number
> values mentioned in comments.
>
> This fix h
On Wed, 25 May 2022 07:23:36 GMT, Serguei Spitsyn wrote:
> A part of this issue was contributed with the following changeset:
>
> commit ea23e7333e03abb4aca3e9f3854bab418a4b70e2
> Author: Daniel D. Daugherty <[dcu...@openjdk.org](mailto:dcu...@openjdk.org)>
> Date: Mon Nov
On Mon, 9 May 2022 20:15:21 GMT, Daniel D. Daugherty wrote:
> A trivial fix to nsk_jvmti_threadByName() to solve a native memory leak.
>
> This fix has been stress tested with my
> StressWrapper60M_NMT_detail_suspendthrd003.java
> test and I did NMT detailed monitoring for th
On Mon, 9 May 2022 20:15:21 GMT, Daniel D. Daugherty wrote:
> A trivial fix to nsk_jvmti_threadByName() to solve a native memory leak.
>
> This fix has been stress tested with my
> StressWrapper60M_NMT_detail_suspendthrd003.java
> test and I did NMT detailed monitoring for th
On Mon, 9 May 2022 21:57:41 GMT, Leonid Mesnik wrote:
>> A trivial fix to nsk_jvmti_threadByName() to solve a native memory leak.
>>
>> This fix has been stress tested with my
>> StressWrapper60M_NMT_detail_suspendthrd003.java
>> test and I did NMT detailed monitoring for the whole 60M run. Tot
On Thu, 5 May 2022 13:02:58 GMT, Jaroslav Bachorik
wrote:
>> A gist of the fix is to allow relaxed special handling of code blob lookup
>> when done for ASGCT.
>>
>> Currently, a guarantee will fail when we happen to hit a zombie method which
>> is still on stack. While this would indicate a
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the
A trivial copyright fix to solve validate-source failure after JDK-8283710.
-
Commit messages:
- 8284687: validate-source failure after JDK-8283710
Changes: https://git.openjdk.java.net/jdk/pull/8181/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8181&range=00
Issue:
On Mon, 11 Apr 2022 16:20:02 GMT, Daniel D. Daugherty
wrote:
> A trivial copyright fix to solve validate-source failure after JDK-8283710.
This pull request has now been integrated.
Changeset: 470a6684
Author: Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/com
On Mon, 11 Apr 2022 16:21:34 GMT, Iris Clark wrote:
>> A trivial copyright fix to solve validate-source failure after JDK-8283710.
>
> Marked as reviewed by iris (Reviewer).
@irisclark - Thanks for the lightning fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/8181
On Wed, 30 Mar 2022 15:09:08 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList containers/docker/TestJcmd.java on linux-x64.
This pull request has now been integrated.
Changeset: d9d19e96
Author: Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/com
A trivial fix to ProblemList containers/docker/TestJcmd.java on linux-x64.
-
Commit messages:
- 8284015: ProblemList containers/docker/TestJcmd.java on linux-x64
Changes: https://git.openjdk.java.net/jdk/pull/8042/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8042&ran
On Wed, 30 Mar 2022 15:11:36 GMT, Brian Burkhalter wrote:
>> A trivial fix to ProblemList containers/docker/TestJcmd.java on linux-x64.
>
> Marked as reviewed by bpb (Reviewer).
@bplb and @hseigel - Thanks for the fast reviews!
-
PR: https://git.openjdk.java.net/jdk/pull/8042
On Thu, 24 Mar 2022 01:31:42 GMT, Alex Menkov wrote:
> The change reverts the fix for JDK-8282241 which causes regression
Thumbs up. Looks like a clean [BACKOUT] so this is a trivial fix.
-
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7934
On Wed, 9 Mar 2022 20:41:37 GMT, Daniel D. Daugherty wrote:
> A trivial fix to solve a memory leak/memory pinning for long runs of
> suspendthrd003.
>
> See the bug report for the gory analysis details.
>
> This fix was included in my jdk-19+12 stress runs so the updated te
On Thu, 10 Mar 2022 18:11:58 GMT, Mikhailo Seledtsov
wrote:
>> A trivial fix to solve a memory leak/memory pinning for long runs of
>> suspendthrd003.
>>
>> See the bug report for the gory analysis details.
>>
>> This fix was included in my jdk-19+12 stress runs so the updated test was
>> ex
On Thu, 10 Mar 2022 16:17:22 GMT, Leonid Mesnik wrote:
>> A trivial fix to solve a memory leak/memory pinning for long runs of
>> suspendthrd003.
>>
>> See the bug report for the gory analysis details.
>>
>> This fix was included in my jdk-19+12 stress runs so the updated test was
>> executed
On Wed, 9 Mar 2022 20:41:37 GMT, Daniel D. Daugherty wrote:
> A trivial fix to solve a memory leak/memory pinning for long runs of
> suspendthrd003.
>
> See the bug report for the gory analysis details.
>
> This fix was included in my jdk-19+12 stress runs so the updated te
On Thu, 10 Mar 2022 04:52:46 GMT, David Holmes wrote:
>> The fix looks fine, but what about StopAtExit? That test seemed to use a lot
>> more memory than suspendthrd003.
>
> @plummercj - see https://bugs.openjdk.java.net/browse/JDK-8282704 for
> StopAtExit.
@dholmes-ora, @plummercj and @alex
A trivial fix to solve a memory leak/memory pinning for long runs of
suspendthrd003.
See the bug report for the gory analysis details.
This fix was included in my jdk-19+12 stress runs so the updated test was
executed
in the NSK JVM/TI testsuite for 3 runs in {fastdebug,release,slowdebug}
con
A trivial fix to ProblemList jdk/jfr/jvm/TestWaste.java.
-
Commit messages:
- 8282428: ProblemList jdk/jfr/jvm/TestWaste.java
Changes: https://git.openjdk.java.net/jdk/pull/7631/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7631&range=00
Issue: https://bugs.openjdk.
On Sun, 27 Feb 2022 03:42:50 GMT, Mikael Vidstedt wrote:
>> A trivial fix to ProblemList jdk/jfr/jvm/TestWaste.java.
>
> Marked as reviewed by mikael (Reviewer).
@vidmik - Thanks for the lightning fast review! Especially considering
that it's Saturday night...
-
PR: https://git.ope
On Sun, 27 Feb 2022 03:37:11 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jdk/jfr/jvm/TestWaste.java.
This pull request has now been integrated.
Changeset: 630ad1ac
Author: Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/com
On Wed, 23 Feb 2022 05:56:18 GMT, Chris Plummer wrote:
>> This test has 4 test cases/modes: two core files test cases and two process.
>> Each runs with and w/o `-Xcomp`. The `-Xcomp` test cases are not suppose to
>> run when `-XX:+DeoptimizeALot` is used, because the test does some checks
>>
On Tue, 22 Feb 2022 22:38:08 GMT, Chris Plummer wrote:
>> test/hotspot/jtreg/serviceability/sa/ClhsdbFindPC.java line 61:
>>
>>> 59: * @bug 8193124
>>> 60: * @summary Test the clhsdb 'findpc' command w/o Xcomp on live process
>>> 61: * @requires vm.hasSA
>>
>> Summary says w/o xcomp but no
On Sat, 19 Feb 2022 04:00:30 GMT, Chris Plummer wrote:
> This test has 4 test cases/modes: two core files test cases and two process.
> Each runs with and w/o `-Xcomp`. The `-Xcomp` test cases are not suppose to
> run when `-XX:+DeoptimizeALot` is used, because the test does some checks
> that
On Fri, 4 Feb 2022 11:18:39 GMT, Alex Menkov wrote:
> The test expects ClassFileReconstituter restores exactly the same bytes as
> original classbytes.
> This can be wrong if the class has more than 1 method (due to method sorting
> in the VM).
> MethodParametersTarget class had only 1 method (
On Fri, 28 Jan 2022 15:37:59 GMT, Aleksey Shipilev wrote:
> Recent test regression after adding new cases in the test. Without compressed
> oops, ~1G elements `Object[]` array takes >8G of memory, which fails the
> test. The fix cuts it down to 512M when reference size is 8 bytes.
> Additional
On Thu, 20 Jan 2022 20:22:42 GMT, Alexander Zvegintsev
wrote:
>> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java
>> on all X64 platforms.
>
> Marked as reviewed by azvegint (Reviewer).
@azvegint - Thanks for the fast review!
-
PR: https://git.openjdk.ja
On Thu, 20 Jan 2022 20:21:17 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on
> all X64 platforms.
This pull request has now been integrated.
Changeset: 293fb46f
Author:Daniel D. Daugherty
URL:
A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on
all X64 platforms.
-
Commit messages:
- 8280413: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on all
X64 platforms
Changes: https://git.openjdk.java.net/jdk/pull/7168/files
Webrev: https://
On Fri, 14 Jan 2022 17:46:12 GMT, Calvin Cheung wrote:
>> A trivial fix to ProblemList
>> jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-x64.
>
> LGTM.
@calvinccheung - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk18/pull/102
On Fri, 14 Jan 2022 17:41:20 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-x64.
This pull request has now been integrated.
Changeset: 09d61b61
Author:Daniel D. Daugherty
URL:
A trivial fix to ProblemList
jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-x64.
-
Commit messages:
- 8280034: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java
on linux-x64
Changes: https://git.openjdk.java.net/jdk18/pull/102/files
Webrev: https:/
On Fri, 31 Dec 2021 23:54:22 GMT, David Nadlinger wrote:
>> @gerard-ziemski - Thanks for the re-review!
>
> @dcubed-ojdk: I just ran into this in the Julia runtime and reached a similar
> conclusion/fix. Did you find out anything more about why this happens? At a
> glance, I didn't see any blat
On Tue, 21 Dec 2021 19:56:07 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on
> 2 platforms
This pull request has now been integrated.
Changeset: 84dc
Author:Daniel D. Daugherty
URL:
https://git.openjdk.ja
On Tue, 21 Dec 2021 20:36:05 GMT, Alexander Zvegintsev
wrote:
>> A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java
>> on 2 platforms
>
> Marked as reviewed by azvegint (Reviewer).
@azvegint and @sspitsyn - Thanks for the reviews!
-
PR: https://git.openjdk
A trivial fix to ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2
platforms
-
Commit messages:
- 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2
platforms
Changes: https://git.openjdk.java.net/jdk18/pull/61/files
Webrev: https://webrevs.openj
On Mon, 13 Dec 2021 04:19:39 GMT, David Holmes wrote:
> Investigation showed this test was experiencing interference from threads
> created by other tests in agentvm mode. The simple solution is to run this
> test isolated using othervm mode. Also added some diagnostics to the test
> incase we
On Thu, 9 Dec 2021 21:57:13 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/lang/management/ThreadMXBean/ThreadLists.java on all configs.
This pull request has now been integrated.
Changeset: d40e90b4
Author:Daniel D. Daugherty
URL:
A trivial fix to ProblemList java/lang/management/ThreadMXBean/ThreadLists.java
on all configs.
-
Commit messages:
- 8278521: ProblemList java/lang/management/ThreadMXBean/ThreadLists.java
Changes: https://git.openjdk.java.net/jdk18/pull/3/files
Webrev: https://webrevs.openjdk.jav
On Thu, 9 Dec 2021 21:59:19 GMT, Brian Burkhalter wrote:
>> A trivial fix to ProblemList
>> java/lang/management/ThreadMXBean/ThreadLists.java on all configs.
>
> Marked as reviewed by bpb (Reviewer).
@bplb - Thanks for the lightning fast review!
-
PR: https://git.openjdk.java.net
On Thu, 2 Dec 2021 17:36:43 GMT, Chris Plummer wrote:
> Increase the test timeout to 480 just to make sure we don't see this timeout
> anymore. This same change was already made to TestJmapCoreMetaspace.java a
> long time ago.
Thumbs up. This is a trivial change.
-
Marked as revi
On Wed, 24 Nov 2021 22:03:29 GMT, Daniel D. Daugherty
wrote:
> A couple of trivial ProblemListings:
>
> JDK-8277811 ProblemList
> vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
> JDK-8277813 ProblemList
> vmTestbase/nsk/jvmti/AttachO
On Wed, 24 Nov 2021 22:08:31 GMT, David Holmes wrote:
>> A couple of trivial ProblemListings:
>>
>> JDK-8277811 ProblemList
>> vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
>> JDK-8277813 ProblemList
>> vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/TestDescr
A couple of trivial ProblemListings:
JDK-8277811 ProblemList
vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
JDK-8277813 ProblemList
vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java
-
Commit messages:
- 8277813: ProblemList
vmTe
On Fri, 19 Nov 2021 10:14:23 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1401:
>>
>>> 1399: if (!self) {
>>> 1400: if (!java_thread->is_suspended()) {
>>> 1401: _result = JVMTI_ERROR_THREAD_NOT_SUSPENDED;
>>
>> I don't see an obvious reason for this
On Thu, 18 Nov 2021 09:34:13 GMT, Serguei Spitsyn wrote:
>> The test fails when the target JavaThread has is_exiting() status. In such a
>> case the JvmtiExport::cleanup_thread(this) has already made a clean up of
>> its jvmtiThreadState, so the JavaThread address returned by
>> _state->get_th
On Thu, 18 Nov 2021 09:34:13 GMT, Serguei Spitsyn wrote:
>> The test fails when the target JavaThread has is_exiting() status. In such a
>> case the JvmtiExport::cleanup_thread(this) has already made a clean up of
>> its jvmtiThreadState, so the JavaThread address returned by
>> _state->get_th
On Thu, 18 Nov 2021 09:34:13 GMT, Serguei Spitsyn wrote:
>> The test fails when the target JavaThread has is_exiting() status. In such a
>> case the JvmtiExport::cleanup_thread(this) has already made a clean up of
>> its jvmtiThreadState, so the JavaThread address returned by
>> _state->get_th
On Wed, 17 Nov 2021 20:43:46 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64.
This pull request has now been integrated.
Changeset: ce4471f8
Author: Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/com
On Wed, 17 Nov 2021 21:16:18 GMT, Thomas Schatzl wrote:
>> A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64.
>
> Lgtm and trivial
@tschatzl and @bplb - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/6438
A trivial fix to ProblemList 7 serviceability/sa tests on macosx-x64.
-
Commit messages:
- 8277351: ProblemList
runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java on macosx-x64
- 8277346: ProblemList 7 serviceability/sa tests on macosx-x64
Changes: https://git.openjdk
On Sat, 3 Jul 2021 14:15:54 GMT, Daniel D. Daugherty wrote:
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
This
On Sun, 4 Jul 2021 23:39:00 GMT, David Holmes wrote:
>> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
>> we add sanity checks for ThreadsListHandles higher in the call stack.
>>
>> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
>
> Hi Dan,
>
> I jus
On Fri, 5 Nov 2021 21:54:01 GMT, Coleen Phillimore wrote:
>> I've written up a rather long analysis about how the use of
>> `JvmtiThreadState_lock`
>> in `JvmtiEventControllerPrivate::recompute_enabled()` means that we can
>> safely
>> traverse the JvmtiThreadState list returned by `JvmtiThread
On Fri, 5 Nov 2021 23:42:07 GMT, Daniel D. Daugherty wrote:
>> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
>> we add sanity checks for ThreadsListHandles higher in the call stack.
>>
>> This fix was tested with Mach5 Tier[1-8]; Tier8 is sti
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementa
On Fri, 5 Nov 2021 15:43:37 GMT, Daniel D. Daugherty wrote:
>> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
>> we add sanity checks for ThreadsListHandles higher in the call stack.
>>
>> This fix was tested with Mach5 Tier[1-8]; Tier8 is sti
On Fri, 5 Nov 2021 16:43:04 GMT, Coleen Phillimore wrote:
>> The `ThreadsListHandle` protects `JavaThread` objects not `JvmtiThreadState`
>> objects.
>> `JvmtiThreadState::first()` returns the head of the global list of
>> `JvmtiThreadState`
>> objects for the system. Each `JvmtiThreadState` ob
On Mon, 1 Nov 2021 15:32:54 GMT, Daniel D. Daugherty wrote:
> macOS12 has changed the dladdr() function to accept "-1" as a valid address
> and
> we have functions that use dladdr() to convert DLL addresses into function or
> library names. We also have a gtest that verif
On Sun, 4 Jul 2021 23:39:00 GMT, David Holmes wrote:
>> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
>> we add sanity checks for ThreadsListHandles higher in the call stack.
>>
>> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
>
> Hi Dan,
>
> I jus
On Thu, 4 Nov 2021 21:45:16 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr2.patch
>
> Sorry for such a long delay looking at this.
On Fri, 5 Nov 2021 15:15:14 GMT, Daniel D. Daugherty wrote:
>> Yes, ^ that might make the logic easier to follow. I can't figure out what
>> checkTLSOnly means. Could it be refactored into a different function like
>> check_TLS() and then call it in the place where y
On Thu, 4 Nov 2021 19:33:33 GMT, Coleen Phillimore wrote:
>> It wasn't quite missing from the baseline code. This version of execute():
>>
>> `Handshake::execute(HandshakeClosure* hs_cl, JavaThread* target)`
>>
>> used to always create a ThreadsListHandle. I added a `ThreadsListHandle*`
>> para
On Thu, 4 Nov 2021 21:44:45 GMT, Coleen Phillimore wrote:
>> I'm really tempted to go ahead and change it to always set
>> current thread when it is declared and then clean things up a bit.
>
> Yes, ^ that might make the logic easier to follow. I can't figure out what
> checkTLSOnly means. Coul
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementa
On Fri, 5 Nov 2021 14:49:45 GMT, Gerard Ziemski wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8273967.cr1.patch
>
> Thank you Dan for the fix!
@gerard-ziem
On Fri, 5 Nov 2021 05:16:28 GMT, Thomas Stuefe wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8273967.cr1.patch
>
> Looks good!
@tstuefe - Thanks for the re-rev
hat code needs to be excluded
> on macOS.
>
> 2) In `src/hotspot/share/runtime/os.cpp` I noticed a simple typo in a comment
> on an
> `#endif` that I fixed. That typo does not appear anywhere else in the
> HotSpot code
> base so I'd like to fix it with this bug
On Mon, 1 Nov 2021 15:32:54 GMT, Daniel D. Daugherty wrote:
> macOS12 has changed the dladdr() function to accept "-1" as a valid address
> and
> we have functions that use dladdr() to convert DLL addresses into function or
> library names. We also have a gtest that verif
On Thu, 4 Nov 2021 05:13:29 GMT, Thomas Stuefe wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8273967.cr1.patch
>
> Marked as reviewed by stuefe (Reviewer).
@tstuefe and @ger
On Wed, 3 Nov 2021 21:14:17 GMT, Gerard Ziemski wrote:
>> macOS12 has changed the dladdr() function to accept "-1" as a valid address
>> and
>> we have functions that use dladdr() to convert DLL addresses into function or
>> library names. We also have a gtest that verifies that "-1" is not a va
On Thu, 4 Nov 2021 05:12:48 GMT, Thomas Stuefe wrote:
>> I took a quick look at the other calls to `dladdr()` in
>> src/hotspot/os/bsd/os_bsd.cpp
>> and I'm not comfortable with changing those uses without having a specific
>> test
>> case that I can use to investigate those code paths.
>>
>>
On Mon, 1 Nov 2021 15:32:54 GMT, Daniel D. Daugherty wrote:
> macOS12 has changed the dladdr() function to accept "-1" as a valid address
> and
> we have functions that use dladdr() to convert DLL addresses into function or
> library names. We also have a gtest that verif
On Thu, 4 Nov 2021 05:12:32 GMT, Thomas Stuefe wrote:
>> It's actually fairly common to have Mac-specific stuff in the BSD files. The
>> macOS
>> port was built on top of the BSD port and the BSD port was built by copying
>> a LOT
>> of code from Linux into BSD specific files with modifications
On Thu, 4 Nov 2021 01:16:03 GMT, David Holmes wrote:
>> I suspect that the way that git is displaying the diffs is confusing you.
>>
>> We need `current_thread` set if we get to line 474 so we have to init
>> `current_thread` on line 446 for the `checkTLHOnly == true` case and
>> on line 463 for
On Thu, 4 Nov 2021 01:18:23 GMT, David Holmes wrote:
>> The rationale for removing the is_exiting() check from `java_suspend()` was
>> that it
>> was redundant because the handshake code detected and handled the
>> `is_exiting()`
>> case so we didn't need to do that work twice.
>>
>> If we loo
On Sun, 4 Jul 2021 23:39:00 GMT, David Holmes wrote:
>> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
>> we add sanity checks for ThreadsListHandles higher in the call stack.
>>
>> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
>
> Hi Dan,
>
> I jus
> A fix to reduce ThreadsListHandle overhead in relation to handshakes and
> we add sanity checks for ThreadsListHandles higher in the call stack.
>
> This fix was tested with Mach5 Tier[1-8]; Tier8 is still running.
Daniel D. Daugherty has updated the pull request incrementa
On Wed, 3 Nov 2021 19:08:38 GMT, Daniel D. Daugherty wrote:
>> src/hotspot/os/bsd/os_bsd.cpp line 902:
>>
>>> 900: return false;
>>> 901: }
>>> 902: #endif
>>
>> We use dladdr() in several places in this code. I wonder whether
On Wed, 3 Nov 2021 17:49:40 GMT, Thomas Stuefe wrote:
>> macOS12 has changed the dladdr() function to accept "-1" as a valid address
>> and
>> we have functions that use dladdr() to convert DLL addresses into function or
>> library names. We also have a gtest that verifies that "-1" is not a val
On Mon, 1 Nov 2021 15:32:54 GMT, Daniel D. Daugherty wrote:
> macOS12 has changed the dladdr() function to accept "-1" as a valid address
> and
> we have functions that use dladdr() to convert DLL addresses into function or
> library names. We also have a gtest that verif
On Mon, 1 Nov 2021 15:32:54 GMT, Daniel D. Daugherty wrote:
> macOS12 has changed the dladdr() function to accept "-1" as a valid address
> and
> we have functions that use dladdr() to convert DLL addresses into function or
> library names. We also have a gtest that verif
On Wed, 3 Nov 2021 09:50:08 GMT, Robbin Ehn wrote:
>> src/hotspot/share/runtime/handshake.cpp line 350:
>>
>>> 348: }
>>> 349:
>>> 350: void Handshake::execute(HandshakeClosure* hs_cl, ThreadsListHandle*
>>> tlh_p, JavaThread* target) {
>>
>> Nit: can we drop the `_p` part of `tlh_p` please.
On Wed, 3 Nov 2021 01:21:50 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8249004.cr2.patch
>
> src/hotspot/share/runtime/thread.cpp line 446:
>
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote:
>> This will fix a few issues with the tests added in #5290:
>>
>> - [x] intermittent failures
>> - [x] tests should use `failure` method to report problems rather than
>> throwing `AssertionError`
>
> Jakob Cornell has updated the pull requ
1 - 100 of 1805 matches
Mail list logo
