On Wed, 23 Feb 2022 05:56:18 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> This test has 4 test cases/modes: two core files test cases and two process. >> Each runs with and w/o `-Xcomp`. The `-Xcomp` test cases are not suppose to >> run when `-XX:+DeoptimizeALot` is used, because the test does some checks >> that assume certain methods will be compiled. This is handled by adding the >> following to the test case: >> >> ` * @requires vm.opt.DeoptimizeALot != true` >> >> When this was first added, only the process test cases existed. Later on the >> core tests cases were added, and the `@requires` was copied improperly. It >> ended up with `#no-xcomp-process` rather than `#xcomp-core`, which allows >> the `#xcomp-core` test case to run even when `-XX:+DeoptimizeALot` is being >> used. > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > Move @requires for Xcomp to the correct test case. Still thumbs up. ------------- Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7542
