Re: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

Hello Markus, CheckIntrinsics is a diagnostic flag. I think you need to add -XX:+UnlockDiagnosticVMOptions before it because otherwise test will fail on product build. Thanks, Dmitry On 03.03.2016 3:15, Markus Gronlund wrote: Greetings, Could a please ask for reviews for the following sim

Re: RFR[9u-dev]: 8151509: In check_addr0() function pointer is not updated correctly

Hi Cheleswer, Looks good, but I have questions/comments about other code in this function: 1) I think that "::close(fd);" should be inside "if (fd >= 0) {". 2) Just interesting, do you really need to set memory to 0 by memset? Thanks, Dmitry On 10.03.2016 13:43, Cheleswer Sahu wrote: Hi, Pl

Re: RFR[9u-dev]: 8151509: In check_addr0() function pointer is not updated correctly

able in the below location http://cr.openjdk.java.net/~csahu/8151509/webrev.01/ <http://cr.openjdk.java.net/%7Ecsahu/8151509/webrev.01/> Regards, Cheleswer *From:*Thomas Stüfe [mailto:thomas.stu...@gmail.com] *Sent:* Thursday, March 10, 2016 7:39 PM *To:* Dmitry Dmitriev *Cc:* Cheleswer S

Re: RFR[9u-dev]: 8151509: In check_addr0() function pointer is not updated correctly

Cheleswer, thank you! But I think you need a "R"eviewer for that change before push. Dmitry On 11.03.2016 14:38, Cheleswer Sahu wrote: Thanks Dmitry and Thomas for reviews. After adding space I will request for the push. Regards, Cheleswer *From:*Dmitry Dmitriev *Sent:* Fri

Re: RFR[9u-dev]: 8151442: jstack doesn't close quotation marks properly with threads' name greater than 1996 characters

Hello Cheleswer, It is possible to create a regression test for that? Dmitry On 18.03.2016 10:54, Cheleswer Sahu wrote: Hi, Please review the code changes for https://bugs.openjdk.java.net/browse/JDK-8151442. Webrev Link: http://cr.openjdk.java.net/~csahu/8151442/ Bug Brief: In jstack t

RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

Hello, Please review small patch which fixes error message for NULL memory size arguments. Currently message for nanotime arguments is printed. I change it to make it consistent with other error messages for memory size arguments. JBS: https://bugs.openjdk.java.net/browse/JDK-8160102 webrev.

Re: RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

David, thank you for the review! Dmitry On 23.06.2016 3:08, David Holmes wrote: Looks good. Thanks, David On 23/06/2016 6:57 AM, Dmitry Dmitriev wrote: Hello, Please review small patch which fixes error message for NULL memory size arguments. Currently message for nanotime arguments is

Re: RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

Robbin, thank you for the review! Dmitry On 23.06.2016 12:54, Robbin Ehn wrote: Hi Dmitry, Looks good, thanks! /Robbin On 06/22/2016 10:57 PM, Dmitry Dmitriev wrote: Hello, Please review small patch which fixes error message for NULL memory size arguments. Currently message for nanotime

RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

Hello, Please review fix for jdk/test/sun/tools/jps tests. sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools. The problem is that TestJpsJar not add class path to the process builder and fails to find test library classes if these classes were

Re: RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

Hello, I withdraw this patch because it's wrong. Thanks! On 06.09.2016 14:43, Dmitry Dmitriev wrote: Hello, Please review fix for jdk/test/sun/tools/jps tests. sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools. The problem is that TestJ

Re: RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

FYI: the problem is with new JDK 9 multi-release jar tool which ignores second(and others) '-C .' arguments. Bug: JDK-8165500 "jar not proceed second(and others) -C . arguments" <https://bugs.openjdk.java.net/browse/JDK-8165500> Dmitry On 06.09.2016 15:35, Dmitry

RFR(XXS): 8165513: Quarantine sun/tools/jps/TestJpsJar.java

Hello, Please review small fix. JDK-8160923 removes this test from problem list, but it still fails due to JDK-8165500 . Thus put sun/tools/jps/TestJpsJar.java back to the problem list with ne

Re: RFR(XXS): 8165513: Quarantine sun/tools/jps/TestJpsJar.java

Dmitry, thank you for the review! Dmitry On 06.09.2016 20:32, Dmitry Samersoff wrote: Dmitry, Looks good for me! -Dmitry On 2016-09-06 19:42, Dmitry Dmitriev wrote: Hello, Please review small fix. JDK-8160923 <https://bugs.openjdk.java.net/browse/JDK-8160923> removes this tes

Re: RFR(S): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Hi Dmitry, I don't think that this solves the problem. If some test build testlibrary before TestJpsJar.java, then testlibrary classes will be outside the folder with JpsHelper class and thus missed in the jar file. I can reproduce this problem with your patch applied: 1) Run sun/tools/jinfo/

Re: RFR(S): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

oduced it. I'll check what is happening. -Dmitry On 2016-09-15 15:34, Dmitry Dmitriev wrote: Hi Dmitry, I don't think that this solves the problem. If some test build testlibrary before TestJpsJar.java, then testlibrary classes will be outside the folder with JpsHelper class and thus m

RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

Hello, Please review new tests for module aware agents. There are 3 tests: 1) MAAClassFileLoadHook.java - verifies ClassFileLoadHook event with different combinations of can_generate_early_vmstart and can_generate_early_class_hook_events JVMTI capabilities. Expects to find(or not) class from j

Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

;Class is found in ClassPrepare events duringVM Start phase!\n"); 296 return FAILED; 297 } Could you, please, replace "VM Start phase" with "normal VM start phase"?It will be more clear that the start phase mode is "normal". Thanks, S

Re: RFR: 8150758: [TESTBUG] need jvmti tests for module aware agents

g nits: libMAAClassFileLoadHook.c 103: missed space after , libMAAClassFileLoadHook.c: 266: extra semicolon -Dmitry On 2016-09-20 13:17, Dmitry Dmitriev wrote: Serguei, Dmitry, Thank you for the feedback! Here is an updated webrev.01; http://cr.openjdk.java.net/~ddmitriev/8150758/webrev.01/

Re: RFR: 8158797: Test java/lang/management/MemoryMXBean/LowMemoryTest.java fails when GC is specified explicitly

Hi Alexander, Looks good. Please correct copyright year in the header(2015 -> 2016). Not need a new webrev for that. Thanks, Dmitry On 10.10.2016 13:51, Alexander Kulyakhtin wrote: Hi, Could you, please, review this simple, test-only change: CR: https://bugs.openjdk.java.net/browse/JDK-815

Re: RFR: 8168479: Backout the changes for JDK-8168478

Hi Alexander, can you please change bug title to "Quarantine AllModulesCommandTest.java test". The change looks good. Dmitry - Original Message - From: alexander.kulyakh...@oracle.com To: serviceability-dev@openjdk.java.net Sent: Friday, October 21, 2016 4:10:41 PM GMT +03:00 Iraq Subje