Looks good to me (emcmanus) too.
Éamonn
2016-01-06 7:04 GMT-08:00 Alan Bateman :
>
>
> On 06/01/2016 11:00, Jaroslav Bachorik wrote:
>
>> On 5.1.2016 16:47, Eamonn McManus wrote:
>>
>>> OK. In that case I would suggest removing the checkVersion variable
>&
OK. In that case I would suggest removing the checkVersion variable since
it is now always true, along with the logic from ImplVersionCommand for
when it is false.
Éamonn
2016-01-05 5:52 GMT-08:00 Jaroslav Bachorik :
> On 4.1.2016 21:26, Eamonn McManus wrote:
>
>> I think this
I think this test should either be deleted or reduced to a simple check
that the MBeanServerDelegate's ImplementationVersion attribute is equal to
System.getProperty("java.runtime.version"). The whole business of starting
up a separate process and checking things with security managers and so on
is
Looks fine to me (emcmanus).
On Aug 13, 2015 11:13 AM, "Jaroslav Bachorik"
wrote:
> On 13.8.2015 02:53, Daniel Fuchs wrote:
>
>> Hi Jaroslav,
>>
>> On 12/08/15 18:05, Jaroslav Bachorik wrote:
>>
>>> On 5.8.2015 08:04, Eamonn McManus wrote:
&
t is whether we would want to add a check to the JCK. I would argue
not, so a vague specification is appropriate.
Éamonn
2015-08-05 12:39 GMT-07:00 Stuart Marks :
> On 8/5/15 8:02 AM, Jaroslav Bachorik wrote:
>>
>> On 5.8.2015 16:53, Eamonn McManus wrote:
>>>
>>> I woul
That makes me sad. The limit is clearly a detail of this particular
implementation and should not be enshrined in the spec.
Éamonn
2015-08-05 8:02 GMT-07:00 Jaroslav Bachorik :
> On 5.8.2015 16:53, Eamonn McManus wrote:
>>
>> I would remove the spec changes about the limit on th
I would remove the spec changes about the limit on the domain length,
which are a property of this particular implementation. It's perfectly
reasonable to blow up if the domain length is > 536,870,911, but
there's no reason for it to be in the spec.
Éamonn
2015-08-05 4:48 GMT-07:00 Jaroslav Bacho
I would like to suggest some cosmetic changes. The hex constants could
have underscores, for example 0x8000_. The FLAG_MASK constant
could be expressed as the OR of the three flags rather than as a
literal, and the DOMAIN_LENGTH_MASK could be ~FLAG_MASK. In
setDomainLength, the parameter name l
2015-03-25 9:53 GMT-07:00 Jaroslav Bachorik :
> On 23.3.2015 13:12, Jaroslav Bachorik wrote:
>>
>> On 18.3.2015 23:28, Eamonn McManus wrote:
>>>>
>>>> Mainly because the long term goal (beyond the scope of this JEP,
>>>> anyway) would be to get use
ize for the formatting mess - clearly the JIRA's markdown processor
> is rather confused with more extensive usage of the code blocks.
>
> On 4.3.2015 18:42, Eamonn McManus wrote:
>>
>> Thank you for updating the JEP text referencing JSR 255.
>>
>> Perhaps unsurpri
ing to
implement four methods when you're usually only interested in one. You
could also add a preDeregister overload with MBeanServer and
ObjectName parameters, again with a default implementation.
Éamonn
2015-03-04 0:47 GMT-08:00 Jaroslav Bachorik :
> On 4.3.2015 02:09, Eamonn McManus w
Could you explain what you mean by this, regarding the annotations
that were already agreed on by the JSR 255 Expert Group:
* Smaller scope compared to the proposed solution
* Conceptually in pre JDK7 era
I have a number of other comments, but procedurally I'm not sure what
the precedent is for s
Reviewed-by: emcmanus
The order of the parameters in checkMutableReference and
checkReturnMutables is surprising, but otherwise this looks good.
Éamonn
2013/9/26 Jaroslav Bachorik
> I've updated the webrev to utilize "readResolve" method to clone the
> deserialized instance before returning i
I would recommend against changing the code to do additional calls to
Class.forName during MBean introspection. As I recall we made the opposite
change some years ago, both because Class.forName can be slow (it may call
out to a user ClassLoader) and because it is a potential source of security
pro
This area has historically caused a lot of problems and I am not
surprised to see that there are more. While I don't know what the best
way to fix the issue at hand is, I don't think this proposed change is
it. The reason is that the checkConnection and gotIOException methods
do blocking operations
Looks good.
Reviewed-by: emcmanus
Éamonn
2012/10/25 Jaroslav Bachorik
> Thanks, addressing the comments ...
>
> On 10/24/2012 05:43 PM, Eamonn McManus wrote:
> > The fix looks good, but I would adjust a couple of small things. First,
> you
> > can improve the existing
Looks good.
Reviewed-by: emcmanus
Éamonn
2012/10/25 Jaroslav Bachorik
> Thanks, addressing the comments ...
>
> On 10/24/2012 05:43 PM, Eamonn McManus wrote:
> > The fix looks good, but I would adjust a couple of small things. First,
> you
> > can improve the existing
The fix looks good, but I would adjust a couple of small things. First, you
can improve the existing and new code with multi-catch. Second, the message
in the if (notFoundCount > 0) block should be adjusted to take into account
the new cases. Finally, hardwiring port 12345 into the test makes it a
This is already Reviewed-by: emcmanus, but I'm afraid I can't sponsor it.
Éamonn
2012/10/24 Jaroslav Bachorik
> I am looking for review and a sponsor.
>
> Webrev is available at
> http://cr.openjdk.java.net/~jbachorik/JDK-6783290/webrev.01/
>
> The serialization of javax.management.MBeanInfo a
Looks good to me (emcmanus).
Éamonn
2012/10/12 Jaroslav Bachorik
> Thanks. Minor nits picked ...
>
> http://btrace.kenai.com/webrevs/JDK-6783290/webrev.v3/
>
> -JB-
>
> On 10/11/2012 07:42 PM, Eamonn McManus wrote:
> > Looks good. A couple of minor nits about
chorik/JDK-6783290-v1/
>
> -JB-
>
> On Wed 10 Oct 2012 08:46:04 PM CEST, Jaroslav Bachorik wrote:
>> Hi,
>>
>> On Wed 10 Oct 2012 05:49:11 PM CEST, Eamonn McManus wrote:
>>> Hi Jaroslav,
>>>
>>> The patch looks correct and the
Hi Jaroslav,
The patch looks correct and the test is ingenious.
I do not understand why the previous SerializationTest needs to be
deleted. It doesn't seem that the new test is covering the same
things.
Reviewed-by: emcmanus
Incidentally I was not able to find a way to see the patch with the
us
>From Jaroslav's description it sounds as if RMI/IIOP is not following
the expected semantics of RMI. In "plain" RMI (RMI/JRMP), unexporting
an object on the server does not prevent already-received operations
on that object from running to completion and sending their results
back to the client. I
OK, well if you've managed to align modules on package boundaries
everywhere else then congratulations, because that can't have been
easy! Certainly a relatively minor feature like ConstructorProperties
shouldn't be the only obstacle to completing that split. If we had
known that this question woul
mes or whatever, because you would still
have to support existing code that uses @ConstructorProperties.
Éamonn
On 13 September 2012 14:45, Mandy Chung wrote:
>
> Hi Eamonn,
>
> Thanks for the review and the information.
>
>
> On 9/13/2012 9:48 AM, Eamonn McManus wrote
If at all possible, it would be better to split out
ConstructorProperties into a separable dependency so that JMX could
depend on just that. The idea that a profile with JMX but not
JavaBeans is almost but not quite exactly like a profile with both
seems rather user-hostile.
If it is not possible
I think there is a good case to be made for throwing an exception in
the constructor if the name or type is null. I guess that would
require a minor spec change, though.
Without such a change, the code can be simplified using Objects.equals
and Objects.hash. That assumes it doesn't need to be back
wrote:
>
> I think I have not been clear enough here.
>
> I Agree with Eammon's argument, and anyway ok with this change.
>
> Olivier.
>
>
> Olivier Lagneau said on date 2/24/2012 12:38 PM:
>
> Hi Éamonn,
>
> Eamonn McManus said on date 2/23/2012 8:44 P
Changeset: 7fee717f4707
Author:emcmanus
Date: 2010-10-29 12:35 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7fee717f4707
6984037: jmx/management rebranding vendor changes needed
Reviewed-by: ohair
! make/netbeans/jmx/build.properties
! src/share/classes/com/sun/jmx/default
I think an alternative approach to the one here would be to use a global
ReferenceQueue and a subclass of WeakReference that has a pointer back
to the Logger or LogNode that contains this WeakReference. Then, in the
cases where you currently check for stale entries, you could simply poll
the Re
Changeset: f23a3ae59169
Author:emcmanus
Date: 2009-10-21 17:33 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f23a3ae59169
6851617: Remove JSR 255 (JMX API 2.0) from JDK 7
Summary: See
http://weblogs.java.net/blog/2009/06/16/jsr-255-jmx-api-20-postponed
Reviewed-by: dfuchs
Changeset: c8db1ddbdba4
Author:emcmanus
Date: 2008-12-10 11:59 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c8db1ddbdba4
6456269: Add a GenericMBeanException so clients don't have to have server's
exception classes present
Reviewed-by: jfdenise, dfuchs
! src/share/classes
Changeset: 0b1c7f982cc0
Author:emcmanus
Date: 2008-12-09 18:30 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1c7f982cc0
6780803: Wrong parameter name in description of EventClient::addListeners()
6470295: Misleading exception message says context classloader when it isn't
Changeset: b4bf1806ee66
Author:emcmanus
Date: 2008-12-09 12:01 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b4bf1806ee66
6774918: @NotificationInfo is ineffective on MBeans that cannot send
notifications
Reviewed-by: jfdenise
! src/share/classes/com/sun/jmx/mbeanserver/MB
Changeset: 24a31530683d
Author:emcmanus
Date: 2008-11-27 15:44 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/24a31530683d
6776225: JMX.isNotificationSource wrong when DynamicWrapperMBean +
SendNotification injection
Reviewed-by: dfuchs, jfdenise
! src/share/classes/com/sun
Changeset: 098e456e860e
Author:emcmanus
Date: 2008-11-20 10:10 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/098e456e860e
6772779: @NotificationInfo does not create MBeanNotificationInfo in the MBean's
MBeanInfo
6773593: CompositeDataSupport constructor javadoc is not in sy
Changeset: 2410a0b48d06
Author:emcmanus
Date: 2008-11-07 19:19 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2410a0b48d06
6336968: Methods to convert AttributeList to/from Map
6750008: Add JMX.getSpecificationVersion(MBeanServerConnection) and document
interop
6750472: Add
Changeset: 810a95940b99
Author:emcmanus
Date: 2008-11-07 11:48 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/810a95940b99
5072267: A way to communicate client context such as locale to the JMX server
Summary: Support for client contexts and also for localization of descripti
Changeset: 8d17cc67a857
Author:emcmanus
Date: 2008-10-31 17:34 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8d17cc67a857
6766173: Spec should say that createMBean wraps a constructor RuntimeException
in a RuntimeMBeanException
Summary: JMX spec clarification
Reviewed-by: d
Changeset: cdfb6f963a60
Author:emcmanus
Date: 2008-10-30 18:19 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cdfb6f963a60
6450848: make it easier to get the ObjectName of a JMX Proxy
Summary: Rework proxy javadoc to explain how to do this.
Reviewed-by: sjiang
! src/share/cl
Changeset: 8dcde0b16199
Author:emcmanus
Date: 2008-10-30 17:46 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8dcde0b16199
6252609: Two different default descriptor forms defined for
ModelMBeanInfoSupport
6253137: Documentation for NotificationListener's handback parameter i
Changeset: 58e52eb46bd3
Author:emcmanus
Date: 2008-10-28 18:21 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58e52eb46bd3
6763051: MXBean: Incorrect type names for parametrized dealing with arrays
(openType)
6713777: developer diagnosability of errors in uncompliant mxbean
Changeset: 76ecb928e83a
Author:emcmanus
Date: 2008-10-27 14:02 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76ecb928e83a
6763639: Remove "rawtypes" warnings from JMX code
Reviewed-by: dfuchs
! make/netbeans/jmx/build.xml
! src/share/classes/com/sun/jmx/event/LeaseManager.j
Changeset: 86799e45c230
Author:emcmanus
Date: 2008-10-08 18:38 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86799e45c230
6757225: MXBean: Incorrect type names for parametrized types, dealing with
arrays
Reviewed-by: sjiang
! src/share/classes/com/sun/jmx/mbeanserver/MXBea
Changeset: 48a790c67659
Author:emcmanus
Date: 2008-09-24 15:19 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48a790c67659
6750935: The expected NotCompliantMBeanException is not thrown for the custom
MXBeanMappingFactory
6751872: MXBeanMappingFactory example says "implement
Changeset: ebc38225b4a9
Author:emcmanus
Date: 2008-09-12 15:17 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ebc38225b4a9
6747411: EventClient causes thread leaks
Summary: Reworked thread management in EventClient and related classes.
Reviewed-by: sjiang, dfuchs
! src/share
Changeset: b35ccd203a7e
Author:emcmanus
Date: 2008-09-10 14:56 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b35ccd203a7e
6746759: Fix for 6734813 introduced build break
Reviewed-by: dfuchs
! src/share/classes/sun/management/ClassLoadingImpl.java
! src/share/classes/sun/man
Changeset: 2b44dd8ed72d
Author:emcmanus
Date: 2008-09-10 13:36 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2b44dd8ed72d
6734813: Provide a way to construct an ObjectName without checked exceptions
6746649: ObjectName constructors and methods declare unchecked exceptions in
Changeset: 1643868af837
Author:emcmanus
Date: 2008-09-09 14:57 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1643868af837
6746196: Some JMX classes do not compile with Eclipse compiler
Reviewed-by: dfuchs
Contributed-by: [EMAIL PROTECTED]
! src/share/classes/com/sun/jmx/mbe
Changeset: 00ea8fc81867
Author:emcmanus
Date: 2008-09-03 14:31 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00ea8fc81867
6744132: Spurious failures from
test/javax/management/MBeanInfo/NotificationInfoTest.java
Reviewed-by: dfuchs
! test/javax/management/MBeanInfo/Notific
Changeset: 1d1d66438d11
Author:emcmanus
Date: 2008-09-02 14:14 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d1d66438d11
6405862: Allow CompositeType to have zero items
6737133: Compilation failure of
test/javax/management/eventService/LeaseManagerDeadlockTest.java
6737140
Changeset: 0a427d0e70a7
Author:emcmanus
Date: 2008-09-01 17:11 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0a427d0e70a7
6731410: JMXServiceURL cannot use @ConstructorProperties for compatibility
reasons
Reviewed-by: dfuchs
! src/share/classes/javax/management/MXBean.java
Changeset: 7afa7314d883
Author:emcmanus
Date: 2008-08-27 11:03 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7afa7314d883
5041784: (reflect) generic signature methods needlessly return generic arrays
Reviewed-by: darcy
! src/share/classes/sun/reflect/generics/factory/CoreRe
Changeset: 343d63bb2609
Author:emcmanus
Date: 2008-08-08 18:36 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/343d63bb2609
6610174: Improve CompositeDataSupport.toString when it includes arrays
Reviewed-by: dfuchs
! src/share/classes/javax/management/openmbean/CompositeDataS
Changeset: e9de9ae8c214
Author:emcmanus
Date: 2008-08-08 15:08 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e9de9ae8c214
6334663: TabularDataSupport should be able to return values in the insertion
order
Reviewed-by: dfuchs
! src/share/classes/com/sun/jmx/mbeanserver/Defa
Changeset: afe18ad188a1
Author:emcmanus
Date: 2008-08-07 16:25 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/afe18ad188a1
6717257: MBeanServer doesn't describe RuntimeException for methods inherited
from MBeanServerConnection
Reviewed-by: dfuchs
! src/share/classes/javax/m
Changeset: 13b8426bb0cd
Author:emcmanus
Date: 2008-08-06 18:28 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/13b8426bb0cd
6734273: Minor updates to documentation of Custom MXBean Mappings
Reviewed-by: dfuchs
! src/share/classes/javax/management/MXBean.java
! src/share/class
Changeset: 00c40e393a75
Author:emcmanus
Date: 2008-08-05 10:49 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00c40e393a75
6733589: Intermittent failure of
test/javax/management/eventService/SharingThreadTest.java
Reviewed-by: sjiang
! test/javax/management/eventService/Sha
Reviewed OK.
Éamonn McManus · JMX Spec Lead · http://weblogs.java.net/blog/emcmanus/
Daniel Fuchs wrote:
See
attached diff...
5108776 has added a new public javax.management.event package.
The javax.management.event package must also be declared
in CORE_PKGS.gmk in order to be i
Changeset: 8f52c4d1d934
Author:sjiang
Date: 2008-07-31 15:31 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8f52c4d1d934
5108776: Add reliable event handling to the JMX API
6218920: API bug - impossible to delete last MBeanServerForwarder on a connector
Reviewed-by: emcmanus
Changeset: afa8b71365aa
Author:emcmanus
Date: 2008-07-09 10:36 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/afa8b71365aa
6323980: Annotations to simplify MBean development
Reviewed-by: jfdenise, dfuchs
! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerIntercept
Changeset: a031e88c72ec
Author:emcmanus
Date: 2008-07-04 18:55 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a031e88c72ec
6601652: MXBeans: no IllegalArgumentException in the ex. chain for
SortedSet/Map with a non-null comparator()
Summary: Forward-port this bug fix from JD
Changeset: b715e82ef7e1
Author:emcmanus
Date: 2008-06-05 13:40 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b715e82ef7e1
6701498: Change JMX query language to use * and ? as wildcards rather than %
and _
Reviewed-by: dfuchs
! src/share/classes/javax/management/MatchQueryE
Changeset: 1483094a7c17
Author:emcmanus
Date: 2008-05-16 11:34 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1483094a7c17
6703552: Missing files from changeset for 6701459
Summary: Previous push missed a small number of files.
Reviewed-by: dfuchs
!
src/share/classes/javax/
Changeset: 94ded5c8cfba
Author:emcmanus
Date: 2008-05-14 18:38 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94ded5c8cfba
6701459: Synchronization bug pattern found in
javax.management.relation.RelationService
Summary: Fixed this and many other problems found by FindBugs.
R
Changeset: 92ea0ac77d2f
Author:emcmanus
Date: 2008-04-22 18:58 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92ea0ac77d2f
6692027: Custom subclasses of QueryEval don't serialize
Summary: Remove non-public superclass of QueryEval
Reviewed-by: dfuchs
! src/share/classes/javax
Changeset: 2965459a8ee7
Author:emcmanus
Date: 2008-04-01 14:45 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2965459a8ee7
6610917: Define a generic NotificationFilter
Summary: Adds javax.management.QueryNotificationFilter
Reviewed-by: dfuchs
! src/share/classes/com/sun/jmx/
Changeset: 01f7eeea81f1
Author:emcmanus
Date: 2008-03-21 18:07 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01f7eeea81f1
6643627: JMX source code includes incorrect Java code
Summary: javac compiler bug accepts incorrect code; JMX code inadvertently has
such code
Reviewed-
Changeset: 9a97ca4eb8b7
Author:emcmanus
Date: 2008-03-21 09:49 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a97ca4eb8b7
6649542: Document explicitly in registerMBean etc that MBeanServerNotification
is emitted
Summary: Make spec more readable by adding cross-references.
Changeset: 0d4923ce2707
Author:emcmanus
Date: 2008-03-19 15:17 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d4923ce2707
6675768: NoSuchElementException thrown in RequiredModelMBean when tracing
enabled
Summary: Rewrite logging in
RequiredModelMBean.addAttributeChangeNoti
Changeset: 302cbd0a8ace
Author:emcmanus
Date: 2008-03-03 15:44 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/302cbd0a8ace
6670375: Missing unit test for 6607114 (Make JMXServiceURL reconstructible)
Summary: Current setup doesn't allow two pushes with same CR number
Reviewed-
Changeset: 10256bd4afcd
Author:emcmanus
Date: 2008-03-03 15:28 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/10256bd4afcd
6607114: Make JMXServiceURL reconstructible in MXBeans
Summary: Add @ConstructorProperties tag to JMXServiceURL
Reviewed-by: dfuchs
! src/share/classes/
Changeset: 41d9c673dd9d
Author:emcmanus
Date: 2008-03-03 10:32 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/41d9c673dd9d
6602310: Extensions to Query API for JMX 2.0
6604768: IN queries require their arguments to be constants
Summary: New JMX query language and support for
73 matches
Mail list logo
