On Mon, 9 Nov 2020 20:23:55 GMT, Harold Seigel wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment
>
> Looks good!
Claes, Lois, Harold,
Thank you for yo
On Mon, 9 Nov 2020 15:43:09 GMT, Frederic Parain wrote:
> Please review this small cleanup code, removing the now unused allocation
> type from the fieldInfo structure.
>
> Tested with Mach5, tiers 1 to 3 and locally by running
> test/hotspot/jtreg/serviceability/sa tests.
On Mon, 9 Nov 2020 19:53:32 GMT, Harold Seigel wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused symbol from vmStruct
>
> src/hotspot/share/oops/f
> Please review this small cleanup code, removing the now unused allocation
> type from the fieldInfo structure.
>
> Tested with Mach5, tiers 1 to 3 and locally by running
> test/hotspot/jtreg/serviceability/sa tests.
>
> Thank you,
>
> Fred
Frederic Parain h
> Please review this small cleanup code, removing the now unused allocation
> type from the fieldInfo structure.
>
> Tested with Mach5, tiers 1 to 3 and locally by running
> test/hotspot/jtreg/serviceability/sa tests.
>
> Thank you,
>
> Fred
Frederic Parain h
On Mon, 9 Nov 2020 16:36:07 GMT, Claes Redestad wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused symbol from vmStruct
>
> Nice cleanup!
Hi Claes,
Thank you for your
> Please review this small cleanup code, removing the now unused allocation
> type from the fieldInfo structure.
>
> Tested with Mach5, tiers 1 to 3 and locally by running
> test/hotspot/jtreg/serviceability/sa tests.
>
> Thank you,
>
> Fred
Frederic Parain h
Please review this small cleanup code, removing the now unused allocation type
from the fieldInfo structure.
Tested with Mach5, tiers 1 to 3 and locally by running
test/hotspot/jtreg/serviceability/sa tests.
Thank you,
Fred
-
Commit messages:
- Cleanup fieldInfo structure
Chang
ed "combinable" and only allow those commands to be
> specified?
>
> If we want a general purpose way of expressing a list of Dcmds to execute
> then perhaps it should be specified to process each command in turn, with a
> sequence of combinable safepoint ops processed at a single
st omit the steps needing a heap lock.)
>
> So, yes, on first glance I find this useful. I'll play around with
> this a bit more. Lets wait for others to chime in.
>
> Best Regards, Thomas
>
>
> On Fri, Jun 15, 2018 at 5:32 PM, Frederic Parain
> wrote:
&g
order to
correctly
check Java Permissions before executing the commands.
Let me know if you consider this code useful or if the limitations described
above
make this feature not as pretty as we wanted it to be.
Regards,
Fred
> On May 29, 2018, at 15:54, Frederic Parain wrote:
>
>
Hi Thomas,
> On May 26, 2018, at 04:07, Thomas Stüfe wrote:
>
>>
>> I think that it is a fundamental piece of the design. Adding a new diagnostic
>> command to group several commands under a unique safepoint:
>> 1 - requires explicit action from the user (and acknowledgment of the risks)
>>
Hi Thomas,
> On May 24, 2018, at 16:47, Thomas Stüfe wrote:
>
> Hi Frederic,
>
> On Thu, May 24, 2018 at 7:29 PM, Frederic Parain
> wrote:
>> Hi Thomas,
>>
>>
>> On 05/24/2018 12:08 PM, Thomas Stüfe wrote:
>>>
>>> Hi Erik,
>&
Hi Thomas,
On 05/24/2018 12:08 PM, Thomas Stüfe wrote:
Hi Erik,
On Tue, May 22, 2018 at 11:08 PM, Erik Gahlin wrote:
Not sure if this will have an impact, but we have plans to add
parameterization to JFR.start.
It will work like the recording wizard in JMC. All the the widgets you see
in the
Looks good to me.
Fred
> On Dec 19, 2017, at 03:16, David Buck wrote:
>
> Hi!
>
> Please review this straightforward serviceability backport to JDK 8.
>
> No real changes to product code. I just moved the import statements in the
> DynLibDcmdTest.java test case to below the copyright header.
Looks good to me.
Thank you,
Fred
On 12/20/2016 01:29 AM, Ujwal Vangapally wrote:
Please review this small change
https://bugs.openjdk.java.net/browse/JDK-8170861
webrev:
http://cr.openjdk.java.net/~asapre/sponsorships/Ujwal/JDK-8170861/webrev.00/
Thanks,
Ujwal.
Thumbs up.
Fred
On 11/18/2016 10:43 AM, Harsha Wardhana B wrote:
Hello,
Please review below webrev incorporating Roger's comment.
http://cr.openjdk.java.net/~hb/8169575/webrev.01/
-Harsha
On Friday 18 November 2016 09:08 PM, Frederic Parain wrote:
"exitVM.*" should b
"exitVM.*" should be fine to avoid future maintenance burden.
Thank you for pointing this out Roger.
Fred
On 11/18/2016 10:32 AM, Harsha Wardhana B wrote:
Hi Roger,
I was not sure about adding exitVM.* as that would give permissions for
all exit codes.
Maybe Fred can comment since he is the t
Looks good to me.
Fred
On 11/18/2016 04:47 AM, Harsha Wardhana B wrote:
Hello All,
Please review below fix for issue
https://bugs.openjdk.java.net/browse/JDK-8169575
having webrev at,
http://cr.openjdk.java.net/~hb/8169575/webrev.00/
Regards
Harsha
Looks good to me too.
Fred
On 11/02/2016 05:58 AM, Amit Sapre wrote:
Hello,
Can I have one more review for these changes ?
-Original Message-
From: David Holmes
Sent: Saturday, October 29, 2016 12:22 AM
To: Amit Sapre; serviceability-dev
Subject: Re: RFR - JDK-8006078 : [findbugs]
jav
David,
Interesting twist about JavaThreads returning to their plain
Thread nature before dying.
Fix looks good to me.
Fred
On 08/02/2016 09:13 PM, David Holmes wrote:
webrev: http://cr.openjdk.java.net/~dholmes/8159461/webrev/
bug: https://bugs.openjdk.java.net/browse/JDK-8159461
The suspen
.data_dump will send the data dump request to JVMTI.
Both of these commands are covered by the corresponding tests.
Thanks,
-JB-
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ear the code
has "settled". I would like to know if there are any existing tests
for GC.class_stats and GC.class_histogram (there are none in the
"test" directory). If so, possibly one could serve as the basis for a
new test for VM.class_hierarchy.
thanks,
Chris
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ter is
indeed a delimiter char
(src/share/vm/services/diagnosticFramework.cpp#68).
The rest of the patch deals with testing - the WhiteBox support needs
to be enhanced to handle DCMD arguments (currently only options) and
custom delimiters (currently only comma).
Thanks,
-JB-
--
Frederic
(*env)->CallStaticObjectMethod(env, arraysCls, mid,
result);
105 return resultList;
If there is an exception pending due to the call what will resultList be
set to? Hopefully NULL but the JNI spec says nothing.
Thanks,
David
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4
Thank you for the review Chris.
Fred
On 02/28/2014 11:27 PM, Chris Hegarty wrote:
Looks good to me Frederic.
JVM_Read is restartable, but that may not be an issue here.
-Chris.
On 28 Feb 2014, at 21:19, frederic parain wrote:
Greetings,
Please review this small changeset for CR JDK
Thank you for the review.
Fred
On 03/04/2014 03:46 PM, Staffan Larsen wrote:
Looks good to me!
Thanks,
/Staffan
On 4 mar 2014, at 12:47, Frederic Parain wrote:
Here's an updated webrev:
http://cr.openjdk.java.net/~fparain/8035952/webrev.01/
Same testing as for the initial version.
Oops, I replied to the wrong e-mail.
Your latest comments have been taken into account
in the final changeset.
Thank you,
Fred
On 03/05/2014 11:31 AM, Frederic Parain wrote:
Thank you for the review Alan.
Fred
On 03/03/2014 10:32 PM, Alan Bateman wrote:
On 03/03/2014 10:30, Frederic Parain
Mandy,
Thank you for the review.
Fred
On 03/01/2014 12:10 AM, Mandy Chung wrote:
On 2/28/14 1:19 PM, frederic parain wrote:
Greetings,
Please review this small changeset for CR JDK-8035952
"Remove use of JVM_Open, JVM_Read and JVM_Close functions from
serviceability code"
Thank you for the review Alan.
Fred
On 03/03/2014 10:32 PM, Alan Bateman wrote:
On 03/03/2014 10:30, Frederic Parain wrote:
:
I'd prefer to keep open() and read() as they are,
for the sake of simplicity. In the unlikely case
where one of these calls gets interrupted, it would
simply gen
Here's an updated webrev:
http://cr.openjdk.java.net/~fparain/8035952/webrev.01/
Same testing as for the initial version.
Thank you,
Fred
On 03/03/2014 10:32 PM, Alan Bateman wrote:
On 03/03/2014 10:30, Frederic Parain wrote:
:
I'd prefer to keep open() and read() as they are,
fo
ed
by OperatingSystem.getCommittedVirtualMemorySize()
with a easily identifiable value of -1.
Regards,
Fred
On 03/01/2014 09:53 AM, Alan Bateman wrote:
On 28/02/2014 21:19, frederic parain wrote:
Greetings,
Please review this small changeset for CR JDK-8035952
"Remove use of JVM_Open, JVM_Read and
ested with jdk_management test suite + manual tests
to verify consistency of values returned by new code.
Thank you,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ev.00/>
Jira: https://bugs.openjdk.java.net/browse/JDK-8031304
/Fredrik
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ava.net/browse/JDK-8031304
/Fredrik
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
llection type, cause, ...
Thanks
Kevin
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: 83ca9dc4564d
Author:fparain
Date: 2013-07-26 15:24 +
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/83ca9dc4564d
8019845: Memory leak during class redefinition
Reviewed-by: acorn, jmasa, coleenp, dcubed, mgerdin
! src/share/vm/memory/metaspace.cpp
Changeset: c90c698831d7
Author:kvn
Date: 2013-07-12 14:01 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c90c698831d7
8020215: Different execution plan when using JIT vs interpreter
Summary: fix bytecode analyzer
Reviewed-by: twisti
! src/share/vm/ci/bcEscapeAnaly
Changeset: e50be1620201
Author:goetz
Date: 2013-07-08 14:15 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e50be1620201
8020059: The flag introduced by 8014972 is not defined if Hotspot is built
without a compiler (zero, ppc64 core build).
Summary: define CodeCac
Changeset: dbc0b5dc08f5
Author:fparain
Date: 2013-07-10 15:49 +
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dbc0b5dc08f5
7143807: ResourceMark nesting problem in stringStream
Reviewed-by: kvn, dcubed
! src/share/vm/memory/resourceArea.hpp
! src/share/vm/runtime/t
Changeset: c92b74c62d97
Author:brutisso
Date: 2013-06-27 09:59 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c92b74c62d97
8017483: G1 tests fail with native OOME on Solaris x86 after HeapBaseMinAddress
has been increased
Summary: Set HeapBaseMinAddress as default
Changeset: 93e6dce53ba7
Author:fparain
Date: 2013-07-05 08:26 +
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/93e6dce53ba7
8016465: The hs_err file gets wrong name
Reviewed-by: dcubed, dholmes, rdurbin
! src/share/vm/utilities/vmError.cpp
Changeset: 068b406e307f
Author:fparain
Date: 2013-07-01 09:13 +
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/068b406e307f
7060111: race condition in VMError::report_and_die()
Reviewed-by: zgu, coleenp
Contributed-by: volker.simo...@gmail.com
! src/share/vm/utiliti
Changeset: e857b2a3ecee
Author:fparain
Date: 2013-06-05 08:41 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e857b2a3ecee
7150256: Add back Diagnostic Command JMX API
Reviewed-by: mchung, jbachorik
! make/java/management/Exportedfiles.gmk
! make/java/management/FILES_c.gmk
!
Changeset: 31a4e55f8c9d
Author:fparain
Date: 2013-05-03 05:05 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/31a4e55f8c9d
8004095: Add support for JMX interface to Diagnostic Framework and Commands
Reviewed-by: acorn, sla
! src/share/vm/classfile/vmSymbols.hpp
! s
ut 's'.
On 5/3/2013 11:40 AM, frederic parain wrote:
MBeanServer.setAttributes() returns an AttributeList
but the return type of DynamicMBean.setAttributes() is
void. Does it mean that in our case, setAttributes()
should simply be a no-op method?
Fred
On 03/05/2013 20:19, Daniel Fuchs
>
and
<http://docs.oracle.com/javase/7/docs/api/javax/management/MBeanServer.html#setAttributes%28javax.management.ObjectName,%20javax.management.AttributeList%29>
-- daniel
Thanks
Mandy
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ws UOE which seem to be okay. It's good to confirm
what is specified or not specified per DynamicMBean spec
Thanks
Mandy
On 5/3/2013 9:43 AM, frederic parain wrote:
Hi all,
After an intense work with Mandy, here's a new webrev which
fix the issue with the PlatformMa
t;
-- daniel
Thanks
Mandy
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
ne 39: diamond operator
Since the test is for MXBeans, it's more appropriate to exclude
non-MXBean from this test or rename the test to cover the new platform
mbeans.
On 4/18/2013 7:23 AM, frederic parain wrote:
DiagnosticCommandImpl.Wrapper class
If there is any issue initializing the
icCommand.cpp
lines 105/109 - what prints if p._name is null?
thanks,
Karen
On Apr 30, 2013, at 12:26 PM, frederic parain wrote:
Hi all,
This is a second request for review to add back
Remote Diagnostic Commands.
This work adds a new platform MBean providing
remote access to the diag
tpone the
fix of this issue after the JDK8 feature freeze
(leaving for vacations soon, I won't have time to
fix tests before the feature freeze).
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
,
It's good to see the management interface for diagnostic commands is back.
On 12/17/12 6:58 AM, Frederic Parain wrote:
http://cr.openjdk.java.net/~fparain/7150256/webrev.01/
Please send your makefiles change to build-dev and build-infra for
review to ensure necessary change is made in th
still get caught
Diagnostic commands themselves could throw exceptions, so
the code only catches exception it could have triggered itself.
9. sorry - copyrights will all want to be 2013 now
Fixed
Thanks,
Fred
thanks,
Karen
On Dec 17, 2012, at 10:01 AM, Frederic Parain wrote:
Staffan,
T
nks,
/Staffan
On 17 dec 2012, at 12:26, Frederic Parain wrote:
Hi,
Please review the following change for CR 8004095.
This changeset is the JDK side of two parts project.
The goal of this feature is to allow remote invocations of
Diagnostic Commands via JMX.
Diagnostic Commands are actually
Done.
JB4: src/share/classes/sun/management/DiagnosticCommandImpl.java
Line 249 - typo "dcmd.permissionCame" instead of "dcmd.permissionName"
Fixed.
Thank you for the review,
Fred
On 12/17/2012 12:27 PM, Frederic Parain wrote:
Hi,
Please review the following change for CR 7150256.
This changese
they require.
The webrev is here:
http://cr.openjdk.java.net/~fparain/7150256/webrev.00/
The second part of this project is the support for this
feature in the HotSpot VM, and is tracked by CR 8004095
(separate request for review will be sent for it).
Thanks,
Fred
--
Frederic Parain - Oracle
extended to specify the Java Permission required
for their execution.
The webrev is here:
http://cr.openjdk.java.net/~fparain/8004095/webrev.00/
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: d900d95bfdb0
Author:fparain
Date: 2012-07-16 04:06 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d900d95bfdb0
7183754: Test runtime/6294277/Test6294277.sh runs wrong JVM
Reviewed-by: kamg, coleenp, ctornqvi
! test/runtime/6294277/SourceDebugExtension.j
Changeset: 04ade88d9712
Author:fparain
Date: 2012-07-09 01:28 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/04ade88d9712
6294277: java -Xdebug crashes on SourceDebugExtension attribute larger than 64K
Reviewed-by: sspitsyn, dholmes, coleenp, kamg
! agent/src/shar
Changeset: dcfcdd01af4b
Author:fparain
Date: 2012-06-05 06:48 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dcfcdd01af4b
7171703: JNI DefineClass crashes client VM when first parameter is NULL
Reviewed-by: acorn, kamg, sspitsyn, dholmes
! src/share/vm/prims/jni.c
intent clearer?
Thanks,
/Staffan
On 13 apr 2012, at 14:45, Frederic Parain wrote:
Thanks Staffan and Dmitry for your feedback,
here's a new webrev with a refactored code for
name and descriptions fields which are common to
most MBean*Info classes:
http://cr.openjdk.java.net/~fparain/714849
,
/Staffan
On 13 apr 2012, at 14:45, Frederic Parain wrote:
Thanks Staffan and Dmitry for your feedback,
here's a new webrev with a refactored code for
name and descriptions fields which are common to
most MBean*Info classes:
http://cr.openjdk.java.net/~fparain/7148497/webrev.01/
Thanks,
I'm second to Staffan.
Looks good to me but would prefer to have it refactored, e.g. create a
method equalOrNull();
-Dmitry
On 2012-04-10 18:33, Staffan Larsen wrote:
Looks good! (Although I wish there was a better way to write code like
this).
/Staffan
On 10 apr 2012, at 15:50, Frede
hashCode()
method to handle cases where some fields are null without throwing
a NPE.
Webrev:
http://cr.openjdk.java.net/~fparain/7148497/webrev.00/
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: 9a5bef0481c8
Author:fparain
Date: 2012-03-29 02:12 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9a5bef0481c8
7087969: GarbageCollectorMXBean notification contains ticks vs millis
Reviewed-by: acorn, dcubed, rbackman
! src/share/vm/services/gcNotifier.
at a time to the jvm.
A similar fix has already been done for JRockit's jrcmd command and will
be released in R28.2.3.
[ jdk ]
http://cr.openjdk.java.net/~dbuck/7154822/webrev.00/
All the default jprt tests and the jdk_tools tests were run and passed.
Cheers,
-Buck
--
Frederic Parain - Or
coordination dance will have to come into
> play... waiting for the right hotspot to get promoted before
> pushing the test to the jdk repo... etc...
With experience, serviceability engineers become very good dancers
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: 62228dc7a4ac
Author:fparain
Date: 2012-03-28 02:20 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62228dc7a4ac
7156831: The jcmd man page is not included in generated bundles
Reviewed-by: dholmes, sla, dsamersoff
! make/common/Release.gmk
/~fparain/7087969/webrev.00/
Tested manually and with JPRT by running the jdk_management suite.
No new test has been added because the fix is in the HotSpot repository,
and the GarbageCollectorMXBean notification unit tests are in the
jdk repository.
Thanks,
Fred
--
Frederic Parain - Oracle
Makefile to
add the jcmd man page to the list of JDK man pages.
Webrev:
http://cr.openjdk.java.net/~fparain/7156831/webrev.00/
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: 0e4f259f0a1f
Author:fparain
Date: 2012-03-14 09:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e4f259f0a1f
7074616: java.lang.management.ManagementFactory.getPlatformManagementInterfaces
fails
Reviewed-by: dholmes, sla
! src/share/classes/java/lang/management
lmes wrote:
On 2/03/2012 9:07 PM, Staffan Larsen wrote:
Looks good. But should we add a test for this?
I was about to say exactly the same thing! How has this never been
noticed?
David
/Staffan
On 2 mar 2012, at 10:42, Frederic Parain wrote:
Greetings,
A simple bu
/2012 9:07 PM, Staffan Larsen wrote:
Looks good. But should we add a test for this?
I was about to say exactly the same thing! How has this never been noticed?
David
/Staffan
On 2 mar 2012, at 10:42, Frederic Parain wrote:
Greetings,
A simple bug fix. The getPlatformManagementInterfaces
HashSet.
The bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7074616
The webrev:
http://cr.openjdk.java.net/~fparain/7074616/webrev.00/
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: d9b93445a67c
Author:vladidan
Date: 2012-02-15 20:26 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d9b93445a67c
7129401: PPC: runtime/7100935/TestShortArraycopy.java fails
Summary: pass assembler switches for PPC
Reviewed-by: dholmes
! make/linux/makefi
eturn true;
// object is not an object name case
if (!(object instanceof ObjectName)) return false;
ObjectName on = (ObjectName) object;
return _canonicalName.equals(on._canonicalName);
}
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33
improve performance.
It seems to me that this is a case of "fixing" something for one
use-case without knowing what the impact will be on other use-cases!
Is there perhaps a solution that makes String.intern more scalable?
David
-
On 24/02/2012 1:36 AM, Frederic Parain wrote:
Th
improve performance.
It seems to me that this is a case of "fixing" something for one
use-case without knowing what the impact will be on other use-cases!
Is there perhaps a solution that makes String.intern more scalable?
David
-
On 24/02/2012 1:36 AM, Frederic Parain wrote:
Th
Oracle, Grenoble Engineering Center - France
Phone : +33 4 76 18 80 09 Fax :
+33 4 76 18 80 23
Frederic Parain said on date 2/23/2012 6:01 PM:
No particular reason. But after thinking more about it,
equals() should be a better choice, clearer code, and
.00/>
I've tested this fix with the jdk_lang and jdk_management
test suites.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com <mailto:frederic.par...@oracle.com&g
http://cr.openjdk.java.net/~fparain/6988220/webrev.00/
I've tested this fix with the jdk_lang and jdk_management
test suites.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: 77a488cd4af2
Author:dlong
Date: 2012-02-15 00:51 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/77a488cd4af2
7140866: assert(covered) failed: Card for end of new region not committed
Summary: resize covered region only after successfully mapping shared a
Changeset: f1cb6f9cfe21
Author:fparain
Date: 2012-02-15 12:17 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f1cb6f9cfe21
7145243: Need additional specializations for argument parsing framework
Reviewed-by: acorn, fparain
Contributed-by: nils.loo...@oracle.com
! s
Changeset: 20d39a0e6fdc
Author:fparain
Date: 2012-02-15 10:46 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/20d39a0e6fdc
7145925: Removing remote access to diagnostic commands in the
HotSpotDiagnosticMBean
Reviewed-by: acorn, mchung, phh
! make/java/management/mapfile-vers
Changeset: 59884f656b7d
Author:fparain
Date: 2012-02-15 09:29 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59884f656b7d
7144833: sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Reviewed-by: alanb
! test/ProblemList.txt
! test/sun/tools/jcmd/jcmd_Output1.awk
Thanks Alan,
I've fixed the indentation in the BEGIN block.
Fred
On 02/15/12 10:04 AM, Alan Bateman wrote:
On 14/02/2012 11:01, Frederic Parain wrote:
This is a request for review for 7144833:
sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
Bug:
http://bugs.sun.com/bugdat
Changeset: 13aef38438d8
Author:fparain
Date: 2012-02-14 07:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13aef38438d8
7140868: TEST_BUG: jcmd tests need to use -XX:+UsePerfData
Reviewed-by: fparain, dholmes
! test/sun/tools/jcmd/jcmd-Defaults.sh
! test/sun/tools/jcmd/jcm
d). There's actually no way to specify
that an argument can be passed at multiple positions.
StringArrayArgument is an argument type defined to accept multiple
strings. As it is not possible to specify the multiple position for
an argument, StringArrayArgument can only used as an "option
Changeset: 1891640ca63f
Author:fparain
Date: 2012-02-14 06:54 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1891640ca63f
7143760: Memory leak in GarbageCollectionNotifications
Reviewed-by: dholmes, dcubed, kamg
! src/share/vm/services/gcNotifier.cpp
! src/share/v
http://cr.openjdk.java.net/~fparain/7144833/webrev.00/
The webrev also contains the removal of the sun/tools/jps/jps-Vvml.sh
test from the problem list. The test has been fixed (see CR 6986875)
but the test was still in the exclusion list.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - F
http://cr.openjdk.java.net/~fparain/7144833/webrev.00/
The webrev also contains the removal of the sun/tools/jps/jps-Vvml.sh
test from the problem list. The test has been fixed (see CR 6986875)
but the test was still in the exclusion list.
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - F
er, also by running
the tests in sun/tools/jcmd.
http://cr.openjdk.java.net/~nloodin/7145243/webrev.00/
I would also need a sponsor to get this in..
Regards
Nils Loodin
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
Changeset: 5e9fba4e8718
Author:kvn
Date: 2012-02-07 11:33 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5e9fba4e8718
7142167: MAC: _get_previous_fp broken on bsd with llvm-gcc
Summary: LLVM-GCC (__llvm__) should use the same _get_previous_fp
implementation as __c
terminate. Is that the desired behaviour? Other event processing can't
terminate the service thread.
David
-
On 10/02/2012 11:04 PM, Frederic Parain wrote:
Here's a new webrev addressing the following issues:
- the missing HandleMark
- the clean up of the GCNotificationRequest ins
hread is not. I'll add a wrapper around the
sendNotification() method to catch all exceptions.
Thanks for this useful review.
Fred
On 10/02/2012 11:04 PM, Frederic Parain wrote:
Here's a new webrev addressing the following issues:
- the missing HandleMark
- the clean up of the GCNot
27;ve seen of this today!)
David
-Dmitry
On 2012-02-10 13:27, Frederic Parain wrote:
Here's a small fix (one line) for CR 7143760 Memory leak in
GarbageCollectionNotifications
There's a missing HandleMark at the beginning of the
GCNotifier::sendNotificatin() method. Without this Handl
to be just THREAD. ??
(Strange this is the second example I've seen of this today!)
David
-Dmitry
On 2012-02-10 13:27, Frederic Parain wrote:
Here's a small fix (one line) for CR 7143760 Memory leak in
GarbageCollectionNotifications
There's a missing HandleMark a
dk.java.net/~fparain/7143760/webrev.00/
Thanks,
Fred
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
1 - 100 of 141 matches
Mail list logo
