Alan,
Thank you for the review.
I can use open64, even if I doubt the psinfo file
would be so big that it requires a 64-bits offset
(it contains a kernel data structure mapped to a
file and its size is currently 336 bytes).
JVM_Open was not restartable.
JVM_Read was restartable, but none of the other
interruptible system calls in OperatingSystemImpl.c
handles EINTR.
I'd prefer to keep open() and read() as they are,
for the sake of simplicity. In the unlikely case
where one of these calls gets interrupted, it would
simply generate a transient error in the value returned
by OperatingSystem.getCommittedVirtualMemorySize()
with a easily identifiable value of -1.
Regards,
Fred
On 03/01/2014 09:53 AM, Alan Bateman wrote:
On 28/02/2014 21:19, frederic parain wrote:
Greetings,
Please review this small changeset for CR JDK-8035952
"Remove use of JVM_Open, JVM_Read and JVM_Close functions from
serviceability code"
Bug:
https://bugs.openjdk.java.net/browse/JDK-8035952
Webrev:
http://cr.openjdk.java.net/~fparain/8035952/webrev.00/
This looks okay although I guess I would probably use open64. Also Chris
mentions EINTR and it would be good for both open and read to restart if
interrupted.
-Alan
--
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: frederic.par...@oracle.com
