On Sat, 20 Feb 2021 03:27:22 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve jcmd GC.class_histogram to support parallel
>
> For jmap -histo we have:
>
&g
On Wed, 3 Feb 2021 12:44:53 GMT, Hamlin Li wrote:
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
This pull request has now been integrated.
Changeset: 3c47cab6
Author: Hamlin Li
URL:
On Sat, 20 Feb 2021 03:27:22 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve jcmd GC.class_histogram to support parallel
>
> For jmap -histo we have:
>
&g
On Wed, 28 Apr 2021 06:38:57 GMT, Wang Huang wrote:
> Dear All,
> I find a memory leak in `appendBootClassPath()`
> https://github.com/openjdk/jdk/blob/75a2354dc276e107d64516d20fc72bc7ef3d5f86/src/java.instrument/share/native/libinstrument/InvocationAdapter.c#L950
> * we malloc `resolved` fr
On Mon, 26 Apr 2021 02:22:47 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> comm
On Mon, 26 Apr 2021 02:22:47 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> comm
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
refine help message.
-
Changes:
-
On Sun, 7 Feb 2021 12:38:55 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> comm
On Wed, 14 Apr 2021 19:08:25 GMT, Yumin Qi wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList= `
>
On Sat, 20 Feb 2021 03:27:22 GMT, Chris Plummer wrote:
>>> BTW, we have three PRs related to `parallel=`. I think it would be best
>>> to hold off pushing any of them until they have all been reviewed and
>>> approved. One reason is because the `parallel=` output should be
>>> consistent for a
On Fri, 19 Feb 2021 20:23:01 GMT, Chris Plummer wrote:
> BTW, we have three PRs related to `parallel=`. I think it would be best to
> hold off pushing any of them until they have all been reviewed and approved.
> One reason is because the `parallel=` output should be consistent for all
> of th
On Wed, 17 Feb 2021 04:30:45 GMT, Chris Plummer wrote:
>> Dear All,
>> May I say that we all agreed that "noparallel" is not necessary at
>> present? I think the PR #2519 and related CSR and issue could be all closed.
>
>> May I say that we all agreed that "noparallel" is not necessary at
On Wed, 10 Feb 2021 02:21:03 GMT, Lin Zang wrote:
>>> > * Default to not parallel. Allow the user to specify `-parallel`, but not
>>> > specify the thread count. They will get the default number of threads
>>> > just like `parallel=0`
>>> > * Default to parallel using the default number of thre
On Thu, 4 Feb 2021 03:52:23 GMT, Chris Plummer wrote:
> BTW, one thing to keep in mind that whatever we do with `dumpheap`, the jcmd
> version will support fine control over parallelism. So for that reason it
> wouldn't be so bad to just have `dumpheap` and `inspectheap` always use some
> defa
On Wed, 10 Feb 2021 00:34:02 GMT, Lin Zang wrote:
> > * Default to not parallel. Allow the user to specify `-parallel`, but not
> > specify the thread count. They will get the default number of threads just
> > like `parallel=0`
> > * Default to parallel using the default number of threads. All
On Wed, 3 Feb 2021 12:44:53 GMT, Hamlin Li wrote:
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
> Hi @Hamlin-Li,
>
> It looks good in general.
> A question: What is going to happen if the num
On Mon, 8 Feb 2021 02:35:17 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve jcmd GC.class_histogram to support parallel
>
> Marked as reviewed by cjplummer (R
On Sun, 7 Feb 2021 03:29:36 GMT, Chris Plummer wrote:
> diagnosticCommand.hpp still needs a copyright update.
>
Thanks for pointing out.
> For heapRegionSet.cpp, sorry but you'll need to file a new CR to update its
> copyright. Among other things, fixing it here makes backports harder to get
>
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
improve jcmd GC.class_histogram to suppo
On Sat, 6 Feb 2021 04:54:01 GMT, Chris Plummer wrote:
> Copyrights need updating in two of the files.
Updated.
BTW, I also updated the copyright for src/hotspot/share/gc/g1/heapRegionSet.cpp
which I modified several weeks ago in
https://bugs.openjdk.java.net/browse/JDK-8260200, but did not up
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
improve jcmd GC.class_histogram to suppo
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
JDK-8261034: improve jcmd GC.class_histogram to suppo
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
JDK-8261034: improve jcmd GC.class_histogram to suppo
On Thu, 4 Feb 2021 23:08:21 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8261034: improve jcmd GC.class_histogram to support parallel
>
> test/hotspo
On Thu, 4 Feb 2021 08:14:47 GMT, Hamlin Li wrote:
>> From what I've seen it's normal for the 32-bit builds to fail. I'm not sure
>> why they are even being built.
>
>> From what I've seen it's normal for the 32-bit builds to fail. I'm not sure
On Thu, 4 Feb 2021 07:51:35 GMT, Chris Plummer wrote:
> From what I've seen it's normal for the 32-bit builds to fail. I'm not sure
> why they are even being built.
Thanks for the info, then I think it's safe for me to ignore the failures in
linux x86.
-
PR: https://git.openjdk.j
On Thu, 4 Feb 2021 03:40:26 GMT, Chris Plummer wrote:
>> Hi @Hamlin-Li
>> I am not reviewer, but maybe you could add test for "parallel" in
>> BasicJMapTest.java.
>
>> I am not reviewer, but maybe you could add test for "parallel" in
>>
On Wed, 3 Feb 2021 12:44:53 GMT, Hamlin Li wrote:
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
> Hi @Hamlin-Li
> I am not reviewer, but maybe you could add test for "parallel" in
> Ba
On Wed, 3 Feb 2021 21:28:40 GMT, Chris Plummer wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8261034: improve jcmd GC.class_histogram to support parallel
>
> src/hotspot/share/
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
JDK-8261034: improve jcmd GC.class_histogram to suppo
> parallel -histo of jmap was added by JDK-8214535, it's better to support
> parallel for jcmd GC.class_histogram too.
Hamlin Li has updated the pull request incrementally with one additional commit
since the last revision:
JDK-8261034: improve jcmd GC.class_histogram to suppo
On 16/03/2018 4:05 PM, Alan Bateman wrote:
On 16/03/2018 01:54, Hamlin Li wrote:
:
Hi Alan,
Thank you for detailed reviewing. I have updated the webrev in place.
(http://cr.openjdk.java.net/~mli/8199215/webrev.00/)
Looks good, just a minor typo "is better choice" -> "
On 15/03/2018 7:20 PM, Alan Bateman wrote:
On 15/03/2018 08:43, Hamlin Li wrote:
:
Hi Alan,
Thank you for reviewing, I have updated the webrev in place.
( cc'ing serviceability-dev and net-dev as these are the other areas
that use the getFreePort method in the test library. For co
33 matches
Mail list logo
