RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8174994 Webrev: http://cr.openjdk.java.net/~jgeorge/8174994/webrev.00/ While trying to identify the type given an address, a WrongTypeException was getting thrown with various clhsdb commands (like printmdo, jstack, etc).

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Ping: Gentle reminder ! Thanks, Jini. On 4/6/2018 9:51 PM, Jini George wrote: Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8174994 Webrev: http://cr.openjdk.java.net/~jgeorge/8174994/webrev.00/ While trying to identify the type given an address, a

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Thanks, Yasumasa On 2018/04/12 13:21, Jini George wrote: Ping: Gentle reminder ! Thanks, Jini. On 4/6/2018 9:51 PM, Jini George wrote: Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8174994 Webrev: http://cr.openjdk.java.net/~jgeorge/8174994/webrev.00/ While

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

ort %p %s %c" (or dumping to / export/users/dh198349/valhalla/repos/valhalla-dev/open/test/jdk/core.29848) apport isn't even installed, even though core_pattern lists it. Cheers, David On 18/04/2018 4:36 PM, Yasumasa Suenaga wrote: 2018-04-18 15:05 GMT+09:00 Jini George : Thank yo

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

file an RFE to consolidate these? thanks, Coleen On 4/12/18 12:21 AM, Jini George wrote: Ping: Gentle reminder ! Thanks, Jini. On 4/6/2018 9:51 PM, Jini George wrote: Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8174994 Webrev: http://cr.openjdk.java.net/~jg

Re: INCLUDE_SA/serviceability agent - support on s390x

Hi Matthias, Your change looks good to me. It might make sense to also remove the following lines from: src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h 78 #if defined(s390x) 79 #include 80 #endif I am not sure if the following files are required either: src/hotspot/cpu/s390/vmStru

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

s in src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c. The difference between the earlier patch and this one can be seen at: http://cr.openjdk.java.net/~jgeorge/8174994/differential.patch Thank you, Jini. On 4/18/2018 10:37 PM, Jini George wrote: I agree with the need of testing as muc

Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Message- From: Jini George [mailto:jini.geo...@oracle.com] Sent: Dienstag, 24. April 2018 08:58 To: Baesken, Matthias ; 'build- d...@openjdk.java.net' Cc: serviceability-dev@openjdk.java.net; Schmidt, Lutz Subject: Re: INCLUDE_SA/serviceability agent - support on s390x Hi Matthias, Y

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

et 't' as the cause of the new Error so we can see why it failed. Thanks, David On 24/04/2018 7:03 PM, Jini George wrote: Hello! The webrev including the check for the "|" at the beginning of the core_pattern file is at: http://cr.openjdk.java.net/~jgeorge/8174994/webrev.01/

Re: PING: RFR: 8199519: Several GC tests fails with: java.lang.NumberFormatException: Unparseable number: "-"

Hi Yasumasa, Your changes look good to me. Thanks, Jini. On 4/25/2018 6:18 PM, Yasumasa Suenaga wrote: PING: Could you review this change? I've sent review request about a month ago, but I do not yet get second reviewer.     > http://cr.openjdk.java.net/~ysuenaga/JDK-8199519/webrev.03/

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

:14 PM, Yasumasa Suenaga wrote: Hi Jini, 2018-04-18 15:05 GMT+09:00 Jini George :   : I plan to file an enhancement request to address this issue (wrt systemd-coredump) separately since this would apply to other coredump generating test cases also like: test/hotspot/jtreg/compiler

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Many thanks, David! - Jini. On 4/26/2018 10:27 AM, David Holmes wrote: Thanks Jini, I have no further comments as the tests "passed" for me. David On 25/04/2018 1:26 PM, Jini George wrote: Thank you very much, David for looking into this. I have incorporated all the comments and t

Re: RFR: JDK-8174994: SA: clhsdb printmdo throws WrongTypeException when attached to a process with CDS

Thank you, Yasumasa. - Jini. On 4/26/2018 11:41 AM, Yasumasa Suenaga wrote: Hi Jini, I have no further comment. Yasumasa 2018-04-26 13:21 GMT+09:00 Jini George : Thank you, Yasumasa. I hope to implement the consolidation with TestSAServer.java (and have the SA core file debug testing

RFR: (S): SA: clhsdb 'where -a' throws Assertion Failure with illegal code 236 when CDS is used

Hello all, Please review the following proposed fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8174995 Webrev: http://cr.openjdk.java.net/~jgeorge/8174995/webrev.00/ Issue: Clhsdb commands like 'where -a', 'printall' would throw an illegal code assertion failure when CDS is used.

Re: RFR: 8202417: [TESTBUG] Broken hard-coded dependency in serviceability/sa/ClhsdbJhisto.java

Hi Claes, This looks fine to me. Thanks, Jini. (Not a Reviewer) On 4/30/2018 3:00 PM, Claes Redestad wrote: Hi, ClhsdbJhisto has a hard-coded dependency on an ImmutableCollections$SetN$1 appearing in the jhisto output, which is fragile and sometimes break after JDK-8201650. I suggest removi

RFR: (S): JDK-8195613: [SA] HotSpotTypeDataBase.readVMLongConstants truncates values to int

Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8195613 ([SA] HotSpotTypeDataBase.readVMLongConstants truncates values to int) Webrev: http://cr.openjdk.java.net/~jgeorge/8195613/webrev.00/ Testing: The SA tests passed on Mach5. Thanks, Jini.

Re: RFR: (S): SA: clhsdb 'where -a' throws Assertion Failure with illegal code 236 when CDS is used

    _nofast_getfield     _nofast_putfield     _nofast_iload Thanks - Ioi On 4/26/18 11:15 AM, Jini George wrote: Hello all, Please review the following proposed fix for the issue: https://bugs.openjdk.java.net/browse/JDK-8174995 Webrev: http://cr.openjdk.java.net/~jgeorge/8174995/webrev.00/ Is

Re: RFR: (S): SA: clhsdb 'where -a' throws Assertion Failure with illegal code 236 when CDS is used

Thanks, Ioi. Could I get one more reviewer to take a look at this ? Thanks, Jini. On 5/8/2018 8:55 PM, Ioi Lam wrote: Looks good. Thanks! - Ioi On 5/7/18 8:38 PM, Jini George wrote: Thank you very much, Ioi, for the review and for the clarifications and help provided offline. I have added

Re: RFR: (S): JDK-8195613: [SA] HotSpotTypeDataBase.readVMLongConstants truncates values to int

, Jini George wrote: Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8195613 ([SA] HotSpotTypeDataBase.readVMLongConstants truncates values to int) Webrev: http://cr.openjdk.java.net/~jgeorge/8195613/webrev.00/ Actual fix seems fine. I have a few comments on the test

Re: RFR: (S): SA: clhsdb 'where -a' throws Assertion Failure with illegal code 236 when CDS is used

hotspot's bytecodes.cpp also needs to be changed ? Thanks, Jini. On 5/8/2018 11:43 PM, Chris Plummer wrote: Hi Jini, Why are _nofast_aload_0 and _nofast_iload using return type BasicType.getTIllegal() when the return type is known? The test changes look good. thanks, Chris On 5/8/1

Re: RFR: (S): JDK-8195613: [SA] HotSpotTypeDataBase.readVMLongConstants truncates values to int

wrote: Hi Jini, On 11/05/2018 5:34 AM, Jini George wrote: Hi David, Thank you very much for the review and for the clarifications offline! I have addressed your comments and have a new webrev at: http://cr.openjdk.java.net/~jgeorge/8195613/webrev.01/index.html Looks fine. A couple of

Re: RFR: (S): SA: clhsdb 'where -a' throws Assertion Failure with illegal code 236 when CDS is used

't matter. Hopefully someone with a better understanding of the use of this field will chime in. Chris On 5/11/18 12:29 AM, Jini George wrote: Thank you very much, Chris, for taking a look. The bytecodes table initialization in SA's Bytecodes.java mimics the bytecodes table initial

Re: RFR: (S): SA: clhsdb 'where -a' throws Assertion Failure with illegal code 236 when CDS is used

t too sure how that field ends up getting used. I'd say what's likely in this case is that it's wrong but doesn't matter. Hopefully someone with a better understanding of the use of this field will chime in. Chris On 5/11/18 12:29 AM, Jini George wrote: Thank you very much,

Re: RFR: (S): JDK-8195613: [SA] HotSpotTypeDataBase.readVMLongConstants truncates values to int

another webrev if you add it. Thanks, Serguei On 5/11/18 05:11, Jini George wrote: Thank you, David. Could I get another pair of eyes to take a look at: http://cr.openjdk.java.net/~jgeorge/8195613/webrev.02/index.html Thanks, Jini. On 5/11/2018 11:58 AM, David Holmes wrote: Forgot to add - no

Re: RFR: (S): JDK-8195613: [SA] HotSpotTypeDataBase.readVMLongConstants truncates values to int

s some comments indicating what it is trying to test for. thanks, Chris On 5/11/18 5:11 AM, Jini George wrote: Thank you, David. Could I get another pair of eyes to take a look at: http://cr.openjdk.java.net/~jgeorge/8195613/webrev.02/index.html Thanks, Jini. On 5/11/2018 11:58 AM, David

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Leonid, I have mostly looked at only the following file: http://cr.openjdk.java.net/~lmesnik/8203491/webrev.00/test/hotspot/jtreg/serviceability/sa/TestJmapCore.java.html * Would you be adding JMapMetaspaceCore testing to this? Other than this, I think the jhsdb heapdump testing from vmTest

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Leonid, My comments inline. On 5/24/2018 12:09 AM, Leonid Mesnik wrote: I am not sure that JMapMetaspaceCore provides any additional coverage. The test just fill 64M of metaspace and then send signal to dump core. So I don't see how this test could improve coverage. I think that idea of or

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

/~lmesnik/8203491/webrev.01-00/ <http://cr.openjdk.java.net/~lmesnik/8203491/webrev.01-00/> I don't know if existing 64m is enough to produce a lot of classes. However this size was used in original test so I use same in new test TestJmapCoreMetaspace.java. I fixed comments, import

Re: RFR (round 4), JEP-318: Epsilon GC

. Thank you very much, Aleksey, for making the SA changes. Some comments on those. ==> share/classes/sun/jvm/hotspot/oops/ObjectHeap.java 444liveRegions.add(eh.space()); We would need to add an object of type 'Address' to the liveRegions list, instead of type VirtualSpace. Not doing

Re: RFR (round 4), JEP-318: Epsilon GC

Sounds good to me. Thanks, Jini. On 6/4/2018 12:21 PM, Per Liden wrote: Hi, On 06/01/2018 10:13 AM, Jini George wrote: [...] ==>  share/classes/sun/jvm/hotspot/oops/ObjectHeap.java 445 } else { 446    if (Assert.ASSERTS_ENABLED) { 447   Assert.that(false, "E

Re: RFR (round 4), JEP-318: Epsilon GC

Thanks for making the changes, Aleksey. The changes look good. Thanks, Jini. On 6/5/2018 9:16 PM, Aleksey Shipilev wrote: Hi Jini, Thanks for taking a look, see comments inline. On 06/01/2018 10:13 AM, Jini George wrote: ==> share/classes/sun/jvm/hotspot/oops/ObjectHeap.java

Re: RFR(S): 8204110: serviceability/sa/ClhsdbSymbol.java and ClhsdbInspect.java failed when running in CDS mode

Your changes look good to me, Calvin. Thanks, Jini. On 6/7/2018 10:24 PM, Calvin Cheung wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8204110 webrev: http://cr.openjdk.java.net/~ccheung/8204110/webrev.00/ For fixing the ClhsdbSymbol.java test, I've added dumping the symbols from the sh

Re: RFR(S/M): 8205419: [testbug] TestJmapCore failing without SA: introduce @requires vm.hasSA

Hi Goetz, Tests like TestJmapCore which involve only corefile debugging by SA (and not attaching to a live process) would only need to check for the presence of SA, and would not need to check for ptrace related attach permissions like what is done for Linux and OSX -- since super user privil

RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

Hi all, [Including build-dev also since this includes build related changes]. Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8189429 (SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC) Webrev: http://cr.openjdk.java.net/~jgeorge/8189429/webrev.04/ This is the

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

[1]). In Lib-jdk.hotspot.agent.gmk: I believe adding extra src should be enough as that will implicitly add the same directories as header dirs by default. At least that's the intention. /Erik [1] http://openjdk.java.net/groups/build/doc/code-conventions.html On 2018-06-22 11:11, Jini G

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

Thank you, Sharath. May I have a Reviewer to take a look at the MacosxDebuggerLocal code? Thanks, Jini. On 6/25/2018 1:52 PM, Sharath Ballal wrote: Hi Jini, Changes in MacosxDebuggerLocal.m looks good. Thanks, Sharath -Original Message- From: Jini George Sent: Sunday, June 24

Re: RFR(S/M): 8205419: [testbug] TestJmapCore failing without SA: introduce @requires vm.hasSA

if runOnCore() is changed. http://cr.openjdk.java.net/~goetz/wr18/8205419-requiresHasSA/02/ This also makes the implementation of VMProps and VMPlatform more clear as requested by Chris. Best regards, Goetz. -----Original Message- From: Jini George Sent: Thursday, June 21, 2018 12:18 PM To: Lind

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

Thank you, Erik ! - Jini. On 6/25/2018 9:23 PM, Erik Joelsson wrote: Build changes look good. /Erik On 2018-06-24 10:37, Jini George wrote: Hi Erik, Thank you very much for looking into this. I have addressed your comments. The latest webrev is at: http://cr.openjdk.java.net/~jgeorge

Re: RFR(S/M): 8205419: [testbug] TestJmapCore failing without SA: introduce @requires vm.hasSA

latform more clear as requested by Chris. Best regards,   Goetz. -----Original Message- From: Jini George Sent: Thursday, June 21, 2018 12:18 PM To: Lindenmaier, Goetz ; 'Chris Plummer' ; serviceability-dev (serviceability- d...@openjdk.java.net) Subject: Re: RFR(S/M): 8205419

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

Ping - Gentle reminder ! Thanks, Jini. On 6/25/2018 3:41 PM, Jini George wrote: Thank you, Sharath. May I have a Reviewer to take a look at the MacosxDebuggerLocal code? Thanks, Jini. On 6/25/2018 1:52 PM, Sharath Ballal wrote: Hi Jini, Changes in MacosxDebuggerLocal.m looks good. Thanks

Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH with PT_ATTACHEXC

David On 26/06/2018 5:25 PM, Jini George wrote: Ping - Gentle reminder ! Thanks, Jini. On 6/25/2018 3:41 PM, Jini George wrote: Thank you, Sharath. May I have a Reviewer to take a look at the MacosxDebuggerLocal code? Thanks, Jini. On 6/25/2018 1:52 PM, Sharath Ballal wrote: Hi Ji

Re: [12] RFR (S) 8205534: Remove SymbolTable dependency from serviceability agent

Hi Coleen, Apologize for the delay. Your changes look good to me overall. A few comments: It might make sense to also remove the corresponding lines in the vmStructs files. Like: File Line vmStructs.cpp 170 typedef RehashableHashtable RehashableSymbolHashtable; vmStructs.cpp 47

RFR: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

Requesting reviews for enabling SA tests on OS X for Mach5. https://bugs.openjdk.java.net/browse/JDK-8199700 Webrev: http://cr.openjdk.java.net/~jgeorge/8199700/webrev.00/ The changes are mostly to include the addition of sudo privileges to the SA launchers for OSX if Platform.shouldSAAttach()

Re: RFR: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

Gentle reminder ! Thanks, Jini. On 7/10/2018 12:14 AM, Jini George wrote: Requesting reviews for enabling SA tests on OS X for Mach5. https://bugs.openjdk.java.net/browse/JDK-8199700 Webrev: http://cr.openjdk.java.net/~jgeorge/8199700/webrev.00/ The changes are mostly to include the

Re: RFR: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

sub-sequences. Thanks, Jini. Thanks, David PS. I start vacation in 48 hours :) On 11/07/2018 12:38 PM, Jini George wrote: Gentle reminder ! Thanks, Jini. On 7/10/2018 12:14 AM, Jini George wrote: Requesting reviews for enabling SA tests on OS X for Mach5. https://bugs.openjdk.java.

Re: PING: RFR: 8205992: jhsdb cannot attach to Java processes running in Docker containers

Hi Yasumasa, This looks good to me except for one nit. And some more comments would help. For e.g., it would help to say that NSPidMap is to map the host to container lwpids. The nit: * http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.00/src/jdk.hotspot.agent/linux/native/libsaproc/L

Re: PING: RFR: 8205992: jhsdb cannot attach to Java processes running in Docker containers

Looks good to me. Thanks! Jini (Not a Reviewer). On 7/12/2018 10:12 AM, Yasumasa Suenaga wrote: Thanks Jini, I uploaded new webrev. It contains some comments and removing extra space. http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.01/ Yasumasa 2018-07-12 2:32 GMT+09:00 Jini

Re: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

always return false. I'll run the patch throuqh our nightly tests to see whether they pass mac. Best regards, Goetz. -Original Message- From: serviceability-dev [mailto:serviceability-dev- boun...@openjdk.java.net] On Behalf Of Jini George Sent: Montag, 9. Juli 2018 20:

Re: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

I'll run the patch throuqh our nightly tests to see whether they pass mac. Thanks for this. Let me know in case there are timeouts due to there not being a no-password entry for the user in the /etc/sudoers list. Thanks, Jini.

Re: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

7 more JavaTest Message: Test threw exception: java.lang.RuntimeException: Test ERROR java.lang.RuntimeException: Expected to get exit value of [0] JavaTest Message: shutting down test STATUS:Failed.`main' threw exception: java.lang.RuntimeException: Test ERROR java.lang.RuntimeException:

Re: RFR: xs: JDK-8209342 - Problemlist SA tests on Solaris due to Error attaching to process: Can't create thread_db agent!

Hi Sharath, Your changes look good. One question: Was the following test excluded by mistake ? serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java Would you please also delete these 2 lines since these tests have been removed ? serviceability/sa/ClhsdbSymbol.java 8193639 solaris-all se

Re: RFR: xs: JDK-8209342 - Problemlist SA tests on Solaris due to Error attaching to process: Can't create thread_db agent!

Hi again, Sharath, I missed a point. The tests serviceability/sa/ClhsdbCDSCore.java and test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java would also have to be excluded for solaris. Thanks, Jini. On 8/15/2018 9:46 PM, Jini George wrote: Hi Sharath, Your changes look

Re: RFR: xs: JDK-8209342 - Problemlist SA tests on Solaris due to Error attaching to process: Can't create thread_db agent!

m list after fixing JDK-8207832. Please check if you need to add it again for solaris only. See http://hg.openjdk.java.net/jdk/jdk/diff/45d1f2ec5342/test/hotspot/jtreg/ProblemList.txt Thanks On 8/15/18 9:37 PM, Jini George wrote: Hi again, Sharath, I missed a point. The tests serviceabili

Re: RFR[S] 8209657 Refactor filemap.hpp to simplify integration with Serviceability Agent

Hi Ioi, It looks good to me except for: filemap.hpp: 313 assert(i >= 0 && i <= NUM_CDS_REGIONS, "invalid region"); Shouldn't the assert be: assert(i >= 0 && i < NUM_CDS_REGIONS, "invalid region"); Thanks! Jini. On 8/21/2018 1:53 AM, Ioi Lam wrote: Hi, I've updated the webrev to merge

RFR: (S): JDK-8204308 : SA: serviceability/sa/TestInstanceKlassSize*.java fails when running in CDS mode

Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8204308 Webrev: http://cr.openjdk.java.net/~jgeorge/8204308/webrev.00/index.html The proposed fix is to use longs instead of ints while computing the identity hash of klass symbols. It mimics the implementation of Symbol:

Re: RFR: (S): JDK-8204308 : SA: serviceability/sa/TestInstanceKlassSize*.java fails when running in CDS mode

. On 8/24/2018 8:20 PM, Lois Foltan wrote: Hi Jini, This looks good.  I have the same questions as Coleen about the tests on the ProblemList. Thanks, Lois On 8/24/2018 4:04 AM, Jini George wrote: Hello! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8204308 Webrev: http

Re: RFR: 8210647: libsaproc is being compiled without optimization.

Looks good to me. Thanks, Jini (Not a (R)eviewer) On 9/14/2018 7:03 PM, Severin Gehwolf wrote: Hi, Could I please get a review of this one-liner fix. It changes optimization of libsaproc from -O0 to -O3 (as per Magnus' suggestion). I've run servicability tests and haven't seen any new failures

RFR: JDK-8210836 : Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

Hi all, Please review the small change for fixing the build failure in src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c with -Werror=unused-result. https://bugs.openjdk.java.net/browse/JDK-8210836 Webrev: http://cr.openjdk.java.net/~jgeorge/8210836/webrev.00/ A quick review would be ap

Re: RFR: JDK-8210836 : Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

of file). Thanks, Jc On Tue, Sep 18, 2018 at 6:06 AM Thomas Stüfe <mailto:thomas.stu...@gmail.com>> wrote: Looks good. Thanks for fixing. ..Thomas On Tue, Sep 18, 2018 at 1:52 PM, Jini George mailto:jini.geo...@oracle.com>> wrote: > Hi all, > &

Re: RFR: JDK-8210836 : Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

Thanks for the review, Thomas! - Jini. On 9/18/2018 6:36 PM, Thomas Stüfe wrote: Looks good. Thanks for fixing. ..Thomas On Tue, Sep 18, 2018 at 1:52 PM, Jini George wrote: Hi all, Please review the small change for fixing the build failure in src/jdk.hotspot.agent/linux/native/libsaproc

Re: RFR: JDK-8210836 : Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

an error as you stated). Thanks for taking the time to look and explain it to me :), Looks good to me (not a reviewer though), Jc On Tue, Sep 18, 2018 at 10:26 AM Jini George <mailto:jini.geo...@oracle.com>> wrote: Hi JC, Thank you for looking into this. Since we are r

Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

Hi Fairoz, This looks good to me. One nit which got missed out in the original change also is that in saproc.cpp, the following comments 452 453 // Pstack_iter() proc_stack_f callback prior to Nevada-B159 476 // Pstack_iter() proc_stack_f callback in Nevada-B159 or later 477 /*ARGSUSED*/

Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

for JDK-8. Thanks! Jini. On 9/24/2018 7:21 PM, Fairoz Matte wrote: Hi Jini, -Original Message- From: Jini George Sent: Friday, September 21, 2018 4:07 PM To: Fairoz Matte ; serviceability- d...@openjdk.java.net Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12

Re: RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times out parsing a 4GB hprof file

Looks good to me. Thanks, Jini. On 9/24/2018 9:19 AM, Sharath Ballal wrote: Hi, Pls review this test fix to add "-Xmx512m" to SA tests which create either core file or heap dump, to avoid timeout due to large heap sizes. Bug id: https://bugs.openjdk.java.net/browse/JDK-8207745 Webrev: http

Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

and found no issues Thanks, Fairoz -Original Message----- From: Jini George Sent: Tuesday, September 25, 2018 3:48 PM To: Fairoz Matte ; serviceability- d...@openjdk.java.net Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core Hi Fairoz,

RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

Hello! [Including runtime-dev since the changes are in runtime code] Requesting reviews for: Webrev: http://cr.openjdk.java.net/~jgeorge/8200613/webrev.01/ BugID: https://bugs.openjdk.java.net/browse/JDK-8200613 Issue: jhsdb jstack would throw an UnmappedAddressException with a core file gene

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

Gentle reminder! Thanks, - Jini On 10/9/2018 11:31 AM, Jini George wrote: Hello! [Including runtime-dev since the changes are in runtime code] Requesting reviews for: Webrev: http://cr.openjdk.java.net/~jgeorge/8200613/webrev.01/ BugID: https://bugs.openjdk.java.net/browse/JDK-8200613

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

, trigger a core dump, and compare the size of the core file before/after this change? Thanks - Ioi Thanks - Ioi On 10/21/18 8:58 PM, Jini George wrote: Gentle reminder! Thanks, - Jini On 10/9/2018 11:31 AM, Jini George wrote: Hello! [Including runtime-dev since the changes are in

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

Gentle reminder. Thanks! Jini. On 10/29/2018 11:32 AM, Jini George wrote: Thank you very much, Ioi, for looking into this, and the clarification offline. My bad, I had missed the earlier mail from you. :-( My responses below. Yes, I had tested this on MacOS. The issue does not exist on

RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

Hello! Requesting reviews for a small change for disabling the testing of TestJmapCoreMetaspace.java and TestJmapCore.java with ZGC. The change also includes skipping of creating the heapdump file with jmap if the GC being used is ZGC. Webrev: http://cr.openjdk.java.net/~jgeorge/8213323/webr

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

(the user would have to know to set a flag, to disable the new coredump filter ahead of time). Thanks! Kevin On 29/10/2018 06:02, Jini George wrote: Thank you very much, Ioi, for looking into this, and the clarification offline. My bad, I had missed the earlier mail from you. :-( My responses

Re: RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

Thank you very much, Gary! - Jini. On 11/9/2018 3:17 PM, gary.ad...@oracle.com wrote: Looks OK to me. On 11/9/18 1:40 AM, Jini George wrote: Hello! Requesting reviews for a small change for disabling the testing of TestJmapCoreMetaspace.java and TestJmapCore.java with ZGC. The change also

Re: RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

warranted here but thought I would ask :) Thanks! Jc Thanks, Jc On Fri, Nov 9, 2018 at 1:47 AM gary.ad...@oracle.com <mailto:gary.ad...@oracle.com> <mailto:gary.ad...@oracle.com>> wrote: Looks OK to me. On 11/9/18 1:40 AM, Jini George wrote: >

Re: [8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

Looks good to me, Severin. While looking at this, I realized that the code improvement change of 8140482 in ps_core.c of increasing the BUF_SIZE by 1 and adding the '\0' would be needed for MacOS also -- I will file another bug for that for JDK 12. Thanks! Jini. On 11/9/2018 9:31 PM, Severi

Re: RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

The modified webrev with the RuntimeException and the nit removed is at: http://cr.openjdk.java.net/~jgeorge/8213323/webrev.01/ Thanks! Jini. On 11/12/2018 12:41 PM, Jini George wrote: Thank you very much, JC, for looking into this. http://mail.openjdk.java.net/pipermail/zgc-dev/2018-August

Re: RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

Thanks a bunch, JC ! Could have a Reviewer also take a look at this please ? - Jini. On 11/21/2018 11:05 PM, JC Beyler wrote: Hi Jini, Looks good to me, thanks for fixing the nits :) Thanks, Jc On Wed, Nov 21, 2018 at 9:29 AM Jini George <mailto:jini.geo...@oracle.com>> wrote:

Re: Suggested improvement to X86Frame.getInterpreterFrameBCI

Thank you very much for working on the fix for this issue, David. It would be great if you can send in a complete patch for the review (With a first cut look, there seems to be missing pieces). I have created a bug for this: https://bugs.openjdk.java.net/browse/JDK-8214226 Thank you, Jini On

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Roman, The SA tests which iterate over the heap (ClhsdbJhisto.java, TestHeapDumpFor*.java) fail if ZGC is passed as an option to these also (Am planning on fixing these). It might be better to avoid invoking those tests for Shenandoah now with an @requires tag. Thank you, Jini On 11/29/2

Re: RFR(XXS): 8214462: Add serviceability/sa/ClhsdbInspect.java to ProblemList.txt

Looks good. Thanks! Jini. On 11/29/2018 9:13 AM, leonid.mes...@oracle.com wrote: Hi Could you please review following trivial fix which just exclude test ClhsdbInspect.java from execution on Windows where it might hang because of https://bugs.openjdk.java.net/browse/JDK-8213457. bug: https

Re: RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

, Jini George wrote: Thanks a bunch, JC ! Could have a Reviewer also take a look at this please ? - Jini. On 11/21/2018 11:05 PM, JC Beyler wrote: Hi Jini, Looks good to me, thanks for fixing the nits :) Thanks, Jc On Wed, Nov 21, 2018 at 9:29 AM Jini George <mailto:jini.geo...@oracle.

Re: RFR: 8214499: SA should follow 8150689

The change looks good to me, Yasumasa. (One minor nit: line 110: 2 spaces instead of 4 to align with the rest of the file). Would the second part of this comment, 126 // Print out all monitors that we have locked, or are trying to lock, 127 // including re-locking after being notifi

Re: RFR: 8214499: SA should follow 8150689

Yes, Yasumasa. You can push the fix. Thanks! - Jini. On 11/30/2018 12:36 PM, Yasumasa Suenaga wrote: Hi Jini, On 2018/11/30 15:15, Jini George wrote: The change looks good to me, Yasumasa. (One minor nit: line 110: 2 spaces instead of 4 to align with the rest of the file). Thanks! I will

Re: Suggested improvement to X86Frame.getInterpreterFrameBCI

at 09:02, Jini George <mailto:jini.geo...@oracle.com>> wrote: Thank you very much for working on the fix for this issue, David. It would be great if you can send in a complete patch for the review (With a first cut look, there seems to be missing pieces). I have created

Re: RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

Gentle reminder ! Thanks, Jini On 11/29/2018 12:03 PM, Jini George wrote: Thank you very much, Chris. I have modified HeapHprofBinWriter.java slightly so that the hprof file does not dumped if this is ZGC. In the test, we check for the presence of the hprof file and throw an exception if the

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Roman, A few comments on the SA changes: ==> Could you please add the following lines in src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java from line 1120 onwards to avoid the "[Unknown generation]" message with hsdb while displaying the Stack Memory for a mutator thread ? els

Re: RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

Thank you, Chris! - Jini On 12/4/2018 9:29 AM, Chris Plummer wrote: Looks good. Chris On 12/2/18 8:36 PM, Jini George wrote: Gentle reminder ! Thanks, Jini On 11/29/2018 12:03 PM, Jini George wrote: Thank you very much, Chris. I have modified HeapHprofBinWriter.java slightly so that the

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Roman, Thank you for making the changes. The SA portion looks good to me. One nit though: In src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java, in printGCAlgorithm(), does displaying the nbr of Parallel GC threads not make sense for Shenandoah (like it is for G1,

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

/browse/JDK-8215027) since this seems a bit involved. Thanks a bunch, Jini. On 11/12/2018 10:26 AM, Jini George wrote: Thank you very much, Chris, Kevin and Ioi for your comments! I will send another webrev with this change enabled under an opt-out flag, as you suggest, and would look at

Re: RFR(XS): 8215042: Move serviceability/sa tests from tier1 to tier3.

Hi Leonid, I agree with David. I am also concerned about us not detecting SA breakages (which could happen along with hotspot changes) soon enough. (Which was the primary reason to get these tests in). Thank you, Jini. On 12/8/2018 4:48 PM, David Holmes wrote: Hi Leonid, My concern here, i

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

Thank you very much, Ioi! - Jini. On 12/10/2018 12:01 PM, Ioi Lam wrote: Hi Jini, These changes look good to me. Thanks! - Ioi On 12/7/18 11:22 AM, Jini George wrote: I have the revised webrev here: http://cr.openjdk.java.net/~jgeorge/8200613/webrev.02/index.html The extra changes here

Re: RFR(XS): 8215042: Move serviceability/sa tests from tier1 to tier3.

[1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html On Dec 9, 2018, at 7:19 PM, Jini George <mailto:jini.geo...@oracle.com>> wrote: Hi Leonid, I agree with David. I am also concerned about us not detecting SA breakages (which could happen along with hotspot c

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

Thank you very much, Kevin! - Jini. On 12/10/2018 3:09 PM, Kevin Walls wrote: Thanks for adding the flag Jini, all looks good to me too, Thanks Kevin On 10/12/2018 06:44, Jini George wrote: Thank you very much, Ioi! - Jini. On 12/10/2018 12:01 PM, Ioi Lam wrote: Hi Jini, These changes

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

he mappings to understand and use the SA tools on it, we want to have them. Thanks, Coleen On 12/7/18 2:22 PM, Jini George wrote: I have the revised webrev here: http://cr.openjdk.java.net/~jgeorge/8200613/webrev.02/index.html The extra changes here are to: * Introduce a new option DumpPrivate

RFR: JDK-8202884: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

Hello ! Requesting reviews for: https://bugs.openjdk.java.net/browse/JDK-8202884 Webrev: http://cr.openjdk.java.net/~jgeorge/8202884/webrev.00/index.html Details: For attaching to the threads in a process, we first go ahead and do a ptrace attach to the main thread. Later, we use the libthread

Re: RFR: (S): JDK-8200613: SA: jstack throws UnmappedAddressException with a CDS core file

Thank you, Coleen! -Jini. On 12/12/2018 12:58 AM, coleen.phillim...@oracle.com wrote: On 12/11/18 2:37 AM, Jini George wrote: Thank you very much, Coleen. I have converted the flag into a diagnostic flag. The revised webrev is at: http://cr.openjdk.java.net/~jgeorge/8200613/webrev.03

Re: RFR: JDK-8202884: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

r pid %d\n", pid); +  } +  fclose (fp); +  return !found_state; I have modified this to: 257 if (!found_state) { 258 // Assuming the thread exists. 259 print_error("Could not find the 'State:' string in the /proc/%d/status file\n", pid); 260 } 261 fclose (f

Re: RFR: JDK-8202884: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

tion, the webrev looks good to me :-) Jc Thank you again! Jini On Wed, Dec 12, 2018 at 4:15 AM Jini George <mailto:jini.geo...@oracle.com>> wrote: Thank you very much for looking into this, JC! I have a revised webrev addressing your comments at: http://cr.openj

Re: RFR: JDK-8202884: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

) will be stored in /proc//task/. So you should check /proc//task/status for threads. Thanks, Yasumasa On 2018/12/12 21:15, Jini George wrote: Thank you very much for looking into this, JC! I have a revised webrev addressing your comments at: http://cr.openjdk.java.net/~jgeorge/8202884/webre

Re: RFR: JDK-8202884: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

Thanks! Jc On Wed, Dec 12, 2018 at 10:27 AM Jini George <mailto:jini.geo...@oracle.com>> wrote: On 12/12/2018 10:47 PM, JC Beyler wrote: > Hi Jini, > > Should your return not be return !found_state instead of false here: > > 257   if (!fo

Re: RFR: JDK-8202884: SA: Attach/detach might fail on Linux if debugee application create/destroy threads during attaching

Going forward, we should remove the libpthread_db dependency for the threads discovery and only depend on /proc//task/s for this (https://bugs.openjdk.java.net/browse/JDK-8181313). It's great news! I will help you :-) Sure -- and thank you for the review! -Jini.

  1   2   3   >