Re: RFR(XS) 8241696: ProblemList gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java due to JDK-8241293

Hi Chris, Looks good, thanks for fixing this. Thanks, Christian > On Mar 26, 2020, at 1:27 PM, Chris Plummer wrote: > > Hello, > > Please review the following: > > https://bugs.openjdk.java.net/browse/JDK-8241696 > > diff --git a/test/hotspot/jtreg/ProblemList.txt >

Re: RFR(T): 8241532: ProblemList tests from 8241530 on OSX

Looks good, thanks for doing this. Thanks, Christian > On Mar 24, 2020, at 10:01 AM, Daniel D. Daugherty > wrote: > > Greetings, > > I have a trivial review for ProblemListing some tests. > > We're having some network issues with the new OSX 10.15 machines that > are being addressed. In the

Re: RFR 8149790: NegativeArraySizeException with hprof

Hi George, This looks good. Thanks, Christian > On Aug 14, 2017, at 11:31 AM, George Triantafillou > wrote: > > Please review this change to fix NegativeArraySizeException test failures > with hprof: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8149790

RE: RFR: JDK-8165114: stale reference to hotspot test Test8028623.java

, September 2, 2016 4:46 AM To: Sharath Ballal <sharath.bal...@oracle.com>; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8165114: stale reference to hotspot test Test8028623.java On 2/09/2016 5:47 PM, Sharath Ballal wrote: > Hi David, > I had a similar doubt and checked wi

RE: JDK-8164943: sun/tools/jhsdb/HeapDumpTest failed with Can't find library: /test/lib/share/classes

Hi Sharath, This looks good, thanks for fixing this. Thanks, Christian From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Sharath Ballal Sent: Thursday, September 1, 2016 12:37 AM To: serviceability-dev@openjdk.java.net Subject: RFR:

RE: PING! Re: RFR(XS): JDK-8160923: sun/tools/jps/TestJpsJar.java fails due to ClassNotFoundException: jdk.testlibrary.ProcessTools

Hi Dmitry, You don't need to explicitly build JpsHelper, I also noticed that you're using ProcessTools and OutputAnalyzer from /lib/testlibrary , would it make sense to change this to use the /test/lib ones and simply have: @library /test/lib ? Thanks, Christian -Original Message-

RE: RFR:8153978:New test to verify the modules info as returned by the JVMTI

v...@oracle.com <mailto:christian.tornqv...@oracle.com> , alexander.kulyakh...@oracle.com <mailto:alexander.kulyakh...@oracle.com> Cc: serviceability-dev@openjdk.java.net <mailto:serviceability-dev@openjdk.java.net> Sent: Thursday, July 21, 2016 6:39:21 PM GMT +03:00 Iraq Subject: Re: RFR:8153978:New

RE: RFR:8153978:New test to verify the modules info as returned by the JVMTI

xander.kulyakh...@oracle.com <mailto:alexander.kulyakh...@oracle.com> Cc: serviceability-dev@openjdk.java.net <mailto:serviceability-dev@openjdk.java.net> Sent: Thursday, July 21, 2016 6:39:21 PM GMT +03:00 Iraq Subject: Re: RFR:8153978:New test to verify the modules info as returned by the

RE: RFR:8153978:New test to verify the modules info as returned by the JVMTI

Hi Alexander, >The JVMTI always reports 3 unnamed modules: the boot module, the system module >and the application module. >The Java API does not report any unnamed modules. I’ll leave this up to you if this is something that we need to verify or not, the code for doing this is also

RE: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

failed. It’d be a lot nicer if it’d just throw an exception when one of the checks in the native code failed. Thanks, Christian From: serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com] Sent: Tuesday, June 21, 2016 10:59 AM To: Christian Tornqvist <christian.tornqv...@o

RE: RFR:8153978:New test to verify the modules info as returned by the JVMTI

Hi Serguei, Yes, this is path is set in the make files/scripts that run jtreg. Thanks, Christian From: serguei.spit...@oracle.com [mailto:serguei.spit...@oracle.com] Sent: Tuesday, June 21, 2016 5:39 AM To: Christian Tornqvist <christian.tornqv...@oracle.com>; 'Alexander Kuly

RE: RFR:8153978:New test to verify the modules info as returned by the JVMTI

Hi Serguei, We’re currently using jtreg 4.2 b02, so you should be able to do this. Thanks, Christian From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of serguei.spit...@oracle.com Sent: Friday, June 17, 2016 7:39 PM To: Alexander Kulyakhtin

Re: RFR(XXS): 8156777: [TESTBUG] test/testlibrary_tests/SimpleClassFileLoadHookTest.java requires non minimal VM

Hi Leonid, Change looks good. Thanks, Christian > On May 11, 2016, at 12:36 PM, Leonid Mesnik wrote: > > Hi > > Could you please review this extra small fix which add @requires to the > single test. This test is not compatible with minimal VM even it doesn't >

RE: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

Hi Harold, This looks good, thanks for fixing this! Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of harold seigel Sent: Friday, April 29, 2016 2:01 PM To: serviceability-dev@openjdk.java.net Subject:

RE: RFR: JDK-8151196 Several tests fail due to test library not found

Hi Staffan, Looks good, thanks for fixing this. Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Staffan Larsen Sent: Wednesday, March 9, 2016 5:03 AM To: Bengt Rutisson Cc:

RE: RFR: JDK-8075586: add @modules as needed to the open hotspot tests

Hi Alex, I assume you've run all the tests and that they are still passing? The @module changes looks good. As Lois pointed out, you need to update the copyrights and this should be done as part of this change. Thanks, Christian -Original Message- From: serviceability-dev

RE: RFR(XXS): 8074905: Exclude aarch64 from Visual Studio projectcreator.make

Hi Markus, This looks good, thanks for fixing this. Thanks, Christian From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Markus Gronlund Sent: Tuesday, March 10, 2015 5:02 PM To: hotspot-runtime-...@openjdk.java.net;

RE: RFR(XXS): 8068584: Compiler attach tests should be quarantined

Looks good. Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Mattias Tobiasson Sent: Thursday, January 8, 2015 7:45 AM To: Mikael Auno; serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8068584:

RE: 8055677 java/lang/instrument/RedefineBigClass.sh RetransformBigClass.sh start failing after JDK-8055012

Hi Staffan, This looks good, thanks for fixing this. Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Staffan Larsen Sent: Thursday, August 21, 2014 6:16 AM To: serviceability-dev@openjdk.java.net Subject:

RFR(XS): 8055012 - [TESTBUG] NMTHelper fails to parse NMT output

Hi, This is a small update to NMTHelper.java to make it work with recent changes in the NMT implementation that changed the output format a bit. I've tested the change locally using java\lang\instrument\RedefineBigClass.sh and java\lang\instrument\RetransformBigClass.sh Webrev doesn't

RE: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently

; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; Christian Tornqvist Subject: Re: RFR JDK-8031554: com/sun/tools/attach/BasicTests.java fails intermittently It does look suspicious to catch and ignore the InterruptedException, especially since the OutputAnalyzer

hg: hsx/hotspot-rt/hotspot: 8023796: [TESTBUG] Add -XX:-TransmitErrorReport to runtime/6888954/vmerrors.sh

Changeset: cc4f5f8d885e Author:mseledtsov Date: 2013-10-06 16:13 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cc4f5f8d885e 8023796: [TESTBUG] Add -XX:-TransmitErrorReport to runtime/6888954/vmerrors.sh Summary: added -XX:-TransmitErrorReport to the test

hg: hsx/hotspot-rt/hotspot: 8025671: Test name changed, test list not updated. Test6878713.sh

Changeset: d574419c5372 Author:mseledtsov Date: 2013-10-02 15:17 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d574419c5372 8025671: Test name changed, test list not updated. Test6878713.sh Summary: Removed the obsolete test from the test group file Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 5b1191bf0b4b Author:ctornqvi Date: 2013-09-25 17:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5b1191bf0b4b 8024677: [TESTBUG] Move tests for classes in /testlibrary Summary: Moved the tests to /testlibrary_tests and updated TEST.groups Reviewed-by:

RE: 7196151: ParserTest SEGv on solaris

Looks good! Thanks, Christian From: hotspot-runtime-dev-boun...@openjdk.java.net [mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Peter Allwin Sent: Tuesday, September 17, 2013 11:44 AM To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 88d6b9a1c27c Author:mseledtsov Date: 2013-09-17 20:09 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/88d6b9a1c27c 8016029: test runtime/6878713/Test6878713.sh failed Summary: Rewrote test in Java; updated the test condition to reflect latest changes in

RE: RFR: 8020962: dump loaded java classes when vm crash

this would be best suited. Thanks, Christian -Original Message- From: Coleen Phillimore [mailto:coleen.phillim...@oracle.com] Sent: Monday, August 12, 2013 5:44 PM To: Yumin Qi Cc: Christian Tornqvist; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net; 'hotspot

hg: hsx/hotspot-rt/hotspot: 3 new changesets

Changeset: fa57c8104b76 Author:ctornqvi Date: 2013-08-02 18:12 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fa57c8104b76 8009585: test/runtime/7196045 times out Summary: test/runtime/7196045 times out Reviewed-by: dholmes, mseledtsov -

hg: hsx/hotspot-rt/hotspot: 3 new changesets

Changeset: 9bd314787fad Author:mseledtsov Date: 2013-08-01 22:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9bd314787fad 8020614: OutputAnalyzer.shouldHaveExitValue() should print stdout/stderr output Summary: OutputAnalyzer.shouldHaveExitValue() should print

RFR(S) 8014294: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of handle

Small fix for an assertion due to a use of a naked oop, reproduces with the original regression test. The fix has been tested by running vm.quick locally on my Windows machine and using the original regression test. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8014294/webrev.00/

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 2e8f19c2feef Author:allwin Date: 2013-07-12 18:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2e8f19c2feef 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand Summary: Intermittent

RE: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

Looks good, thanks for taking the time to write a test for this! Thanks, Christian -Original Message- From: hotspot-runtime-dev-boun...@openjdk.java.net [mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Peter Allwin Sent: den 11 juli 2013 10:14 To:

RE: RFR 7162400: Intermittent java.io.IOException: Bad file number during HotSpotVirtualMachine.executeCommand

Hi Peter, Looks good, thanks for fixing this. Thanks, Christian From: hotspot-runtime-dev-boun...@openjdk.java.net [mailto:hotspot-runtime-dev-boun...@openjdk.java.net] On Behalf Of Peter Allwin Sent: den 8 juli 2013 09:55 To: serviceability-dev@openjdk.java.net;

hg: hsx/hotspot-rt/hotspot: 3 new changesets

Changeset: 2bffd20a0fcc Author:ctornqvi Date: 2013-06-13 21:57 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2bffd20a0fcc 8016065: Write regression test for 7167142 Summary: Regression tests written for both test cases (.hotspotrc and .hotspot_compiler). Also

hg: hsx/hotspot-rt/hotspot: 6726963: multi_allocate() call does not CHECK_NULL and causes crash in fastdebug bits

Changeset: efe8b7d64424 Author:ctornqvi Date: 2013-05-31 20:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/efe8b7d64424 6726963: multi_allocate() call does not CHECK_NULL and causes crash in fastdebug bits Summary: Using CHECK_NULL when calling

hg: hsx/hotspot-rt/hotspot: 8015329: Print reason for failed MiniDumpWriteDump() call

Changeset: a213d425d87a Author:ctornqvi Date: 2013-05-28 15:08 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a213d425d87a 8015329: Print reason for failed MiniDumpWriteDump() call Summary: Printing both result from GetLastError and text representation of error.

hg: hsx/hotspot-rt/hotspot: 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header

Changeset: 243469d929e6 Author:ctornqvi Date: 2013-05-16 15:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/243469d929e6 8008169: test/runtime/7158804/Test7158804.sh has bad copyright header Summary: Re-wrote test in Java in addition to fixing the Copyright

hg: hsx/hotspot-rt/hotspot: 8014511: runtime/RedefineObject/TestRedefineObject.java has incorrect classname in @run tag

Changeset: 17db82f22f1e Author:ctornqvi Date: 2013-05-16 17:54 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/17db82f22f1e 8014511: runtime/RedefineObject/TestRedefineObject.java has incorrect classname in @run tag Summary: Corrected the class name Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 8009577: Test test/closed/runtime/classunload broken

Changeset: 33bcd9ead1d5 Author:ctornqvi Date: 2013-05-07 21:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/33bcd9ead1d5 8009577: Test test/closed/runtime/classunload broken Summary: Fixed tests to use new way of utilizing the WB API, fixed issue with where

hg: hsx/hotspot-rt/hotspot: 8009125: Add NMT tests for Virtual Memory operations

Changeset: 3b890cd4da64 Author:ctornqvi Date: 2013-04-03 21:41 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3b890cd4da64 8009125: Add NMT tests for Virtual Memory operations Summary: Tests added for Reserve/Commit/Uncommit/Unreserve operations Reviewed-by: zgu,

RE: Review Request: 8002118: WindbgDebuggerLocal should not try to load 64-bit debug libraries for 32-bit JVM

I'm quite certain there will never be a \Program Files (x64)\. On 64bit systems there's \Program Files\ and \Program Files (x86)\, on a 32bit systems there will only be a \Program Files\. So it would make sense to add \Program Files (x86)\ if we're running a 32bit JVM since we might be on a

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: c342fbdf8a70 Author:ctornqvi Date: 2013-03-24 09:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c342fbdf8a70 8008454: test/runtime/NMT/PrintNMTStatistics is broken Summary: Added @run tag so that it actually runs the test, also fixed broken command

hg: hsx/hotspot-rt/hotspot: 8010084: Race in runtime/NMT/BaselineWithParameter.java

Changeset: a649f6511c04 Author:ctornqvi Date: 2013-03-20 08:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a649f6511c04 8010084: Race in runtime/NMT/BaselineWithParameter.java Summary: Added a waitFor() on the process Reviewed-by: mgerdin, sla, zgu !

hg: hsx/hotspot-rt/hotspot: 8007982: some runtime/CommandLine/ tests fail on 32-bit platforms

Changeset: 1feda2e9f044 Author:ctornqvi Date: 2013-03-20 20:40 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1feda2e9f044 8007982: some runtime/CommandLine/ tests fail on 32-bit platforms Summary: Changed tests to use platform independent flags Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 8007434: Write tests for 8006298

Changeset: 3a88007634b0 Author:ctornqvi Date: 2013-02-08 10:42 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3a88007634b0 8007434: Write tests for 8006298 Summary: Four tests written for 8006298 Reviewed-by: mgerdin, coleenp +

hg: hsx/hotspot-rt/hotspot: 3 new changesets

Changeset: 4102b59539ce Author:ctornqvi Date: 2013-02-01 23:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4102b59539ce 8005012: Add WB APIs to better support NMT testing Summary: Add WB API functions to enable better NMT testing Reviewed-by: dholmes, zgu !

hg: hsx/hotspot-rt/hotspot: 8006413: Add utility classes for writing better multiprocess tests in jtreg

Changeset: 9be6cde7919d Author:ctornqvi Date: 2013-01-25 10:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9be6cde7919d 8006413: Add utility classes for writing better multiprocess tests in jtreg Summary: Add a few utility classes to test/testlibrary to support

hg: jdk7/hotspot-rt/hotspot: 7018366: hotspot/runtime_erro Fix for 7014918 does not build using MVC 2003

Changeset: b83527d0482d Author:ctornqvi Date: 2011-02-10 12:55 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b83527d0482d 7018366: hotspot/runtime_erro Fix for 7014918 does not build using MVC 2003 Summary: Looking at API_VERSION_NUMBER define to see what

hg: jdk7/hotspot-rt/hotspot: 7014918: Improve core/minidump handling in Hotspot

Changeset: 63d374c54045 Author:ctornqvi Date: 2011-02-09 11:08 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/63d374c54045 7014918: Improve core/minidump handling in Hotspot Summary: Added Minidump support on Windows, enabled large page core dumps when