Re: RFR: 8287200: Test java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java timed out after JDK-8287103

2022-05-24 Thread Kevin Walls
On Tue, 24 May 2022 19:52:57 GMT, Leonid Mesnik wrote: > Need to use proper synchronization. > > The CyclicBarriers might move the thread to WAITING state but not BLOCKED. So > it should not confuse existing checks. Yes I think that's nice - the two competing Threads own their first lock and

Re: RFR: 8287103: java/lang/management/ThreadMXBean/VirtualThreadDeadlocks.java fails with Xcomp [v2]

2022-05-23 Thread Kevin Walls
On Sat, 21 May 2022 16:34:32 GMT, Leonid Mesnik wrote: >> Sync improved in test > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fix Looks good! - Marked as reviewed by kevinw (Committer). PR:

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-19 Thread Kevin Walls
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. OK. I started with serviceability but then went through everything as it's hard to

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-19 Thread Kevin Walls
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java line 84: > 82: > 83: /** >

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-19 Thread Kevin Walls
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/hotspot/share/cds/filemap.cpp line 1914: > 1912: > 1913: // the current value

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-19 Thread Kevin Walls
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/hotspot/share/interpreter/bytecodeUtils.cpp line 186: > 184: static const int

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-19 Thread Kevin Walls
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/hotspot/share/opto/graphKit.cpp line 3626: > 3624: // The optional arguments are

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-19 Thread Kevin Walls
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/jdk.jdi/share/classes/com/sun/jdi/ClassType.java line 348: > 346: > 347: /** >

Re: RFR: 8284191: Replace usages of 'a the' in hotspot and java.base

2022-05-19 Thread Kevin Walls
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > Also, I fixed a couple of spelling mistakes. src/jdk.sctp/share/classes/com/sun/nio/sctp/ShutdownNotification.java line 28: > 26: >

Re: RFR: 8281268: Resolve duplication of test ClassTransformer class

2022-05-16 Thread Kevin Walls
On Fri, 13 May 2022 22:50:11 GMT, Alex Menkov wrote: > The fix deletes ClassTransformer class from jdi, switches all the test to > jdk.test.lib copy. Looks good. Those are the only imports I can see for this, and the ClassTransformer.java text is the same in both places. -

Integrated: 8284331: Add sanity check for signal handler modification warning.

2022-04-29 Thread Kevin Walls
On Tue, 5 Apr 2022 10:37:26 GMT, Kevin Walls wrote: > A sanity check using "jcmd VM.info" to catch the signal handler modification > warning: it should never trigger during this test. This pull request has now been integrated. Changeset: 116763cb Author:Kevin Walls U

Re: RFR: 8284331: Add sanity check for signal handler modification warning.

2022-04-29 Thread Kevin Walls
On Tue, 5 Apr 2022 10:37:26 GMT, Kevin Walls wrote: > A sanity check using "jcmd VM.info" to catch the signal handler modification > warning: it should never trigger during this test. thanks David and Alex and Chris 8-) - PR: https://git.openjdk.java.net/jdk/pull/8106

Re: RFR: 8284331: Add sanity check for signal handler modification warning.

2022-04-29 Thread Kevin Walls
On Fri, 29 Apr 2022 03:15:09 GMT, Chris Plummer wrote: > How does this relate the failure in JDK-8285647? Is this just meant to detect > that failure, but a proper fix is still needed for it? ..it's not directly related - I had this test addition in progress already, as an addition to

Re: RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

2022-04-27 Thread Kevin Walls
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote: >> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which >> JDK version to target. >> >> We will refresh this PR periodically to pick up changes and fixes from the >> loom repo. >> >> Most of the new mechanisms in

Re: RFR: 8285366: Fix typos in serviceability

2022-04-21 Thread Kevin Walls
On Thu, 21 Apr 2022 17:22:04 GMT, Magnus Ihse Bursie wrote: >> src/jdk.jdwp.agent/share/native/libjdwp/invoker.h line 38: >> >>> 36: jboolean pending; /* Is an invoke requested? */ >>> 37: jboolean started; /* Is an invoke happening? */ >>> 38: jboolean available;/* Is

Re: RFR: 8285366: Fix typos in serviceability

2022-04-21 Thread Kevin Walls
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on modules owned by the serviceability team > (`java.instrument java.management.rmi java.management jdk.attach > jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi > jdk.jdwp.agent jdk.jstatd

Re: RFR: 8284853: Fix various 'expected' typo [v2]

2022-04-20 Thread Kevin Walls
On Thu, 14 Apr 2022 18:04:16 GMT, Andrey Turbanov wrote: > I found [yet another > typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948) > ... I didn't think "JVMInvokeMethodSlack" was a typo. I think it's the idea of "slack space" meaning leftover space.

Re: RFR: 8284330: jcmd may not be able to find processes in the container [v2]

2022-04-06 Thread Kevin Walls
On Wed, 6 Apr 2022 12:44:35 GMT, Yasumasa Suenaga wrote: >> jcmd uses >> src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java >> to scan temporary directories to find out processes in the container. It >> checks inode to ensure the temp directory is not conflicted.

Re: RFR: 8284330: jcmd may not be able to find processes in the container

2022-04-06 Thread Kevin Walls
On Tue, 5 Apr 2022 09:04:56 GMT, Yasumasa Suenaga wrote: > jcmd uses > src/jdk.internal.jvmstat/linux/classes/sun/jvmstat/PlatformSupportImpl.java > to scan temporary directories to find out processes in the container. It > checks inode to ensure the temp directory is not conflicted. However

Re: RFR: 8284331: Add sanity check for signal handler modification warning.

2022-04-06 Thread Kevin Walls
On Tue, 5 Apr 2022 10:37:26 GMT, Kevin Walls wrote: > A sanity check using "jcmd VM.info" to catch the signal handler modification > warning: it should never trigger during this test. (adding a note to trigger email notification, as that appears lost...)

Re: RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode [v4]

2022-03-30 Thread Kevin Walls
On Wed, 30 Mar 2022 11:02:18 GMT, xpbob wrote: >> ``` >>long hostTicks = getHostTotalCpuTicks0(); >> int totalCPUs = getHostOnlineCpuCount0(); >> int containerCPUs = getAvailableProcessors(); >> // scale the total host load

Re: RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode [v3]

2022-03-30 Thread Kevin Walls
On Wed, 30 Mar 2022 06:20:19 GMT, xpbob wrote: >> ``` >>long hostTicks = getHostTotalCpuTicks0(); >> int totalCPUs = getHostOnlineCpuCount0(); >> int containerCPUs = getAvailableProcessors(); >> // scale the total host load

Re: RFR: 8283254: Remove redundant class jdk/internal/agent/spi/AgentProvider

2022-03-23 Thread Kevin Walls
On Tue, 22 Mar 2022 21:19:20 GMT, Kevin Walls wrote: > There are no uses of jdk/internal/agent/spi/AgentProvider, since the SNMP > agent was removed ( 8071367 ): this class should be removed. It is not a > public interface. > > Remove > src/jdk.management.agent/share/cl

Integrated: 8283254: Remove redundant class jdk/internal/agent/spi/AgentProvider

2022-03-23 Thread Kevin Walls
On Tue, 22 Mar 2022 21:19:20 GMT, Kevin Walls wrote: > There are no uses of jdk/internal/agent/spi/AgentProvider, since the SNMP > agent was removed ( 8071367 ): this class should be removed. It is not a > public interface. > > Remove > src/jdk.management.agent/share/cl

RFR: 8283254: Remove redundant class jdk/internal/agent/spi/AgentProvider

2022-03-22 Thread Kevin Walls
There are no uses of jdk/internal/agent/spi/AgentProvider, since the SNMP agent was removed ( 8071367 ): this class should be removed. It is not a public interface. Remove src/jdk.management.agent/share/classes/jdk/internal/agent/spi/AgentProvider.java Remove import from

Integrated: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-22 Thread Kevin Walls
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote: > Removing permission checks which, in the presence of a Security Manager, > would check for a RuntimePermission "className.subclass". This was to > prevent subclassing these classes, but is no longer necessary with stro

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation [v3]

2022-03-22 Thread Kevin Walls
On Mon, 21 Mar 2022 20:19:03 GMT, Kevin Walls wrote: >> Removing permission checks which, in the presence of a Security Manager, >> would check for a RuntimePermission "className.subclass". This was to >> prevent subclassing these classes, but is no

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation [v2]

2022-03-21 Thread Kevin Walls
On Mon, 21 Mar 2022 18:40:53 GMT, Mandy Chung wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Test update > > src/java.management/share/classes/sun/management/spi/PlatformMBeanProvid

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation [v3]

2022-03-21 Thread Kevin Walls
> Removing permission checks which, in the presence of a Security Manager, > would check for a RuntimePermission "className.subclass". This was to > prevent subclassing these classes, but is no longer necessary with strong > encapsulation from modules. Kevin Walls has up

Re: RFR: 8281853 serviceability/sa/ClhsdbThreadContext.java failed with NullPointerException: Cannot invoke "sun.jvm.hotspot.gc.shared.GenCollectedHeap.getGen(int)" because "this.heap" is null

2022-03-21 Thread Kevin Walls
On Sat, 19 Mar 2022 19:34:23 GMT, Chris Plummer wrote: > `isInNewGen()` is throwing an NPE because "heap" is null: > > > public boolean isInNewGen() { > return ((gen != null) && (gen == ((GenCollectedHeap)heap).getGen(0))); > } > > > The call came from here: > > > } else if

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation [v2]

2022-03-18 Thread Kevin Walls
> Removing permission checks which, in the presence of a Security Manager, > would check for a RuntimePermission "className.subclass". This was to > prevent subclassing these classes, but is no longer necessary with strong > encapsulation from modules. Kevin Walls has up

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-18 Thread Kevin Walls
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote: > Removing permission checks which, in the presence of a Security Manager, > would check for a RuntimePermission "className.subclass". This was to > prevent subclassing these classes, but is no longer necessary with stro

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-18 Thread Kevin Walls
On Thu, 17 Mar 2022 13:55:22 GMT, Sean Mullan wrote: > test/jdk/sun/management/PlatformMBeanProviderConstructorCheck.java Thank for noticing that Sean - had run various tests but missed this. I have an update, will add it here soon. - PR:

Re: RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-16 Thread Kevin Walls
On Wed, 16 Mar 2022 15:14:53 GMT, Daniel Fuchs wrote: >> Removing permission checks which, in the presence of a Security Manager, >> would check for a RuntimePermission "className.subclass". This was to >> prevent subclassing these classes, but is no longer necessary with strong >>

RFR: 8283092: JMX subclass permission check redundant with strong encapsulation

2022-03-15 Thread Kevin Walls
Removing permission checks which, in the presence of a Security Manager, would check for a RuntimePermission "className.subclass". This was to prevent subclassing these classes, but is no longer necessary with strong encapsulation from modules. - Commit messages: - 8283092: JMX

Re: RFR: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process [v4]

2022-03-14 Thread Kevin Walls
On Sat, 12 Mar 2022 05:44:21 GMT, Chris Plummer wrote: >> jdb has 3 types of arguments: >> >> 1. Those that are jdb specific, such as -attach, -launch, and -listconnectors >> 2. Those that are passed to the JVM used to run jdb. These are all prefixed >> with -J, and any valid JVM argument can

Re: RFR: 8282691: add jdb "-R" option for passing any argument to the launched debuggee process [v3]

2022-03-11 Thread Kevin Walls
On Tue, 8 Mar 2022 19:26:41 GMT, Chris Plummer wrote: >> jdb has 3 types of arguments: >> >> 1. Those that are jdb specific, such as -attach, -launch, and -listconnectors >> 2. Those that are passed to the JVM used to run jdb. These are all prefixed >> with -J, and any valid JVM argument can

Re: RFR: 8282691: add jdb support for passing --enable-preview and --add-modules to the debuggee JVM [v2]

2022-03-08 Thread Kevin Walls
On Tue, 8 Mar 2022 03:37:44 GMT, Chris Plummer wrote: >> jdb has 3 types of arguments: >> >> 1. Those that are jdb specific, such as -attach, -launch, and -listconnectors >> 2. Those that are passed to the JVM used to run jdb. These are all prefixed >> with -J, and any valid JVM argument can

Re: RFR: 8282641: Make jdb "threadgroup" command with no args reset the current threadgroup back to the default [v2]

2022-03-07 Thread Kevin Walls
On Fri, 4 Mar 2022 07:34:35 GMT, Chris Plummer wrote: >> jdb has a probably very little used command called "threadgroup" which is >> used to set the current TheadGroup. The only purpose of the current >> ThreadGroup is as the default ThreadGroup to use for the "threads" command >> when no

Re: RFR: 8282691: add jdb support for passing --enable-preview and --add-modules to the debuggee JVM

2022-03-07 Thread Kevin Walls
On Fri, 4 Mar 2022 22:12:08 GMT, Chris Plummer wrote: > jdb has 3 types of arguments: > > 1. Those that are jdb specific, such as -attach, -launch, and -listconnectors > 2. Those that are passed to the JVM used to run jdb. These are all prefixed > with -J, and any valid JVM argument can be

Re: RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError [v2]

2022-03-01 Thread Kevin Walls
On Tue, 1 Mar 2022 13:07:36 GMT, Alex Menkov wrote: >> test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java >> line 75: >> >>> 73: * @run main/othervm/native >>> 74: * -agentlib:hs201t002=pathToNewByteCode=./bin,-waittime=5,-verbose >>> 75: *

Re: RFR: 8267796: vmTestbase/nsk/jvmti/scenarios/hotswap/HS201/hs201t002/TestDescription.java fails with NoClassDefFoundError

2022-03-01 Thread Kevin Walls
On Thu, 24 Feb 2022 12:44:18 GMT, Alex Menkov wrote: > The fix adds workaround in hs201t001a class like we have in hs201t001 test to > avoid class loading while the test do single stepping/pop frame. > Also fixed a number of issues in the test. Looks like a good improvement.

Integrated: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

2022-02-25 Thread Kevin Walls
On Wed, 23 Feb 2022 13:59:19 GMT, Kevin Walls wrote: > Test fails occasionally due to a port clash. > Presumably the port that was returned by Utils.getFreePort(), is no longer > free. > The test creates a ProcessBuilder with the parameters for JMX, including port > n

Re: RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use [v2]

2022-02-24 Thread Kevin Walls
On Thu, 24 Feb 2022 12:17:54 GMT, Kevin Walls wrote: >> Test fails occasionally due to a port clash. >> Presumably the port that was returned by Utils.getFreePort(), is no longer >> free. >> The test creates a ProcessBuilder with the parameters for JMX, including

Re: RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use [v3]

2022-02-24 Thread Kevin Walls
hat was thrown in a > different process. > Make the testDefaultAgent method (the main part of the test) handle retrying > with a new port, a limited number of times. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use [v2]

2022-02-24 Thread Kevin Walls
hat was thrown in a > different process. > Make the testDefaultAgent method (the main part of the test) handle retrying > with a new port, a limited number of times. Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Clarify predicat

Re: RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

2022-02-24 Thread Kevin Walls
On Wed, 23 Feb 2022 17:42:35 GMT, Alex Menkov wrote: > The test uses warm-up predicate in a strange way Thanks Alex - yes so that's why we only see one line in the predicate, it contains the word "exception" and the predicate returns true, signalling that the process is done starting up. 8-)

Re: RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

2022-02-24 Thread Kevin Walls
On Wed, 23 Feb 2022 17:19:16 GMT, Mark Sheppard wrote: > An alternative is to use a fixed port 1098 Thanks Mark - I will avoid that fixed slot as we no doubt run tests concurrently, and also in case these get backported far enough that it's not free. 8-) Utils.getFreePort() lets new

Re: RFR: 8282200: ShouldNotReachHere() reached by AsyncGetCallTrace after JDK-8280422 [v4]

2022-02-24 Thread Kevin Walls
On Wed, 23 Feb 2022 21:59:35 GMT, Johannes Bechberger wrote: >> Fixes the mentioned bug by replacing the check in AsyncGetCallTrace using >> the newly introduced method `JavaThread::thread_from_jni_environment`. > > Johannes Bechberger has updated the pull request incrementally with one >

RFR: 8206187: javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java fails with Port already in use

2022-02-23 Thread Kevin Walls
Test fails occasionally due to a port clash. Presumably the port that was returned by Utils.getFreePort(), is no longer free. The test creates a ProcessBuilder with the parameters for JMX, including port number, and uses that to create a new Process. It should retry with a new port if we fail due

Re: RFR: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.

2022-02-07 Thread Kevin Walls
On Mon, 7 Feb 2022 15:40:11 GMT, Kevin Walls wrote: > Test failed many years ago. > Cannot provoke a failure today in hundreds of runs. > Initial failure may have been specific to Solaris. Right - vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/MixedDeadlock001/TestDescrip

Integrated: 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

2022-02-07 Thread Kevin Walls
On Mon, 7 Feb 2022 17:28:29 GMT, Kevin Walls wrote: > Trivial comment and exception text update, correcting a bug ID to make more > sense. This pull request has now been integrated. Changeset: 8a662105 Author: Kevin Walls URL: https://git.openjdk.java.net/jdk/

Re: RFR: 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

2022-02-07 Thread Kevin Walls
On Mon, 7 Feb 2022 17:28:29 GMT, Kevin Walls wrote: > Trivial comment and exception text update, correcting a bug ID to make more > sense. Thanks Chris, thanks Daniel! - PR: https://git.openjdk.java.net/jdk/pull/7371

Integrated: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.

2022-02-07 Thread Kevin Walls
On Mon, 7 Feb 2022 15:40:11 GMT, Kevin Walls wrote: > Test failed many years ago. > Cannot provoke a failure today in hundreds of runs. > Initial failure may have been specific to Solaris. This pull request has now been integrated. Changeset: 1dfc94dd Author: Kevin Walls URL:

Re: RFR: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.

2022-02-07 Thread Kevin Walls
On Mon, 7 Feb 2022 15:40:11 GMT, Kevin Walls wrote: > Test failed many years ago. > Cannot provoke a failure today in hundreds of runs. > Initial failure may have been specific to Solaris. Thanks Serguei! - PR: https://git.openjdk.java.net/jdk/pull/7369

RFR: 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java

2022-02-07 Thread Kevin Walls
Trivial comment and exception text update, correcting a bug ID to make more sense. - Commit messages: - 6779701: Wrong defect ID in the code of test LocalRMIServerSocketFactoryTest.java Changes: https://git.openjdk.java.net/jdk/pull/7371/files Webrev:

RFR: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.

2022-02-07 Thread Kevin Walls
Test failed many years ago. Cannot provoke a failure today in hundreds of runs. Initial failure may have been specific to Solaris. - Commit messages: - 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.

RFR: 8276680: Malformed Javadoc inline tags in JDK source in javax/management

2022-02-07 Thread Kevin Walls
Trivial doc typo. Now I realise this javadoc for a package-private constructor isn't even in the standard generated docs. But you could choose to use different javadoc options. - Commit messages: - 8276680: Malformed Javadoc inline tags in JDK source in javax/management

Integrated: 8281049: man page update for jstatd Security Manager dependency removal

2022-02-04 Thread Kevin Walls
On Wed, 2 Feb 2022 10:54:19 GMT, Kevin Walls wrote: > Policy settings are no longer required to run jstatd. > > This PR is the change to the source file src/jdk.jstatd/share/man/jstatd.1 > and in case that's hard to read, here is a diff of the text as rendered by > the man co

Re: RFR: 8281049: man page update for jstatd Security Manager dependency removal [v2]

2022-02-03 Thread Kevin Walls
On Thu, 3 Feb 2022 16:39:45 GMT, Chris Plummer wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update > > src/jdk.jstatd/share/man/jstatd.1 line 124: > >> 122: .PP >>

Re: RFR: 8281049: man page update for jstatd Security Manager dependency removal [v3]

2022-02-03 Thread Kevin Walls
et/~kevinw/8281049/jstatd.man.diff.txt > > And a copy of the new text rendered by man: > https://cr.openjdk.java.net/~kevinw/8281049/jstatd.man.new.txt Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Quotes/bold ---

Integrated: 8272777: Clean up remaining AccessController warnings in test library

2022-02-03 Thread Kevin Walls
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote: > Reduce noise in test output by adding the @SuppressWarnings("removal") > annotation (which has already been widely applied). This pull request has now been integrated. Changeset: 63a00a0d Author:Kevin Walls U

Re: RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-03 Thread Kevin Walls
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote: > Reduce noise in test output by adding the @SuppressWarnings("removal") > annotation (which has already been widely applied). Thanks Roger and Serguei! - PR: https://git.openjdk.java.net/jdk/pull/7328

Re: RFR: 8281049: man page update for jstatd Security Manager dependency removal [v2]

2022-02-03 Thread Kevin Walls
On Wed, 2 Feb 2022 22:41:02 GMT, Chris Plummer wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update > > src/jdk.jstatd/share/man/jstatd.1 line 124: > >> 122: .PP >>

Re: RFR: 8281049: man page update for jstatd Security Manager dependency removal [v2]

2022-02-03 Thread Kevin Walls
et/~kevinw/8281049/jstatd.man.diff.txt > > And a copy of the new text rendered by man: > https://cr.openjdk.java.net/~kevinw/8281049/jstatd.man.new.txt Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Update - Changes: - all: h

RFR: 8272777: Clean up remaining AccessController warnings in test library

2022-02-02 Thread Kevin Walls
Reduce noise in test output by adding the @SuppressWarnings("removal") annotation (which has already been widely applied). - Commit messages: - 8272777: Clean up remaining AccessController warnings in test library Changes: https://git.openjdk.java.net/jdk/pull/7328/files Webrev:

Re: RFR: 8279662: serviceability/sa/ClhsdbScanOops.java can fail do to unexpected GC

2022-02-02 Thread Kevin Walls
On Wed, 2 Feb 2022 16:21:05 GMT, Chris Plummer wrote: > Actually it's not, and that's why I check the Eden gen. Yes sorry, should have said it's a good bet to find a String when only checking one generation. Carry on... - PR: https://git.openjdk.java.net/jdk/pull/7295

RFR: 8281049: man page update for jstatd Security Manager dependency removal

2022-02-02 Thread Kevin Walls
Policy settings are no longer required to run jstatd. This PR is the change to the source file src/jdk.jstatd/share/man/jstatd.1 and in case that's hard to read, here is a diff of the text as rendered by the man command: https://cr.openjdk.java.net/~kevinw/8281049/jstatd.man.diff.txt And a

Re: RFR: 8279662: serviceability/sa/ClhsdbScanOops.java can fail do to unexpected GC

2022-02-02 Thread Kevin Walls
On Tue, 1 Feb 2022 05:29:36 GMT, Chris Plummer wrote: > The test is failing to find certain types in the scanoops output when run > with -Xcomp. This is happening in the loom repo. The reason it is happening > there is because loom introduced a full GC during codecache sweeping. The > test

Re: RFR: 8280601: ClhsdbThreadContext.java test is triggering codecache related assert in PointerFinder.find() [v2]

2022-01-28 Thread Kevin Walls
On Fri, 28 Jan 2022 04:07:40 GMT, Chris Plummer wrote: >> It's possible for an address to be in the codecache but not in any CodeBlob. >> Don't assert in this case. >> >> Also I ran into a couple of other asserts listed below. It looks like since >> dumping the threadcontext can result in

Integrated: 8272317: jstatd has dependency on Security Manager which needs to be removed

2022-01-28 Thread Kevin Walls
On Wed, 22 Dec 2021 18:14:43 GMT, Kevin Walls wrote: > Remove the use of Security Manager from jstatd. > Add use of an ObjectInputFilter to restrict RMI. > > Also we can undo the property-setting Launcher.gmk change from: 8279007: > jstatd fails to start because SecurityMana

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v4]

2022-01-28 Thread Kevin Walls
gt; Docs/man page update to follow (JDK-8278619). Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last re

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Kevin Walls
On Thu, 27 Jan 2022 17:44:39 GMT, Roger Riggs wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Wildcard in object filter to permit proxies, in case other activity in >> this JVM

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-27 Thread Kevin Walls
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v3]

2022-01-27 Thread Kevin Walls
gt; Docs/man page update to follow (JDK-8278619). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Copyright update - Changes: - all: https://git.openjdk.java.net/jdk/pull/6919/files - new: https://git.openjdk.java

Re: RFR: 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed [v2]

2022-01-26 Thread Kevin Walls
On Wed, 19 Jan 2022 18:22:13 GMT, Chris Plummer wrote: >> For any SA test that attaches to an OSX process (this would be all SA tests >> except for those that test core file support), there is a check to make sure >> that the target jvm process is not a signed binary. If it is, >>

Re: RFR: 8280601: ClhsdbThreadContext.java test is triggering codecache related assert in PointerFinder.find()

2022-01-26 Thread Kevin Walls
On Tue, 25 Jan 2022 22:07:37 GMT, Chris Plummer wrote: > It's possible for an address to be in the codecache but not in any CodeBlob. > Don't assert in this case. > > Note I couldn't reproduce this failure. Not sure why since it seemed to > reproduce pretty readily in our CI tier7, and I ran

Re: RFR: 8076089: Cleanup: Inline & remove sun.management.Util.newException

2022-01-26 Thread Kevin Walls
On Wed, 26 Jan 2022 04:35:58 GMT, Jaikiran Pai wrote: > Can I please get a review for this cleanup that's requested in > https://bugs.openjdk.java.net/browse/JDK-8076089? > > The change here removes a package private method > `sun.management.Util.newException(Exception e)` and inlines its >

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-20 Thread Kevin Walls
On Thu, 20 Jan 2022 16:54:21 GMT, Mandy Chung wrote: > If `sun.jvmstat.monitor.remote.RemoteVm` is the only proxy interface, > `com.sun.proxy.jdk.proxy*` should adequately cover the proxy classes created > for `RemoteVm`. Thanks. With that endorsement I think there are no unresolved issues

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-20 Thread Kevin Walls
On Wed, 19 Jan 2022 19:56:53 GMT, Mandy Chung wrote: > Are all the proxy interfaces public? sun.jvmstat.monitor.remote.RemoteVm is "public interface RemoteVm extends Remote" and methods in there only return basic types. This is in the jdk.jstatd module, where I see the module info contains

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-19 Thread Kevin Walls
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v3]

2022-01-19 Thread Kevin Walls
On Wed, 19 Jan 2022 09:10:56 GMT, Xin Liu wrote: >> In early stage of initialization, HotSpot doesn't handle SIGQUIT. The >> default signal preposition on Linux is to quit the process and generate >> coredump. >> >> There are 2 applications for this signal. >> 1. There's a handshake protocol

Re: RFR: 8279124: VirtualMachineImpl should check signal handler has installed before sending SIGQUIT

2022-01-17 Thread Kevin Walls
On Mon, 17 Jan 2022 08:10:57 GMT, Thomas Stuefe wrote: > I propose a simpler and more robust way to fix it though Great, this is the kind of thing I was heading towards with the conversation in the bug text. Although not sure why I could not reproduce the problem, with various different JDK

Re: RFR: 8279918: Fix various doc typos

2022-01-13 Thread Kevin Walls
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote: > - Most of the typos are of a trivial kind: missing whitespace. > - If any of the typos should be fixed in the upstream projects instead, > please say so; I will drop those typos from the patch. > - As I understand it, ` ` in

Re: RFR: 8279918: Fix various doc typos

2022-01-13 Thread Kevin Walls
On Thu, 13 Jan 2022 11:04:43 GMT, Pavel Rappo wrote: >> src/java.sql/share/classes/java/sql/BatchUpdateException.java line 58: >> >>> 56: * A JDBC driver implementation should use >>> 57: * the constructor {@code BatchUpdateException(String reason, String >>> SQLState, >>> 58: * int

Re: RFR: 8279918: Fix various doc typos

2022-01-13 Thread Kevin Walls
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote: > - Most of the typos are of a trivial kind: missing whitespace. > - If any of the typos should be fixed in the upstream projects instead, > please say so; I will drop those typos from the patch. > - As I understand it, ` ` in

Re: RFR: 8279918: Fix various doc typos

2022-01-13 Thread Kevin Walls
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote: > - Most of the typos are of a trivial kind: missing whitespace. > - If any of the typos should be fixed in the upstream projects instead, > please say so; I will drop those typos from the patch. > - As I understand it, in ImageInputStream

Re: RFR: 8279918: Fix various doc typos

2022-01-13 Thread Kevin Walls
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote: > - Most of the typos are of a trivial kind: missing whitespace. > - If any of the typos should be fixed in the upstream projects instead, > please say so; I will drop those typos from the patch. > - As I understand it, in ImageInputStream

Integrated: 8278597: Remove outdated comments regarding RMISecurityManager in HotSpotAgent.java

2022-01-13 Thread Kevin Walls
On Wed, 12 Jan 2022 15:04:04 GMT, Kevin Walls wrote: > The HotSpotAgent.java setupDebugger method has a commmented out section > relating to possibly using RMISecurityManager. > The comment is from pre-jdk7. As RMISecurityManager has been deprecated for > a while the com

Re: RFR: 8278597: Remove outdated comments regarding RMISecurityManager in HotSpotAgent.java

2022-01-13 Thread Kevin Walls
On Wed, 12 Jan 2022 15:04:04 GMT, Kevin Walls wrote: > The HotSpotAgent.java setupDebugger method has a commmented out section > relating to possibly using RMISecurityManager. > The comment is from pre-jdk7. As RMISecurityManager has been deprecated for > a while the com

RFR: 8278597: Remove outdated comments regarding RMISecurityManager in HotSpotAgent.java

2022-01-12 Thread Kevin Walls
The HotSpotAgent.java setupDebugger method has a commmented out section relating to possibly using RMISecurityManager. The comment is from pre-jdk7. As RMISecurityManager has been deprecated for a while the comments should be removed. This is a comment-only change, no impact on what we build,

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed [v2]

2022-01-10 Thread Kevin Walls
gt; Docs/man page update to follow (JDK-8278619). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Wildcard in object filter to permit proxies, in case other activity in this JVM changes the nameing/numbering of proxy classes. ---

RE: [libattach] misleading error message when checking gid fails

2022-01-07 Thread Kevin Walls
Hi - The file is "/proc/1974261/root/tmp/.java_pid1974261", so is that a JVM in a container, and is the group of the file in the container unknown to the host? ( so -1 is"nogroup") -Original Message- From: serviceability-dev On Behalf Of Serguei Spitsyn Sent: 07 January 2022 18:25

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed

2022-01-07 Thread Kevin Walls
On Wed, 22 Dec 2021 18:14:43 GMT, Kevin Walls wrote: > Remove the use of Security Manager from jstatd. > Add use of an ObjectInputFilter to restrict RMI. > > Also we can undo the property-setting Launcher.gmk change from: 8279007: > jstatd fails to start because SecurityMana

Re: RFR: 8250801: Add clhsdb "threadcontext" command [v2]

2022-01-04 Thread Kevin Walls
On Sun, 2 Jan 2022 00:56:49 GMT, Chris Plummer wrote: >> SA has the ability to fetch the thread's registers via the thread context. >> It would be nice to allow access to the registers from clhsdb. This plays in >> well with the enhancements being done to PointerFinder as part of >>

Re: RFR: 8250801: Add clhsdb "threadcontext" command

2021-12-24 Thread Kevin Walls
On Thu, 23 Dec 2021 04:06:58 GMT, Chris Plummer wrote: > SA has the ability to fetch the thread's registers via the thread context. It > would be nice to allow access to the registers from clhsdb. This plays in > well with the enhancements being done to PointerFinder as part of > JDK-8247514.

Re: RFR: 8250801: Add clhsdb "threadcontext" command

2021-12-24 Thread Kevin Walls
On Thu, 23 Dec 2021 04:06:58 GMT, Chris Plummer wrote: > SA has the ability to fetch the thread's registers via the thread context. It > would be nice to allow access to the registers from clhsdb. This plays in > well with the enhancements being done to PointerFinder as part of > JDK-8247514.

Re: RFR: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist

2021-12-23 Thread Kevin Walls
On Thu, 23 Dec 2021 03:45:31 GMT, Chris Plummer wrote: > The SA src/jdk.hotspot.agent/doc/index.html file contains a table of SA > scripts and their descriptions. All of these scripts are now gone. They were > used to make it easier to launch what today we would call SA tools. Now all > these

Re: RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed

2021-12-22 Thread Kevin Walls
On Wed, 22 Dec 2021 21:41:13 GMT, Mandy Chung wrote: >> Remove the use of Security Manager from jstatd. >> Add use of an ObjectInputFilter to restrict RMI. >> >> Also we can undo the property-setting Launcher.gmk change from: 8279007: >> jstatd fails to start because SecurityManager is

RFR: 8272317: jstatd has dependency on Security Manager which needs to be removed

2021-12-22 Thread Kevin Walls
Remove the use of Security Manager from jstatd. Add use of an ObjectInputFilter to restrict RMI. Also we can undo the property-setting Launcher.gmk change from: 8279007: jstatd fails to start because SecurityManager is disabled ..as that is no longer needed. Docs/man page update to follow

  1   2   3   4   >