Hi Jini, David,
Please have a look at the revised webrev:
http://cr.openjdk.java.net/~dstewart/8196361/webrev.01/
In this webrev I have changed the approach to finding the addresses. This was
necessary because in the case of matching for the locks the addresses are
before what is matched and i
Please review this webrev [1] which attempts to fix a test error in
serviceability/sa/ClhsdbWhere.java when it is run under an AArch64 system (not
necessarily exclusive to this system, but it was the system under test). The
bug report [2] provides further details and has the jtr report that was
David,
Thanks for the review. I'll change the split() to look for '\r' instead. I was
unaware of the problems with line.separator, and was actually trying to avoid
cross-platform issues by using it. But things are always more complicated than
they seem!
As far as the original intent of the tes
Please have a look at the newest changes at:
http://cr.openjdk.java.net/~dstewart/8196361/webrev.02/
The only difference between this and the last changeset is the use of "\\R"
instead of whatever is the platform line.separator.
Thank you,
Daniel
-Original Message-
From: David Holmes
Hi Jini,
Thank you for the review. I have made the requested changes and posted them at
http://cr.openjdk.java.net/~dstewart/8196361/webrev.03/
Please have a look and review the changes.
Thanks,
Daniel
-Original Message-
From: Jini George [mailto:jini.geo...@oracle.com]
Sent: Friday,
Hi Sharath,
Thank you for your comments and insight. I have made the requested changes and
the new webrev is at: http://cr.openjdk.java.net/~dstewart/8196521/webrev.01/
Please have a look and let me know if there are any other changes required.
This does pass testing on my system.
Thanks,
Dani
Thanks for sponsoring, Sharath.
Daniel
-Original Message-
From: Sharath Ballal [mailto:sharath.bal...@oracle.com]
Sent: Saturday, February 3, 2018 4:16 AM
To: David Holmes ; stewartd.qdt
; Jini Susan George
; serviceability-dev
Subject: RE: RFR: 8196521: serviceability/sa/ClhsdbWher
Thanks David.
-Original Message-
From: David Holmes [mailto:david.hol...@oracle.com]
Sent: Saturday, February 3, 2018 3:58 AM
To: stewartd.qdt ; Sharath Ballal
; Jini Susan George ;
serviceability-dev
Subject: Re: RFR: 8196521: serviceability/sa/ClhsdbWhere.java fails to find
method '
Thanks Jini.
Regards,
Daniel
-Original Message-
From: Jini George [mailto:jini.geo...@oracle.com]
Sent: Sunday, February 4, 2018 10:56 PM
To: stewartd.qdt ; David Holmes
Cc: serviceability-dev ;
hotspot-...@openjdk.java.net
Subject: Re: RFR: 8196361: JTReg failure in serviceability/s
I am getting Null Pointer Exceptions with both ClhsdbJstack.java and
ClhsdbFindPC.java. It appears the addition of testing with '-Xcomp` causing a
Method to come back as null during the stack walk. I have included the results
of the Jstack test (the FindPC is similar) for the Xcomp section belo
Yes, this is consistently reproducible on my system. I'm happy to provide more
information if it will help. If I knew more about how the Java stack worked, I
could do more of this debugging myself. Is it ever legal to have a Method
pointer of null?
Daniel
-Original Message-
From: Jini
This test actually fails for me for the same reason that ClhsdbJstack.java
fails, there is a frame in the stack of the main method that is returning null
for the method. See the OpenJDK bug at
https://bugs.openjdk.java.net/browse/JDK-8196969 for details of that issue.
In this case I get the sa
Thanks Sharath. I did realize this patch was solving another issue, but just
wanted to make you aware that the null Method issue pops up in this test as
well.
Please let me know if there is something I can do to help you solve this issue.
I don't know if you are able to reproduce the issue or
13 matches
Mail list logo
