Re: 15 RFR(XS): 8165276: Spec states that invoke the premain method in an agent class if it's public but implementation differs

Looks good -Sundar On 24/06/20 7:35 am, serguei.spit...@oracle.com wrote: Please, review a fix for:   https://bugs.openjdk.java.net/browse/JDK-8165276 CSR draft (one CSR reviewer is needed before finalizing it):   https://bugs.openjdk.java.net/browse/JDK-8248189 Webrev:

Re: RFR(S): 8244668: Remove SA's javascript support

Hi Chris, Yes. There are bugs with the label "nashorn_removal" for uses of nashorn. Many scripts are needed for now (till the respective test or make file use etc. are "ported" to do something else. For eg. make use of .js falls back to bootjdk for now). Thanks -Sundar On 28/05/20 9:40

Re: RFR(S): 8244668: Remove SA's javascript support

Hi Chris, Note that not all .js files are related to nashorn! * The one in java.scripting module is init.js file used by jrunscript tool. The jrunscript is javax.script based scripting language independent shell tool. It uses init.js script if the underlying language engine happens to be

Re: RFR(S): 8244668: Remove SA's javascript support

Looks good to me. -Sundar On 27/05/20 5:01 am, Chris Plummer wrote: Hello, Please review the following changes to fully remove javascript support from SA. It's been non-functional since JDK 9 and there are no plans to support it anymore. https://bugs.openjdk.java.net/browse/JDK-8244668

Re: Removal of SA javascript support

Hi, I am going to reiterate. This will lead to maintenance nightmare! Any "Unsupported Java API" is still an API! Remember Unsafe? Once blessed in any form, it is very difficult to remove. Exposing hotspot VM internals as a Java API is very bad idea. No, not even as "unsupported API".

Re: Removal of SA javascript support

Replacing one scripting language with another (jython) does not solve anything. You'd still face the same issues - accessing module private stuff from SA module from scripts. Besides you'll have a new problem in addition. How to bundle jython? We've been using bundled scripting engine

Re: Removal of SA javascript support

Effectively you're asking for SA as API. I don't think that is a good idea. That implies supporting hotspot data structures as Java *API*. That will be maintainability nightmare - we've to keep tracking hotspot data structures in SA code. That itself is problematic. API would be next level

Re: Removal of SA javascript support

Hi Kris, Glad to hear that someone used JS interface of SA :) Quick prototyping + debugger interactive scripting were the goals of JS interface! As you mentioned, given the current state of SA JS interface, it has to be removed :( Thanks -Sundar On 11/12/19 8:56 am, Krystal Mok wrote: Hi

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

? If it can't, is it allowed to use deprecated module? I guess Nashorn might be replaced to Graal.js in the future. So I concern it is not better to depend on Nashorn. Thanks, Yasumasa On 2019/04/19 11:36, Sundararajan Athijegannathan wrote: Hi Yasumasa Thanks for confirming that we've the same issue

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

/16 13:32, Sundararajan Athijegannathan wrote: Hi Yasumasa, Response comments inlined below.. On 16/04/19, 5:21 AM, Yasumasa Suenaga wrote: Hi Sundar, On 2019/04/15 16:58, Sundararajan Athijegannathan wrote: Both options are hacks :( Personally I'm not comfortable with either option. JSObject

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

Hi Yasumasa, Response comments inlined below.. On 16/04/19, 5:21 AM, Yasumasa Suenaga wrote: Hi Sundar, On 2019/04/15 16:58, Sundararajan Athijegannathan wrote: Both options are hacks :( Personally I'm not comfortable with either option. JSObject wrapper suggested in the bug

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

Both options are hacks :( Personally I'm not comfortable with either option. JSObject wrapper suggested in the bug is not impossible to do. VM.getVM() would the "initial object" -- a JSObject impl. that walks through objects is possible. JSObject impls. can cache fields/methods reflectively

Re: 8215534: [testbug] some jfr test don't check @requires vm.hasJFR

Looks good. PS. I just checked that there are other tests with the same requires clause. -Sundar On 13/12/18, 1:20 PM, Lindenmaier, Goetz wrote: Hi, These tests lack @requires vm.hasJFR, thus they are failing on AIX. http://cr.openjdk.java.net/~goetz/wr18/8215334-JFR_requires/01/ Please

Re: RFR : JDK-8170299 - Debugger does not stop inside the low memory notifications code

+1. It is better not to fix this bug. -Sundar On 24/08/18, 7:36 PM, Daniel Fuchs wrote: Hi Harsha, On 23/08/2018 17:35, Daniel Fuchs wrote: So all in all - maybe this is worth fixing but better early in the release than late. I also wonder whether such a behavior change should deserve a

Re: RFR: JDK-8199682 Clean up building the saproc library

-dev from the cc list... 16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan <sundararajan.athijegannat...@oracle.com>: Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we either use /proc & libproc, so calling saproc for those makes sense. But Windows? We have

Re: RFR: JDK-8199682 Clean up building the saproc library

Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we either use /proc & libproc, so calling saproc for those makes sense. But Windows? We have a separate debugger class to load platform specific native library. What is the reason for uniform naming? -Sundar On 16/03/18, 12:19

Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

+1 -Sundar On 21/11/17, 3:26 PM, Sharath Ballal wrote: I have made minor modification to the test (added @bug and removed @modules). The revised webrev is http://cr.openjdk.java.net/~sballal/8184982/webrev.01/ Thanks, Sharath

Re: RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates NullPointerException

+1 -Sundar On 21/11/17, 12:26 PM, Sharath Ballal wrote: Gentle reminder. Thanks, Sharath *From:* Sharath Ballal *Sent:* Tuesday, November 14, 2017 10:31 AM *To:* serviceability-dev@openjdk.java.net *Subject:* RFR: JDK-8184982 - SA: Running ClassDump on a simple java program generates

Re: RFR: JDK-8164783: SA: jhsdb clhsdb 'printall' often throws "Corrupted constant pool" assertion failure

New files (LingeredAppWithInvokeDynamic.java, TestCpoolForInvokeDynamic.java) should just have current year for copyright (2005, 2015 should be removed). Other than that, +1 -Sundar On 11/2/2016 9:29 AM, Jini Susan George wrote: > Could I get one more review done for this, please ? > Thanks,

Re: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

+1 PS. * SA module does not export any package - as of now, only jhsdb is the only way to use SA. So, most findbugs findings are noise. i.e., user code or any code outside SA module cannot access SA programmatically. Only way is to use command line switches of Java launcher - if untrusted code

Re: RFR: JDK-8068155: [Findbugs]new sun.jvm.hotspot.utilities.ObjectReader() creates a sun.jvm.hotspot.utilities.ProcImageClassLoader classloader, which should be performed within a doPrivileged block

Does SA runs under security manager at all? For eg. can jhsdb tool run under security manager? I doubt. Do we want to make it runnable under security manager? If not, does this fix makes sense? -Sundar On 9/14/2016 1:44 PM, Sharath Ballal wrote: > > Hello, > > Please review this fix to add

Re: JDK 9 RFR of 8161970, 8157664: Remove 4 tools tests from ProblemList.txt

+1 for the jlink test being removed from the problem test. -Sundar On 8/2/2016 11:27 AM, Amy Lu wrote: > tools/jlink/JLinkOptimTest.java > This test has been removed in JDK-8160829 > > sun/tools/jinfo/JInfoSanityTest.java > sun/tools/jinfo/JInfoRunningProcessFlagTest.java >

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

htly lesser > concern here given that this is a debugging scenario? > > Thanks, > Jini. > >> -Original Message- >> From: David Holmes >> Sent: Monday, August 01, 2016 6:25 AM >> To: Daniel Daugherty; Sundararajan Athijegannathan; Jini Susan George; >&

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

s reports the same issue on JDK9 code, then we want to >address such that we reduce any Findbugs noise > > 2) Fixing it could be considered to be a defense-in-depth change. > > Dan > > > On 7/29/16 7:19 AM, Sundararajan Athijegannathan wrote: >> Well, we can't cod

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

t hold true even if > –XaddExports is used ? > > > > Regards, > > Jini. > > > > *From:*Sundararajan Athijegannathan > *Sent:* Friday, July 29, 2016 5:11 PM > *To:* serviceability-dev@openjdk.java.net > *Subject:* Re: RFR: (XS): JDK-8068004: > [Fi

Re: RFR: (XS): JDK-8068004: [Findbugs]sun.jvm.hotspot.debugger may expose internal representation

If cloning is done to avoid exposing byte[] outside SA, this fix is not needed in jdk9. In jdk9, none of the SA packages are exposed and code outside SA cannot access this. Besides, Page data may be very big - cloning that ever constructor and getter may be too costly. -Sundar On 7/29/2016 5:07

Re: RFR(S) 8151342: Add module name/version to class histogram output

+1 PS. Don't we have to update the SA code that dumps histogram so that -F mode output would be similar? -Sundar On 4/27/2016 6:04 PM, harold seigel wrote: > Hi, > > Please review this small change to add module information to the class > histogram displayed by tools such as jmap and jcmd. The

Re: RFR (XS): 8153902 remove com/sun/jdi/InterfaceMethodsTest.java, com/sun/jdi/InvokeTest.java from ProblemList

+1 -Sundar On 4/12/2016 11:42 AM, serguei.spit...@oracle.com wrote: > Ping... > > Thanks, > Serguei > > > On 4/8/16 16:04, serguei.spit...@oracle.com wrote: >> Please, review this trivial, test-only change (enabling previously >> excluded tests). >> >> Bug: >>

hg: jdk8/tl/nashorn: 8032944: Improve reflection in Nashorn

Changeset: a43c125b03dc Author:sundar Date: 2014-01-30 18:34 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/a43c125b03dc 8032944: Improve reflection in Nashorn Reviewed-by: jlaskey, attila, ahgross ! src/jdk/nashorn/internal/objects/NativeObject.java +

hg: jdk8/tl/nashorn: 8032954: Nashorn: extend Java.extend

Changeset: eca774d33fa4 Author:sundar Date: 2014-01-30 19:04 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/eca774d33fa4 8032954: Nashorn: extend Java.extend Reviewed-by: attila, jlaskey, ahgross ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java !

hg: jdk8/tl/nashorn: 8032949: Nashorn linkages awry

Changeset: c59fb10cb0b5 Author:sundar Date: 2014-01-30 19:45 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c59fb10cb0b5 8032949: Nashorn linkages awry Reviewed-by: jlaskey, attila, ahgross ! src/jdk/nashorn/internal/objects/NativeObject.java !

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 4706897b4dec Author:attila Date: 2013-12-09 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4706897b4dec 8029467: Widening of booleans causes bad results Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java +

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: e0b4483668a7 Author:jlaskey Date: 2013-11-26 11:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e0b4483668a7 8029173: Debugger support doesn't handle ConsString Reviewed-by: lagergren, hannesw, sundar Contributed-by: james.las...@oracle.com !

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: fea9f0f9bbde Author:sundar Date: 2013-11-14 15:53 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fea9f0f9bbde 8028161: nashorn: src/jdk/nashorn/api/scripting/ScriptEngineTest.java Reviewed-by: lagergren, hannesw !

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: e65a98146b94 Author:attila Date: 2013-11-11 14:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e65a98146b94 8028020: Function parameter as last expression in comma in return value causes bad type calculation Reviewed-by: jlaskey, lagergren, sundar !

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: 2f07b4234451 Author:sundar Date: 2013-11-07 17:26 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2f07b4234451 8027828: ClassCastException when converting return value of a Java method to boolean Reviewed-by: jlaskey, attila !

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: ae5f2130c3b9 Author:sundar Date: 2013-11-01 19:54 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae5f2130c3b9 8027700: function redeclaration checks missing for declaration binding instantiation Reviewed-by: jlaskey, lagergren !

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: d8d5b7919c57 Author:sundar Date: 2013-10-22 14:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8d5b7919c57 8027016: Array.prototype.indexOf should return -1 when array is of length zero Reviewed-by: lagergren, attila !

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: d8aa87d292eb Author:hannesw Date: 2013-10-18 22:42 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8aa87d292eb 8026858: Array length does not handle defined properties correctly Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Lower.java !

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: b01a10c7c7c2 Author:attila Date: 2013-10-17 12:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b01a10c7c7c2 8026161: Don't narrow floating-point literals in the lexer Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/Lexer.java !

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 1899da5c71d3 Author:hannesw Date: 2013-10-16 10:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1899da5c71d3 8026692: eval() throws NullPointerException with --compile-only Reviewed-by: sundar, lagergren !

hg: jdk8/tl/nashorn: 7 new changesets

Changeset: 6cb4f20d971f Author:jlaskey Date: 2013-10-11 14:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6cb4f20d971f 8026309: latest runsunspider.js tests contains several bugs Reviewed-by: sundar, lagergren Contributed-by: james.las...@oracle.com !

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: 34f7a699cdef Author:sundar Date: 2013-10-10 14:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/34f7a699cdef 8026162: this in SAM adapter functions is wrong Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/internal/runtime/ScriptFunction.java !

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 03a68e7ca1d5 Author:lagergren Date: 2013-10-09 17:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/03a68e7ca1d5 8026137: Fix Issues with Binary Evaluation Order Reviewed-by: hannesw, jlaskey Contributed-by: marcus.lagerg...@oracle.com,

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 8d29733ad609 Author:sundar Date: 2013-10-09 10:47 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8d29733ad609 8026112: Function(with(x ? 1e81 : (x2.constructor = 0.1)){}) throws AssertionError: double is not compatible with object Reviewed-by: lagergren,

hg: jdk8/tl/nashorn: 6 new changesets

Changeset: 6345d08fd5de Author:hannesw Date: 2013-10-08 11:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6345d08fd5de 8025213: Assignment marks variable as defined too early Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java +

hg: jdk8/tl/nashorn: 8025771: Enhance Nashorn Contexts

Changeset: 3470bc26128f Author:sundar Date: 2013-10-04 16:21 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3470bc26128f 8025771: Enhance Nashorn Contexts Reviewed-by: jlaskey, hannesw - make/java.security.override ! make/project.properties !

hg: jdk8/tl/nashorn: 8 new changesets

Changeset: 2016a6b9e1f3 Author:hannesw Date: 2013-09-27 16:59 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/2016a6b9e1f3 8025515: Performance issues with Source.getLine() Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java !

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: 279f47b353f3 Author:sundar Date: 2013-09-20 20:55 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/279f47b353f3 8025147: Trailing comma is not allowed in JSONArray and JSONObject Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/parser/JSONParser.java !

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: 195be8ca5c97 Author:sundar Date: 2013-09-20 12:56 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/195be8ca5c97 8025111: undefined or null 'with' expression in empty with block should throw TypeError Reviewed-by: lagergren, hannesw !

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: f954d3f4d192 Author:sundar Date: 2013-09-19 13:34 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f954d3f4d192 8025048: true as case label results in ClassCastException Reviewed-by: lagergren ! src/jdk/nashorn/internal/codegen/Attr.java +

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: 1971c2d770ae Author:sundar Date: 2013-09-18 13:06 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/1971c2d770ae 8024972: for (LeftHandSideExpression in Expression) crashes the compiler Reviewed-by: lagergren, hannesw !

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: e60f6add90d7 Author:hannesw Date: 2013-09-12 14:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e60f6add90d7 8024476: Octane regression on Richards Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/runtime/JSType.java Changeset: 572a2e50ba9e Author:

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 7ae169639485 Author:sundar Date: 2013-09-05 21:17 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/7ae169639485 8024255: When a keyword is used as object property name, the property can not be deleted Reviewed-by: jlaskey, lagergren !

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: b5ff11e00050 Author:sundar Date: 2013-09-04 14:29 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/b5ff11e00050 8024120: Setting __proto__ to null removes the __proto__ property Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/runtime/ScriptObject.java

hg: jdk8/tl/nashorn: 10 new changesets

Changeset: badc919cd621 Author:lagergren Date: 2013-08-23 14:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/badc919cd621 8023550: -d option was broken for any dir but '.'. Fixed Java warnings. Reviewed-by: jlaskey, sundar !

hg: jdk8/tl/nashorn: 7 new changesets

Changeset: bbc4e9d37315 Author:jlaskey Date: 2013-08-12 18:00 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bbc4e9d37315 8022676: Confusing error message checking instanceof non-class Reviewed-by: jlaskey, sundar Contributed-by: michael.horow...@oracle.com !

hg: jdk8/tl/nashorn: 9 new changesets

Changeset: 14ea21d58f83 Author:jlaskey Date: 2013-08-08 11:20 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/14ea21d58f83 Merge - src/jdk/internal/dynalink/support/Backport.java Changeset: 47e2b609fe31 Author:sundar Date: 2013-08-09 20:48 +0530 URL:

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 9a3e3bb30db3 Author:attila Date: 2013-08-07 16:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/9a3e3bb30db3 8022509: Various Dynalink security enhancements Reviewed-by: jlaskey, hannesw ! src/jdk/internal/dynalink/ChainedCallSite.java !

hg: jdk8/tl/jdk: 8022483: Nashorn compatibility issues in jhat's OQL feature

Changeset: 99f4319763a9 Author:sundar Date: 2013-08-07 18:16 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/99f4319763a9 8022483: Nashorn compatibility issues in jhat's OQL feature Reviewed-by: lagergren, attila, hannesw !

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: 0ad00ae4fec6 Author:hannesw Date: 2013-08-01 12:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0ad00ae4fec6 8020132: Big object literal with numerical keys exceeds method size Reviewed-by: lagergren, sundar !

hg: jdk8/tl/jdk: 8016531: jconsole-plugin script demo does not work with nashorn

Changeset: 87367a1c7f76 Author:sundar Date: 2013-08-05 21:31 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87367a1c7f76 8016531: jconsole-plugin script demo does not work with nashorn Reviewed-by: lagergren, hannesw Contributed-by: rieberandr...@gmail.com !

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: f6588f168d79 Author:hannesw Date: 2013-07-26 13:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f6588f168d79 8020719: Run tests with reduced splitter threshold Reviewed-by: lagergren, sundar, jlaskey ! make/build.xml ! make/project.properties +

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: 0532397d0732 Author:sundar Date: 2013-07-29 18:07 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0532397d0732 8012792: print function defined in engine.js does not handle multiple arguments Reviewed-by: hannesw !

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 5c035c4ccc61 Author:sundar Date: 2013-07-25 14:05 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5c035c4ccc61 8021252: invokeMethod throws NoSuchMethodException when script object is from different script context Reviewed-by: lagergren, hannesw !

hg: jdk8/tl/nashorn: 7 new changesets

Changeset: 8b97fe2b7c98 Author:attila Date: 2013-07-23 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/8b97fe2b7c98 8021129: Use public lookup again Reviewed-by: lagergren, sundar ! src/jdk/internal/dynalink/beans/AbstractJavaLinker.java !

hg: jdk8/tl/nashorn: 10 new changesets

Changeset: e1d19f9fd5a9 Author:jlaskey Date: 2013-07-16 17:40 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e1d19f9fd5a9 8017585: Exclude two failing tests from Nashorn CC run Reviewed-by: jlaskey, sundar, attila Contributed-by: konstantin.she...@oracle.com +

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 965d876853ec Author:attila Date: 2013-07-16 15:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/965d876853ec 8020357: throw RangeError for too large NativeArrayBuffer size Reviewed-by: jlaskey, hannesw, sundar !

hg: jdk8/tl/nashorn: 7 new changesets

Changeset: 973d78ee0728 Author:attila Date: 2013-07-15 12:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/973d78ee0728 8020324: Implement Object.bindProperties(target, source) for beans Reviewed-by: hannesw, sundar !

hg: jdk8/tl/nashorn: 18 new changesets

Changeset: 5106d43feed7 Author:hannesw Date: 2013-07-08 19:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5106d43feed7 8019963: empty char range in regex Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java !

hg: jdk8/tl/jdk: 7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error

Changeset: dadcfd84d33f Author:sundar Date: 2013-07-11 18:50 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dadcfd84d33f 7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error Reviewed-by: mcimadamore, jlaskey, hannesw, attila !

hg: jdk8/tl/nashorn: 20 new changesets

Changeset: 313bdcd2fd22 Author:sundar Date: 2013-07-03 00:08 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/313bdcd2fd22 8019629: void operator should always evaluate to undefined Reviewed-by: jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java !

hg: jdk8/tl/nashorn: 12 new changesets

Changeset: 218c2833c344 Author:sundar Date: 2013-06-28 19:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/218c2833c344 8019365: Error stack format Reviewed-by: hannesw ! src/jdk/nashorn/api/scripting/NashornException.java !

hg: jdk8/tl/nashorn: 11 new changesets

Changeset: c30beaf3c42a Author:jlaskey Date: 2013-06-21 14:34 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c30beaf3c42a 8010732: BigDecimal, BigInteger and Long handling in nashorn Reviewed-by: sundar Contributed-by: james.las...@oracle.com +

hg: jdk8/tl/nashorn: 7 new changesets

Changeset: 6a75a505301f Author:sundar Date: 2013-06-18 18:43 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6a75a505301f 8012698: [nashorn] tests fail to run with agentvm or samevm Reviewed-by: hannesw, jlaskey !

hg: jdk8/tl/nashorn: 14 new changesets

Changeset: df5d7f34e35e Author:hannesw Date: 2013-06-11 17:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/df5d7f34e35e 8015379: PropertyMap.addProperty() is slow Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/runtime/PropertyMap.java Changeset: aa16622193e1

hg: jdk8/tl/nashorn: 7 new changesets

Changeset: bab844827181 Author:sundar Date: 2013-06-06 21:41 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/bab844827181 8015346: JSON parsing issues with escaped strings, octal, decimal numbers Reviewed-by: hannesw, jlaskey !

hg: jdk8/tl/nashorn: 16 new changesets

Changeset: 66b2fde90c9d Author:jlaskey Date: 2013-05-29 16:23 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/66b2fde90c9d 8015636: Add more typed arrays code coverage tests. Reviewed-by: sundar Contributed-by: james.las...@oracle.com + test/script/basic/typedarrays.js

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: 6fc7b51e83d6 Author:lagergren Date: 2013-05-23 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6fc7b51e83d6 8012522: Clean up lexical contexts - split out stack based functionality in CodeGenerator and generify NodeVisitors based on their LexicalContext

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 92164a5742db Author:lagergren Date: 2013-05-20 16:38 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/92164a5742db 8006069: Range analysis first iteration, runtime specializations Reviewed-by: jlaskey, sundar !

hg: jdk8/tl/nashorn: 15 new changesets

Changeset: 80d4db063d5a Author:jlaskey Date: 2013-05-14 11:15 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/80d4db063d5a 8014512: Exclude testing and infrastructure packages from code coverage Reviewed-by: sundar Contributed-by: james.las...@oracle.com !

hg: jdk8/tl/nashorn: 21 new changesets

Changeset: 0547a1c76259 Author:attila Date: 2013-04-23 12:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0547a1c76259 8011065: Problems when script implements an interface with variadic methods Reviewed-by: jlaskey, hannesw, sundar !

hg: jdk8/tl/nashorn: 9 new changesets

Changeset: ac309d492b8d Author:sundar Date: 2013-04-18 15:50 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ac309d492b8d 8012462: Date.prototype.toJSON does not handle non-Date 'this' as per the spec. Reviewed-by: jlaskey, hannesw !

hg: jdk8/tl/nashorn: 5 new changesets

Changeset: aa8170c0dec9 Author:sundar Date: 2013-04-15 20:12 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/aa8170c0dec9 8012240: Array.prototype.map.call({length: -1, get 0(){throw 0}}, function(){}).length does not throw error Reviewed-by: lagergren, jlaskey !

hg: jdk8/tl/nashorn: 9 new changesets

Changeset: 635a93b61d34 Author:hannesw Date: 2013-04-10 14:00 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/635a93b61d34 8011714: Regexp decimal escape handling still not correct Reviewed-by: lagergren, attila !

hg: jdk8/tl/nashorn: 20 new changesets

Changeset: af6fc67aa73d Author:jlaskey Date: 2013-04-02 11:37 -0300 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/af6fc67aa73d 8011233: Create a Nashorn shell for JavaFX Reviewed-by: lagergren, sundar Contributed-by: james.las...@oracle.com ! make/build.xml !

hg: jdk8/tl/nashorn: 2 new changesets

Changeset: 3e4369fb810b Author:hannesw Date: 2013-04-02 13:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3e4369fb810b 8011219: Regression with recent PropertyMap history changes Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/PropertyMap.java

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: 41a212ea8c0c Author:sundar Date: 2013-03-28 20:48 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/41a212ea8c0c 8010924: Dealing with undefined property gets you a fatal stack Reviewed-by: lagergren, jlaskey !

hg: jdk8/tl/jdk: 8010991: Enable test/javax/script/GetInterfaceTest.java again

Changeset: 811c771acf65 Author:sundar Date: 2013-03-28 14:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/811c771acf65 8010991: Enable test/javax/script/GetInterfaceTest.java again Reviewed-by: lagergren, hannesw ! test/javax/script/GetInterfaceTest.java

hg: jdk8/tl/nashorn: 4 new changesets

Changeset: ae4ef3102d9c Author:lagergren Date: 2013-03-25 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/ae4ef3102d9c 8017010: index evaluation to a temporary location for index operator much change temporaries to slots, but never scoped vars Reviewed-by: hannesw,

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 3b0a0d9d51f0 Author:sundar Date: 2013-03-18 21:03 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3b0a0d9d51f0 8010199: javax.script.Invocable implementation for nashorn does not return null when matching functions are missing Reviewed-by: lagergren, jlaskey

hg: jdk8/tl/jdk: 8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java failed after fix for 8009869

Changeset: d92a96dcbfe1 Author:sundar Date: 2013-03-25 19:25 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d92a96dcbfe1 8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java failed after fix for 8009869 Reviewed-by: lagergren, hannesw !

hg: jdk8/tl/jdk: 8009869: Need to modify java.security property package.access to include nashorn packages

Changeset: 9ee1aff76498 Author:sundar Date: 2013-03-21 19:19 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ee1aff76498 8009869: Need to modify java.security property package.access to include nashorn packages Reviewed-by: ahgross, jlaskey, lagergren !

hg: jdk8/tl/jdk: 8010136: Make jrunscript's init.js to work on nashorn

Changeset: 46ad8dfabd5f Author:sundar Date: 2013-03-15 19:30 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46ad8dfabd5f 8010136: Make jrunscript's init.js to work on nashorn Reviewed-by: lagergren, hannesw ! src/share/classes/com/sun/tools/script/shell/init.js

hg: jdk8/tl/langtools: 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {}

Changeset: f071cd32d297 Author:sundar Date: 2012-08-08 22:17 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f071cd32d297 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {} Reviewed-by: darcy, jjg !

hg: jdk8/tl/langtools: 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type

Changeset: 96a8278e323c Author:sundar Date: 2012-05-11 20:06 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96a8278e323c 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type Reviewed-by: mcimadamore !