On Thu, 30 Sep 2021 05:43:40 GMT, Yumin Qi wrote:
> Please review,
> Refactor fundamental CDS FileMapHeader code for reliable reading of basic
> info from shared archive.
> With the change, it makes it possible to read an archive generated by
> different version o
On Thu, 7 Oct 2021 06:06:02 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add offset check for _generic_header in populate_header
>
> LGTM
@iklam @calvinccheung Thanks
On Thu, 7 Oct 2021 20:30:00 GMT, Calvin Cheung wrote:
> I just have one minor comment. It's up to you if you want to change it.
Thanks for review --- I will leave as it is now.
-
PR: https://git.openjdk.java.net/jdk/pull/5768
> CDS archive If the archive supplied is not readable or fails to pass the
> check.
>
> Tests: tier1-4
>jtreg on sa.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
Add offset check
On Wed, 6 Oct 2021 17:01:58 GMT, Ioi Lam wrote:
>> see above reply. We need read the full _header_size for _header. Also note
>> that helper class will delete gen_header when out of scope.
>
> I see. I think your current code is fine.
>
> Note that the current code writes the header as a
> CDS archive If the archive supplied is not readable or fails to pass the
> check.
>
> Tests: tier1-4
>jtreg on sa.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
Change FileHe
On Wed, 6 Oct 2021 04:09:32 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a helper class to facilitate checking archive
>
> src/hotspot/share/cds/filemap.cpp line 1
> CDS archive If the archive supplied is not readable or fails to pass the
> check.
>
> Tests: tier1-4
>jtreg on sa.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
Fixed comm
On Wed, 6 Oct 2021 04:15:06 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a helper class to facilitate checking archive
>
> src/hotspot/share/cds/filemap.cpp line
On Wed, 6 Oct 2021 04:17:16 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added a helper class to facilitate checking archive
>
> src/jdk.hotspot.agent/share/native/libsa
> CDS archive If the archive supplied is not readable or fails to pass the
> check.
>
> Tests: tier1-4
>jtreg on sa.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
Added a help
> CDS archive If the archive supplied is not readable or fails to pass the
> check.
>
> Tests: tier1-4
>jtreg on sa.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
Fixed comment
> CDS archive If the archive supplied is not readable or fails to pass the
> check.
>
> Tests: tier1-4
>jtreg on sa.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
Fixed output acco
> CDS archive If the archive supplied is not readable or fails to pass the
> check.
>
> Tests: tier1-4
>jtreg on sa.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
Fixed miss return after f
Please review,
Refactor fundamental CDS FileMapHeader code for reliable reading of basic
info from shared archive.
With the change, it makes it possible to read an archive generated by
different version of hotspot. Also it is possible to automatically generate a
CDS archive If the archive
On Sat, 27 Feb 2021 18:20:52 GMT, Ioi Lam wrote:
>> Hi Yumin,
>>
>> This is a very useful addition.
>>
>> My biggest concern with this patch though is the use of
>> `os::fork_and_exec()` in regular, non-fatal situations. I had a look at that
>> function and I think that is very unsafe.
>>
On Fri, 26 Feb 2021 00:03:40 GMT, Yumin Qi wrote:
> Hi, Please review
>
> Added jcmd option for dumping CDS archive during application runtime.
> Before this change, user has to dump shared archive in two steps: first run
> application with
> `java -XX:D
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
On Fri, 19 Mar 2021 05:39:25 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
On Fri, 26 Feb 2021 22:46:07 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional
On Fri, 26 Feb 2021 22:01:50 GMT, Calvin Cheung wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five
On Wed, 10 Mar 2021 04:28:04 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix white space in CDS.java
>
> src/java.base/share/classes/jdk/internal/misc/CDS.jav
On Sat, 27 Feb 2021 18:11:38 GMT, Ioi Lam wrote:
>> How would it overflow? But I agree, I would not add jsa extension if the
>> user did not specify one. I dislike when programs do that.
>
> `file_name` is user input that comes from the jcmd, so it can be arbitrarily
> long and exceed
On Sat, 27 Feb 2021 05:12:25 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/metaspaceShared.cpp line 783:
>>
>>> 781: char* start = buffer + strlen(buffer);
>>> 782: snprintf(start, buff_len, "%s ", arg);
>>> 783: }
>>
>> Maybe move the above function to the StringUtils class under
On Fri, 26 Feb 2021 21:39:48 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains five additional
On Wed, 10 Mar 2021 04:18:29 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix white space in CDS.java
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1124:
>
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
For static dump, user can dump multiple
> times against same process.
>The file name is optional, if the file name is not supplied, the file name
> will take format of `java_pid_static.jsa` or
> `java_pid_dynamic.jsa` for static and dynamic respectively. The
> `` is the application
On Fri, 26 Feb 2021 22:05:06 GMT, Calvin Cheung wrote:
>> Hi, Please review
>>
>> Added jcmd option for dumping CDS archive during application runtime.
>> Before this change, user has to dump shared archive in two steps: first run
>> application with
>> `java -XX:DumpLoadedClassList=
On Mon, 22 Feb 2021 22:26:50 GMT, Yumin Qi wrote:
> Hi, Please review
>
> When debugging for other test case which uses jcmd to attach LingeredApp
> process, found there is no error information logged when the app started with
> function 'startAppExactJvmOpts' exits due
es the function startAppExactJvmOpts to create LingeredApp, also the
> test case in debugging, which indeed captured the error message upon start
> error.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revisio
es the function startAppExactJvmOpts to create LingeredApp, also the
> test case in debugging, which indeed captured the error message upon start
> error.
>
> Thanks
> Yumin
Yumin Qi has updated the pull request incrementally with one additional commit
since the last revision:
On Tue, 23 Feb 2021 03:43:41 GMT, Chris Plummer wrote:
>> It seems error prone to have to call finishApp() manually in order to see
>> the error log. Since LingeredApp.startApp calls finishApp() on exceptions,
>> shouldn't startAppExactJvmOpts do the same thing?
>
> Although you have a point,
, will
send codereview after the problems fixed.
Thanks
Yumin
On 1/14/21 12:03 PM, Yumin Qi wrote:
Hi, All
I have created bug and CSR for this issue and wish have your comments on it:
BUG: https://bugs.openjdk.java.net/browse/JDK-8259070
CSR: https://bugs.openjdk.java.net/browse/JDK
Oops, push send too soon.
Thanks
Yumin
Forwarded Message
Subject:CSR: 8259798: Add jcmd option to dump CDS
Date: Thu, 14 Jan 2021 12:03:38 -0800
From: Yumin Qi
To: hotspot-runtime-...@openjdk.java.net
Hi, All
I have created bug and CSR for this issue
On Tue, 15 Dec 2020 17:26:25 GMT, Coleen Phillimore wrote:
> See bug for details. Tested:
>
> $ java -XX:+StressLdcRewrite -version
> Error: VM option 'StressLdcRewrite' is diagnostic and must be enabled via
> -XX:+UnlockDiagnosticVMOptions.
> Error: The unlock option must precede
Thanks Dan for the review!
On 6/25/20 12:17 PM, Daniel D. Daugherty wrote:
On 6/25/20 1:33 PM, Yumin Qi wrote:
Hi, please review the tiny changes for
bug: https://bugs.openjdk.java.net/browse/JDK-8203005
webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/
src/hotspot/share
://bugs.openjdk.java.net/browse/JDK-8174995 has this same bug.
What do you think?
thanks,
Chris
On 6/25/20 10:33 AM, Yumin Qi wrote:
Hi, please review the tiny changes for
bug: https://bugs.openjdk.java.net/browse/JDK-8203005
webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/
Summary
Hi, please review the tiny changes for
bug: https://bugs.openjdk.java.net/browse/JDK-8203005
webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/
Summary: The change was left by
8074345(https://bugs.openjdk.java.net/browse/JDK-8074345), the types
were wrongly put as T_ILLEGAL
product(bool, UsePerfData,
true, \
"Flag to disable jvmstat instrumentation for performance
testing "\
"and problem isolation
purposes") \
The flag default value set to true --- should we change
Hi, Dan
Looks good to me and it is trivial.
Thanks
Yumin
On 6/12/20 11:40 AM, Daniel D. Daugherty wrote:
Tap, tap, tap... is this thing working?
Anyone out there? This is a trivial 1-liner review...
Dan
On 6/12/20 12:46 PM, Daniel D. Daugherty wrote:
Greetings,
It's time to reduce
eclaration. It probably
doesn't matter, but we usually add 'inline' to the declaration of
functions that appear in xxx_inline.hpp files.
Thanks
- Ioi
On 5/5/20 1:32 PM, Yumin Qi wrote:
Hi, Ioi and Calvin
There is an file classLoader.inline.hpp which also includes
atomic.
to this (to reduce unnecessary header
file dependencies)
inline static void load_zip_library_if_needed();
and then move the implementation to the classLoader.cpp file. You also
need to add include "runtime/atomic.hpp" to classLoader.cpp.
Thanks
- Ioi
On 5/4/20 4:40 PM, Yumin Qi wrote
fences/
Thanks
- Ioi
On 5/1/20 8:00 PM, Yumin Qi wrote:
Dean,
I have updated to use MutexLocker instead at same link:
http://cr.openjdk.java.net/~minqi/8237750/webrev-01/
Tested locally, passed jtreg/runtime.
Thanks
Yumin
On 5/1/20 4:24 PM, Dean Long wrote:
OK, I didn't realize com
, Yumin Qi wrote:
Hi, Dean
Thanks for the review. I will try MutextLocker, for AOT, I think
currently the tests are not using CDS then it will load classes from
stream, that will use libzip's Crc32.
I will check for AOT to see if it really loads libzip with the
patch. For test compiler/aot
S.
Thanks
Yumin
On 5/1/20 2:11 PM, Dean Long wrote:
It looks like Zip_lock could be a MutexLocker instead of a MonitorLocker.
dl
On 5/1/20 10:24 AM, Yumin Qi wrote:
Hi, please review:
bug 8237750: https://bugs.openjdk.java.net/browse/JDK-8237750
webrev: http://cr.openjdk.java.net/~minqi/8237750
Hi, please review:
bug 8237750: https://bugs.openjdk.java.net/browse/JDK-8237750
webrev: http://cr.openjdk.java.net/~minqi/8237750/webrev-01/
Summary:
zip library is loaded unconditionally at start up but it is only
needed when
1) bootclasspath contains zip or
2) UseAOT enabled or
3)
Looks good to me.
Thanks
Yumin
On Wed, Dec 19, 2018 at 7:42 AM JC Beyler wrote:
> Hi all,
>
> Could I get a second review for this please? :)
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8215495/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8215495
>
> Thanks!
> Jc
>
> On Mon,
Jini,
Looks good. One minor comment:
+ public void printG1HeapSummary(G1CollectedHeap heap) {+
G1CollectedHeap g1h = (G1CollectedHeap) heap;
'heap' has been cast to 'G1CollectedHeap' at call site, so seems no need
to convert here again.
Thanks
Yumin
On Mon, Mar 12, 2018 at 8:52 AM, Jini
Symbol.identityHash() method
* Add a new whitebox API to return the C version of the
identity_hash() value
* Check if the C value is the same as the Java value
Please run the test on all platforms (both 32-bit and 64-bit, and all
OSes).
Thanks
- Ioi
On 7/15/15 10:37 AM, Yumin Qi wrote:
Hi
Hi,
This is redo for bug 8087143, in that push, it caused failure on
Serviceability Agent failed to get type for _identity_hash: mistakenly
used JShortField for it, but in fact it still is CIntegerField. In this
change, besides of the original change in hotspot/src, I add code to
calculate
Jiangli,
Two minor suggestions (did not pay attention in first round, anyway,
no harm):
1) CompactHashtable.java:
58 private static long uintxSize;
I did not find the usage of this var, please remove it.
2)
+ anyway. Searches the regular symbol table and the shared symbol
Looks good to me. Not a 'R'eviwer.
Thanks
Yumin
On 1/29/2015 5:46 PM, Jiangli Zhou wrote:
Hi Serguei,
Thanks for noticing that. It’s actually a duplicated bug ID for the same issue.
I just fixed the web rev:
http://cr.openjdk.java.net/~jiangli/8071962/webrev.00/.
Thanks,
Jiangli
On Jan
I'm not a Reviewer, so you still need one. (Forgot to mention in my
reply email).
Thanks
Yumin
On 1/14/2015 8:33 AM, Jiangli Zhou wrote:
Hi Yumin,
Thanks for the review! Will fix the copyright.
Thanks,
Jiangli
On 01/13/2015 07:56 PM, Yumin Qi wrote:
Looks good to me. Could you update
Looks good to me. Could you update the copyright year?
Thanks
Yumin
On 1/13/2015 4:50 PM, Jiangli Zhou wrote:
Hi,
Please review the fix for JDK-8067982
https://bugs.openjdk.java.net/browse/JDK-8067982 (Some jcmd
/gc/heap_dump tests failed: hprof output contains warning or error).
The jcmd
David
On 18/10/2014 3:08 PM, Yumin Qi wrote:
David, (cc Karen)
I think I got why it throws CircularityError in 'main' thread.
The CircularityError thrown in TestThread, which was handled in
classloading, the loading class is put into unresolved list. Note we
clean pending exception and return
(InstrumentationImpl.java:428)
at java.lang.Shutdown.clinit(Shutdown.java:61)
This output in
On 10/15/2014 9:58 AM, Yumin Qi wrote:
David,
I will take another detail trace to see where the exception begins
in main thread, it should not thrown in main thread. I only saw it is
thrown
David, Thanks for the comment. See embedded.
On 10/13/2014 7:30 PM, David Holmes wrote:
Hi Yumin,
jdk9-dev is not the best place for code review requests.
serviceability-dev would be better for this test.
On 14/10/2014 8:58 AM, Yumin Qi wrote:
bug: https://bugs.openjdk.java.net/browse
I have to make a correction: DestroyJavaVM thread will not load
TestClass2 so no CircularityError happened with it. When it is created
and run, the loading of TestClass2 already finished.
On 10/14/2014 11:40 AM, Yumin Qi wrote:
David, Thanks for the comment. See embedded.
On 10/13/2014 7:30
Yumin,
Thank you for comments.
I've updated webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.06/
Could you review this?
Thanks,
Yasumasa
On 03/04/2014 03:29 PM, Yumin Qi wrote:
Yasumasa,
Seems no comments for this email so far. I have some comments of
the changes:
1
Yasumasa,
Seems no comments for this email so far. I have some comments of the
changes:
1) arguments.cpp:
a) line 1896 1897, please merge these two lines into one, the
length will not exceeds longest lines in this file.
b) line 1898 - 1990, move line back 4 spaces, in hotspot we
Yasumasa,
I can sponsor this for you --- will start from next week.
Thanks
Yumin
On 1/24/2014 5:50 AM, Yasumasa Suenaga wrote:
Hi all,
I've created webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.00/
This patch works fine on current jdk9/hs-rt .
Could you review this?
I
Changeset: cdf20166ec45
Author:minqi
Date: 2013-11-13 16:24 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cdf20166ec45
8025632: Remove all references to MagicLambdaImpl from Hotspot
Summary: MagicLambdaImpl was removed from jdk side, this should be done in vm
I think in SA, the command 'vmstructsdump' will trigger your code?
Thanks
Yumin
On 10/9/2013 1:59 PM, Dmitry Samersoff wrote:
Staffan,
I don't have specific test, but I rebuild vm testbase with -parameters
and then run nsk.sajdi.
-Dmitry
On 2013-10-09 22:04, Staffan Larsen wrote:
Dmitry,
Hi, Dmitry
Changes looks good. A minor comment for comment:
agent/src/os/bsd/ps_core.c:233
Please remove the trailing For
agent/src/os/linux/ps_core.c:232
Please remove the trailing For
Thanks
Yumin
On 9/25/2013 12:14 AM, Dmitry Samersoff wrote:
Yumin,
Could you take a look?
Dmitry,
Looks good. Minor comments:
os_bsd.cpp:
+ #elif __APPLE__ //XNU kernel
+ // despite the fact mach port is actually not a thread id use it
+ // instead of syscall(SYS_thread_selfid) as it certenly fit to u4
Is it a typo for 'certainly' here?
certenly = certainly
fit = fits
Changeset: 621eda7235d2
Author:minqi
Date: 2013-09-16 15:35 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/621eda7235d2
7164841: Improvements to the GC log file rotation
Summary: made changes to easily identify current log file in rotation.
Parameterize the input
.
That turned rotation off --- if the current file can grow, it will grow,
just like no rotation case; if it can not grow, VM may or may not
continue which depends on what happens.
Thanks
Yumin
Thank you,
Lois
On 8/27/2013 11:32 PM, Yumin Qi wrote:
Hi,
Based on the discussion, I updated
Changeset: 7e7dd25666da
Author:ccheung
Date: 2013-08-26 14:11 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7e7dd25666da
8020675: invalid jar file in the bootclasspath could lead to jvm fatal error
Summary: removed offending EXCEPTION_MARK calls and code cleanup
Hi, Bernd
On 8/27/2013 10:27 AM, Bernd Eckenfels wrote:
Hello,
no matter what you decide (for example configurable pattern like J9 is
doing it) please add enough header informatiomn to the logfile that it
answers common gc diagnostic questions (version, command line
settings, ram/swap size)
, Yumin Qi wrote:
Bengt,
Thanks for your comments.
Yes, as you said, the purpose of rotating logs is primarily
targeted for saving disk space. This bug is supplying customers
another option to prevent the previous gc logs from removed by
restart app without making copy. Now with this pid
wide audience,
especially sustaining, they have more experience with customer request.
Thanks
Yumin
On 8/26/2013 4:47 AM, Bengt Rutisson wrote:
Hi Yumin and Tao,
I have not reviewed the code change but I have a comment inlined below.
On 8/24/13 1:05 AM, Yumin Qi wrote:
Tao,
Thanks
Changeset: b1fd869e7df0
Author:minqi
Date: 2013-08-19 09:16 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b1fd869e7df0
8023188: Unsafe volatile double store on bsd is broken
Reviewed-by: dcubed, dholmes
Contributed-by: yumin...@oracle.com
!
/2013 01:00 PM, Yumin Qi wrote:
Chris, David
Yes. This can be after crash with core file, but some time no core file
generated (also if the error could not repeat, we will never got information
again), so dumping target process is also a choice. To avoid more
confusion, this step was launched
Sorry forgot to include svc.
Yumin
On 8/11/2013 4:36 PM, Yumin Qi wrote:
Hi, all
I would like to have your review for
http://cr.openjdk.java.net/~minqi/8020962/webrev0/
http://cr.openjdk.java.net/%7Eminqi/8020962/webrev0/
Description: When JVM crashed, we also want to check
Ioi,
Thanks for the reminding, it is possible. I will use env instead.
Yumin
On 8/12/2013 11:00 AM, Ioi Lam wrote:
On 08/12/2013 10:00 AM, Yumin Qi wrote:
- What if it the SA also crashes, will it launch a third VM then a
fourth etc?
Definitely don't want to see this happened
Changeset: 57ac7245594c
Author:minqi
Date: 2013-08-08 15:19 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/57ac7245594c
8019583: [TESTBUG] runtime/7107135 always passes
Summary: If java test return none zero, the value will be override by 'if'
statement, the exit
tests now on Solaris, I found coreadm settings may mean
they don't find the core: putting a coreadm command in the test means
we should find JTwork/scratch/core
Thanks
Kevin
On 08/08/2013 19:25, Yumin Qi wrote:
Kevin,
https://jbs.oracle.com/bugs/browse/JDK-8022655
I assigned this to you
and let you know...
Thanks!
Kevin
On 26/07/13 02:17, Yumin Qi wrote:
Hi, Kevin
http://cr.openjdk.java.net/~kevinw/8010278/webrev.03/
http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/
I found this fix breaks C2 replay for dumping loaded java classes
Changeset: f9ee986a9fea
Author:ccheung
Date: 2013-07-30 14:14 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f9ee986a9fea
8021296: [TESTBUG] Test8017498.sh fails to find gcc and fails to compile on
some Linux releases
Summary: Added checking for gcc and
, as it calls sun.jvm.hotspot.CLHSDB, and gives the
javascript exceptions characteristic of 8011888. Rebuilding with the
suggested new sa.js I see in that bug, I'll test and let you know...
Thanks!
Kevin
On 26/07/13 02:17, Yumin Qi wrote:
Hi, Kevin
http://cr.openjdk.java.net/~kevinw/8010278/webrev
Hi, Kevin
http://cr.openjdk.java.net/~kevinw/8010278/webrev.03/
http://cr.openjdk.java.net/%7Ekevinw/8010278/webrev.03/
I found this fix breaks C2 replay for dumping loaded java classes:
at
sun.jvm.hotspot.tools.jcore.PackageNameFilter.canInclude(PackageNameFilter.java:55)
Changeset: 1b6395189726
Author:minqi
Date: 2013-07-19 14:43 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1b6395189726
8012263: ciReplay: gracefully exit report meaningful error when replay data
parsing fails
Summary: find_method could return NULL so need
Changeset: 72727c4b6dec
Author:ccheung
Date: 2013-07-19 14:54 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/72727c4b6dec
8020791: [TESTBUG] runtime/jsig/Test8017498.sh failed to compile native code
Summary: Added -DLINUX to the gcc command and improved the .sh
Changeset: 4614a598dae1
Author:minqi
Date: 2013-07-19 08:34 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4614a598dae1
8016538: volatile double access via Unsafe.cpp is not atomic
Summary: volatile jdouble load/store is not atomic, fix by using of existing
Changeset: 02d7aa1456c9
Author:ccheung
Date: 2013-07-18 14:57 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/02d7aa1456c9
8004872: Early loading of HashMap and StringValue under -XX:+AggressiveOpts can
be removed
Summary: this fix also removes the
Changeset: 732af649bc3a
Author:ccheung
Date: 2013-07-17 12:22 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/732af649bc3a
8017498: JVM crashes when native code calls sigaction(sig) where sig=0x20
Summary: Added (sig MAXSIGNUM) check in jsig.c
Reviewed-by:
Changeset: cd54c7e92908
Author:minqi
Date: 2013-06-18 09:08 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd54c7e92908
8015660: Test8009761.java Failed: init recursive calls: 24. After deopt 25
Summary: Windows reserves and only partially commits thread stack.
Changeset: 92ef81e2f571
Author:minqi
Date: 2013-05-10 08:27 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/92ef81e2f571
8003557: NPG: Klass* const k should be const Klass* k.
Summary: With NPG, const KlassOop klass which is in fact a definition converted
to
Looks good, thanks for the fix.
/Yumin
On 4/29/2013 7:34 AM, Staffan Larsen wrote:
Please review this small fix of additional NULL-checks in SA on OS X.
webrev: http://cr.openjdk.java.net/~sla/8013466/webrev.00/
Thanks,
/Staffan
Changeset: 6f817ce50129
Author:minqi
Date: 2013-04-19 11:08 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6f817ce50129
8010992: Remove calls to global ::operator new[] and new
Summary: disable use of global operator new and new[] which could cause
unexpected
Changeset: 1b90c7607451
Author:minqi
Date: 2013-03-27 17:03 -0700
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1b90c7607451
2178143: JVM crashes if the number of bound CPUs changed during runtime
Summary: Supply a new flag -XX:+AssumeMP to workaround the problem. With
1 - 100 of 173 matches
Mail list logo
