Re: RFR: 8288214: serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java test failed

2022-06-13 Thread Zhengyu Gu
On Sat, 11 Jun 2022 08:11:34 GMT, Alan Bateman wrote: > This test connects to http://openjdk.java.net/ so it's not reliable if the > host name can't be resolved or a HTTP connection cannot be established. I've > changed the test to use a local HTTP server so the original test works as >

Integrated: 8284458: CodeHeapState::aggregate() leaks blob_name

2022-04-07 Thread Zhengyu Gu
On Wed, 6 Apr 2022 23:30:13 GMT, Zhengyu Gu wrote: > Please review this small patch to fix a possible memory leak. > > Test: > - [x] hotspot_serviceability This pull request has now been integrated. Changeset: d4a48843 Author: Zhengyu Gu URL: https://git.openjdk.java.ne

Re: RFR: 8284458: CodeHeapState::aggregate() leaks blob_name [v3]

2022-04-07 Thread Zhengyu Gu
On Thu, 7 Apr 2022 20:09:24 GMT, Leonid Mesnik wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix > > Marked as reviewed by lmesnik (Reviewer). Thanks, @lmesnik - PR: ht

Re: RFR: 8284458: CodeHeapState::aggregate() leaks blob_name [v3]

2022-04-07 Thread Zhengyu Gu
On Thu, 7 Apr 2022 10:12:21 GMT, Lutz Schmidt wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix > > Looks good to me. > Good catch! Thanks for finding and fixing the leak.

Re: RFR: 8281615: Deadlock caused by jdwp agent [v4]

2022-02-22 Thread Zhengyu Gu
On Tue, 22 Feb 2022 21:32:05 GMT, David Holmes wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify classTrack_reset and revert bagSize check > > src/jdk.jdwp.agent/share/nativ

Integrated: 8281615: Deadlock caused by jdwp agent

2022-02-22 Thread Zhengyu Gu
On Mon, 14 Feb 2022 14:27:45 GMT, Zhengyu Gu wrote: > There are scenarios that JDWP agent can deadlock on `classTrackLock` monitor. > Following is the scenario in bug report. > > **Java Thread** > - loads a class and post `JVMTI_EVENT_CLASS_PREPARE` event > - JDWP even

Re: RFR: 8281615: Deadlock caused by jdwp agent [v5]

2022-02-22 Thread Zhengyu Gu
E` is relevant to JDWP agent. > > The solution I purpose here, is simply move allocation/deallocation code > outside of `classTrackLock` lock. > > > Test: > - [x] tier1 > - [x] vmTestbase_nsk_jdi > - [x] vmTestbase_nsk_jdwp > - [x] vmTestbase_nsk_jvmti Zhengyu Gu has

Re: RFR: 8281615: Deadlock caused by jdwp agent [v4]

2022-02-22 Thread Zhengyu Gu
On Thu, 17 Feb 2022 17:34:41 GMT, Chris Plummer wrote: >>> The correctness here depends on exactly how these different functions can >>> be called. I would have expected the allowed sequence to be: activate -> >>> 1or more processUnloads -> reset >>> >>> but given processUnloads can somehow

Re: RFR: 8281615: Deadlock caused by jdwp agent [v4]

2022-02-17 Thread Zhengyu Gu
On Thu, 17 Feb 2022 05:57:24 GMT, Chris Plummer wrote: > processUnloads is continuously called on every event. It's purpose is to > process pending CLASS_UNLOAD events that have accumulated since the last > JVMTI event. This is a rather hacky solution. JVMTI does not actually send a >

Re: RFR: 8281615: Deadlock caused by jdwp agent [v4]

2022-02-17 Thread Zhengyu Gu
On Thu, 17 Feb 2022 02:25:15 GMT, David Holmes wrote: > The correctness here depends on exactly how these different functions can be > called. I would have expected the allowed sequence to be: activate -> 1or > more processUnloads -> reset > > but given processUnloads can somehow occur

Re: RFR: 8281615: Deadlock caused by jdwp agent [v4]

2022-02-17 Thread Zhengyu Gu
On Thu, 17 Feb 2022 06:57:07 GMT, Chris Plummer wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify classTrack_reset and revert bagSize check > > Actually a bit of a correct

Re: RFR: 8281615: Deadlock caused by jdwp agent [v2]

2022-02-15 Thread Zhengyu Gu
On Wed, 16 Feb 2022 00:53:27 GMT, Chris Plummer wrote: >> I am not sure if it is possible, but checking `bagSize(deletedSignatures) == >> 0` seems to race against `classTrack_reset()` where it does not take >> `handlerLock` lock. > >> I am not sure if it is possible, but checking

Re: RFR: 8281615: Deadlock caused by jdwp agent [v2]

2022-02-15 Thread Zhengyu Gu
On Tue, 15 Feb 2022 20:08:19 GMT, Chris Plummer wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> David and Chris' comments > > src/jdk.jdwp.agent/share/native/libjdwp/cl

Re: RFR: 8281615: Deadlock caused by jdwp agent [v4]

2022-02-15 Thread Zhengyu Gu
E` is relevant to JDWP agent. > > The solution I purpose here, is simply move allocation/deallocation code > outside of `classTrackLock` lock. > > > Test: > - [x] tier1 > - [x] vmTestbase_nsk_jdi > - [x] vmTestbase_nsk_jdwp > - [x] vmTestbase_nsk_jvmti Zhengyu Gu

Re: RFR: 8281615: Deadlock caused by jdwp agent [v2]

2022-02-15 Thread Zhengyu Gu
On Tue, 15 Feb 2022 20:02:50 GMT, Chris Plummer wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> David and Chris' comments > > src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c line

Re: RFR: 8281615: Deadlock caused by jdwp agent [v3]

2022-02-15 Thread Zhengyu Gu
E` is relevant to JDWP agent. > > The solution I purpose here, is simply move allocation/deallocation code > outside of `classTrackLock` lock. > > > Test: > - [x] tier1 > - [x] vmTestbase_nsk_jdi > - [x] vmTestbase_nsk_jdwp > - [x] vmTestbase_nsk_jvmti Zhengyu Gu has u

Re: RFR: 8281615: Deadlock caused by jdwp agent [v2]

2022-02-15 Thread Zhengyu Gu
On Tue, 15 Feb 2022 06:31:46 GMT, Chris Plummer wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> David and Chris' comments > > src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c lin

Re: RFR: 8281615: Deadlock caused by jdwp agent [v2]

2022-02-15 Thread Zhengyu Gu
On Mon, 14 Feb 2022 23:26:17 GMT, David Holmes wrote: >> Zhengyu Gu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> David and Chris' comments > > src/jdk.jdwp.agent/share/native/libjdwp/cl

Re: RFR: 8281615: Deadlock caused by jdwp agent [v2]

2022-02-15 Thread Zhengyu Gu
E` is relevant to JDWP agent. > > The solution I purpose here, is simply move allocation/deallocation code > outside of `classTrackLock` lock. > > > Test: > - [x] tier1 > - [x] vmTestbase_nsk_jdi > - [x] vmTestbase_nsk_jdwp > - [x] vmTestbase_nsk_jvmti Zhengyu Gu has up

Re: RFR: 8281615: Deadlock caused by jdwp agent [v2]

2022-02-15 Thread Zhengyu Gu
On Tue, 15 Feb 2022 06:36:36 GMT, Chris Plummer wrote: >> src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c line 100: >> >>> 98: struct bag* deleted = deletedSignatures; >>> 99: deletedSignatures = NULL; >>> 100: debugMonitorExit(classTrackLock); >> >> This looks risky as the

RFR: 8281615: Deadlock caused by jdwp agent

2022-02-14 Thread Zhengyu Gu
There are scenarios that JDWP agent can deadlock on `classTrackLock` monitor. Following is the scenario in bug report. **Java Thread** - loads a class and post `JVMTI_EVENT_CLASS_PREPARE` event - JDWP event callback handler calls `classTrack_processUnloads()` to handle the event. -

Re: RFR: 8268780: Use 'print_cr' instead of 'print' for the message 'eliminated '

2021-06-15 Thread Zhengyu Gu
On Tue, 15 Jun 2021 17:19:26 GMT, Denghui Dong wrote: > Hi, > > Cound I have a review of this small fix that adds a line feed for the message > 'eliminated '. > > When we run the following code and run `jstack ` > > > public static void main(String[] args) { > for (int i = 0; i

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly [v3]

2021-01-28 Thread Zhengyu Gu
On Wed, 20 Jan 2021 01:47:54 GMT, Alex Menkov wrote: >> The fix adds NMT handling for non-java launchers > > Alex Menkov has updated the pull request incrementally with one additional > commit since the last revision: > > Updated comment Sorry, I overlooked some of details. Final change

Re: RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly

2021-01-15 Thread Zhengyu Gu
On Fri, 15 Jan 2021 23:50:16 GMT, Alex Menkov wrote: > The fix adds NMT handling for non-java launchers Looks good - Marked as reviewed by zgu (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2106

Re: RFR: 8259067: bootclasspath append takes out object lock

2021-01-04 Thread Zhengyu Gu
On Mon, 4 Jan 2021 17:28:30 GMT, Coleen Phillimore wrote: > See CR for details. > I made the classpath append list lock-free. Calling experts in Atomic > operations... > Tested with tier1-6. > Thanks, > Coleen src/hotspot/share/classfile/classLoader.cpp line 843: > 841:

Re: RFR: 8212879: Make JVMTI TagMap table concurrent [v2]

2020-11-02 Thread Zhengyu Gu
On Mon, 2 Nov 2020 15:58:15 GMT, Coleen Phillimore wrote: >> This change turns the HashTable that JVMTI uses for object tagging into a >> regular Hotspot hashtable - the one in hashtable.hpp with resizing and >> rehashing. Instead of pointing directly to oops so that GC has to walk the >>

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v6]

2020-09-29 Thread Zhengyu Gu
On Tue, 29 Sep 2020 14:12:26 GMT, Erik Österlund wrote: > > Hi Erik, > > I have been playing with this patch for past a few days. Great work! > > I found that this patch seems to break an early assumption. > > We have a comment in JavaThread::exit() says: > > // We need to cache the thread name

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v6]

2020-09-29 Thread Zhengyu Gu
On Mon, 28 Sep 2020 12:00:40 GMT, Albert Mingkun Yang wrote: >>> Thank you for the comments and diagrams; they make the code much more >>> digestible. From that diagram, I get the >>> impression that the watermark is associated with stack pointer, so it >>> should be 1:1 relation, but `class

Re: RFR: 8252104: parallel heap inspection for ShenandoahHeap [v3]

2020-09-16 Thread Zhengyu Gu
On Sat, 12 Sep 2020 00:17:58 GMT, Lin Zang wrote: >> - enable parallel heap inspecton for ShenandoahHeap >> - preliminary evaluation: >> Time of jmap histo on (8GB heap with 4GB objects) >> * before: 5.186s >> * after : 1.698s > > Lin Zang has refreshed the contents of this pull

Re: RFR: 8252104: parallel heap inspection for ShenandoahHeap [v3]

2020-09-16 Thread Zhengyu Gu
On Sat, 12 Sep 2020 00:15:06 GMT, Lin Zang wrote: > Hi @zhengyu123 , > Thanks for your comments! I have refined the code and update the PR. > -Lin Looks good to me. @shipilev may want to take a look. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/67

Re: RFR: 8252104: parallel heap inspection for ShenandoahHeap [v2]

2020-09-11 Thread Zhengyu Gu
On Fri, 11 Sep 2020 10:54:42 GMT, Aleksey Shipilev wrote: >> Hi @shipilev, >> I have update a PR that trying to reuse code in serial and parallel >> heap iteration. >> would you like to review again? Thanks >> -Lin > > Thank you, we'll take a look next week. Hi Lin, 1) The patch

Re: RFR 8247808: Move JVMTI strong oops to OopStorage

2020-07-15 Thread Zhengyu Gu
Hi Coleen, Shenandoah part looks good. Thanks, -Zhengyu On 7/15/20 11:38 AM, coleen.phillim...@oracle.com wrote: Hi, This patch has been reviewed and I was waiting for the ability to define different OopStorages, but I'd like to fix that in a further change after the GC changes have been

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-26 Thread Zhengyu Gu
Hi, So perhaps just adding the NULL check in the barrier for the case where the markWord ”is_marked” is the sane thing to do, knowing that the other costs taken in the same path will dominate. I have this patch, exactly what you suggested. I will let Aleksey run his numbers. Aleksey is

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-24 Thread Zhengyu Gu
nks, /Erik Thank, -Zhengyu Thanks, /Erik On 24 Feb 2020, at 17:49, Zhengyu Gu wrote: Hi all, Updated according to your comments: http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.02/ I modified vmTestbase/nsk/jvmti/unit/heap/HeapWalkTests/TestDescription.java test [1] to walk 300K obje

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-24 Thread Zhengyu Gu
, -Zhengyu Thanks, /Erik On 24 Feb 2020, at 17:49, Zhengyu Gu wrote: Hi all, Updated according to your comments: http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.02/ I modified vmTestbase/nsk/jvmti/unit/heap/HeapWalkTests/TestDescription.java test [1] to walk 300K objects. Without patch

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-24 Thread Zhengyu Gu
I think this file could have forward declarations of GrowableArray and I didn't see a need for the markWord.hpp include. This change on the whole looks good to me. Coleen On 2/21/20 5:23 AM, Stefan Karlsson wrote: Hi Zhengyu, On 2020-02-17 15:51, Zhengyu Gu wrote: Hi Stefan, Thanks

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-21 Thread Zhengyu Gu
Hi Kim, On 2/21/20 3:47 PM, Kim Barrett wrote: On Feb 7, 2020, at 10:53 AM, Zhengyu Gu wrote: Hi, I would like purpose this change that allows GC to provide ObjectMarker during JVMTI heap walk. Currently, JVMTI heap walk uses oop markword's 'marked' pattern to indicate 'visited' oop

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-18 Thread Zhengyu Gu
heap walk, the answer was 'no'. As Stefan mentioned, this is a slow piece of code, I doubt if there is any benchmarks for it. I would appreciate it if any performance people can chip in. Thanks, -Zhengyu Thanks, Serguei On 2/17/20 6:51 AM, Zhengyu Gu wrote: Hi Stefan, Thanks

Re: [15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-17 Thread Zhengyu Gu
Hi Stefan, Thanks for the review and suggestions, updated accordingly: http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.01/ --- Previously, the calls to 'mark' and 'visited' were inlineable, but now every GC has to take a virtual call when marking the objects. My guess is that this code

[15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-07 Thread Zhengyu Gu
Hi, I would like purpose this change that allows GC to provide ObjectMarker during JVMTI heap walk. Currently, JVMTI heap walk uses oop markword's 'marked' pattern to indicate 'visited' oop. Unfortunately, it conflicts with Shenandoah, who uses the pattern to indicate 'forwarding'. When

RFR(T) 8225804: SA: Remove unused CollectedHeap.oopOffset() method

2019-06-14 Thread Zhengyu Gu
Please review this patch that removes a method that is no longer needed. CollectedHeap.oopOffset() was added for Shenandoah GC to offset extra header for forwarding pointer. Recently, Shenandoah removed the header and folded the forwarding pointer into regular header, so this method is now

Re: RFR(S) 8225801: Shenandoah: Adjust SA to reflect recent forwarding pointer changes

2019-06-14 Thread Zhengyu Gu
On 6/14/19 12:58 PM, Roman Kennke wrote: Oops, totally forgot about that. Should this also go into jdk13 as bugfix? Yes, I think so. -Zhengyu Roman Am 14. Juni 2019 17:50:57 MESZ schrieb Zhengyu Gu : Please review this patch, that adjusts SA to reflect removal of extra header

Re: RFR(S) 8225801: Shenandoah: Adjust SA to reflect recent forwarding pointer changes

2019-06-14 Thread Zhengyu Gu
Removed the comment and pushed. Thanks! -Zhengyu On 6/14/19 11:55 AM, Aleksey Shipilev wrote: On 6/14/19 5:50 PM, Zhengyu Gu wrote: Please review this patch, that adjusts SA to reflect removal of extra header for forwarding pointer. Bug: https://bugs.openjdk.java.net/browse/JDK-8225801

RFR(S) 8225801: Shenandoah: Adjust SA to reflect recent forwarding pointer changes

2019-06-14 Thread Zhengyu Gu
Please review this patch, that adjusts SA to reflect removal of extra header for forwarding pointer. Bug: https://bugs.openjdk.java.net/browse/JDK-8225801 Webrev: http://cr.openjdk.java.net/~zgu/JDK-8225801/webrev.00/ Test: hotspot_gc_shenandoah Manual test. Thanks, -Zhengyu

Re: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk

2019-04-02 Thread Zhengyu Gu
walk  260   handle = handle.addOffsetToAsOopHandle(heap.oopOffset()); I will fix it before push. -Zhengyu thanks, Chris On 4/1/19 6:26 AM, Zhengyu Gu wrote: Hi, May I get review from serviceability? as it has minor changes in shared code (CollectedHeap.java and ObjectHeap.java

Re: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk

2019-04-01 Thread Zhengyu Gu
Hi, May I get review from serviceability? as it has minor changes in shared code (CollectedHeap.java and ObjectHeap.java) Thanks, -Zhengyu On 3/14/19 11:37 AM, Zhengyu Gu wrote: Please review this patch that provides best-effort implementation of live regions iteration for Shenandoah GC

Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-11-26 Thread Zhengyu Gu
Hi Kim, - taskqueue.hpp has some small adjustments to enable subclassing Why this change instead of JDK-8204947? As the description from that RFE says: "The ShenandoahTaskTerminator from the Shenandoah project is a much better implementation of a task terminator.” We were busy on

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-10-01 Thread zhengyu . gu
Changeset: de059a14e159 Author:zgu Date: 2013-10-01 08:54 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/de059a14e159 8022187: Missing ResourceMark crash when assertion using FormatBufferResource fails Summary: Uses stack for the format buffer instead of resource

hg: hsx/hotspot-rt/hotspot: 37 new changesets

2013-09-13 Thread zhengyu . gu
Changeset: 766fac3395d6 Author:kvn Date: 2013-08-23 11:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/766fac3395d6 8012972: Incremental Inlining should support scalar replaced object in debug info Summary: store in _first_index not absolute index but an index

hg: hsx/hotspot-rt/hotspot: 8022798: assert(seq 0) failed: counter overflow in Kitchensink

2013-09-04 Thread zhengyu . gu
Changeset: baa7927dfbd2 Author:zgu Date: 2013-09-04 08:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/baa7927dfbd2 8022798: assert(seq 0) failed: counter overflow in Kitchensink Summary: Removed incorrect assertion, sequence number can overflow Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-08-30 Thread zhengyu . gu
Changeset: 522d69638aa8 Author:zgu Date: 2013-08-30 11:54 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/522d69638aa8 6991327: using -Xprof trigger native memory leak Summary: Fixed a memory leak in FlatProfiler::record_thread_tick() method Reviewed-by: dholmes,

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-07-12 Thread zhengyu . gu
Changeset: c9a5fab39234 Author:zgu Date: 2013-07-11 13:15 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c9a5fab39234 8012241: NMT huge memory footprint, it usually leads to OOME Summary: Enforce memory limitation on NMT to prevent JVM OOM Reviewed-by: acorn,

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-07-04 Thread zhengyu . gu
Changeset: 5f7a4367c787 Author:zgu Date: 2013-07-04 06:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5f7a4367c787 8016074: NMT: assertion failed: assert(thread-thread_state() == from) failed: coming from wrong thread state Summary: Uses os::NakedYield() on

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-06-26 Thread zhengyu . gu
Changeset: 8cff1de240de Author:zgu Date: 2013-06-25 17:22 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8cff1de240de 8017478: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites Summary: Fixed possible NULL pointer that caused SIGSEGV

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-06-18 Thread zhengyu . gu
Changeset: 1f4355cee9a2 Author:zgu Date: 2013-06-18 08:44 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1f4355cee9a2 8013651: NMT: reserve/release sequence id's in incorrect order due to race Summary: Fixed NMT race condition for realloc, uncommit and release

hg: hsx/hotspot-rt/hotspot: 8013917: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites

2013-06-15 Thread zhengyu . gu
Changeset: cd2118b62475 Author:zgu Date: 2013-06-10 10:45 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd2118b62475 8013917: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites Summary: Simple fix when memory allocation site is gone, NMT should

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-06-14 Thread zhengyu . gu
Changeset: ef57c43512d6 Author:ccheung Date: 2013-06-13 22:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ef57c43512d6 8014431: cleanup warnings indicated by the -Wunused-value compiler option on linux Reviewed-by: dholmes, coleenp Contributed-by:

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-06-14 Thread zhengyu . gu
Changeset: ab313d4e9a8b Author:zgu Date: 2013-06-14 09:18 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ab313d4e9a8b 8011968: Kitchensink crashed with SIGSEGV in MemBaseline::baseline Summary: Simple fix to add NULL pointer check that can cause segv Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-28 Thread zhengyu . gu
Changeset: 51af5fae397d Author:ccheung Date: 2013-05-24 17:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/51af5fae397d 8015265: revise the fix for 8007037 Reviewed-by: sspitsyn, dholmes, dcubed ! src/share/vm/oops/constantPool.cpp Changeset: 4cc7d4d5dc92

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-06 Thread zhengyu . gu
Changeset: c18152e0554e Author:zgu Date: 2013-05-06 11:15 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c18152e0554e 8013120: NMT: Kitchensink crashes with assert(next_region == NULL || !next_region-is_committed_region()) failed: Sanity check Summary: Fixed NMT

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-05-03 Thread zhengyu . gu
Changeset: bf089b838c9e Author:ccheung Date: 2013-05-02 16:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bf089b838c9e 8012641: Perf_CreateLong creates perf counter of incorrect type Reviewed-by: mchung, hseigel, coleenp ! src/share/vm/prims/perf.cpp

hg: hsx/hotspot-rt/hotspot: 8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6'

2013-04-30 Thread zhengyu . gu
Changeset: ed5a590835a4 Author:zgu Date: 2013-04-30 09:17 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ed5a590835a4 8013214: BigApps fails due to 'fatal error: Illegal threadstate encountered: 6' Summary: Grab and drop SR_lock to get the thread to honor the

hg: hsx/hotspot-rt/hotspot: 8011661: Insufficient memory message says malloc when sometimes it should say mmap

2013-04-30 Thread zhengyu . gu
Changeset: 746b070f5022 Author:ccheung Date: 2013-04-30 11:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/746b070f5022 8011661: Insufficient memory message says malloc when sometimes it should say mmap Reviewed-by: coleenp, zgu, hseigel !

hg: hsx/hotspot-rt/hotspot: 8011218: Kitchensink hanged, likely NMT is to blame

2013-04-24 Thread zhengyu . gu
Changeset: fbca7eaeac2e Author:zgu Date: 2013-04-24 14:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fbca7eaeac2e 8011218: Kitchensink hanged, likely NMT is to blame Summary: Made NMT query safepoint aware. Reviewed-by: dholmes, coleenp !

hg: hsx/hotspot-rt/hotspot: 8012464: NMT: classes should not derive from _ValueObj, use VALUE_OBJ_CLASS_SPEC instead

2013-04-18 Thread zhengyu . gu
Changeset: b80cc96882f7 Author:zgu Date: 2013-04-18 10:04 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b80cc96882f7 8012464: NMT: classes should not derive from _ValueObj, use VALUE_OBJ_CLASS_SPEC instead Summary: NMT value objects should use

hg: hsx/hotspot-rt/hotspot: 8010151: nsk/regression/b6653214 fails assert(snapshot != NULL) failed: Worker should not be started

2013-04-10 Thread zhengyu . gu
Changeset: 35f8765422b9 Author:zgu Date: 2013-04-10 08:55 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/35f8765422b9 8010151: nsk/regression/b6653214 fails assert(snapshot != NULL) failed: Worker should not be started Summary: Fixed a racing condition when

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-04-06 Thread zhengyu . gu
Changeset: 4b7cf00ccb08 Author:ccheung Date: 2013-04-05 11:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4b7cf00ccb08 8006001: [parfait] Possible file leak in hotspot/src/os/linux/vm/perfMemory_linux.cpp Reviewed-by: zgu, coleenp, hseigel, dholmes !

hg: hsx/hotspot-rt/hotspot: 8011161: NMT: Memory leak when encountering out of memory error while initializing memory snapshot

2013-04-05 Thread zhengyu . gu
Changeset: 4c8bb5e4f68f Author:zgu Date: 2013-04-05 12:19 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4c8bb5e4f68f 8011161: NMT: Memory leak when encountering out of memory error while initializing memory snapshot Summary: Fix memory leaks when NMT fails to

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-04-04 Thread zhengyu . gu
Changeset: bad3bed4b323 Author:ccheung Date: 2013-03-29 14:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bad3bed4b323 8006006: [parfait] Memory leak at hotspot/src/share/tools/launcher/wildcard.c Summary: a simple fix to add FileList_free(fl) before returning

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-04-02 Thread zhengyu . gu
Changeset: 8c03fc47511d Author:iklam Date: 2013-04-01 14:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8c03fc47511d 8011048: Possible reading from unmapped memory in UTF8::as_quoted_ascii() Summary: Pass utf_length parameter to UTF8::as_quoted_ascii()

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-03-28 Thread zhengyu . gu
Changeset: b5bae74160b7 Author:zgu Date: 2013-03-27 15:41 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b5bae74160b7 8010474: [parfait] Undefined return value of the functions in hotspot/src/share/vm/services/memTracker.hpp Summary: Fixed functions that miss

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-03-26 Thread zhengyu . gu
Changeset: 6b748c9e1845 Author:zgu Date: 2013-03-26 14:11 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b748c9e1845 8010651: create.bat still builds the kernel Summary: Remove old kernel build targets and VS C++ projects created by create.bat on Windows

hg: hsx/hotspot-rt/hotspot: 8010389: After fix for 7107135 a failed dlopen() call results in a VM crash

2013-03-22 Thread zhengyu . gu
Changeset: 14509df4cd63 Author:iklam Date: 2013-03-21 20:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/14509df4cd63 8010389: After fix for 7107135 a failed dlopen() call results in a VM crash Summary: Call dlerror() in VM thread as necessary. Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-03-21 Thread zhengyu . gu
Changeset: 06db4c0afbf3 Author:zgu Date: 2013-03-20 09:42 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/06db4c0afbf3 8009298: NMT: Special version of class loading/unloading with runThese stresses out NMT 8009777: NMT: add new NMT dcmd to control auto shutdown

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-03-15 Thread zhengyu . gu
Changeset: 82f49e8e2c28 Author:zgu Date: 2013-03-15 11:53 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/82f49e8e2c28 8009614: nsk/split_verifier/stress/ifelse/ifelse002_30 fails with 'assert((size (granularity - 1)) == 0) failed: size not aligned to

hg: hsx/hotspot-rt/hotspot: 8008257: NMT: assert(new_rec-is_allocation_record()) failed when running with shared memory option

2013-03-07 Thread zhengyu . gu
Changeset: 6b803ba47588 Author:zgu Date: 2013-03-07 14:06 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6b803ba47588 8008257: NMT: assert(new_rec-is_allocation_record()) failed when running with shared memory option Summary: Corrected virtual memory recording

hg: hsx/hotspot-rt/hotspot: 7107135: Stack guard pages are no more protected after loading a shared library with executable stack

2013-03-06 Thread zhengyu . gu
Changeset: 9058789475af Author:iklam Date: 2013-03-05 13:55 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9058789475af 7107135: Stack guard pages are no more protected after loading a shared library with executable stack Summary: Detect the execstack attribute

hg: hsx/hotspot-rt/hotspot: 8008071: Crashed in promote_malloc_records() with Kitchensink after 19 days

2013-02-21 Thread zhengyu . gu
Changeset: fc64254f5579 Author:zgu Date: 2013-02-21 07:50 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fc64254f5579 8008071: Crashed in promote_malloc_records() with Kitchensink after 19 days Summary: Added NULL pointer check for arena size record Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-02-08 Thread zhengyu . gu
Changeset: 8bf62bd86a4e Author:zgu Date: 2013-02-08 14:49 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8bf62bd86a4e 8007791: More Restricted hs_err file permission Summary: Enforce more restricted hs_file permission Reviewed-by: acorn, dcubed, dsamersoff !

hg: hsx/hotspot-rt/hotspot: 8000692: Remove old KERNEL code

2013-01-25 Thread zhengyu . gu
Changeset: 8b46b0196eb0 Author:zgu Date: 2013-01-25 10:04 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8b46b0196eb0 8000692: Remove old KERNEL code Summary: Removed depreciated kernel VM source code from hotspot VM Reviewed-by: dholmes, acorn ! make/Makefile !

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-01-22 Thread zhengyu . gu
Changeset: edd23b35b1a5 Author:zgu Date: 2013-01-22 14:27 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/edd23b35b1a5 6871190: Don't terminate JVM if it is running in a non-interactive session Summary: Don't handle CTRL_LOGOFF_EVENT event when the process is

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-01-11 Thread zhengyu . gu
Changeset: e0cf9af8978e Author:zgu Date: 2013-01-11 12:30 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e0cf9af8978e 8005936: PrintNMTStatistics doesn't work for normal JVM exit Summary: Moved NMT shutdown code to JVM exit handler to ensure NMT statistics is

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-01-09 Thread zhengyu . gu
Changeset: dd7248d3e151 Author:zgu Date: 2013-01-09 14:46 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dd7248d3e151 7152671: RFE: Windows decoder should add some std dirs to the symbol search path Summary: Added JRE/JDK bin directories to decoder's symbol search

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2013-01-08 Thread zhengyu . gu
Changeset: ecd24264898b Author:zgu Date: 2013-01-08 14:04 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ecd24264898b 8005048: NMT: #loaded classes needs to just show the # defined classes Summary: Count number of instance classes so that it matches class metadata

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-12-17 Thread zhengyu . gu
Changeset: 3f84e17b6bca Author:zgu Date: 2012-12-17 13:14 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3f84e17b6bca 8004802: jcmd VM.native_memory baseline=false crashes VM Summary: NMT has to check option's value also to determine which command to execute

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-11-28 Thread zhengyu . gu
Changeset: bbc14465e7db Author:zgu Date: 2012-11-28 09:19 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bbc14465e7db 8003689: MemTracker::init_tracking_options() reads outside array if commandline argument is empty Summary: Fixed potential buffer overrun when

hg: hsx/hotspot-rt/hotspot: 8003487: NMT: incorrect assertion in VMMemPointerIterator::remove_released_region method (memSnapshot.cpp)

2012-11-16 Thread zhengyu . gu
Changeset: 49cbd3e25ba9 Author:zgu Date: 2012-11-16 09:05 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/49cbd3e25ba9 8003487: NMT: incorrect assertion in VMMemPointerIterator::remove_released_region method (memSnapshot.cpp) Summary: The assertion is applied to

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2012-11-10 Thread zhengyu . gu
Changeset: fb3190e77d3c Author:zgu Date: 2012-11-09 19:24 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fb3190e77d3c 8001592: NMT: assertion failed: assert(_amount = amt) failed: Just check: memBaseline.hpp:180 Summary: Fixed NMT that miscounted arena memory

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-11-09 Thread zhengyu . gu
Changeset: ed8b1e39ff4f Author:zgu Date: 2012-11-09 11:04 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ed8b1e39ff4f 8002273: NMT to report JNI memory leaks when -Xcheck:jni is on Summary: Allows NMT to report that JNI thread failed to detach from JVM before

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-10-19 Thread zhengyu . gu
Changeset: 716c64bda5ba Author:zgu Date: 2012-10-19 21:40 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/716c64bda5ba 7199092: NMT: NMT needs to deal overlapped virtual memory ranges Summary: Enhanced virtual memory tracking to track committed regions as well as

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-09-18 Thread zhengyu . gu
Changeset: 9a86ddfc6c8f Author:zgu Date: 2012-09-17 16:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9a86ddfc6c8f 7188594: Print statistic collected by NMT with VM flag Summary: Print out statistics of collected NMT data if it is on at VM exits Reviewed-by:

hg: hsx/hotspot-rt/hotspot: 7191124: Optimized build is broken due to inconsistent use of DEBUG_ONLY and NOT_PRODUCT macros in NMT

2012-08-14 Thread zhengyu . gu
Changeset: e5bf1c79ed5b Author:zgu Date: 2012-08-14 13:56 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e5bf1c79ed5b 7191124: Optimized build is broken due to inconsistent use of DEBUG_ONLY and NOT_PRODUCT macros in NMT Summary: Updated all related variables and

hg: hsx/hotspot-rt/hotspot: 3 new changesets

2012-08-01 Thread zhengyu . gu
Changeset: 4acebbe310e1 Author:zgu Date: 2012-08-01 17:19 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4acebbe310e1 7185614: NMT ON: check by caller assertion failed on nsk ThreadMXBean test 7187429: NMT ON: Merge failure should cause NMT to shutdown Summary:

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-07-30 Thread zhengyu . gu
Changeset: 3b01d0321dfa Author:zgu Date: 2012-07-30 10:25 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3b01d0321dfa 7186778: MachO decoder implementation for MacOSX Summary: Implementation of decoder for Apple's MacOSX. The implementation is based on the patch

hg: hsx/hotspot-rt/hotspot: 6 new changesets

2012-07-19 Thread zhengyu . gu
Changeset: 7e5976e66c62 Author:zgu Date: 2012-07-19 09:05 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7e5976e66c62 7182543: NMT ON: Aggregate a few NMT related bugs Summary: 1) Fixed MemTrackWorker::generations_in_used() calculation 2) Ensured NMT not to leak

hg: hsx/hotspot-rt/hotspot: 6995781: Native Memory Tracking (Phase 1); ...

2012-06-28 Thread zhengyu . gu
Changeset: d2a62e0f25eb Author:zgu Date: 2012-06-28 17:03 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d2a62e0f25eb 6995781: Native Memory Tracking (Phase 1) 7151532: DCmd for hotspot native memory tracking Summary: Implementation of native memory tracking phase

hg: hsx/hotspot-rt/hotspot: 27 new changesets

2012-05-26 Thread zhengyu . gu
Changeset: a05a695ea044 Author:stefank Date: 2012-05-10 11:27 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a05a695ea044 7167437: Can't build on linux without precompiled headers Reviewed-by: brutisso, mgerdin ! src/share/vm/memory/space.hpp !

hg: hsx/hotspot-rt/hotspot: 24 new changesets

2012-05-12 Thread zhengyu . gu
Changeset: 973046802b6f Author:dlong Date: 2012-04-26 16:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/973046802b6f 7162955: Attach api on Solaris, too many open files Summary: Release server-side socket after client receives it. Reviewed-by: sla, dsamersoff,

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2012-02-13 Thread zhengyu . gu
Changeset: db006a85bf91 Author:zgu Date: 2012-02-09 10:16 -0500 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/db006a85bf91 7141259: Native stack is missing in hs_err Summary: Code cleanup and creating a private decoder for error handler, since it can be triggered from

Re: Code Review Request: CR 6988099 Add version information to jvmti demos.

2011-11-02 Thread Zhengyu Gu
Hi Neil, My understanding is that you need to have at least two reviewers who have 'reviewer' privilege, (and I don't have 'reviewer' privilege). Yes, I am tied up, if you can handle the push, that will be great. What java bug id you need? can you use CR 6988099? BTW, here is the link to

  1   2   >