Re: [RFR]8215623: Add incremental dump for jmap histo

2019-06-03 Thread 臧琳
for large heap. What do you think? BRs, Lin From: serguei.spit...@oracle.com Sent: Tuesday, June 4, 2019 8:55:31 AM To: 臧琳 Cc: Hohensee, Paul; JC Beyler; serviceability-dev@openjdk.java.net Subject: Re: [RFR]8215623: Add incremental dump for jmap histo

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-06-03 Thread serguei.spit...@oracle.com
From: 臧琳 Sent: Monday, May 20, 2019 11:14:34 PM To: serguei.spit...@oracle.com Cc: Hohensee, Paul; JC Beyler; serviceability-dev@openjdk.java.net Subject: RE: [RFR]8215623: Add incremental dump for jmap histo Dear Serguei, The main reason of using separate file for incremental dump

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-06-03 Thread 臧琳
: Hohensee, Paul; JC Beyler; serviceability-dev@openjdk.java.net Subject: RE: [RFR]8215623: Add incremental dump for jmap histo Dear Serguei, The main reason of using separate file for incremental dump is due to the consideration of parallel incremental dump implementation, so that every heap-iteration

RE: [RFR]8215623: Add incremental dump for jmap histo

2019-05-20 Thread 臧琳
Beyler ; serviceability-dev@openjdk.java.net Subject: Re: [RFR]8215623: Add incremental dump for jmap histo Dear Lin, Before I go to the details below could you, please, explain why do we need a separate file for incremental dump. Should we just record the full dump into file= incrementally

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-17 Thread serguei.spit...@oracle.com
> Thanks, > Serguei Again, Thanks for your comments BRs, Lin

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-17 Thread 臧琳
he previous 3-5 ones? > But again, this still needs to be clearly specified. > It would be nice to reach a consensus on a design first. Totally agree :) > Thanks, > Serguei Again, Thanks for your comments BRs, Lin Thanks, Lin From: serguei

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-15 Thread serguei.spit...@oracle.com
e incremental file  - what chunks have been recorded into the incremental But again, this still needs to be clearly specified. It would be nice to reach a consensus on a design first. Thanks, Serguei Thanks, Lin ________ From: sergue

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-14 Thread 臧琳
like gclog, when maxfilesize is reached, the file is renamed with numbered suffix, and new file is created to use. so there can be IncrementalHisto.dump.0 and IncrementalHisto.dump.1 etc for large heap. what do you think? Thanks, Lin ________ From: serguei.spit.

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-10 Thread serguei.spit...@oracle.com
Dear Lin, Sorry for the late reply. I've edited the CSR a little bit to fix some incorrect spots. Now, a couple of spots are not clear to me. > - incremental[:], enable the incremental dump of heap, dumped >   data will be saved to, by default it is "IncrementalHisto.dump"  Q1: Should the

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-05 Thread 臧琳
Dear All, I have updated the CSR at https://bugs.openjdk.java.net/browse/JDK-8222319 May I ask your help to review it? When it is finalized, I will refine the webrev. BRs, Lin > Dear Serguei, > Thanks a lot for your reviewing. > > > > > System.err.println("

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-05-04 Thread 臧琳
Dear Serguei, Thanks a lot for your reviewing. System.err.println(" incremental dump support:"); +System.err.println("chunkcount=object number counted (in Kilo) to trigger incremental dump"); +System.err.println("maxfilesize= size limit of

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-30 Thread serguei . spitsyn
在 2019年2月26日,上午10:50,臧琳 mailto:zangl...@jd.com>> 写道: Dear All, I have revised the webrev at http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.02/ <http://cr.openjdk.java.net/%7Exiaofeya/8215623/webrev.02/>.

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-21 Thread 臧琳
, April 15, 2019 10:54 To: Jean Christophe Beyler Cc: 臧琳; Hohensee, Paul; serviceability-dev@openjdk.java.net Subject: Re: [RFR]8215623: Add incremental dump for jmap histo Dear Jc, Thanks a lot for your suggestions, I have updated the CSR. Hi All, May I get more review about the webrev

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-14 Thread 臧琳
tp://cr.openjdk.java.net/~xiaofeya/8215623/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8215623 Thanks! Lin ________________ From: 臧琳 Sent: Wednesday, January 9, 2019 9:46:55 AM To: Hohensee, Paul; serviceability-dev@openjdk.java.net<mailto:serviceab

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-11 Thread 臧琳
I have revised the webrev at http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.02/. May I ask your help for reviewing? Thanks BRs, Lin -Original Message- From: 臧琳 Sent: Friday, January 25, 2019 9:01 AM To: Hohensee, Paul mailto:hohen...@amazon.com>>; serviceabili

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-10 Thread 臧琳
.openjdk.java.net/~xiaofeya/8215623/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8215623 Thanks! Lin ____________________ From: 臧琳 Sent: Wednesday, January 9, 2019 9:46:55 AM To: Hohensee, Paul; serviceability-dev@openjdk.java.net<mailto:servi

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-10 Thread 臧琳
revised the webrev at http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.02/. May I ask your help for reviewing? Thanks BRs, Lin -Original Message- From: 臧琳 Sent: Friday, January 25, 2019 9:01 AM To: Hohensee, Paul mailto:hohen...@amazon.com>>; serviceability- d...@ope

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-10 Thread 臧琳
s BRs, Lin -Original Message- From: 臧琳 Sent: Friday, January 25, 2019 9:01 AM To: Hohensee, Paul mailto:hohen...@amazon.com>>; serviceability- d...@openjdk.java.net<mailto:d...@openjdk.java.net> Subject: Re: [RFR]8215623: Add incremental dump for jmap histo Dear All, M

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-10 Thread Jean Christophe Beyler
ava.net/~lzang/jmap-8214535/8215623/webrev.04/ >> >> >> BRs, >> Lin >> >> 在 2019年2月26日,上午10:50,臧琳 写道: >> >> Dear All, >> I have revised the webrev at >> http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.02/. >> May

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-01 Thread 臧琳
From: 臧琳 Sent: Wednesday, January 9, 2019 9:46:55 AM To: Hohensee, Paul; serviceability-dev@openjdk.java.net Subject: RE: [RFR]8215623: Add incremental dump for jmap histo Hi Paul and All, Thanks a lot for your review and comments, I have updated the webrev to Webrev: http://cr.openjdk.

RE: [RFR]8215623: Add incremental dump for jmap histo

2019-02-25 Thread 臧琳
ability- > d...@openjdk.java.net > Subject: Re: [RFR]8215623: Add incremental dump for jmap histo > > Dear All, > May I get more review about this webrev? > Webrev: http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.01/ > Bug: https://bugs.op

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-01-24 Thread 臧琳
:55 AM To: Hohensee, Paul; serviceability-dev@openjdk.java.net Subject: RE: [RFR]8215623: Add incremental dump for jmap histo Hi Paul and All, Thanks a lot for your review and comments, I have updated the webrev to Webrev: http://cr.openjdk.java.net/~xiaofeya/8215623/webrev.01/ Bug: https

RE: [RFR]8215623: Add incremental dump for jmap histo

2019-01-08 Thread 臧琳
, January 7, 2019 7:14 PM To: Hohensee, Paul ; serviceability-dev@openjdk.java.net; 臧琳 Subject: RE: [RFR]8215623: Add incremental dump for jmap histo And another way is to add a argument “IncrementalFile=”,which specifies the location for saving the intermediate data file. And if it is not specified

RE: [RFR]8215623: Add incremental dump for jmap histo

2019-01-07 Thread 臧琳
; serviceability-dev@openjdk.java.net Subject: 答复: [RFR]8215623: Add incremental dump for jmap histo Dear Paul, Thanks for your review, I agree your suggestion to make incremental general. and I think the incremental file is better to be different with the file or the "out"

答复: [RFR]8215623: Add incremental dump for jmap histo

2019-01-07 Thread 臧琳
same folder, if "filename" not specified, it will dump to current dir. And if "chunkcount" is 0 or max_int, or "maxfilesize" is 0, the incremental dump will be disabled. ____ 发件人: Hohensee, Paul 发送时间: 2019年1月1日 4:56 收件人: 臧琳; serviceability-dev

Re: [RFR]8215623: Add incremental dump for jmap histo

2018-12-31 Thread Hohensee, Paul
PM To: "serviceability-dev@openjdk.java.net" Subject: [RFR]8215623: Add incremental dump for jmap histo Hi All, May I ask your help to review this patch for enhance jmap –histo. It adds the “incremental” arguments that allow jmap –histo to incrementally save the interme

[RFR]8215623: Add incremental dump for jmap histo

2018-12-20 Thread 臧琳
Hi All, May I ask your help to review this patch for enhance jmap �Chisto. It adds the “incremental” arguments that allow jmap �Chisto to incrementally save the intermediate data into a temp file. The intermediate data is dumped incrementally and write to a rolling file, which limit the