+1
--alex
On 05/24/2019 02:55, serguei.spit...@oracle.com wrote:
Hi Daniil,
The fix has been applied cleanly.
LGTM++
Thanks,
Serguei
On 5/23/19 18:22, Daniil Titov wrote:
Please review the backport of this fix to JDK 12. The JDK 12 changes
applied mostly smoothly, but one hunk in
Hi Daniil,
The fix has been applied cleanly.
LGTM++
Thanks,
Serguei
On 5/23/19 18:22, Daniil Titov wrote:
Please review the backport of this fix to JDK 12. The JDK 12 changes applied
mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply
because of changed context lines.
Looks good.
Thanks,
David
On 24/05/2019 11:22 am, Daniil Titov wrote:
Please review the backport of this fix to JDK 12. The JDK 12 changes applied
mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply
because of changed context lines. That's the only difference.
Webrev:
Please review the backport of this fix to JDK 12. The JDK 12 changes applied
mostly smoothly, but one hunk in make/test/JtregNativeJdk.gmk didn't apply
because of changed context lines. That's the only difference.
Webrev: http://cr.openjdk.java.net/~dtitov/backports/jdk12u/8214545/webrev.01/
Hi Daniil,
+1
Thanks,
Serguei
On 5/20/19 23:20, David Holmes wrote:
Loosk good.
Thanks,
David
On 21/05/2019 1:25 pm, Daniil Titov wrote:
Please review un updated version of the previous change that also
removes unnecessary line
chmod ug+x $REVOKEALL
from
On 21/05/2019 04:25, Daniil Titov wrote:
Please review un updated version of the previous change that also removes
unnecessary line
chmod ug+x $REVOKEALL
from test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
Webrev:http://cr.openjdk.java.net/~dtitov/8214545/webrev.03
Loosk good.
Thanks,
David
On 21/05/2019 1:25 pm, Daniil Titov wrote:
Please review un updated version of the previous change that also removes
unnecessary line
chmod ug+x $REVOKEALL
from test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
Webrev:
Hi Daniil,
I realize now that the test for -f rather than -x was likely because in
the source bundle the exe file couldn't actually have the execute
permission. So -f was correct then while -x should I hope be correct
now. In which case you should be able to get rid of:
chmod ug+x
Please review un updated version of the previous change that also removes
unnecessary line
chmod ug+x $REVOKEALL
from test/jdk/sun/management/jmxremote/bootstrap/GeneratePropertyPassword.sh
Webrev: http://cr.openjdk.java.net/~dtitov/8214545/webrev.03
Bug:
LGTM
--alex
On 05/20/2019 18:02, Daniil Titov wrote:
Please review a new version of the fix that includes the changes David
suggested.
> The count-- is obvious as it is the loop counter, but it is far from
> clear to me that i++ is correct. I don't fully understand the logic
We need to
Please review a new version of the fix that includes the changes David
suggested.
> The count-- is obvious as it is the loop counter, but it is far from
> clear to me that i++ is correct. I don't fully understand the logic
We need to increment i on line 354:
353 if
Hi Alan,
I think it makes sense to put the work for replacing revokeall.exe utility with
a Java code in a separate issue since the current issue is a quite urgent.
I created a new issue for that https://bugs.openjdk.java.net/browse/JDK-8224255
Thanks!
--Daniil
On 5/19/19, 11:04 PM, "Alan
Build changes look good.
/Erik
On 2019-05-19 17:43, David Holmes wrote:
Hi Daniil,
cc: Boris and Erik J.
On 20/05/2019 7:12 am, Daniil Titov wrote:
Please review the change that fixes the failure of
sun/management/jmxremote/bootstrap JMX tests on Windows platform.
While running, these
On 20.05.2019 13:13, Daniel Fuchs wrote:
Hi,
On 20/05/2019 01:43, David Holmes wrote:
Webrev: http://cr.openjdk.java.net/~dtitov/8214545
Bug: https://bugs.openjdk.java.net/browse/JDK-8214545
The count-- is obvious as it is the loop counter, but it is far from
clear to me that i++ is
The change is good. Thank you!
regards,
Boris
On 20.05.2019 3:43, David Holmes wrote:
Hi Daniil,
cc: Boris and Erik J.
On 20/05/2019 7:12 am, Daniil Titov wrote:
Please review the change that fixes the failure of
sun/management/jmxremote/bootstrap JMX tests on Windows platform.
While
Hi,
On 20/05/2019 01:43, David Holmes wrote:
Webrev: http://cr.openjdk.java.net/~dtitov/8214545
Bug: https://bugs.openjdk.java.net/browse/JDK-8214545
The count-- is obvious as it is the loop counter, but it is far from
clear to me that i++ is correct. I don't fully understand the logic but
i
On 19/05/2019 22:12, Daniil Titov wrote:
Please review the change that fixes the failure of
sun/management/jmxremote/bootstrap JMX tests on Windows platform. While
running, these tests invoke revokeall.exe utility and this utility hangs.
The problem here is that invokeall.exe goes into an
Hi Daniil,
cc: Boris and Erik J.
On 20/05/2019 7:12 am, Daniil Titov wrote:
Please review the change that fixes the failure of
sun/management/jmxremote/bootstrap JMX tests on Windows platform. While
running, these tests invoke revokeall.exe utility and this utility hangs.
The problem here
Please review the change that fixes the failure of
sun/management/jmxremote/bootstrap JMX tests on Windows platform. While
running, these tests invoke revokeall.exe utility and this utility hangs.
The problem here is that invokeall.exe goes into an endless loop while
iterating over Access
19 matches
Mail list logo
