INCLUDE_SA/serviceability agent - support on s390x

2018-04-23 Thread Baesken, Matthias
Hello, as far as I know the serviceability agent is not supported on linux s390x . However (unlike on aix where it is not supported as well) , INCLUDE_SA=falseis not set in the central configure m4 files . Should we set it ( suggested diff below) ? Best regards, Matthias hg

Re: INCLUDE_SA/serviceability agent - support on s390x

2018-04-23 Thread Erik Joelsson
Makes sense to me. Looks good. /Erik On 2018-04-23 05:01, Baesken, Matthias wrote: Hello,   as far as I know  the serviceability agent   is not  supported on  linux s390x . However  (unlike  on aix where it is not supported as well) ,   INCLUDE_SA=false is not set  in the central configur

Re: INCLUDE_SA/serviceability agent - support on s390x

2018-04-23 Thread Jini George
Hi Matthias, Your change looks good to me. It might make sense to also remove the following lines from: src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h 78 #if defined(s390x) 79 #include 80 #endif I am not sure if the following files are required either: src/hotspot/cpu/s390/vmStru

RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

2018-04-24 Thread Baesken, Matthias
pril 2018 08:58 > To: Baesken, Matthias ; 'build- > d...@openjdk.java.net' > Cc: serviceability-dev@openjdk.java.net; Schmidt, Lutz > > Subject: Re: INCLUDE_SA/serviceability agent - support on s390x > > Hi Matthias, > > Your change looks good to me. It m

Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

2018-04-24 Thread Jini George
Message- From: Jini George [mailto:jini.geo...@oracle.com] Sent: Dienstag, 24. April 2018 08:58 To: Baesken, Matthias ; 'build- d...@openjdk.java.net' Cc: serviceability-dev@openjdk.java.net; Schmidt, Lutz Subject: Re: INCLUDE_SA/serviceability agent - support on s390x Hi Matthias, Y

RE: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

2018-04-25 Thread Baesken, Matthias
...@oracle.com] Sent: Montag, 23. April 2018 17:43 To: Baesken, Matthias ; 'build-...@openjdk.java.net' Cc: serviceability-dev@openjdk.java.net; Schmidt, Lutz Subject: Re: INCLUDE_SA/serviceability agent - support on s390x Makes sense to me. Looks good. /Erik On 2018-04-23 05:0

Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

2018-04-25 Thread Magnus Ihse Bursie
t; Schmidt, Lutz *Subject:* Re: INCLUDE_SA/serviceability agent - support on s390x Makes sense to me. Looks good. /Erik On 2018-04-23 05:01, Baesken, Matthias wrote: Hello,   as far as I know  the serviceability agent   is not  supported on linux s390x . However  (unlike  on aix