Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Have a couple of reviews but still need official reviewer to pass muster. thanks, bill On 11/22/2012 7:51 AM, Dmitry Samersoff wrote: Bill, Looks good for me. -Dmitry On 2012-11-21 23:31, BILL PITTORE wrote: Hi Dmitry, On 11/21/2012 4:56 AM, Dmitry Samersoff wrote: Bill, Few nits: 1.

Re: Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Hi Bill, A few minor comments, some of which you've touched on with Dmitry. David -- share/back/debugInit.c 40 #include "sys.h" Shouldn't that be ? --- src/share/back/transport.c * Note: Java property sun.boot.library.path contains a single directory. + * Note: Above

Re: Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Thanks David for the review. On 11/26/2012 9:38 PM, David Holmes wrote: Hi Bill, A few minor comments, some of which you've touched on with Dmitry. David -- share/back/debugInit.c 40 #include "sys.h" Shouldn't that be ? No, it's really "sys.h" -> jdk/src/share/back/export/sys.h:

Re: Official reviewer needed: Review request for fix for 7200297: agent code does not handle multiple dll_dir paths correctly

Thanks Bill - Reviewed. David On 28/11/2012 1:49 AM, BILL PITTORE wrote: Thanks David for the review. On 11/26/2012 9:38 PM, David Holmes wrote: Hi Bill, A few minor comments, some of which you've touched on with Dmitry. David -- share/back/debugInit.c 40 #include "sys.h" Shouldn't